New issue
Advanced search Search tips

Issue 700048 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arc: Change VLOG to LOG for HTTP context preparation and auth code fetching.

Project Member Reported by khmel@chromium.org, Mar 9 2017

Issue description

This change VLOG(2) to LOG(WARNING) for failure reasons in ARC
HTTP context preparation and background auth code fetcher. This
information was missing in some user's feedbacks responsible for
SERVER_COMMUNICATION_ERROR failure.

Inner bug: b/36076099
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2d4ff52c748b24a2a57a6f3d3fe7573744442ba

commit f2d4ff52c748b24a2a57a6f3d3fe7573744442ba
Author: khmel <khmel@chromium.org>
Date: Thu Mar 09 18:53:45 2017

arc: Change VLOG to LOG for ArcAuthContext and fetcher.

This change VLOG(2) to LOG(WARNING) for failure reasons in ARC
HTTP context preparation and background auth code fetcher. This
information was missing in some user feedbacks responsible for
SERVER_COMMUNICATION_ERROR failure.

TEST=Ensure that log entries appear in Chrome Log
BUG= 700048 

Review-Url: https://codereview.chromium.org/2742643002
Cr-Commit-Position: refs/heads/master@{#455815}

[modify] https://crrev.com/f2d4ff52c748b24a2a57a6f3d3fe7573744442ba/chrome/browser/chromeos/arc/arc_auth_context.cc
[modify] https://crrev.com/f2d4ff52c748b24a2a57a6f3d3fe7573744442ba/chrome/browser/chromeos/arc/auth/arc_background_auth_code_fetcher.cc

Comment 2 by khmel@chromium.org, Mar 9 2017

Labels: Merge-Request-58
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 10 2017

Labels: merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13d308927b6a8363df6274a3cfa4b9c8f421769c

commit 13d308927b6a8363df6274a3cfa4b9c8f421769c
Author: khmel <khmel@chromium.org>
Date: Fri Mar 10 18:23:03 2017

[Merge M58] arg: Change VLOG to LOG for ArcAuthContext and fetcher.

This change VLOG(2) to LOG(WARNING) for failure reasons in ARC
HTTP context preparation and background auth code fetcher. This
information was missing in some user feedbacks responsible for
SERVER_COMMUNICATION_ERROR failure.

TEST=Ensure that log entries appear in Chrome Log
BUG= 700048 
NOTRY=true
NOPRESUBMIT=true
TBR=yusukes@chromium.org

Review-Url: https://codereview.chromium.org/2742643002
Cr-Commit-Position: refs/heads/master@{#455815}
(cherry picked from commit f2d4ff52c748b24a2a57a6f3d3fe7573744442ba)

Review-Url: https://codereview.chromium.org/2747463002
Cr-Commit-Position: refs/branch-heads/3029@{#114}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/13d308927b6a8363df6274a3cfa4b9c8f421769c/chrome/browser/chromeos/arc/arc_auth_context.cc
[modify] https://crrev.com/13d308927b6a8363df6274a3cfa4b9c8f421769c/chrome/browser/chromeos/arc/auth/arc_background_auth_code_fetcher.cc

Comment 4 by khmel@chromium.org, Mar 10 2017

Labels: -Merge-Request-58
Status: Fixed (was: Started)
Approved at b/36076099
Status: Verified (was: Fixed)

Sign in to add a comment