New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 700032 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Remove [CEReactions] from [PutForward] readonly attributes

Project Member Reported by domenic@chromium.org, Mar 9 2017

Issue description

That is, match the spec at https://github.com/whatwg/html/pull/2378. We discovered there that they were redundant in the spec, and so they should be redundant in implementations too.

We should ideally update the IDL compiler to disallow [CEReactions] on readonly attributes as well, now that this change has been made.
 
Components: -Blink
Components: -Blink>Bindings
Labels: Hotlist-GoodFirstBug OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Owner: dominicc@chromium.org
Status: Assigned (was: Untriaged)
Sign in gmail. Account
Owner: ----
Status: Available (was: Assigned)
Bulk disowning per sshruthi's email about bug triage best practices.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be6ed4ced3695c547d0433eef035a18820359aaa

commit be6ed4ced3695c547d0433eef035a18820359aaa
Author: Yuhong Sha <yuhong.sha@samsung.com>
Date: Thu Mar 29 08:41:42 2018

Remove [CEReactions] from [PutForward] readonly attributes

Removing [CEReactions] from [PutForwards]-decorated readonly
attributes, as it is redundant there.

Bug:  700032 

Signed-off-by: Yuhong Sha <yuhong.sha@samsung.com>
Change-Id: Ie0d26c8181a8a30ccb0b751a41b929e0ff4e64f4
Reviewed-on: https://chromium-review.googlesource.com/980273
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#546772}
[modify] https://crrev.com/be6ed4ced3695c547d0433eef035a18820359aaa/third_party/WebKit/Source/core/dom/Element.idl
[modify] https://crrev.com/be6ed4ced3695c547d0433eef035a18820359aaa/third_party/WebKit/Source/core/html/HTMLIFrameElement.idl
[modify] https://crrev.com/be6ed4ced3695c547d0433eef035a18820359aaa/third_party/WebKit/Source/core/html/HTMLLinkElement.idl
[modify] https://crrev.com/be6ed4ced3695c547d0433eef035a18820359aaa/third_party/WebKit/Source/core/html/forms/HTMLOutputElement.idl

Comment 6 by tkent@chromium.org, Mar 29 2018

Status: Fixed (was: Available)

Sign in to add a comment