New issue
Advanced search Search tips

Issue 700010 link

Starred by 12 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task

Blocking:
issue 433856
issue 446804
issue 447568
issue 450183
issue 450185
issue 472628
issue 493295
issue 505018
issue 505019
issue 505021
issue 505028
issue 505034
issue 569579
issue 636874



Sign in to add a comment

[Password Generation] [META] Password generation issues on iOS

Project Member Reported by kolos@chromium.org, Mar 9 2017

Issue description

This is the meta bug for password generation issues on iOS. 
 

Comment 1 by kolos@chromium.org, Mar 9 2017

Components: UI>Browser>Passwords>Generation
Labels: OS-iOS

Comment 2 by kolos@chromium.org, Mar 9 2017

Issue 636874 has been merged into this issue.

Comment 3 by kolos@chromium.org, Mar 9 2017

Cc: dvadym@chromium.org
 Issue 569579  has been merged into this issue.

Comment 4 by kolos@chromium.org, Mar 9 2017

Cc: jdonnelly@chromium.org vabr@chromium.org
 Issue 505034  has been merged into this issue.

Comment 5 by kolos@chromium.org, Mar 9 2017

 Issue 505028  has been merged into this issue.

Comment 6 by kolos@chromium.org, Mar 9 2017

 Issue 505021  has been merged into this issue.

Comment 7 by kolos@chromium.org, Mar 9 2017

 Issue 505018  has been merged into this issue.

Comment 8 by kolos@chromium.org, Mar 9 2017

 Issue 505019  has been merged into this issue.

Comment 9 by kolos@chromium.org, Mar 9 2017

Issue 493295 has been merged into this issue.
Cc: gcasto@chromium.org
 Issue 472628  has been merged into this issue.
Issue 450185 has been merged into this issue.
Issue 450183 has been merged into this issue.
Issue 447568 has been merged into this issue.
Issue 446804 has been merged into this issue.
Issue 433856 has been merged into this issue.

Comment 16 by vabr@chromium.org, Mar 14 2017

Labels: tracking_work

Comment 17 by kolos@chromium.org, Mar 15 2017

Blocking: 433856 505028 450183 450185 505034 569579 493295 447568 472628 636874 446804 505018 505019 505021
Cc: -gcasto@chromium.org

Comment 18 by vabr@chromium.org, May 2 2017

Labels: -tracking_work Type-Task
Labels: meta-bug
Project Member

Comment 20 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf9011e0b0b616247946b47875e491d75dca190d

commit cf9011e0b0b616247946b47875e491d75dca190d
Author: vasilii <vasilii@chromium.org>
Date: Tue Nov 07 11:37:14 2017

Drop PasswordGenerationAgent on iOS.

The class wasn't maintained because password generation isn't supported yet on iOS.

Bug:  752077 , 700010 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2f05bc83d9a9c076daa046e9b2df37250fe5db6a
Reviewed-on: https://chromium-review.googlesource.com/755595
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514448}
[modify] https://crrev.com/cf9011e0b0b616247946b47875e491d75dca190d/ios/chrome/browser/experimental_flags.h
[modify] https://crrev.com/cf9011e0b0b616247946b47875e491d75dca190d/ios/chrome/browser/experimental_flags.mm
[modify] https://crrev.com/cf9011e0b0b616247946b47875e491d75dca190d/ios/chrome/browser/passwords/BUILD.gn
[modify] https://crrev.com/cf9011e0b0b616247946b47875e491d75dca190d/ios/chrome/browser/passwords/ios_chrome_password_manager_driver.h
[modify] https://crrev.com/cf9011e0b0b616247946b47875e491d75dca190d/ios/chrome/browser/passwords/ios_chrome_password_manager_driver.mm
[modify] https://crrev.com/cf9011e0b0b616247946b47875e491d75dca190d/ios/chrome/browser/passwords/password_controller.h
[modify] https://crrev.com/cf9011e0b0b616247946b47875e491d75dca190d/ios/chrome/browser/passwords/password_controller.mm
[delete] https://crrev.com/e2519016ab06c4fdd6c7855fb234f0e05ab4f217/ios/chrome/browser/passwords/password_controller_off_the_record_unittest.mm
[delete] https://crrev.com/e2519016ab06c4fdd6c7855fb234f0e05ab4f217/ios/chrome/browser/passwords/password_generation_agent.h
[delete] https://crrev.com/e2519016ab06c4fdd6c7855fb234f0e05ab4f217/ios/chrome/browser/passwords/password_generation_agent.mm
[delete] https://crrev.com/e2519016ab06c4fdd6c7855fb234f0e05ab4f217/ios/chrome/browser/passwords/password_generation_agent_unittest.mm
[modify] https://crrev.com/cf9011e0b0b616247946b47875e491d75dca190d/ios/chrome/browser/passwords/password_tab_helper.h
[modify] https://crrev.com/cf9011e0b0b616247946b47875e491d75dca190d/ios/chrome/browser/passwords/password_tab_helper.mm
[modify] https://crrev.com/cf9011e0b0b616247946b47875e491d75dca190d/ios/chrome/browser/tabs/tab_helper_util.mm

Cc: -jdonnelly@chromium.org
I'm no longer working on autofill.
Project Member

Comment 22 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71552dd95119459b8d39effe98e57486b2c7b005

commit 71552dd95119459b8d39effe98e57486b2c7b005
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Mon Nov 13 19:36:12 2017

Remove Password Generation leftovers on IOS.

On CL https://chromium-review.googlesource.com/c/chromium/src/+/755595
Password Generation on IOS was removed. This CL removes leftovers.

Bug:  752077 , 700010 ,782224
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Idbd84d45874a877bdc0ab81299123600442f2c98
Reviewed-on: https://chromium-review.googlesource.com/758836
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516006}
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/passwords/BUILD.gn
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/passwords/js_password_manager.h
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/passwords/js_password_manager.mm
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/passwords/password_controller.h
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/passwords/password_controller_js_unittest.mm
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/passwords/password_controller_unittest.mm
[delete] https://crrev.com/a31797362dd1fcf205cdce92673c0fca888ee40f/ios/chrome/browser/passwords/password_generation_edit_view.h
[delete] https://crrev.com/a31797362dd1fcf205cdce92673c0fca888ee40f/ios/chrome/browser/passwords/password_generation_edit_view.mm
[delete] https://crrev.com/a31797362dd1fcf205cdce92673c0fca888ee40f/ios/chrome/browser/passwords/password_generation_offer_view.h
[delete] https://crrev.com/a31797362dd1fcf205cdce92673c0fca888ee40f/ios/chrome/browser/passwords/password_generation_offer_view.mm
[delete] https://crrev.com/a31797362dd1fcf205cdce92673c0fca888ee40f/ios/chrome/browser/passwords/password_generation_prompt_delegate.h
[delete] https://crrev.com/a31797362dd1fcf205cdce92673c0fca888ee40f/ios/chrome/browser/passwords/password_generation_prompt_view.h
[delete] https://crrev.com/a31797362dd1fcf205cdce92673c0fca888ee40f/ios/chrome/browser/passwords/password_generation_prompt_view.mm
[delete] https://crrev.com/a31797362dd1fcf205cdce92673c0fca888ee40f/ios/chrome/browser/passwords/password_generation_prompt_view_controller.h
[delete] https://crrev.com/a31797362dd1fcf205cdce92673c0fca888ee40f/ios/chrome/browser/passwords/password_generation_prompt_view_controller.mm
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/passwords/password_generation_utils.h
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/passwords/password_generation_utils.mm
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/passwords/password_tab_helper.h
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/passwords/password_tab_helper.mm
[delete] https://crrev.com/a31797362dd1fcf205cdce92673c0fca888ee40f/ios/chrome/browser/passwords/passwords_ui_delegate.h
[delete] https://crrev.com/a31797362dd1fcf205cdce92673c0fca888ee40f/ios/chrome/browser/passwords/passwords_ui_delegate_impl.h
[delete] https://crrev.com/a31797362dd1fcf205cdce92673c0fca888ee40f/ios/chrome/browser/passwords/passwords_ui_delegate_impl.mm
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/passwords/resources/password_controller.js
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/tabs/BUILD.gn
[modify] https://crrev.com/71552dd95119459b8d39effe98e57486b2c7b005/ios/chrome/browser/tabs/tab_helper_util.mm

Status: WontFix (was: Available)
Password Generation is not available on IOS (even with flag) and all code related to it was removed for now. So I close this bug. 

In future we're going to revive Password Generation on IOS, but no concrete plans yet. 
Cc: -vabr@chromium.org

Sign in to add a comment