Using things like disabled_test_macros.h, or IsIPadIdiom require adding multiple test dependencies, just to disable a test. Things commonly used should already be available.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31a6250bc9cd79af047c0650a9f249d7e9ab2d09 commit 31a6250bc9cd79af047c0650a9f249d7e9ab2d09 Author: baxley <baxley@chromium.org> Date: Mon Mar 20 18:35:26 2017 Add disabled_test_macro import to EarlGrey base test cases. This header is often required temporarily by tests, while a test is disabled. The header is often not cleaned up when the test is enabled. Adding this to the base class makes it easier to disable tests, and keeps the test headers cleaner. BUG= 700004 Review-Url: https://codereview.chromium.org/2761443005 Cr-Commit-Position: refs/heads/master@{#458132} [modify] https://crrev.com/31a6250bc9cd79af047c0650a9f249d7e9ab2d09/ios/chrome/browser/autofill/form_input_egtest.mm [modify] https://crrev.com/31a6250bc9cd79af047c0650a9f249d7e9ab2d09/ios/chrome/browser/ui/alert_coordinator/alert_coordinator_egtest.mm [modify] https://crrev.com/31a6250bc9cd79af047c0650a9f249d7e9ab2d09/ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm [modify] https://crrev.com/31a6250bc9cd79af047c0650a9f249d7e9ab2d09/ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm [modify] https://crrev.com/31a6250bc9cd79af047c0650a9f249d7e9ab2d09/ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm [modify] https://crrev.com/31a6250bc9cd79af047c0650a9f249d7e9ab2d09/ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm [modify] https://crrev.com/31a6250bc9cd79af047c0650a9f249d7e9ab2d09/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm [modify] https://crrev.com/31a6250bc9cd79af047c0650a9f249d7e9ab2d09/ios/chrome/browser/ui/settings/accounts_collection_egtest.mm [modify] https://crrev.com/31a6250bc9cd79af047c0650a9f249d7e9ab2d09/ios/chrome/browser/ui/stack_view/stack_view_egtest.mm [modify] https://crrev.com/31a6250bc9cd79af047c0650a9f249d7e9ab2d09/ios/chrome/browser/ui/toolbar/toolbar_egtest.mm [modify] https://crrev.com/31a6250bc9cd79af047c0650a9f249d7e9ab2d09/ios/chrome/browser/web/browsing_egtest.mm [modify] https://crrev.com/31a6250bc9cd79af047c0650a9f249d7e9ab2d09/ios/chrome/browser/web/http_auth_egtest.mm [modify] https://crrev.com/31a6250bc9cd79af047c0650a9f249d7e9ab2d09/ios/chrome/browser/web/navigation_egtest.mm [modify] https://crrev.com/31a6250bc9cd79af047c0650a9f249d7e9ab2d09/ios/chrome/browser/web/progress_indicator_egtest.mm [modify] https://crrev.com/31a6250bc9cd79af047c0650a9f249d7e9ab2d09/ios/chrome/browser/web/push_and_replace_state_navigation_egtest.mm [modify] https://crrev.com/31a6250bc9cd79af047c0650a9f249d7e9ab2d09/ios/chrome/test/earl_grey/BUILD.gn [modify] https://crrev.com/31a6250bc9cd79af047c0650a9f249d7e9ab2d09/ios/chrome/test/earl_grey/chrome_test_case.h [modify] https://crrev.com/31a6250bc9cd79af047c0650a9f249d7e9ab2d09/ios/web/shell/test/context_menu_egtest.mm [modify] https://crrev.com/31a6250bc9cd79af047c0650a9f249d7e9ab2d09/ios/web/shell/test/earl_grey/web_shell_test_case.h [modify] https://crrev.com/31a6250bc9cd79af047c0650a9f249d7e9ab2d09/ios/web/shell/test/page_state_egtest.mm
Is this now fixed per comment #2?
Comment 1 by baxley@chromium.org
, Mar 17 2017