Issue 699983 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ manzagop@chromium.org Last visit > 30 days ago
Closed:	Mar 2017
Components:	Internals>CrashReporting
EstimatedDays:	----
NextAction:	----
OS:	Windows
Pri:	2
Type:	Bug
M-58

chrome_watcher.dll doesn't set itself up for crashing under badness (e.g., OOM)

Project Member Reported by grt@chromium.org, Mar 9 2017

Issue description

Since the watcher doesn't go through content's initialization (https://cs.chromium.org/chromium/src/content/app/content_main_runner.cc?type=cs&sq=package:chromium&q=file:app/content_main_runner.cc+EnableTerminationOnOutOfMemory&l=538), chrome_watcher.dll doesn't benefit from OOM or RegisterInvalidParamHandler. Here's the set that setup.exe uses: https://cs.chromium.org/chromium/src/chrome/installer/setup/setup_main.cc?type=cs&q=EnableTerminationOnHeapCorruption+file:setup_main%5C.cc&sq=package:chromium&l=1368. The watcher should do something similar

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/208cc84708940c682993ea5feff1003410e329b5

commit 208cc84708940c682993ea5feff1003410e329b5
Author: manzagop <manzagop@chromium.org>
Date: Thu Mar 09 18:52:12 2017

Ensure chrome watcher exits cleanly on unexpected errors

This mirrors what the installer does.
https://cs.chromium.org/chromium/src/chrome/installer/setup/setup_main.cc?l=1367

BUG= 699983 

Review-Url: https://codereview.chromium.org/2737263004
Cr-Commit-Position: refs/heads/master@{#455814}

[modify] https://crrev.com/208cc84708940c682993ea5feff1003410e329b5/chrome/chrome_watcher/chrome_watcher_main.cc

Comment 2 by manzagop@chromium.org, Mar 20 2017

Status: Fixed (was: Assigned)

►

Issue 699983 link

Issue metadata

chrome_watcher.dll doesn't set itself up for crashing under badness (e.g., OOM)

Issue description

Comment 1 by bugdroid1@chromium.org, Mar 9 2017

Comment 1 Deleted

Comment 2 by manzagop@chromium.org, Mar 20 2017

Comment 2 Deleted

Sign in to add a comment