New issue
Advanced search Search tips

Issue 699982 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

span->len > 0

Project Member Reported by ClusterFuzz, Mar 9 2017

Issue description

Cc: npm@chromium.org dsinclair@chromium.org
Components: Internals>Plugins>PDF
Labels: Test-Predator-Wrong M-59
Could someone please take a look?
Thank you

Comment 2 by npm@chromium.org, Mar 10 2017

 Issue 660380  has been merged into this issue.

Comment 3 by npm@chromium.org, Mar 13 2017

Cc: -npm@chromium.org
Owner: npm@chromium.org
Status: Assigned (was: Untriaged)
I'll add it to my list
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/f8b15f46e69fdec04a03afeb6f2bf60f90dff433

commit f8b15f46e69fdec04a03afeb6f2bf60f90dff433
Author: Nicolas Pena <npm@chromium.org>
Date: Fri Mar 17 21:22:50 2017

HardClip points a bit better in fx_agg_driver

In agg, the length is of type coord_type, which we have as int16. So having
points bigger than the max short will not work properly.

BUG= chromium:699982 

Change-Id: I0e4cab6ae2b6aa023359aec4b5b3d611f8a8eb4f
Reviewed-on: https://pdfium-review.googlesource.com/3101
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Nicolás Peña <npm@chromium.org>

[modify] https://crrev.com/f8b15f46e69fdec04a03afeb6f2bf60f90dff433/core/fxge/agg/fx_agg_driver.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a77757bbeed5a9f744f68982fe6911c79227925

commit 3a77757bbeed5a9f744f68982fe6911c79227925
Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org>
Date: Sat Mar 18 02:36:56 2017

Roll src/third_party/pdfium/ 7630907c7..85f019a8e (5 commits)

https://pdfium.googlesource.com/pdfium.git/+log/7630907c7ecb..85f019a8e7d3

$ git log 7630907c7..85f019a8e --date=short --no-merges --format='%ad %ae %s'
2017-03-17 thestig Add pdfium::clamp() as a placeholder for std::clamp().
2017-03-17 thestig Use std::vector in CPDF_StreamContentParser.
2017-03-17 thestig Bring CPDF_ICCBasedCS closer to PDF spec.
2017-03-17 tsepez Replace CLines class with std::vector<Cline>.
2017-03-17 npm HardClip points a bit better in fx_agg_driver

Created with:
  roll-dep src/third_party/pdfium
BUG= 691967 , 702238 , 699982 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2756303003
Cr-Commit-Position: refs/heads/master@{#457932}

[modify] https://crrev.com/3a77757bbeed5a9f744f68982fe6911c79227925/DEPS

Project Member

Comment 6 by ClusterFuzz, Mar 18 2017

ClusterFuzz has detected this issue as fixed in range 457921:457941.

Detailed report: https://clusterfuzz.com/testcase?key=6601654632972288

Fuzzer: libfuzzer_pdfium_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: ASSERT
Crash Address: 
Crash State:
  span->len > 0
  void CFX_Renderer::render<agg::scanline_u<unsigned char> >
  void agg::render_scanlines<agg::rasterizer_scanline_aa, agg::scanline_u<unsigned
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=455091:455226
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=457921:457941

Reproducer Testcase: https://clusterfuzz.com/download/AMIfv96YHbC3piJLeqzelJAphBu7bFYcZzv8lpxkydHEKROpGhN7H-voe_Avl_tSfQCwytdWoqHK5Meut4tMiOCzq6BTcI3QjGrSrRyQWD-9yMhlnDs4-RgK0V5n3loYpnQY1SOh0FrSw-xX7s713_kgFmhbqNbRp6j0ud7RySI_nAErBomilLbzEqJ15J8fVMmMCKjjTVGjLg7uBYnSQqUOaD17kXx1FlYzoNUDCAWPdSFXKgPZfQY32vnVq6Rw0zDYZZD6tnOoLbQB9B6IFT3wz3nWGVAvhfSm-BdQM-hI-PVdxLDyMOK84vOxzQ9gVgr-RRP1wUeGyv9S7tndC2n7V7x9F_G61SVgHgwWa9idTpZWgfWuUPU?testcase_id=6601654632972288


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Mar 18 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6601654632972288 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment