New issue
Advanced search Search tips

Issue 699980 link

Starred by 1 user
Status: WontFix
Owner:
mastiz@chromium.org
Closed: May 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 694312
issue 698671


Sign in to add a comment

Add support for multiple favicons per site

Project Member Reported by mastiz@chromium.org, Mar 9 2017 
Currently, Chrome supports one single icon per site and icon type (favicon vs touch icon).

We'd like to extend this to allow sites providing multiple favicons with different resolutions, to facilitate the adoption of high-resolution ones without regressing on existing UIs.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/893e6a902a3ebe3bcee042e6e2bec1413e977a5f

commit 893e6a902a3ebe3bcee042e6e2bec1413e977a5f
Author: mastiz <mastiz@chromium.org>
Date: Tue Mar 21 09:48:35 2017

Remove DownloadRequest registry from FaviconHandler

No behavioral changes: the adoption of a CancelableCallback is a more
natural way to represent a single ongoing request, which needs to be
cancelled in certain cases.

This is possible after https://codereview.chromium.org/2691933004
which reduced the number of received download completions, now
restricted to the ones that the FaviconHandler instance itself
triggered.

BUG= 699980 

Review-Url: https://codereview.chromium.org/2738063004
Cr-Commit-Position: refs/heads/master@{#458360}

[modify] https://crrev.com/893e6a902a3ebe3bcee042e6e2bec1413e977a5f/components/favicon/core/favicon_handler.cc
[modify] https://crrev.com/893e6a902a3ebe3bcee042e6e2bec1413e977a5f/components/favicon/core/favicon_handler.h

Comment 2 by mastiz@chromium.org, May 10 2017

Status: WontFix (was: Assigned)
Because the required code complexity in order to achieve this, and the decreased severity of the issue according to our latest discussions, marking this as obsolete.
►

Sign in to add a comment