Make ContentSuggestionsService::Observer::OnCategoryStatusChanged more explicit |
|||||
Issue descriptionThe comment of ContentSuggestionsService::Observer::OnCategoryStatusChanged states: "When the status changes to an unavailable status, the suggestions of the respective category have been invalidated, which means that they must no longer be displayed to the user. The UI must immediately clear any suggestions of that category." But the Android UI code leaves the UI as-is in opened NTP when the status changes to NOT_PROVIDED: https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java?q=dr=C&l=158 Can we make sure this is consistent?
,
Mar 9 2017
Marc, do you think we can turn this API into something more explicit? Why not tell the UI to drop suggestions immediately (and have that logic in a central place) instead of it having to know how to interpret certain status changes?
,
Mar 9 2017
Good idea - that might be possible, yes. Currently, the UI does two other things with the status: - It reacts specially to the SIGNED_OUT status, but that doesn't actually exist anymore (bug 699979). - It shows a loading indicator if the status is INITIALIZING or AVAILABLE_LOADING. We've been thinking about getting rid of that anyway. (+dgn)
,
Mar 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a57e41b3a0182e8e7b43b36e8ffb9fd05b3c15a commit 2a57e41b3a0182e8e7b43b36e8ffb9fd05b3c15a Author: treib <treib@chromium.org> Date: Mon Mar 13 15:41:52 2017 ntp_snippets cleanup: Update some interface comments BUG=699975 Review-Url: https://codereview.chromium.org/2746133002 Cr-Commit-Position: refs/heads/master@{#456387} [modify] https://crrev.com/2a57e41b3a0182e8e7b43b36e8ffb9fd05b3c15a/components/ntp_snippets/category_status.h [modify] https://crrev.com/2a57e41b3a0182e8e7b43b36e8ffb9fd05b3c15a/components/ntp_snippets/content_suggestions_service.h
,
Apr 10 2017
,
Apr 11 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 18 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by treib@chromium.org
, Mar 9 2017