New issue
Advanced search Search tips

Issue 699957 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Implement match() and matchAll() methods for BackgroundFetchRegistration.

Project Member Reported by peter@chromium.org, Mar 9 2017

Issue description

It gives developers access to the Requests (and Responses) of in-progress background fetches.

https://wicg.github.io/background-fetch/#background-fetch-manager
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a3ff3e332e4667ca5424370e3d7823aebbd82db

commit 3a3ff3e332e4667ca5424370e3d7823aebbd82db
Author: harkness <harkness@chromium.org>
Date: Tue Mar 21 11:06:45 2017

Use std::unique_ptr for access to BackgroundFetchJobInfo

As a temporary implementation, the code was storing maps of
BackgroundFetchJobInfo and BackgroundFetchRequestInfo. The RequestInfo
can't be converted to unique_ptr because we need access to it from two
places until the storage solution is available, but the RequestInfo is
only accessed from the DataManager, so that can be switched to
unique_ptr.

This also allows the JobInfo itself to hold a unique_ptr.

BUG= 699957 

Review-Url: https://codereview.chromium.org/2763613004
Cr-Commit-Position: refs/heads/master@{#458371}

[modify] https://crrev.com/3a3ff3e332e4667ca5424370e3d7823aebbd82db/content/browser/background_fetch/background_fetch_context.cc
[modify] https://crrev.com/3a3ff3e332e4667ca5424370e3d7823aebbd82db/content/browser/background_fetch/background_fetch_context.h
[modify] https://crrev.com/3a3ff3e332e4667ca5424370e3d7823aebbd82db/content/browser/background_fetch/background_fetch_data_manager.cc
[modify] https://crrev.com/3a3ff3e332e4667ca5424370e3d7823aebbd82db/content/browser/background_fetch/background_fetch_data_manager.h
[modify] https://crrev.com/3a3ff3e332e4667ca5424370e3d7823aebbd82db/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/3a3ff3e332e4667ca5424370e3d7823aebbd82db/content/browser/background_fetch/background_fetch_job_info.cc
[modify] https://crrev.com/3a3ff3e332e4667ca5424370e3d7823aebbd82db/content/browser/background_fetch/background_fetch_job_info.h

Cc: mlamouri@chromium.org
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 11 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: peter@chromium.org
Status: Assigned (was: Untriaged)
Assigning to Peter, TL of background fetch and spec author

~ Bug Cop

Comment 5 by peter@chromium.org, Apr 23 2018

Owner: ----
Status: Available (was: Assigned)

Comment 6 by peter@chromium.org, May 9 2018

Cc: na...@chromium.org rayankans@chromium.org
 Issue 841349  has been merged into this issue.

Comment 7 by peter@chromium.org, May 9 2018

Summary: Support the `activeFetches` attribute of a background fetch registration (was: Support the `fetches` attribute of a background fetch registration)
Summary: Implement match(), matchAll() and values() methods for BackgroundFetchRegistration. (was: Support the `activeFetches` attribute of a background fetch registration)
Updating title to reflect the latest state of the spec after https://github.com/WICG/background-fetch/pull/85.
 Issue 824765  has been merged into this issue.
 Issue 863852  has been merged into this issue.
Labels: BlocksMVP
Summary: Implement match() and matchAll() methods for BackgroundFetchRegistration. (was: Implement match(), matchAll() and values() methods for BackgroundFetchRegistration.)
Status: Fixed (was: Available)

Sign in to add a comment