New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699923 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Regression: Text Overlaps for 'Select Destination Overlay' in French language.

Reported by lpa...@etouch.net, Mar 9 2017

Issue description

Chrome Version: 57.0.2987.98 (Official Build) f87f641e0af5bfed98578e340f1d5ca79651bf82-refs/branch-heads/2987@{#802}(32/64-bit)

OS: Windows(7,8,8.1,10)

Pre-Condition:
1. Sign-In to Chrome.
2. Browser Language should be set to French.

Steps to reproduce:
1. Launch chrome, give print command from Wrench Icon, click on Change Button on Print Preview and observe.

Actual Result: Text Overlaps for 'Select Destination Overlay' in French language.
Expected Result: Text should not overlap.

This is a Regression Issue broken in M-36.

Manual Bisect Info: 
Good Build 36.0.1930.0
Bad Build 36.0.1931.0

Note: 1. Issue is not reproducible in MAC and LINUX OS
      2. Unable to provide narrow bisect as 'print preview overlay' is not available in chromium builds, Hence providing suspect from change log URL.

Change-Log URL:
https://chromium.googlesource.com/chromium/src/+log/36.0.1930.0..36.0.1931.0?pretty=fuller&n=10000

Suspecting: r262278?

Kindly help to re-assign if your change is not the cause for this issue.
 
Actual Result.mp4
2.2 MB View Download
Expected Result.mp4
1.9 MB View Download
Cc: dpa...@chromium.org
Labels: -Type-Bug-Regression -M-57 Type-Bug
Owner: ----
Status: Available (was: Assigned)
The expected result also looks terrible. Perhaps we should make the dialog a bit taller so "Showing destinations for" can be moved down a little? Then it won't overlap with "Select a destination".
Owner: rbpotter@chromium.org
Status: Assigned (was: Available)
The change to fix  http://crbug.com/432870  also seems to fix this bug for normal font sizes.

For very large the drop down and label don't actually fit on a line in French. This looks a little odd with the new change as the right margin is non-existent. Will fix that shortly.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/410577f4d719ecdd656e563b58ba327b98e7fe26

commit 410577f4d719ecdd656e563b58ba327b98e7fe26
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Mar 30 19:07:39 2017

Print Preview Destinations: Fix appearance in French with large text

No margin on the right for the label + dropdown for selecting the
account, so dropdown runs against dialog edge if font size is very large
and language is French. Fix this issue.
BUG= 699923 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2780953004
Cr-Commit-Position: refs/heads/master@{#460843}

[modify] https://crrev.com/410577f4d719ecdd656e563b58ba327b98e7fe26/chrome/browser/resources/print_preview/search/destination_search.css

Status: Fixed (was: Assigned)

Sign in to add a comment