New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 699917 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
█ tanvir.r...@samsung.com
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Task



Sign in to add a comment

Remove mark related editing command

Project Member Reported by yosin@chromium.org, Mar 9 2017 
Because of:
 - usage of following commands are zero, not appeared in UMA
 - implementation is broken, e.g. no relocation at DOM mutation == can hold disconnected nodes
 - 100+ lines of code
 - Not web exposed

Foolowing commands are related to mark:
- DeleteToMark
- SelectToMark
- SetMark
- SwapWithMark

I'll ask chromium-dev@ for confirmation of removal

Comment 1 by xiaoche...@chromium.org, Nov 13 2017

Cc: tanvir.r...@samsung.com
What's the current status?

Comment 2 by xiaoche...@chromium.org, Nov 13 2017

Labels: -Type-Bug Type-Task

Comment 3 by yosin@chromium.org, Nov 15 2017 

As of Nov 15, 2017, there are not usage for mark related commands past 28 days.
Thus, we are ready to remove them.

Please post "Intent to Remove" to blink-dev@ to get three LGTM from API owners.

Comment 4 by yosin@chromium.org, Nov 16 2017 

#c3 is WebCore.Document.execCommand.

WebCore.Editing.Commands shows usage of "*Mark" command with non-zero, but very
small usage count.

Comment 5 by phistuck@chromium.org, Mar 3 2018

Labels: Hotlist-Interop
►

Sign in to add a comment