Viewport lengths incorrectly applies page zoom while printing
Reported by
r...@opera.com,
Mar 9 2017
|
||||
Issue descriptionViewport lengths, vw and vh, should be resolved relative to the ICB established by the page for printing. The page size is used as a basis, but the page zoom used for screen display should not be used to scale the lengths in print mode.
,
Mar 9 2017
,
Mar 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de209f3db7bbfda754be262cef35b67340c37774 commit de209f3db7bbfda754be262cef35b67340c37774 Author: rune <rune@opera.com> Date: Fri Mar 10 11:12:13 2017 Initial containing block for print not affected by page zoom. The page zoom factor is not applied to the ICB for printing, yet the ICB basis for media queries and viewport units were. Use 1 as a page zoom factor in viewportSizeForViewportUnits and use that method to get the size for the ICB for evaluating media queries. BUG= 699014 , 699910 Review-Url: https://codereview.chromium.org/2738173002 Cr-Commit-Position: refs/heads/master@{#456040} [modify] https://crrev.com/de209f3db7bbfda754be262cef35b67340c37774/third_party/WebKit/Source/core/css/MediaValues.cpp [modify] https://crrev.com/de209f3db7bbfda754be262cef35b67340c37774/third_party/WebKit/Source/core/frame/FrameView.cpp [modify] https://crrev.com/de209f3db7bbfda754be262cef35b67340c37774/third_party/WebKit/Source/core/frame/FrameView.h [modify] https://crrev.com/de209f3db7bbfda754be262cef35b67340c37774/third_party/WebKit/Source/web/tests/WebViewTest.cpp
,
Mar 10 2017
,
Mar 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9bf08c7035e4fb55adc870418679bb003034d2b commit e9bf08c7035e4fb55adc870418679bb003034d2b Author: Rune Lillesveen <rune@opera.com> Date: Mon Mar 13 23:11:47 2017 Initial containing block for print not affected by page zoom. The page zoom factor is not applied to the ICB for printing, yet the ICB basis for media queries and viewport units were. Use 1 as a page zoom factor in viewportSizeForViewportUnits and use that method to get the size for the ICB for evaluating media queries. BUG= 699014 , 699910 Review-Url: https://codereview.chromium.org/2738173002 Cr-Commit-Position: refs/heads/master@{#456040} (cherry picked from commit de209f3db7bbfda754be262cef35b67340c37774) Review-Url: https://codereview.chromium.org/2752543002 . Cr-Commit-Position: refs/branch-heads/3029@{#173} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/e9bf08c7035e4fb55adc870418679bb003034d2b/third_party/WebKit/Source/core/css/MediaValues.cpp [modify] https://crrev.com/e9bf08c7035e4fb55adc870418679bb003034d2b/third_party/WebKit/Source/core/frame/FrameView.cpp [modify] https://crrev.com/e9bf08c7035e4fb55adc870418679bb003034d2b/third_party/WebKit/Source/core/frame/FrameView.h [modify] https://crrev.com/e9bf08c7035e4fb55adc870418679bb003034d2b/third_party/WebKit/Source/web/tests/WebViewTest.cpp |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugsnash@chromium.org
, Mar 9 2017