New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699902 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 674593


Show other hotlists

Hotlists containing this issue:
Non-Standard-IDL


Sign in to add a comment

Align PaymentAppManifest and PaymentAppOption dictionaries with the spec

Project Member Reported by foolip@chromium.org, Mar 9 2017

Issue description

We have two payment-related dictionaries in Blink that are different from the spec in interesting ways:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/payments/PaymentAppManifest.idl
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/payments/PaymentAppOption.idl

PaymentAppManifest doesn't exist in the spec anymore, and this is PaymentAppOption:
https://w3c.github.io/webpayments-payment-apps-api/#payment-options

It's PaymentAppOptions with a trailing 's' in the spec, but the names of dictionaries aren't observable, so that's not a big deal.

Important differences:
 * We have a "DOMString? icon" member but the spec has "sequence<ImageObjects> icons".
 * We have an id member, but the spec does not.

This bug can remain open until Blink's IDL for these dictionaries is a strict subset of the spec, or matches it exactly.
 
Cc: hs1217....@samsung.com
Speedy triage of this issue appreciated, since this might be a future interop problem.
Owner: jinho.b...@samsung.com
Status: Assigned (was: Untriaged)
foolip@,

Yes, recently the shape of APIs was changed.
(For example, PaymentAppManifest was already removed from the spec.)
The work is not trivial because it requires structure change.
Anyway, I'm working on the issue right now.
So, I'll take this issue.

Thanks :)
Cc: foolip@chromium.org
Thanks Jinho, hard work is hard :)

Comment 5 by zino@chromium.org, May 21 2017

Status: Fixed (was: Assigned)

Sign in to add a comment