Brought up while refactoring content layer. The goal is: 1) Update parameter type |Screen::GetDisplayNearestWindow(gfx::Native{View -> Window})| 2) Add |Screen::GetDisplayNearestView(gfx::NativeView)| 3) Update call sites accordingly
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61bc73e74f6cd55f220c22d2c8f154573b2f1ef8 commit 61bc73e74f6cd55f220c22d2c8f154573b2f1ef8 Author: jinsukkim <jinsukkim@chromium.org> Date: Tue Mar 14 00:36:15 2017 Simplify calls for scale factor Made callsites simpler by replacing multiple commands with one api |ui::GetScaleFactorForNativeView(gfx::NativeView)|. Android got further simpler by |ViewAndroid::GetDipScale()| BUG= 699891 Review-Url: https://codereview.chromium.org/2739113002 Cr-Commit-Position: refs/heads/master@{#456560} [modify] https://crrev.com/61bc73e74f6cd55f220c22d2c8f154573b2f1ef8/content/browser/compositor/mus_browser_compositor_output_surface.cc [modify] https://crrev.com/61bc73e74f6cd55f220c22d2c8f154573b2f1ef8/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/61bc73e74f6cd55f220c22d2c8f154573b2f1ef8/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/61bc73e74f6cd55f220c22d2c8f154573b2f1ef8/content/browser/renderer_host/render_widget_host_view_base.cc [modify] https://crrev.com/61bc73e74f6cd55f220c22d2c8f154573b2f1ef8/content/browser/renderer_host/render_widget_host_view_mac.h [modify] https://crrev.com/61bc73e74f6cd55f220c22d2c8f154573b2f1ef8/content/browser/renderer_host/render_widget_host_view_mac.mm [modify] https://crrev.com/61bc73e74f6cd55f220c22d2c8f154573b2f1ef8/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/61bc73e74f6cd55f220c22d2c8f154573b2f1ef8/ui/aura/window_tree_host.cc [modify] https://crrev.com/61bc73e74f6cd55f220c22d2c8f154573b2f1ef8/ui/aura/window_tree_host_platform.cc [modify] https://crrev.com/61bc73e74f6cd55f220c22d2c8f154573b2f1ef8/ui/aura/window_tree_host_x11.cc [modify] https://crrev.com/61bc73e74f6cd55f220c22d2c8f154573b2f1ef8/ui/base/layout.cc [modify] https://crrev.com/61bc73e74f6cd55f220c22d2c8f154573b2f1ef8/ui/base/layout_mac.mm [modify] https://crrev.com/61bc73e74f6cd55f220c22d2c8f154573b2f1ef8/ui/snapshot/DEPS [modify] https://crrev.com/61bc73e74f6cd55f220c22d2c8f154573b2f1ef8/ui/snapshot/snapshot_android.cc [modify] https://crrev.com/61bc73e74f6cd55f220c22d2c8f154573b2f1ef8/ui/views/cocoa/bridged_native_widget.mm [modify] https://crrev.com/61bc73e74f6cd55f220c22d2c8f154573b2f1ef8/ui/views/drag_utils.cc [modify] https://crrev.com/61bc73e74f6cd55f220c22d2c8f154573b2f1ef8/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc [modify] https://crrev.com/61bc73e74f6cd55f220c22d2c8f154573b2f1ef8/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
Landed https://codereview.chromium.org/2688413007/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493 commit 2dd85f3c4e3aa91bbcccfb122dc70130a99b9493 Author: jinsukkim <jinsukkim@chromium.org> Date: Fri Mar 17 01:54:28 2017 Reland "Add display::GetDisplayNearestView" Reverted CL: https://crrev.com/2688413007 Fixed a missing signature mismatch to make the build work. (extensions/browser/api/system_display/system_display_apitest.cc) This reverts commit a0c89e94b3310fa12b58db00eaca0e66c2f98c7b. BUG= 699891 TBR=sky@chromium.org,boliu@chromium.org,msw@chromium.org,halliwell@chromium.org,bshe@chromium.org,alexclarke@chromium.org,oshima@chromium.org,tapted@chromium.org Review-Url: https://codereview.chromium.org/2751833004 Cr-Commit-Position: refs/heads/master@{#457653} [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/chrome/browser/android/vr_shell/vr_shell.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/chrome/browser/chromeos/display/output_protection_delegate.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/chrome/browser/site_per_process_interactive_browsertest.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/chrome/browser/ui/views/chrome_views_delegate.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/chrome/browser/ui/views/profiles/user_manager_view.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/chrome/browser/ui/views/status_bubble_views.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/chrome/browser/ui/views/toolbar/toolbar_button.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/chrome/browser/ui/views/validation_message_bubble_view.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/chrome/browser/ui/window_sizer/window_sizer_common_unittest.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/chromecast/graphics/cast_screen.h [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/components/constrained_window/constrained_window_views.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/content/browser/renderer_host/render_widget_host_view_base.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/content/browser/renderer_host/render_widget_host_view_mac.mm [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/content/browser/web_contents/web_contents_view_android.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/content/browser/web_contents/web_contents_view_mac.mm [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/extensions/browser/api/system_display/system_display_apitest.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/extensions/shell/browser/shell_screen.h [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/headless/lib/browser/headless_screen.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/headless/lib/browser/headless_screen.h [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/ui/android/display_android_manager.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/ui/android/display_android_manager.h [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/ui/android/dummy_screen_android.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/ui/app_list/presenter/app_list_presenter_impl.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/ui/aura/test/test_screen.h [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/ui/base/layout.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/ui/display/BUILD.gn [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/ui/display/ios/screen_ios.mm [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/ui/display/mac/screen_mac.mm [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/ui/display/screen.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/ui/display/screen.h [add] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/ui/display/screen_android.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/ui/display/screen_aura.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/ui/display/screen_base.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/ui/display/screen_base.h [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/ui/display/test/test_screen.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/ui/display/test/test_screen.h [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/ui/display/win/screen_win.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/ui/display/win/screen_win.h [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/ui/message_center/views/toast_contents_view.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/ui/views/controls/textfield/textfield.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/ui/views/mus/screen_mus.cc [modify] https://crrev.com/2dd85f3c4e3aa91bbcccfb122dc70130a99b9493/ui/views/mus/screen_mus.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e18e618f9e27b12ad26277f7a692766b513694a7 commit e18e618f9e27b12ad26277f7a692766b513694a7 Author: jinsukkim <jinsukkim@chromium.org> Date: Thu Apr 06 13:24:01 2017 Fix mistmached |GetDisplayNearest{Window,View}| param type Fixes the mismatched parameter type (gfx::Native{Window,View}) used for |display::Screen::GetDisplayNearest{Window,View}| in ash. This does not make any functional difference since gfx::NativeWindow and NativeView are of same type when aura is on. The changes are just for correctness' sake. BUG= 699891 Review-Url: https://codereview.chromium.org/2804523002 Cr-Commit-Position: refs/heads/master@{#462449} [modify] https://crrev.com/e18e618f9e27b12ad26277f7a692766b513694a7/ash/common/system/tray/system_tray.cc [modify] https://crrev.com/e18e618f9e27b12ad26277f7a692766b513694a7/ash/common/wm/window_cycle_list.cc [modify] https://crrev.com/e18e618f9e27b12ad26277f7a692766b513694a7/ash/content/keyboard_overlay/keyboard_overlay_delegate.cc [modify] https://crrev.com/e18e618f9e27b12ad26277f7a692766b513694a7/ash/display/screen_ash.h [modify] https://crrev.com/e18e618f9e27b12ad26277f7a692766b513694a7/ash/laser/laser_pointer_view.cc [modify] https://crrev.com/e18e618f9e27b12ad26277f7a692766b513694a7/ash/mus/screen_mus.cc [modify] https://crrev.com/e18e618f9e27b12ad26277f7a692766b513694a7/ash/mus/screen_mus.h [modify] https://crrev.com/e18e618f9e27b12ad26277f7a692766b513694a7/ash/system/chromeos/rotation/tray_rotation_lock.cc
Comment 1 by bugdroid1@chromium.org
, Mar 14 2017