New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699880 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Change /var/run to /run

Project Member Reported by kirtika@chromium.org, Mar 9 2017

Issue description

Tracking bug for changing references of "/var/run" to "/run"
Since /var/run is a symlink to /run, and we want to avoid going
through the stateful /var whenever possible, use the direct path.

This applies to several CrOS repositories and partner overlays. 

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/721886e45e0ae2d10e4839286bea01f28be16c82

commit 721886e45e0ae2d10e4839286bea01f28be16c82
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Mar 10 21:05:18 2017

shill: Change /var/run to /run

Since /var/run is a symlink to /run, and we want to avoid going
through the stateful /var whenever possible, use the direct path.

BUG= chromium:699880 
TEST=shill unit-tests, booted and connected on Reef

Change-Id: I5ba0265a15452fe1090929510482567ae8e06079
Reviewed-on: https://chromium-review.googlesource.com/451440
Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org>
Tested-by: Kirtika Ruchandani <kirtika@chromium.org>
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>

[modify] https://crrev.com/721886e45e0ae2d10e4839286bea01f28be16c82/bin/shill_login_user
[modify] https://crrev.com/721886e45e0ae2d10e4839286bea01f28be16c82/bin/shill_logout_user
[modify] https://crrev.com/721886e45e0ae2d10e4839286bea01f28be16c82/shill.gyp
[modify] https://crrev.com/721886e45e0ae2d10e4839286bea01f28be16c82/init/shill-pre-start.sh

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 14 2017

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7d6c1c0de2720983184769f03dbcc27f440e458c

commit 7d6c1c0de2720983184769f03dbcc27f440e458c
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Mar 14 05:40:06 2017

wpa_supplicant: migrate to /run

Since /var/run is a symlink to /run, and we want to avoid going
through the stateful /var whenever possible, use the direct path.

BUG= chromium:699880 
TEST=precq passes

Change-Id: I8fc549cca999416eb3770e4a003b6fc0d9c594eb
Reviewed-on: https://chromium-review.googlesource.com/453241
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>

[modify] https://crrev.com/7d6c1c0de2720983184769f03dbcc27f440e458c/net-wireless/wpa_supplicant/wpa_supplicant-9999.ebuild
[modify] https://crrev.com/7d6c1c0de2720983184769f03dbcc27f440e458c/net-wireless/wpa_supplicant/files/init/wpasupplicant.conf

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a8776e339278e87ff5dde1492629aa741109c4e5

commit a8776e339278e87ff5dde1492629aa741109c4e5
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Mar 21 02:30:24 2017

bluez: migrate to /run

Since /var/run is a symlink to /run, and we want to avoid going
through the stateful /var whenever possible, use the direct path.

BUG= chromium:699880 
TEST=precq passes

Change-Id: I16810cde001ff33a660035a36ab8efc027bcb105
Reviewed-on: https://chromium-review.googlesource.com/453418
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>

[modify] https://crrev.com/a8776e339278e87ff5dde1492629aa741109c4e5/net-wireless/bluez/files/bluez-upstart.conf
[modify] https://crrev.com/a8776e339278e87ff5dde1492629aa741109c4e5/net-wireless/bluez/files/bluetoothd-directories.conf
[rename] https://crrev.com/a8776e339278e87ff5dde1492629aa741109c4e5/net-wireless/bluez/bluez-5.41-r87.ebuild

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/23a65668bbfae5d4a7c67f3c8ba248c8eb0b7213

commit 23a65668bbfae5d4a7c67f3c8ba248c8eb0b7213
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Mar 29 20:43:14 2017

trim: switch to /run/lock

Since /var/lock is a symlink to /run/lock, and we want to avoid going
through the stateful /var whenever possible, use the direct path.

BUG= chromium:699880 
TEST=precq is happy

Change-Id: Id56a0a426047bc97156f4f12557fdd507bdd15d1
Reviewed-on: https://chromium-review.googlesource.com/451462
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>

[modify] https://crrev.com/23a65668bbfae5d4a7c67f3c8ba248c8eb0b7213/trim/share/trim_utils.sh

Project Member

Comment 7 by bugdroid1@chromium.org, May 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0a99321dae3bb5690aeca1205de7bdb831acb251

commit 0a99321dae3bb5690aeca1205de7bdb831acb251
Author: Mike Frysinger <vapier@chromium.org>
Date: Sun May 07 02:52:27 2017

shill: move /etc/resolv.conf to /run

Since /var/run is a symlink to /run, and we want to avoid going
through the stateful /var whenever possible, use the direct path.

BUG= chromium:699880 
TEST=precq passes
CQ-DEPEND=CL:481201

Change-Id: I4bf2d463be9a715f4e05dbd3a69de7b5732ff887
Reviewed-on: https://chromium-review.googlesource.com/481200
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/0a99321dae3bb5690aeca1205de7bdb831acb251/chromeos-base/shill/shill-9999.ebuild

Project Member

Comment 8 by bugdroid1@chromium.org, May 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a1a45b85dbaf4c33eb809c6d7bdc962106068f72

commit a1a45b85dbaf4c33eb809c6d7bdc962106068f72
Author: Mike Frysinger <vapier@chromium.org>
Date: Sun May 07 02:52:28 2017

security_RootfsStatefulSymlinks: move /etc/resolv.conf to /run

Since /var/run is a symlink to /run, and we want to avoid going
through the stateful /var whenever possible, use the direct path.

BUG= chromium:699880 
TEST=precq passes
CQ-DEPEND=CL:481200

Change-Id: Icc6a2ac84c2906e8d92e038842525817880fd48b
Reviewed-on: https://chromium-review.googlesource.com/481201
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/a1a45b85dbaf4c33eb809c6d7bdc962106068f72/client/site_tests/security_RootfsStatefulSymlinks/baseline

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/ap-daemons/+/e75236ae0b7a57bedbf9d1adc3bac7d4600b5f2d

commit e75236ae0b7a57bedbf9d1adc3bac7d4600b5f2d
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Aug 01 02:21:07 2017

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/ap/+/4d86568284363e6d635af5391bd0600fe071ab51

commit 4d86568284363e6d635af5391bd0600fe071ab51
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Aug 01 17:15:42 2017

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/898bd550e04f770a321eb7daf8ab70732d06c3d7

commit 898bd550e04f770a321eb7daf8ab70732d06c3d7
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Aug 22 21:46:14 2017

migrate to /run and /run/lock

Since /var/run is a symlink to /run, and we want to avoid going
through the stateful /var whenever possible, use the direct path.
Same goes for /var/lock.

BUG= chromium:699880 
TEST=precq passes

Change-Id: I9c79d3bc8f1b3d9b0bed3127bdca3e3f7255f4ae
Reviewed-on: https://chromium-review.googlesource.com/473968
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>

[modify] https://crrev.com/898bd550e04f770a321eb7daf8ab70732d06c3d7/client/cros/crash/crash_test.py
[modify] https://crrev.com/898bd550e04f770a321eb7daf8ab70732d06c3d7/client/cros/vpn_server.py
[modify] https://crrev.com/898bd550e04f770a321eb7daf8ab70732d06c3d7/client/cros/chrooted_avahi.py
[modify] https://crrev.com/898bd550e04f770a321eb7daf8ab70732d06c3d7/client/site_tests/network_ShillInitScripts/network_ShillInitScripts.py
[modify] https://crrev.com/898bd550e04f770a321eb7daf8ab70732d06c3d7/client/cros/power_suspend.py
[modify] https://crrev.com/898bd550e04f770a321eb7daf8ab70732d06c3d7/client/site_tests/platform_TempFS/platform_TempFS.py
[modify] https://crrev.com/898bd550e04f770a321eb7daf8ab70732d06c3d7/client/common_lib/cros/arc_util.py
[modify] https://crrev.com/898bd550e04f770a321eb7daf8ab70732d06c3d7/client/tests/dbt2/pgpool.conf
[modify] https://crrev.com/898bd550e04f770a321eb7daf8ab70732d06c3d7/apache/conf/django-directives
[modify] https://crrev.com/898bd550e04f770a321eb7daf8ab70732d06c3d7/client/site_tests/platform_AnomalyCollector/platform_AnomalyCollector.py
[modify] https://crrev.com/898bd550e04f770a321eb7daf8ab70732d06c3d7/client/cros/constants.py
[modify] https://crrev.com/898bd550e04f770a321eb7daf8ab70732d06c3d7/client/site_tests/platform_MetricsUploader/platform_MetricsUploader.py
[modify] https://crrev.com/898bd550e04f770a321eb7daf8ab70732d06c3d7/client/common_lib/cros/arc.py
[modify] https://crrev.com/898bd550e04f770a321eb7daf8ab70732d06c3d7/client/site_tests/platform_TempFS/control
[modify] https://crrev.com/898bd550e04f770a321eb7daf8ab70732d06c3d7/site_utils/admin/apache/apache2.conf
[modify] https://crrev.com/898bd550e04f770a321eb7daf8ab70732d06c3d7/client/common_lib/cros/autoupdater.py
[modify] https://crrev.com/898bd550e04f770a321eb7daf8ab70732d06c3d7/client/site_tests/security_RootfsStatefulSymlinks/baseline
[modify] https://crrev.com/898bd550e04f770a321eb7daf8ab70732d06c3d7/client/cros/network_chroot.py
[modify] https://crrev.com/898bd550e04f770a321eb7daf8ab70732d06c3d7/client/cros/networking/shill_context.py

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/bf48bda38b92fedc4016c9d8a6c68dfe544cc65a

commit bf48bda38b92fedc4016c9d8a6c68dfe544cc65a
Author: Kirtika Ruchandani <kirtika@chromium.org>
Date: Mon Oct 09 07:12:33 2017

moblab: Switch /var/run to /run

Since /var/run is a symlink to /run, and we want to avoid going
through the stateful /var whenever possible, use the direct path.

BUG= chromium:699880 
TEST=None

Change-Id: I187006c5df4c3d4530b4ee5d81695df08d26d13d
Reviewed-on: https://chromium-review.googlesource.com/451939
Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org>
Tested-by: Kirtika Ruchandani <kirtika@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/bf48bda38b92fedc4016c9d8a6c68dfe544cc65a/project-moblab/chromeos-base/chromeos-bsp-moblab/files/moblab-apache-settings.conf
[modify] https://crrev.com/bf48bda38b92fedc4016c9d8a6c68dfe544cc65a/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-apache-init.conf
[modify] https://crrev.com/bf48bda38b92fedc4016c9d8a6c68dfe544cc65a/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-dhcpd-init.conf
[rename] https://crrev.com/bf48bda38b92fedc4016c9d8a6c68dfe544cc65a/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5-r68.ebuild
[modify] https://crrev.com/bf48bda38b92fedc4016c9d8a6c68dfe544cc65a/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-database-init.conf

Project Member

Comment 13 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/77ec85ea3bd9b0cf5e29f7365e7d00b3e4f882da

commit 77ec85ea3bd9b0cf5e29f7365e7d00b3e4f882da
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Oct 24 01:22:24 2017

README: use /run paths

Since /var/run is a symlink to /run, and we want to avoid going
through the stateful /var whenever possible, use the direct path.

BUG= chromium:699880 
TEST=precq passes

Change-Id: I5d95f5358c1fb0cb2ca73f9c4b145d8e36b4a361
Reviewed-on: https://chromium-review.googlesource.com/734225
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[modify] https://crrev.com/77ec85ea3bd9b0cf5e29f7365e7d00b3e4f882da/README.md

Project Member

Comment 14 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/docs/+/6579006002ed087e8dba2739dd9a09404bf5acc1

commit 6579006002ed087e8dba2739dd9a09404bf5acc1
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Oct 23 20:20:56 2017

Change /var/run paths to /run

Since /var/run is a symlink to /run, and we want to avoid going
through the stateful /var whenever possible, use the direct path.

BUG= chromium:699880 
TEST=precq passes

Change-Id: I35817c31ba3f466975e68ac8122d4c4105933dc1

[modify] https://crrev.com/6579006002ed087e8dba2739dd9a09404bf5acc1/dbus_best_practices.md
[modify] https://crrev.com/6579006002ed087e8dba2739dd9a09404bf5acc1/simple_chrome_workflow.md

Project Member

Comment 15 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/arc-camera/+/9e7a1e4d4275d65527325d9c9c0cc044cf99a5a9

commit 9e7a1e4d4275d65527325d9c9c0cc044cf99a5a9
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Oct 24 07:37:00 2017

migrate /var/run paths to /run

Since /var/run is a symlink to /run, and we want to avoid going
through the stateful /var whenever possible, use the direct path.

BUG= chromium:699880 
TEST=precq passes

Change-Id: I438f3d7c88290954206ff6881ac4a43ad321b9d3
Reviewed-on: https://chromium-review.googlesource.com/733874
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Ricky Liang <jcliang@chromium.org>
Reviewed-by: Hung-yu Wu <hywu@chromium.org>

[modify] https://crrev.com/9e7a1e4d4275d65527325d9c9c0cc044cf99a5a9/hal_adapter/camera_hal_server_impl.cc
[modify] https://crrev.com/9e7a1e4d4275d65527325d9c9c0cc044cf99a5a9/common/camera_algorithm_internal.h

Project Member

Comment 16 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/fd83b66d4448b972f75481aba18bf3beab1023fb

commit fd83b66d4448b972f75481aba18bf3beab1023fb
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Oct 24 22:30:18 2017

auto_updater: change /var/run paths to /run

Since /var/run is a symlink to /run, and we want to avoid going
through the stateful /var whenever possible, use the direct path.

BUG= chromium:699880 
TEST=precq passes

Change-Id: Ic1f3360d7df8ab75d62a8213461c0b97729fd651
Reviewed-on: https://chromium-review.googlesource.com/734227
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Amin Hassani <ahassani@chromium.org>

[modify] https://crrev.com/fd83b66d4448b972f75481aba18bf3beab1023fb/lib/auto_updater.py

Project Member

Comment 17 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/9404eb365b8439ca5b4ee64638c53bfd8e55ffdc

commit 9404eb365b8439ca5b4ee64638c53bfd8e55ffdc
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Oct 25 08:38:45 2017

mod_for_test_scripts: convert to /run

Since /var/run is a symlink to /run, and we want to avoid going
through the stateful /var whenever possible, use the direct path.

BUG= chromium:699880 
TEST=precq passes

Change-Id: I1f13029d06e2e177433acf555317685701551632
Reviewed-on: https://chromium-review.googlesource.com/733609
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Kirtika Ruchandani <kirtika@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>

[modify] https://crrev.com/9404eb365b8439ca5b4ee64638c53bfd8e55ffdc/mod_for_test_scripts/100setupTestingInterface

Project Member

Comment 18 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/initramfs/+/e895698b7005bbbd518b93b5d303d347c8f2ed1f

commit e895698b7005bbbd518b93b5d303d347c8f2ed1f
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Oct 26 09:33:46 2017

recovery: use /run directly

/var/run is a symlink to /run already.

BUG= chromium:699880 
TEST=samus recovery kernel still works

Change-Id: Iab4baa64f733cd0ee895ca5b01f06386bf866139
Reviewed-on: https://chromium-review.googlesource.com/737549
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/e895698b7005bbbd518b93b5d303d347c8f2ed1f/recovery/messages.sh

Project Member

Comment 19 by bugdroid1@chromium.org, Oct 28 2017

Status: Fixed (was: Started)
this is largely done now.  there might be some hold outs, but we can address them as we go.  cs/ doesn't show too many relevant hits anymore.
Project Member

Comment 21 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/db0b6e270a3a2d840fcd67dac2bd9c88ef4a761e

commit db0b6e270a3a2d840fcd67dac2bd9c88ef4a761e
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Nov 09 19:53:14 2017

crdev: use /run directly

/var/run is a symlink to /run already.

BUG= chromium:699880 
TEST=None

Change-Id: I37a289142b3389cc0dc81a10a1f608e99ed026eb
Reviewed-on: https://chromium-review.googlesource.com/759121
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>

[modify] https://crrev.com/db0b6e270a3a2d840fcd67dac2bd9c88ef4a761e/crdev

Comment 22 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 23 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment