Callback for WebApkUpdateManger::UpdateAsync() is not called when using Google Play updates |
|||||||||
Issue descriptionCallback for WebApkUpdateManger::UpdateAsync() is not called when using Google Play updates
,
Mar 14 2017
This bug was fixed by https://codereview.chromium.org/2740003002/ Marking as Fixed. Unfortunately, this CL is hard to test
,
Mar 14 2017
,
Mar 15 2017
Requesting a merge of https://codereview.chromium.org/2740003002/ to M58. The CL has made its way to Canary
,
Mar 17 2017
Peter, did you mean to tag Merge-Request-M58?
,
Mar 17 2017
,
Mar 20 2017
Thanks Sam, marked as Merge-Request-58
,
Mar 21 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d34d8a7b1dcccfa8ee2803000d0fab027f9eda0 commit 8d34d8a7b1dcccfa8ee2803000d0fab027f9eda0 Author: Peter Kotwicz <pkotwicz@google.com> Date: Tue Mar 21 19:18:56 2017 [WebAPKs]: Run WebApkInstaller::OnInstallFinished() for Google Play updates This CL: - fixes bug where WebApkInstaller#updateAsyncFromGooglePlay() was not calling nativeOnInstallFinished() - passes callback to GooglePlayWebApkInstallDelegate#installAsync() so that callback is called only after update completes Review-Url: https://codereview.chromium.org/2740003002 Cr-Commit-Position: refs/heads/master@{#456589} (cherry picked from commit 8c81f4b49feeac64da3f1ff1ff2dd58053420247) BUG= 699879 Review-Url: https://codereview.chromium.org/2767643003 . Cr-Commit-Position: refs/branch-heads/3029@{#339} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/8d34d8a7b1dcccfa8ee2803000d0fab027f9eda0/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java
,
Mar 23 2017
Marking as fixed since this was merged (please re-open if I'm mistaken) |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by pkotw...@chromium.org
, Mar 9 2017Labels: OS-Android