Align Location and WorkerLocation IDL with HTML spec |
|||||
Issue descriptionBlink's IDL is different in some subtle ways from the spec: https://html.spec.whatwg.org/multipage/browsers.html#location https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/frame/Location.idl https://html.spec.whatwg.org/multipage/workers.html#worker-locations https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/workers/WorkerLocation.idl First, the URLUtilsReadOnly mixin is gone from the spec, the interfaces have been "flattened". Our URLUtilsReadOnly.idl matches the spec's WorkerLocation, so that would be any easy fix. For Location: * A number of things are DOMString instead of USVString. * We have a toString() override instead of a stringifier keyword on the href attribute. * We have a valueOf() override that may or may not be explained by anything in the spec, but at any rate isn't in the spec. Of these, only the DOMString/USVString differences are clearly observable, the rest could be refactoring only.
,
Mar 9 2017
,
Mar 9 2017
,
Mar 14 2017
But Gecko doesn't have URLUtilsReadOnly
,
Mar 15 2017
Right, to fix this we'd get rid of URLUtilsReadOnly by flattening it into WorkerLocation.
,
Jul 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1eb90b4476ad3f09d6303f0dce5c0c3580629242 commit 1eb90b4476ad3f09d6303f0dce5c0c3580629242 Author: Takeshi Yoshino <tyoshino@chromium.org> Date: Sat Jul 15 06:30:48 2017 Add OWNERS and README.md to core/url/ and comment update in URLUtilsReadOnly.idl Bug: 699873 Change-Id: I9663d6728e770a4860f4f05beffc68722fa981b8 Reviewed-on: https://chromium-review.googlesource.com/571202 Reviewed-by: Sigbjørn Finne <sigbjornf@opera.com> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#486982} [add] https://crrev.com/1eb90b4476ad3f09d6303f0dce5c0c3580629242/third_party/WebKit/Source/core/url/OWNERS [add] https://crrev.com/1eb90b4476ad3f09d6303f0dce5c0c3580629242/third_party/WebKit/Source/core/url/README.md [modify] https://crrev.com/1eb90b4476ad3f09d6303f0dce5c0c3580629242/third_party/WebKit/Source/core/url/URLUtilsReadOnly.idl
,
Jun 12 2018
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4da8b35e88618534dd713edb42d532acfcf55ce2 commit 4da8b35e88618534dd713edb42d532acfcf55ce2 Author: Amos Lim <eui-sang.lim@samsung.com> Date: Fri Nov 16 09:05:15 2018 Remove URLUtilsReadOnly IDL by flattening it into WorkerLocation Align WorkerLocation IDL with HTML spec by getting rid of URLUtilsReadOnly and flattening it into WorkerLocation. Spec: https://html.spec.whatwg.org/multipage/workers.html#worker-locations Bug: 699873 Change-Id: I525a47c01e7ef31457958dd76a811134737597b4 Reviewed-on: https://chromium-review.googlesource.com/c/1339680 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#608703} [modify] https://crrev.com/4da8b35e88618534dd713edb42d532acfcf55ce2/third_party/blink/renderer/core/core_idl_files.gni [modify] https://crrev.com/4da8b35e88618534dd713edb42d532acfcf55ce2/third_party/blink/renderer/core/url/url.idl [delete] https://crrev.com/73564b6cfded2a0d68005f535be0f26505fd78f1/third_party/blink/renderer/core/url/url_utils_read_only.idl [modify] https://crrev.com/4da8b35e88618534dd713edb42d532acfcf55ce2/third_party/blink/renderer/core/workers/worker_location.idl
,
Nov 20
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by foolip@chromium.org
, Mar 9 2017