WebAPK updates are broken |
|||||
Issue descriptionhttps://chrome-internal-review.googlesource.com/c/331179/ broke WebAPK updates. We need to pass an extra parameter in order to do the right thing. I will fix when I change the GooglePlayWebApkInstallDelegate interface
,
Mar 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ed6bd7f20513e2df40909ccd6e1935d3021fcb3 commit 5ed6bd7f20513e2df40909ccd6e1935d3021fcb3 Author: pkotwicz <pkotwicz@chromium.org> Date: Mon Mar 13 18:26:42 2017 Explicitly check for an installed WebAPK before starting installation This CL moves the checking for whether a WebAPK is already installed from GooglePlayWebApkInstallDelegate to WebApkInstaller. This enables checking whether the WebAPK is already installed only for installs and not updates. Previously, the check was done for both installs and updates and prevented updates from occurring. BUG= 699870 Review-Url: https://codereview.chromium.org/2739303005 Cr-Commit-Position: refs/heads/master@{#456436} [modify] https://crrev.com/5ed6bd7f20513e2df40909ccd6e1935d3021fcb3/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java
,
Mar 14 2017
,
Mar 15 2017
Requesting a merge to M58. This CL has made its way to Chrome Canary
,
Mar 15 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa962b931c34b789ce8193c2a616226ed221f48b commit aa962b931c34b789ce8193c2a616226ed221f48b Author: Peter Kotwicz <pkotwicz@google.com> Date: Thu Mar 16 18:04:17 2017 Explicitly check for an installed WebAPK before starting installation This CL moves the checking for whether a WebAPK is already installed from GooglePlayWebApkInstallDelegate to WebApkInstaller. This enables checking whether the WebAPK is already installed only for installs and not updates. Previously, the check was done for both installs and updates and prevented updates from occurring. BUG= 699870 Review-Url: https://codereview.chromium.org/2739303005 Cr-Commit-Position: refs/heads/master@{#456436} (cherry picked from commit 5ed6bd7f20513e2df40909ccd6e1935d3021fcb3) Review-Url: https://codereview.chromium.org/2755723005 . Cr-Commit-Position: refs/branch-heads/3029@{#245} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/aa962b931c34b789ce8193c2a616226ed221f48b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java
,
Mar 16 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Mar 13 2017