Rethink the return value of FrameConnectedBluetoothDevices::CloseConnectionToDeviceWithAddress |
||||||
Issue descriptionBased on the comment at: https://codereview.chromium.org/2718583002/diff/60001/content/browser/bluetooth/frame_connected_bluetooth_devices.cc FrameConnectedBluetoothDevices::CloseConnectionToDeviceWithAddress returns the device id because we need it to send the event. But after the change of the above CL, we send the event from there and we don't need the device id. So the return value can be something else or even void.
,
Mar 10 2017
,
Mar 21 2017
I took another look at this, and FrameConnectedBluetoothDevices::CloseConnectionToDeviceWithAddress() needs to erase the device::BluetoothGattConnection and the mojom associated pointer from the map. So these pointers become invalid after the function call.
,
Mar 28 2017
We could take the pointer out of the map then delete the connection and finally return the pointer, right?
,
Apr 5 2017
,
Apr 5 2017
,
Apr 6 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 17 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ortuno@chromium.org
, Mar 9 2017