New issue
Advanced search Search tips

Issue 699812 link

Starred by 1 user
Status: Fixed
Owner:
tkent@chromium.org
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Node.isDefaultNamespace() handles nodes without parent incorrectly

Project Member Reported by tkent@chromium.org, Mar 9 2017 
Chrome Version: 59 canary
OS: All but iOS

What steps will reproduce the problem?
(1) Open http://w3c-test.org/dom/nodes/Node-lookupNamespaceURI.html

What is the expected result?
The following sub-tests pass:
- DocumentFragment is in default namespace, prefix null
- DocumentFragment is in default namespace, prefix ""
- Empty namespace is not default, prefix null
- Empty namespace is not default, prefix ""


What happens instead?
They fail.

Please use labels and text to provide additional information.
https://dom.spec.whatwg.org/#dom-node-isdefaultnamespace

The current implementation doesn't handle cases where the node has no parent and null namespace is specified correctly.

These tests pass with Firefox.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/089c67c27a4ea8c5a1aeafcc7674bff96298a1e3

commit 089c67c27a4ea8c5a1aeafcc7674bff96298a1e3
Author: tkent <tkent@chromium.org>
Date: Fri Mar 10 05:27:52 2017

[DOM] Fix null namespace handling in Node.isDefaultNamespace().

- Fix the implementation bug.
- Remove obsolete test in the legacy DOM conformance tests.
- Add tests for DocumentType node to WPT.

BUG= 699812 

Review-Url: https://codereview.chromium.org/2737273002
Cr-Commit-Position: refs/heads/master@{#456002}

[delete] https://crrev.com/ba3f171d0f3e4300341ba8a719f4f98f61af0165/third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/nodeisdefaultnamespace03-expected.txt
[delete] https://crrev.com/ba3f171d0f3e4300341ba8a719f4f98f61af0165/third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/nodeisdefaultnamespace03.js
[delete] https://crrev.com/ba3f171d0f3e4300341ba8a719f4f98f61af0165/third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/nodeisdefaultnamespace03.xhtml
[delete] https://crrev.com/ba3f171d0f3e4300341ba8a719f4f98f61af0165/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Node-lookupNamespaceURI-expected.txt
[modify] https://crrev.com/089c67c27a4ea8c5a1aeafcc7674bff96298a1e3/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Node-lookupNamespaceURI.html
[modify] https://crrev.com/089c67c27a4ea8c5a1aeafcc7674bff96298a1e3/third_party/WebKit/Source/core/dom/Node.cpp

Comment 2 by tkent@chromium.org, Mar 10 2017

Labels: M-59
Status: Fixed (was: Started)
►

Sign in to add a comment