Issue 699791 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	tbansal@chromium.org
Closed:	Apr 2017
Components:	Internals>Network>NetworkQuality
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	3
Type:	Bug
M-59

NQE: Cached hit rate should be recorded only for networks that support caching

Project Member Reported by tbansal@chromium.org, Mar 8 2017

Issue description

Currently, NQE.CachedNetworkQualityAvailable histogram is recorded on all connection types which makes the results difficult to interpret. This histogram should be recorded only when the cache is checked on a network that supports caching of network quality results.

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/746ad2a88e424ff48b4153b7db219eea98a0e79d

commit 746ad2a88e424ff48b4153b7db219eea98a0e79d
Author: tbansal <tbansal@chromium.org>
Date: Thu Mar 09 03:08:19 2017

Record UMA only when network quality is eligible for caching

BUG= 699791 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2731333003
Cr-Commit-Position: refs/heads/master@{#455651}

[modify] https://crrev.com/746ad2a88e424ff48b4153b7db219eea98a0e79d/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/746ad2a88e424ff48b4153b7db219eea98a0e79d/net/nqe/network_quality_estimator_unittest.cc
[modify] https://crrev.com/746ad2a88e424ff48b4153b7db219eea98a0e79d/net/nqe/network_quality_store.cc
[modify] https://crrev.com/746ad2a88e424ff48b4153b7db219eea98a0e79d/net/nqe/network_quality_store.h

Comment 2 by tbansal@chromium.org, Apr 27 2017

Labels: M-59
Status: Fixed (was: Assigned)

►

Issue 699791 link

Issue metadata

NQE: Cached hit rate should be recorded only for networks that support caching

Issue description

Comment 1 by bugdroid1@chromium.org, Mar 9 2017

Comment 1 Deleted

Comment 2 by tbansal@chromium.org, Apr 27 2017

Comment 2 Deleted

Sign in to add a comment