Issue metadata
Sign in to add a comment
|
run-webkit-tests: mac10.12 isn't mac? |
||||||||||||||||||||
Issue descriptionChrome Version: ToT OS: macOS 10.12 What steps will reproduce the problem? (1) run-webkit-tests fast/forms/select-popup What is the expected result? Run no tests because fast/forms/select-popup is marked as WontFix in NeverFixTests [ Mac ] fast/forms/select-popup [ WontFix ] What happens instead? 33 tests in fast/forms/select-popup ran. This is a recent regression.
,
Mar 8 2017
,
Mar 8 2017
Maybe the following line should be updated? https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py?type=cs&q=mac10.11+file:webkitpy&sq=package:chromium&l=102 > CONFIGURATION_SPECIFIER_MACROS = { > 'mac': ['retina', 'mac10.9', 'mac10.10', 'mac10.11'],
,
Mar 8 2017
Yep, that's right -- Mac10.12 is still in the process of getting set up (see bug 697971 ), and CONFIGURATION_SPECIFIER_MACROS definitely needs to be updated.
,
Mar 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/334f3cfa4383af5f17c35e0f23ee7485f37136ff commit 334f3cfa4383af5f17c35e0f23ee7485f37136ff Author: qyearsley <qyearsley@chromium.org> Date: Thu Mar 09 01:36:03 2017 Add mac10.12 to Port.ALL_SYSTEMS and Port.CONFIGURATION_SPECIFIER_MACROS. BUG= 699767 , 697971 Review-Url: https://codereview.chromium.org/2738053002 Cr-Commit-Position: refs/heads/master@{#455626} [modify] https://crrev.com/334f3cfa4383af5f17c35e0f23ee7485f37136ff/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
,
Mar 9 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by tkent@chromium.org
, Mar 8 2017Console output: tkent:~/chrome/src [master] % run-webkit-tests -t gnd fast/forms/select-popup Using port 'mac-mac10.12' Test configuration: <mac10.12, x86, debug> View the test results at file:///Users/tkent/chrome/src/out/gnd/layout-test-results/results.html View the archived results dashboard at file:///Users/tkent/chrome/src/out/gnd/layout-test-results/dashboard.html Using random order with seed: 1489014544 Baseline search path: mac -> generic Using Debug build Pixel tests enabled Regular timeout: 18000, slow test timeout: 90000 Command line: /Users/tkent/chrome/src/out/gnd/Content Shell.app/Contents/MacOS/Content Shell --run-layout-test - Found 33 tests; running 33, skipping 0. Running 1 Content Shell. ...