New issue
Advanced search Search tips

Issue 699736 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.3%-20% regression in memory.top_10_mobile at 455227:455296

Project Member Reported by benhenry@google.com, Mar 8 2017

Issue description

See the link to graphs below.
 
Cc: rmcilroy@chromium.org
Owner: rmcilroy@chromium.org

=== Auto-CCing suspected CL author rmcilroy@chromium.org ===

Hi rmcilroy@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Ross McIlroy
  Commit : f774d8c56f00de92614886fc4cb541411eff7aa1
  Date   : Tue Mar 07 20:41:12 2017
  Subject: [Flags] Add negation implications for --turbo negative so --no-turbo works.

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:v8:effective_size_avg/foreground/http_search_yahoo_com_search__ylt_p_google
  Change       : 19.89% | 5609900.0 -> 6725478.0

Revision                           Result                  N
chromium@455226                    5609900 +- 15565.4      6      good
chromium@455261                    5619282 +- 32752.1      6      good
chromium@455279                    5626413 +- 4420.35      6      good
chromium@455288                    5621499 +- 25943.8      9      good
chromium@455288,v8@f774d8c56f      6737366 +- 79092.7      6      bad       <--
chromium@455288,v8@181a1b4dff      6722269 +- 5292.21      6      bad
chromium@455289                    6601628 +- 1123872      9      bad
chromium@455290                    6759083 +- 124813       6      bad
chromium@455292                    6723391 +- 9310.19      6      bad
chromium@455296                    6725478 +- 13733.1      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8985652078285351296

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6461632043024384


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Cc: mstarzinger@chromium.org
Status: Started (was: Untriaged)
This is due to the flag negation turning off Ignition unless Turbo is also enabled. We are landing Turbo + Ignition for all platforms so that should fix this regression.
Status: WontFix (was: Started)
thanks.
Yup just looked at the graph and these all recovered after the I+TF roll. Thanks Ben.

Sign in to add a comment