Issue metadata
Sign in to add a comment
|
Convert remaining CBD pngs to vectors |
||||||||||||||||||||
Issue descriptionThis is not 0%, but a real change.
,
Mar 8 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8985655916075130752
,
Mar 10 2017
Direct link to size graph: https://chromeperf.appspot.com/report?sid=5d55db44beb13bb1e813882381fe82b47aa2934496f2e59840f8ee908da122ca&rev=455241 Although easy to see it's from images being added: https://codereview.chromium.org/2652983002 dullweber - Could you see about obtaining vector drawables for these? For reference, here's another ongoing change switching things over: https://bugs.chromium.org/p/chromium/issues/detail?id=697861
,
Mar 10 2017
I created a cl to replace the png files with vector images: http://crrev.com/2740893004
,
Mar 10 2017
I asked Christian to leave some of the pngs (ic_history_grey600_24dp) because I need them for an in-flight CL that requires the asset to be tinted depending on selected state. While we are making progress toward being able to tint vector drawables, we still don't have an implemented solution (see issue 697888). The other PNGs can be converted to vector drawables.
,
Mar 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aaa07f46771138c6b4f554ee34dba359ebd68813 commit aaa07f46771138c6b4f554ee34dba359ebd68813 Author: dullweber <dullweber@chromium.org> Date: Mon Mar 13 15:53:42 2017 Replace png icons from CBD with vector graphics. Screenshot with new vector icons (cache, passwords) https://screenshot.googleplex.com/2CrUBWX3suU.png Previous screenshot: https://screenshot.googleplex.com/GQ0LeamyMkN.png BUG= 699711 Review-Url: https://codereview.chromium.org/2740893004 Cr-Commit-Position: refs/heads/master@{#456389} [delete] https://crrev.com/5597947fdabe0d8449d99f9d43c041613a501b47/chrome/android/java/res/drawable-hdpi/ic_collections_grey600_24dp.png [delete] https://crrev.com/5597947fdabe0d8449d99f9d43c041613a501b47/chrome/android/java/res/drawable-hdpi/ic_vpn_key_grey600_24dp.png [delete] https://crrev.com/5597947fdabe0d8449d99f9d43c041613a501b47/chrome/android/java/res/drawable-mdpi/ic_collections_grey600_24dp.png [delete] https://crrev.com/5597947fdabe0d8449d99f9d43c041613a501b47/chrome/android/java/res/drawable-mdpi/ic_vpn_key_grey600_24dp.png [delete] https://crrev.com/5597947fdabe0d8449d99f9d43c041613a501b47/chrome/android/java/res/drawable-xhdpi/ic_collections_grey600_24dp.png [delete] https://crrev.com/5597947fdabe0d8449d99f9d43c041613a501b47/chrome/android/java/res/drawable-xhdpi/ic_vpn_key_grey600_24dp.png [delete] https://crrev.com/5597947fdabe0d8449d99f9d43c041613a501b47/chrome/android/java/res/drawable-xxhdpi/ic_collections_grey600_24dp.png [delete] https://crrev.com/5597947fdabe0d8449d99f9d43c041613a501b47/chrome/android/java/res/drawable-xxhdpi/ic_vpn_key_grey600_24dp.png [delete] https://crrev.com/5597947fdabe0d8449d99f9d43c041613a501b47/chrome/android/java/res/drawable-xxxhdpi/ic_collections_grey600_24dp.png [delete] https://crrev.com/5597947fdabe0d8449d99f9d43c041613a501b47/chrome/android/java/res/drawable-xxxhdpi/ic_vpn_key_grey600_24dp.png [add] https://crrev.com/aaa07f46771138c6b4f554ee34dba359ebd68813/chrome/android/java/res/drawable/ic_collections_grey.xml [add] https://crrev.com/aaa07f46771138c6b4f554ee34dba359ebd68813/chrome/android/java/res/drawable/ic_vpn_key_grey.xml [modify] https://crrev.com/aaa07f46771138c6b4f554ee34dba359ebd68813/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
,
Mar 14 2017
I changed 2/3 of the png icons to vectors. The last one will be converted when the right way to tint vectors is figured out.
,
Mar 23 2017
,
Mar 24 2017
,
May 9 2017
,
May 16 2017
The remaining png file (ic_history_grey600_24dp) is used by chrome home. I'm not sure if it would be a good idea to replace it with a vector because it will be shown very frequently and png icons have better performance. Should this issue be closed?
,
May 16 2017
ic_history_grey600_24dp shouldn't be converted to a vector, so, in my opinion, yes this can be closed.
,
May 17 2017
Closing this because most images have been converted and the last remaining image shouldn't be converted. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by benhenry@google.com
, Mar 8 2017