New issue
Advanced search Search tips

Issue 699697 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Task

Blocking:
issue 694734



Sign in to add a comment

Merge request for experimental feature: Chrome settings reset prompt

Project Member Reported by alito@chromium.org, Mar 8 2017

Issue description

The 3 CLs listed below are needed for a new experimental feature in Chrome that we would like to merge up to M58.

Launch bug: https://crbug.com/694734

The feature is disabled by default behind a Finch config. We would like to experiment with the feature on non-stable channels first, and if everything looks good according to our stats, to enable it for a small population of Windows Chrome users on stable as an experiment in M58.

The three CLs are:
https://codereview.chromium.org/2727063006/
https://codereview.chromium.org/2728773006/
https://codereview.chromium.org/2739513002/ (only adds UMA metrics)

We have confirmed that the first two CLs work as expected in the current Canary release (the last CL does not add any new functionality).
 

Comment 1 by alito@chromium.org, Mar 8 2017

Description: Show this description

Comment 2 by alito@chromium.org, Mar 8 2017

Blocking: 694734
Cc: csharp@chromium.org privard@chromium.org robertshield@chromium.org
Components: UI>Browser>Preferences>Protector
Labels: Merge-Request-58

Comment 3 by alito@chromium.org, Mar 9 2017

Labels: M-58
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 9 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Your change is approved for M58. Please merge ASAP so that it will be picked up for next Dev release.

Comment 6 by alito@chromium.org, Mar 10 2017

The CLs have now been merged.

Comment 7 by alito@chromium.org, Mar 10 2017

Status: Fixed (was: Untriaged)

Comment 8 by gov...@chromium.org, Mar 12 2017

Please merge your change to M58 branch 3029 before 5:00 PM PT, Monday (03/13/17) so we can take it in for next week dev release. Thank you!

Project Member

Comment 9 by sheriffbot@chromium.org, Mar 13 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-58 mer
Removing Merge-Approved-58 label since the merges were already completed.
Labels: -mer

Sign in to add a comment