New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699688 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug
ntp
Team-Accessibility



Sign in to add a comment

[A11y Assessment - NTP] Issues with interacting with site tiles

Project Member Reported by lpalmaro@chromium.org, Mar 8 2017

Issue description

Chrome Version: 
OS: Mac 

What steps will reproduce the problem?
(1) Enable Voiceover and use it to navigate through the NTP page, to the tile area 
(2) Attempt to navigate through the tiles and remove one from the page 

Two issues: 

1) The whole tile section is announced as Frame Zero. This needs to be better and more descriptive. 

2) The tiles don't appear to be marked up well for VoiceOver. You can technically get to everything you need to here, but in order to get to the close button, you have to focus the tile with VoiceOver, and then know to then press Ctrl Option Shift Down to interact with the items inside it. We need to figure out a way to tell VoiceOver to tell the user that this is interactive. There is no verbal indication of this right now, so unless I saw the X button visually, I wouldn't know to interact with it. 
 
Version: 56.0.2924.87
Cc: -ellyjo...@chromium.org
Owner: ellyjo...@chromium.org
Status: Assigned (was: Untriaged)
Labels: OS-Chrome
Adding a bit more context from testing on Chrome OS. When using ChromeVox to navigate through these, you simply can't get to the X close buttons using ChromeVox or just the keyboard. These X buttons are only available on mouse hover. If we don't want to go as far as to make each of these X buttons accessible with the keyboard, we need to at the very least put the option to remove the tile from the NTP in the context menu. 
Labels: NewComponent-Accessibility NewComponent-Accessibility-ChromeVox
Labels: -NewComponent-Accessibility-ChromeVox NewComponent-Accessibility-Browser
Labels: -newcomponent-accessibility-browser -newcomponent-accessibility
Owner: ----
Status: Available (was: Assigned)
Marking this Available pending the new NTP.
Any updates on timing regarding the new NTP? 

Comment 9 by treib@chromium.org, Nov 3 2017

Cc: treib@chromium.org sfiera@chromium.org
Components: UI>Browser>NewTabPage
The X buttons to remove tiles are now keyboard-focusable (M64 or later), both on the local and the remote NTP, so I believe that part is fixed.

I don't think the iframe has a proper title yet, but that should be easy to fix. Any guidance on what the string should be? "Most visited"?

Comment 10 by hwi@chromium.org, Nov 3 2017

Cc: maxwalker@chromium.org srahim@chromium.org
+srahim, +maxwalker

re: c#9 - label for a tile(that's what 'iframe' refers to, correct?)
- how about "{page title}, button"?
- 'button' because it looks and works like a button
- '{page title}' is used for tooltip as well.
- Although a challenge with "{page title}' is when its url is used as title, url seems the next alternative to identify a page when a title was not specified. 
Sorry, no, the "iframe" is the whole tiles section - what's announced as "Frame Zero" according to the original report.

The individual tiles do have the title in an "aria-label" property, so I'd hope they are being announced as something sensible. They are links rather than buttons, which I think makes sense, since they do essentially behave like a link.

Comment 12 by hwi@chromium.org, Nov 3 2017

Cc: lpalmaro@chromium.org leberly@chromium.org
+ lpalmaro@, leberly@, srahim@, Please advise here more regarding labeling a group element (I'm new to that area). 

Thanks for clarifying treib@. 

re: whole titles section
- How about "Most visited sites, 8 links" for the grouping(i.e. iframe)?

re: title
- 'link' sounds reasonable to me as well
- adding "x of y" at the end seems useful as well e.g. 'Twitter, link, 1 of 8'


Project Member

Comment 13 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bd69c3b82d7faa7060703854ee2930a97d20175

commit 7bd69c3b82d7faa7060703854ee2930a97d20175
Author: Marc Treib <treib@chromium.org>
Date: Mon Nov 27 15:53:12 2017

Local NTP: Set a title on the most visited iframe

Bug: 777167,  699688 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6688363fa9c1d996f3d0d6bb1f27fc4720f803df
Reviewed-on: https://chromium-review.googlesource.com/789846
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519309}
[modify] https://crrev.com/7bd69c3b82d7faa7060703854ee2930a97d20175/chrome/browser/resources/local_ntp/local_ntp.js
[modify] https://crrev.com/7bd69c3b82d7faa7060703854ee2930a97d20175/chrome/browser/search/local_ntp_source.cc

Comment 14 by treib@chromium.org, Nov 27 2017

The above CL sets a title of "Most visited" for the iframe. The counts would be a nice addition, but they might be hard to translate (and anyway will be more work).

Comment 15 by treib@chromium.org, Nov 28 2017

Labels: -Pri-2 OS-Linux OS-Windows Pri-3
I think the worst things here have been addressed: The confusing "frame zero" announcement is gone, and the "x" buttons on the tiles are now tabbable via the keyboard (which I hope also makes them accessible via VoiceOver).
Reducing prio for the remaining polish (count and "i of n" announcement).
This bug is related to https://bugs.chromium.org/p/chromium/issues/detail?id=696272

This bug is left open for the remaining polish (count and "i of n" announcement).

696272 is for being able to remove tiles using the keyboard



Labels: win-a11y
Labels: ntp
Labels: -Pri-3 Pri-2

Comment 20 by treib@chromium.org, Jan 11 2018

Labels: -Pri-2 Pri-3
Reducing prio since only some polish remains.

Comment 21 by treib@chromium.org, Jan 11 2018

Labels: ntp-starter-bug
Cc: adriennetran@google.com
Status: Fixed (was: Available)
Fixed in latest Canary

Sign in to add a comment