New issue
Advanced search Search tips

Issue 699678 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 671246



Sign in to add a comment

Convert WmWindowUserData to use aura

Project Member Reported by sky@chromium.org, Mar 8 2017

Issue description

e.g. DEFINE_UI_CLASS_PROPERTY_KEY
 

Comment 1 by sky@chromium.org, Mar 9 2017

Owner: sky@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e02e09e5f6b809e3af3c8d2707929c1bfcb43781

commit e02e09e5f6b809e3af3c8d2707929c1bfcb43781
Author: sky <sky@chromium.org>
Date: Thu Mar 09 22:54:23 2017

Renames WmWindowUserData and converts to using aura

As part of this I converted a handful of places from WmWindow to aura::Window. For example, GetContainersFromAllRootWindows was converted from WmWindow to aura::Window.

BUG= 699678 
TEST=covered by tests
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2735983006
Cr-Commit-Position: refs/heads/master@{#455891}

[modify] https://crrev.com/e02e09e5f6b809e3af3c8d2707929c1bfcb43781/ash/BUILD.gn
[add] https://crrev.com/e02e09e5f6b809e3af3c8d2707929c1bfcb43781/ash/common/window_user_data.h
[add] https://crrev.com/e02e09e5f6b809e3af3c8d2707929c1bfcb43781/ash/common/window_user_data_unittest.cc
[modify] https://crrev.com/e02e09e5f6b809e3af3c8d2707929c1bfcb43781/ash/common/wm/container_finder.cc
[modify] https://crrev.com/e02e09e5f6b809e3af3c8d2707929c1bfcb43781/ash/common/wm/container_finder.h
[modify] https://crrev.com/e02e09e5f6b809e3af3c8d2707929c1bfcb43781/ash/common/wm/screen_dimmer.cc
[modify] https://crrev.com/e02e09e5f6b809e3af3c8d2707929c1bfcb43781/ash/common/wm/screen_dimmer.h
[modify] https://crrev.com/e02e09e5f6b809e3af3c8d2707929c1bfcb43781/ash/common/wm/system_modal_container_layout_manager.cc
[modify] https://crrev.com/e02e09e5f6b809e3af3c8d2707929c1bfcb43781/ash/common/wm/window_dimmer.cc
[modify] https://crrev.com/e02e09e5f6b809e3af3c8d2707929c1bfcb43781/ash/common/wm/window_dimmer.h
[delete] https://crrev.com/77f6721b3f38f935a2fb473507dbba81bca6fea1/ash/common/wm_window_user_data.h
[delete] https://crrev.com/77f6721b3f38f935a2fb473507dbba81bca6fea1/ash/common/wm_window_user_data_unittest.cc
[modify] https://crrev.com/e02e09e5f6b809e3af3c8d2707929c1bfcb43781/ash/shell.cc
[modify] https://crrev.com/e02e09e5f6b809e3af3c8d2707929c1bfcb43781/ash/wm/ash_focus_rules.cc
[modify] https://crrev.com/e02e09e5f6b809e3af3c8d2707929c1bfcb43781/ash/wm/screen_dimmer_unittest.cc
[modify] https://crrev.com/e02e09e5f6b809e3af3c8d2707929c1bfcb43781/ash/wm/screen_pinning_controller.cc
[modify] https://crrev.com/e02e09e5f6b809e3af3c8d2707929c1bfcb43781/ash/wm/screen_pinning_controller.h
[modify] https://crrev.com/e02e09e5f6b809e3af3c8d2707929c1bfcb43781/ash/wm/system_modal_container_layout_manager_unittest.cc
[modify] https://crrev.com/e02e09e5f6b809e3af3c8d2707929c1bfcb43781/ui/base/class_property.h

Comment 3 by sky@chromium.org, Mar 9 2017

Status: Fixed (was: Started)
Summary: Convert WmWindowUserData to use aura (was: Remove WmWindowUserData and replace with aura properties)
I ended up doing something slightly different than I set out to. In particular WmWindowUserData is now WindowUserData and is in terms of aura, not WmWindow. So, while the class still exists it no longer uses WmWindow, which was the ultimate goal.

Comment 4 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 5 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment