New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699667 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Chrome , Mac
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

[A11y Assessment - Toolbar] Not able to access the volume controls in tabs with keyboard + Screen reader

Project Member Reported by lpalmaro@chromium.org, Mar 8 2017

Issue description

Chrome Version: 
OS: Mac 


What steps will reproduce the problem?
(1)  Enable VoiceOver
(2) Play a video with sound in a tab
(3) Attempt to navigate to the tab and control the mute button in the tab with the screen reader

I don't see a way to do this with keyboard and voiceover. When you press ctrl option shift m to open the context menu, the focus isn't on the tab so it doesn't pull up the right options. We need to figure out a way to make this work with keyboard and screen reader. 
 
This goes beyond just taking action on the volume control. This also has to do with being able to right click the tab with keyboard only and do things like pin the tab. 
Version: 56.0.2924.87
Labels: -Pri-2 Pri-1
Owner: ellyjo...@chromium.org
Status: Assigned (was: Untriaged)
I'll take this one on.

I think that probably, VoiceOver focus needs to go to the tab itself instead of to the close button, which is where it lands now, and then we could have the context menu open. Close Tab is available other ways too, so having focus not land on the close button is probably okay.
Labels: OS-Chrome OS-Windows
Same issue occurs on other platforms. 
Summary: [A11y Assessment - Toolbar] Not able to access the volume controls in tabs with keyboard + Screen reader (was: [A11y Assessment - Toolbar] Not able to access the volume controls in tabs with keyboard + VoiceOver)
Labels: NewComponent-Accessibility NewComponent-Accessibility-Browser
Labels: -newcomponent-accessibility-browser -newcomponent-accessibility
Project Member

Comment 9 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0101ba06c70108d8165c8e2f53e8f3069ab9478c

commit 0101ba06c70108d8165c8e2f53e8f3069ab9478c
Author: ellyjones <ellyjones@chromium.org>
Date: Fri May 19 15:50:26 2017

cocoa: add some tab-manipulation menu items

This change adds these items to the Window menu:
* Duplicate Tab
* Pin Tab
* Mute Tab

The latter two are toggle-able menu items.

BUG= 699667 

Review-Url: https://codereview.chromium.org/2876223003
Cr-Commit-Position: refs/heads/master@{#473202}

[modify] https://crrev.com/0101ba06c70108d8165c8e2f53e8f3069ab9478c/chrome/app/chrome_command_ids.h
[modify] https://crrev.com/0101ba06c70108d8165c8e2f53e8f3069ab9478c/chrome/app/generated_resources.grd
[modify] https://crrev.com/0101ba06c70108d8165c8e2f53e8f3069ab9478c/chrome/app/nibs/MainMenu.xib
[modify] https://crrev.com/0101ba06c70108d8165c8e2f53e8f3069ab9478c/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/0101ba06c70108d8165c8e2f53e8f3069ab9478c/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/0101ba06c70108d8165c8e2f53e8f3069ab9478c/chrome/browser/ui/browser_commands.h
[modify] https://crrev.com/0101ba06c70108d8165c8e2f53e8f3069ab9478c/chrome/browser/ui/cocoa/browser_window_command_handler.mm
[modify] https://crrev.com/0101ba06c70108d8165c8e2f53e8f3069ab9478c/chrome/browser/ui/tabs/tab_strip_model.cc
[modify] https://crrev.com/0101ba06c70108d8165c8e2f53e8f3069ab9478c/chrome/browser/ui/tabs/tab_strip_model.h

Status: Fixed (was: Assigned)
This is fixed by the above CL.

Sign in to add a comment