Issue metadata
Sign in to add a comment
|
Shelf overlaps bottom of maximized window in guest mode
Reported by
seanis...@gmail.com,
Mar 8 2017
|
||||||||||||||||||||||
Issue descriptionGoogle Chrome 58.0.3027.0 (Official Build) dev (64-bit) Platform 9331.0.0 (Official Build) dev-channel kip Firmware Version Google_Kip.5216.227.78 <b>Network info: <network, encryption type, router model (if known)></b> Please specify Cr-* of the system to which this bug/feature applies (add the label below). Steps To Reproduce: (1) Open guest mode (2) Open a full screen page, e.g. chrome://flags Expected Result: I can interact with elements at the bottom of the page Actual Result: The bottom of the page is behind the bottom bar. How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) Always What is the impact to the user, and is there a workaround? If so, what is it? Fairly annoying, but page can be minimized. Please provide any additional information below. Attach a screen shot or log if possible. Screenshot attached For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Mar 9 2017
,
Mar 14 2017
Issue 701528 has been merged into this issue.
,
Mar 14 2017
,
Mar 14 2017
This effects M58, which was recently promoted to Beta. Can somebody check the priority?
,
Mar 14 2017
,
Mar 14 2017
,
Mar 15 2017
issue not seen on latest M57. Tag it as M58.
,
Mar 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5859fcdeb7fa7508f902d80d401958c956cb964f commit 5859fcdeb7fa7508f902d80d401958c956cb964f Author: warx <warx@chromium.org> Date: Wed Mar 15 22:50:00 2017 cros: Fix shelf overlaps bottom of maximized window in guest session Changes: CL in https://codereview.chromium.org/2688353005 makes change that leave the shelf bottom locked and hidden until user prefs are loaded. When ChromeLauncherController::SetShelfBehaviorsFromPrefs(), it will be blocked on https://cs.chromium.org/chromium/src/ash/common/shelf/shelf_controller.cc?l=96, which leaves shelf alignment bottom locked in guest session. We don't set display work area change for bottom locked, that is why bug happens. Solution is to delete the CanChangeShelfAlignment() check as it should be enforced on shelf context menu already. BUG= 699661 TEST=emulator test saw reporter's bug fixed Review-Url: https://codereview.chromium.org/2748983004 Cr-Commit-Position: refs/heads/master@{#457246} [modify] https://crrev.com/5859fcdeb7fa7508f902d80d401958c956cb964f/ash/common/shelf/shelf_controller.cc
,
Mar 15 2017
Merge request to M-58 for #9 CL: (1) reporter's bug affects user experience badly (2) #9 CL should be pretty safe, and reviewer also suggests to do the back merge.
,
Mar 15 2017
,
Mar 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05f8c49347384a74e7081d0b1947a61406f96677 commit 05f8c49347384a74e7081d0b1947a61406f96677 Author: Qiang Xu <warx@chromium.org> Date: Wed Mar 15 23:32:12 2017 [Merge to M58] cros: Fix shelf overlaps bottom of maximized window in guest session Changes: CL in https://codereview.chromium.org/2688353005 makes change that leave the shelf bottom locked and hidden until user prefs are loaded. When ChromeLauncherController::SetShelfBehaviorsFromPrefs(), it will be blocked on https://cs.chromium.org/chromium/src/ash/common/shelf/shelf_controller.cc?l=96, which leaves shelf alignment bottom locked in guest session. We don't set display work area change for bottom locked, that is why bug happens. Solution is to delete the CanChangeShelfAlignment() check as it should be enforced on shelf context menu already. TBR=msw@chromium.org, jamescook@chromium.org BUG= 699661 TEST=emulator test saw reporter's bug fixed Review-Url: https://codereview.chromium.org/2748983004 Cr-Commit-Position: refs/heads/master@{#457246} (cherry picked from commit 5859fcdeb7fa7508f902d80d401958c956cb964f) Review-Url: https://codereview.chromium.org/2757453002 . Cr-Commit-Position: refs/branch-heads/3029@{#221} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/05f8c49347384a74e7081d0b1947a61406f96677/ash/common/shelf/shelf_controller.cc
,
Mar 15 2017
,
Mar 15 2017
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82d4b66fd8df31637f3a9cdbb4ada8a00b6b3781 commit 82d4b66fd8df31637f3a9cdbb4ada8a00b6b3781 Author: warx <warx@chromium.org> Date: Thu Mar 16 21:42:35 2017 cros: test coverage of shelf alignment initialization for guest session BUG= 699661 BUG= 702014 TEST=automated tests Review-Url: https://codereview.chromium.org/2741343018 Cr-Commit-Position: refs/heads/master@{#457568} [modify] https://crrev.com/82d4b66fd8df31637f3a9cdbb4ada8a00b6b3781/chrome/browser/ui/ash/shelf_browsertest.cc
,
Mar 22 2017
Verified on Chromeos 58.0.3029.31/9334.17.0 caroline |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vapier@chromium.org
, Mar 8 2017