New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699635 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 674219
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

<webview>: TakeFocus sometimes doesn't work with oopif

Project Member Reported by aval...@chromium.org, Mar 8 2017

Issue description

See test case here: https://codereview.chromium.org/2732913005/

The main issue is that if the next/previous element in focus order relative to the webview is focused and the webview is focused by the browser (clicking in the webview instead of tabbing in), then it is impossible to tab out of the webview in that direction

For example: <button id=a><webview><button id=b>. Start with b focused -> click the webview -> repeated tab keypressed. In this case focus never moves out of the webview and onto b.

Nothing happens in the embedder which should be refocusing b due to https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/page/FocusController.cpp?sq=package:chromium&dr&l=1001

 
I'm not sure if this would be the correct fix, but I'm thinking that RenderFrameProxy::OnSetFocusedFrame might need to change the focused element.
When the focus change into the guest webview is initiated by the embedder (handling a tab key event that moves into the webview), the owner document clears the focused element and the focuses the webview's iframe. This is why you can normally get out of the webview when reaching the last focusable element in the inner document.
Mergedinto: 674219
Status: Duplicate (was: Assigned)
Hah, reported my own bug twice.

Sign in to add a comment