if the build cycle is not successful, eg: exception occurs at the very beginning of the recipe run like bot_update, we should go back one more build to run the analysis.
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/b7dac2260a961be46af80d8d4e75365cfb070572 commit b7dac2260a961be46af80d8d4e75365cfb070572 Author: Chan <chanli@chromium.org> Date: Tue Mar 28 21:41:24 2017 [Findit] Flake Analyzer: Add sanity check for flake algorithms. For builds had exceptions, they may stop early without running the flaky test. We could not use the artifacts from those builds. 1. When trigger a swarming rerun, first check if can find the step in the original swarming task, if not, is there exception in build. 2. If found exception, this build cannot be used, save a data point of this build with 'valid_artifact' set to False 3. When searching for next build to run, keep a list for these 'bad builds', and check if a new candidate is in these builds, if so use a neighbour 4. After found suspected build, check if the suspected build's previous build is bad, if so, include the blame list of the bad build for try jobs as well BUG= 699613 Change-Id: Ie65a9b82cd8093a4a1e79d5777c0131a8a0e3ac5 Reviewed-on: https://chromium-review.googlesource.com/453080 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> Reviewed-by: Roberto Carrillo <robertocn@chromium.org> [modify] https://crrev.com/b7dac2260a961be46af80d8d4e75365cfb070572/appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py [modify] https://crrev.com/b7dac2260a961be46af80d8d4e75365cfb070572/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py [modify] https://crrev.com/b7dac2260a961be46af80d8d4e75365cfb070572/appengine/findit/waterfall/flake/test/lookback_algorithm_test.py [modify] https://crrev.com/b7dac2260a961be46af80d8d4e75365cfb070572/appengine/findit/waterfall/flake/recursive_flake_pipeline.py [modify] https://crrev.com/b7dac2260a961be46af80d8d4e75365cfb070572/appengine/findit/waterfall/flake/lookback_algorithm.py [modify] https://crrev.com/b7dac2260a961be46af80d8d4e75365cfb070572/appengine/findit/model/flake/test/master_flake_analysis_test.py [modify] https://crrev.com/b7dac2260a961be46af80d8d4e75365cfb070572/appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py [modify] https://crrev.com/b7dac2260a961be46af80d8d4e75365cfb070572/appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py [modify] https://crrev.com/b7dac2260a961be46af80d8d4e75365cfb070572/appengine/findit/model/flake/master_flake_analysis.py [modify] https://crrev.com/b7dac2260a961be46af80d8d4e75365cfb070572/appengine/findit/waterfall/flake/recursive_flake_try_job_pipeline.py [modify] https://crrev.com/b7dac2260a961be46af80d8d4e75365cfb070572/appengine/findit/waterfall/test/process_base_swarming_task_result_pipeline_test.py [modify] https://crrev.com/b7dac2260a961be46af80d8d4e75365cfb070572/appengine/findit/waterfall/flake/test/recursive_flake_try_job_pipeline_test.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/6580c905925f1d8ffe9c415caa77a2ce50cc5851 commit 6580c905925f1d8ffe9c415caa77a2ce50cc5851 Author: Chan Li <chanli@chromium.org> Date: Tue Mar 28 21:56:57 2017 Revert "[Findit] Flake Analyzer: Add sanity check for flake algorithms." This reverts commit b7dac2260a961be46af80d8d4e75365cfb070572. Reason for revert: <INSERT REASONING HERE> Original change's description: > [Findit] Flake Analyzer: Add sanity check for flake algorithms. > > For builds had exceptions, they may stop early without running the flaky test. We could not use the artifacts from those builds. > > 1. When trigger a swarming rerun, first check if can find the step in the original swarming task, if not, is there exception in build. > 2. If found exception, this build cannot be used, save a data point of this build with 'valid_artifact' set to False > 3. When searching for next build to run, keep a list for these 'bad builds', and check if a new candidate is in these builds, if so use a neighbour > 4. After found suspected build, check if the suspected build's previous build is bad, if so, include the blame list of the bad build for try jobs as well > > BUG= 699613 > > Change-Id: Ie65a9b82cd8093a4a1e79d5777c0131a8a0e3ac5 > Reviewed-on: https://chromium-review.googlesource.com/453080 > Commit-Queue: Chan Li <chanli@chromium.org> > Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> > Reviewed-by: Roberto Carrillo <robertocn@chromium.org> > TBR=stgao@chromium.org,robertocn@chromium.org,lijeffrey@chromium.org,chanli@chromium.org,chromium-reviews@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 699613 Change-Id: I94a17238014f8c07226ae53b7d77c869b987ddb7 Reviewed-on: https://chromium-review.googlesource.com/461296 Reviewed-by: Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> [modify] https://crrev.com/6580c905925f1d8ffe9c415caa77a2ce50cc5851/appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py [modify] https://crrev.com/6580c905925f1d8ffe9c415caa77a2ce50cc5851/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py [modify] https://crrev.com/6580c905925f1d8ffe9c415caa77a2ce50cc5851/appengine/findit/waterfall/flake/test/lookback_algorithm_test.py [modify] https://crrev.com/6580c905925f1d8ffe9c415caa77a2ce50cc5851/appengine/findit/waterfall/flake/recursive_flake_pipeline.py [modify] https://crrev.com/6580c905925f1d8ffe9c415caa77a2ce50cc5851/appengine/findit/waterfall/flake/lookback_algorithm.py [modify] https://crrev.com/6580c905925f1d8ffe9c415caa77a2ce50cc5851/appengine/findit/model/flake/test/master_flake_analysis_test.py [modify] https://crrev.com/6580c905925f1d8ffe9c415caa77a2ce50cc5851/appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py [modify] https://crrev.com/6580c905925f1d8ffe9c415caa77a2ce50cc5851/appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py [modify] https://crrev.com/6580c905925f1d8ffe9c415caa77a2ce50cc5851/appengine/findit/model/flake/master_flake_analysis.py [modify] https://crrev.com/6580c905925f1d8ffe9c415caa77a2ce50cc5851/appengine/findit/waterfall/flake/recursive_flake_try_job_pipeline.py [modify] https://crrev.com/6580c905925f1d8ffe9c415caa77a2ce50cc5851/appengine/findit/waterfall/test/process_base_swarming_task_result_pipeline_test.py [modify] https://crrev.com/6580c905925f1d8ffe9c415caa77a2ce50cc5851/appengine/findit/waterfall/flake/test/recursive_flake_try_job_pipeline_test.py
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/3b733d1312074714c784c0078192281b76072938 commit 3b733d1312074714c784c0078192281b76072938 Author: Chan <chanli@chromium.org> Date: Tue Mar 28 22:47:58 2017 Reland "[Findit] Flake Analyzer: Add sanity check for flake algorithms." Bug: 699613 Change-Id: Ic28d600c685885be69d8600c50745696b9a762e1 Reviewed-on: https://chromium-review.googlesource.com/461331 Reviewed-by: Shuotao Gao <stgao@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> [modify] https://crrev.com/3b733d1312074714c784c0078192281b76072938/appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py [modify] https://crrev.com/3b733d1312074714c784c0078192281b76072938/appengine/findit/waterfall/process_flake_swarming_task_result_pipeline.py [modify] https://crrev.com/3b733d1312074714c784c0078192281b76072938/appengine/findit/waterfall/flake/test/lookback_algorithm_test.py [modify] https://crrev.com/3b733d1312074714c784c0078192281b76072938/appengine/findit/waterfall/flake/recursive_flake_pipeline.py [modify] https://crrev.com/3b733d1312074714c784c0078192281b76072938/appengine/findit/waterfall/flake/lookback_algorithm.py [modify] https://crrev.com/3b733d1312074714c784c0078192281b76072938/appengine/findit/model/flake/test/master_flake_analysis_test.py [modify] https://crrev.com/3b733d1312074714c784c0078192281b76072938/appengine/findit/waterfall/process_base_swarming_task_result_pipeline.py [modify] https://crrev.com/3b733d1312074714c784c0078192281b76072938/appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py [modify] https://crrev.com/3b733d1312074714c784c0078192281b76072938/appengine/findit/model/flake/master_flake_analysis.py [modify] https://crrev.com/3b733d1312074714c784c0078192281b76072938/appengine/findit/waterfall/flake/recursive_flake_try_job_pipeline.py [modify] https://crrev.com/3b733d1312074714c784c0078192281b76072938/appengine/findit/waterfall/test/process_base_swarming_task_result_pipeline_test.py [modify] https://crrev.com/3b733d1312074714c784c0078192281b76072938/appengine/findit/waterfall/flake/test/recursive_flake_try_job_pipeline_test.py
Comment 1 by bugdroid1@chromium.org
, Mar 28 2017