Conformance tests to web-platform-tests for geometry interfaces |
||||||||
Issue descriptionhttp://test.csswg.org/suites/geometry-1_dev/nightly-unstable/html/toc.htm Upload these tests to web-platform-tests and also add more tests (structured cloning) to the test suites. Related issue: crbug.com/388780
,
Mar 8 2017
,
Mar 9 2017
,
Mar 9 2017
,
Mar 9 2017
I'm not sure but hs1217.lee@ investigated these tests. As the result, the test suit looks old and doesn't follow with current spec exactly.
,
Mar 9 2017
this test suit was made base on this spec(https://www.w3.org/TR/geometry-1/#). but GeometryInterfaces of chromium was implemented base on Editor’s Draft(https://drafts.fxtf.org/geometry/). should we need to update this test suit? or should we add new test suit base on Editor's Draft?
,
Mar 9 2017
hs1217.lee@: If you would like to start working on this pls feel free to own this issue; I may not be able to work on them immediately now. We should definitely follow the latest spec (https://drafts.fxtf.org/geometry/) in writing the tests. The old/outdated tests can be just used as a starting point to build a new test suite. To upload the tests, I guess we need a new directory in https://github.com/w3c/web-platform-tests.
,
Mar 11 2017
@xlai thank you. i will take care of this issue.
,
Mar 22 2017
first all before upload conformance tests to web-platform-tests, i found some problems of conformance tests. so after fix conformance test, i will upload conformance tests to web-platform-tests. i had send first pull-requests to fix conformance tests. (https://github.com/w3c/csswg-test/pull/1243)
,
Apr 25 2017
Note that csswg-test has now been merged into web-platform-tests, and this test suite is here: https://github.com/w3c/web-platform-tests/tree/master/css/geometry-1 I'll set it to be imported in W3CImportExpectations
,
Apr 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fffbf016d040c9fe6ee3ae7b0c0358e69ed2c4f4 commit fffbf016d040c9fe6ee3ae7b0c0358e69ed2c4f4 Author: foolip <foolip@chromium.org> Date: Tue Apr 25 13:24:45 2017 Import Geometry tests from web-platform-tests The actual tests will come with the next (automatic) import. BUG= 388780 , 699610 R=xlai@chromium.org,jinho.bang@samsung.com,hs1217.lee@samsung.com Review-Url: https://codereview.chromium.org/2841823002 Cr-Commit-Position: refs/heads/master@{#466963} [modify] https://crrev.com/fffbf016d040c9fe6ee3ae7b0c0358e69ed2c4f4/third_party/WebKit/LayoutTests/W3CImportExpectations
,
Apr 27 2017
,
May 8 2017
Anything missing on this issue? The Geometry tests are being imported and the tests are already updated or being so. Is it ok to close this?
,
May 8 2017
,
May 11 2017
Since geometry tests are being updated both ways, I'm going to close this. Re-open if there's an actual task missing. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by chrishtr@chromium.org
, Mar 8 2017