New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699578 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Collect reasonable metrics for percentage of page views that have tofu impressions

Project Member Reported by drott@chromium.org, Mar 8 2017

Issue description

I am thinking we could add a UMA histogram of script code or even character code / grapheme sequence for tofu rendered sequences / .notdef shaping results.
 

Comment 1 by drott@chromium.org, Mar 8 2017

Components: Blink>Fonts

Comment 2 Deleted

Cc: -brawer@google.com sascha@google.com

Comment 4 by drott@chromium.org, Mar 13 2017

Thank you, yes, that's whom I meant. 

Comment 5 by drott@chromium.org, Mar 15 2017

Cc: e...@chromium.org
My current thinking is to place two different metrics. One, UseCounter based, to record per page whether any shaping resulted in any .notdefs to see how often we have a .notdef impression as a ratio of all page views. Second, a metric in our shaping code that records a histogram of graphemes or only the initial characters for which no glyphs were found. What do you think, Sascha & Emil?

Comment 6 by sascha@google.com, Mar 15 2017

Sounds great!
Project Member

Comment 7 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3976985653410d2d753c268f8085873b6ed4a56

commit a3976985653410d2d753c268f8085873b6ed4a56
Author: drott <drott@chromium.org>
Date: Thu May 11 11:23:59 2017

Report new UseCounter metric when observing NotDef glyphs

When shaping fails to find at least one glyph, report this as a new
UseCounter metric "FontShapingNotDefGlyphObserved" for the current
document, which we can access via FontSelector. Measuring it as a ratio
against all UseCounter events should help us evaluate how frequently
.notdef glyphs occur in general. A separate histogram to be added later
will help find out for which characters or graphemes specifically we
fail to find glyphs for.

BUG=699578

Review-Url: https://codereview.chromium.org/2751163002
Cr-Commit-Position: refs/heads/master@{#470917}

[modify] https://crrev.com/a3976985653410d2d753c268f8085873b6ed4a56/third_party/WebKit/Source/core/css/CSSFontSelector.cpp
[modify] https://crrev.com/a3976985653410d2d753c268f8085873b6ed4a56/third_party/WebKit/Source/core/css/CSSFontSelector.h
[modify] https://crrev.com/a3976985653410d2d753c268f8085873b6ed4a56/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/a3976985653410d2d753c268f8085873b6ed4a56/third_party/WebKit/Source/platform/fonts/Font.cpp
[modify] https://crrev.com/a3976985653410d2d753c268f8085873b6ed4a56/third_party/WebKit/Source/platform/fonts/Font.h
[modify] https://crrev.com/a3976985653410d2d753c268f8085873b6ed4a56/third_party/WebKit/Source/platform/fonts/FontSelector.h
[modify] https://crrev.com/a3976985653410d2d753c268f8085873b6ed4a56/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
[modify] https://crrev.com/a3976985653410d2d753c268f8085873b6ed4a56/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h
[modify] https://crrev.com/a3976985653410d2d753c268f8085873b6ed4a56/third_party/WebKit/Source/platform/testing/FontTestHelpers.cpp
[modify] https://crrev.com/a3976985653410d2d753c268f8085873b6ed4a56/tools/metrics/histograms/enums.xml

Sign in to add a comment