Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 699569 Mojo JS bindings: change module loading from AMD to <script> tag
Starred by 5 users Project Member Reported by yzshen@chromium.org, Mar 8 Back to list
Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 647036
issue 711009



Sign in to add a comment
.
 
Project Member Comment 1 by bugdroid1@chromium.org, Mar 8
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b

commit e3c870b6d13a2b5a55deba853b04ad328fc4bc6b
Author: yzshen <yzshen@chromium.org>
Date: Wed Mar 08 18:06:52 2017

Mojo JS bindings: duplicate the bindings files into src/mojo/public/js/new_bindings.

New module-loading approach will be developed on this copy. The original code
will be removed after all user code is switched to the new approach.

BUG=699569

Review-Url: https://codereview.chromium.org/2736273002
Cr-Commit-Position: refs/heads/master@{#455492}

[add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/bindings.js
[add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/buffer.js
[add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/codec.js
[add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/connector.js
[add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/interface_types.js
[add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/lib/control_message_handler.js
[add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/lib/control_message_proxy.js
[add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/router.js
[add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/unicode.js
[add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/validator.js

Project Member Comment 2 by bugdroid1@chromium.org, Mar 25
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/628771d2f70705a9aba44a5f994dafdac9fd61ea

commit 628771d2f70705a9aba44a5f994dafdac9fd61ea
Author: yzshen <yzshen@chromium.org>
Date: Sat Mar 25 07:24:06 2017

Layout tests: Enable fetching generated files from the build directory.

This CL allows URLs that start with "file:///gen/" to be mapped to the files in "<build_dir>/gen/".

One use case is to allow loading generated mojom.js files using <script> tag. (We are already loading those generated mojom.js files, but using a special JS function exposed to the testing environment for AMD-style module loading. This CL is a cleaner approach.)

BUG=699569
TBR=jam@chromium.org
(jam@ delegated to other reviewers)

Review-Url: https://codereview.chromium.org/2759803002
Cr-Commit-Position: refs/heads/master@{#459641}

[modify] https://crrev.com/628771d2f70705a9aba44a5f994dafdac9fd61ea/content/shell/browser/layout_test/blink_test_controller.cc
[modify] https://crrev.com/628771d2f70705a9aba44a5f994dafdac9fd61ea/content/shell/common/layout_test.mojom
[modify] https://crrev.com/628771d2f70705a9aba44a5f994dafdac9fd61ea/content/shell/renderer/layout_test/blink_test_runner.cc

Project Member Comment 3 by bugdroid1@chromium.org, Mar 25
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0

commit e6a5534bb3fe61b5224f1a22e43ba957190ad5d0
Author: yzshen <yzshen@chromium.org>
Date: Sat Mar 25 15:59:50 2017

Mojo JS bindings: change module loading solution.

This change takes place on the mojo/public/js/new_bindings copy so it doesn't
affect existing users.

- This change gets rid of AMD module loading. Now the bindings API is defined in
the "mojoBindings" namespace. At build time, all bindings files are combined
into a single file "mojo_bindings.js". Users should use <script> tag to include
this file (as well as generated mojom.js files).

- Generated mojom.js files export their definitions under the same namespace as
the "module" statement in the corresponding mojom files.

- This change also adds a "use_new_js_bindings" option to the generator. It
  duplicates the control message mojom files in order to generate two
  different flavors of JS bindings.

- The new bindings use the Mojo system API defined by Web IDL.

BUG=699569

Review-Url: https://codereview.chromium.org/2759563004
Cr-Commit-Position: refs/heads/master@{#459654}

[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/interfaces/bindings/BUILD.gn
[add] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/interfaces/bindings/new_bindings/OWNERS
[add] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/interfaces/bindings/new_bindings/interface_control_messages.mojom
[add] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/interfaces/bindings/new_bindings/pipe_control_messages.mojom
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/interfaces/bindings/tests/BUILD.gn
[add] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/interfaces/bindings/tests/echo.mojom
[add] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/interfaces/bindings/tests/echo_import.mojom
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/BUILD.gn
[add] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/base.js
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/bindings.js
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/buffer.js
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/codec.js
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/connector.js
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/interface_types.js
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/lib/control_message_handler.js
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/lib/control_message_proxy.js
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/router.js
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/unicode.js
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/validator.js
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/tools/bindings/generators/js_templates/module_definition.tmpl
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/tools/bindings/generators/mojom_js_generator.py
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/tools/bindings/mojom.gni
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/tools/bindings/mojom_bindings_generator.py
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/tools/bindings/pylib/mojom/generate/generator.py
[add] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/third_party/WebKit/LayoutTests/mojo/module-loading.html

Project Member Comment 5 by bugdroid1@chromium.org, Mar 27
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae2b29ed27f84f0209be6f0482f5b85c0578ee75

commit ae2b29ed27f84f0209be6f0482f5b85c0578ee75
Author: hayato <hayato@chromium.org>
Date: Mon Mar 27 08:48:19 2017

Revert of Mojo JS bindings: support auto-loading mojom.js deps. (patchset #3 id:40001 of https://codereview.chromium.org/2779493002/ )

Reason for revert:
It looks we have to revert this CL too in order to revert https://codereview.chromium.org/2759563004/.

The previous revert failed in: https://codereview.chromium.org/2779533002/

Original issue's description:
> Mojo JS bindings: support auto-loading mojom.js deps.
>
> It also adds a config to turn off this behavior.
>
> BUG=699569
>
> Review-Url: https://codereview.chromium.org/2779493002
> Cr-Commit-Position: refs/heads/master@{#459695}
> Committed: https://chromium.googlesource.com/chromium/src/+/e326a5d409dadb3df6811b3dca7f1cfecb4ef520

TBR=rockot@chromium.org,yzshen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=699569

Review-Url: https://codereview.chromium.org/2777083002
Cr-Commit-Position: refs/heads/master@{#459724}

[modify] https://crrev.com/ae2b29ed27f84f0209be6f0482f5b85c0578ee75/mojo/public/js/new_bindings/base.js
[modify] https://crrev.com/ae2b29ed27f84f0209be6f0482f5b85c0578ee75/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl
[modify] https://crrev.com/ae2b29ed27f84f0209be6f0482f5b85c0578ee75/mojo/public/tools/bindings/generators/mojom_js_generator.py
[delete] https://crrev.com/f988185f6973f485ef5aeed2cc1b6e38797359bd/third_party/WebKit/LayoutTests/mojo/module-loading-manual-deps-loading.html
[modify] https://crrev.com/ae2b29ed27f84f0209be6f0482f5b85c0578ee75/third_party/WebKit/LayoutTests/mojo/module-loading.html

Project Member Comment 6 by bugdroid1@chromium.org, Mar 27
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06cde11f9f3843eb13e3d3d73296a07e9e8601f5

commit 06cde11f9f3843eb13e3d3d73296a07e9e8601f5
Author: hayato <hayato@chromium.org>
Date: Mon Mar 27 10:55:09 2017

Revert of Mojo JS bindings: change module loading solution. (patchset #7 id:120001 of https://codereview.chromium.org/2759563004/ )

Reason for revert:
Consistent failure: webkit_tests failing on 6 builders

33 since the first detection
e.g. https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.10

This CL is suspicious because mojo/module-loading.html has been failing.

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Mac10.10%2F31815%2F%2B%2Frecipes%2Fsteps%2Fwebkit_tests%2F0%2Fstdout

Regressions: Unexpected text-only failures (1)
  mojo/module-loading.html [ Failure ]

09:20:53.708 5958 worker/0 virtual/mojo-loading/http/tests/bluetooth/https/requestDevice/cross-origin-iframe.html output stderr lines:
09:20:53.709 5958   [09:20:53.354] vtDecompressionDuctCreate signalled err=-8973 (err) (Could not select and open decoder instance) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.235/Sources/VideoToolbox/VTDecompressionSession.c line 1181
09:20:53.709 5958   <<<< VTVideoEncoderSelection >>>> VTSelectAndCreateVideoEncoderInstanceInternal: no video encoder found for 'avc1'

Original issue's description:
> Mojo JS bindings: change module loading solution.
>
> This change takes place on the mojo/public/js/new_bindings copy so it doesn't
> affect existing users.
>
> - This change gets rid of AMD module loading. Now the bindings API is defined in
> the "mojoBindings" namespace. At build time, all bindings files are combined
> into a single file "mojo_bindings.js". Users should use <script> tag to include
> this file (as well as generated mojom.js files).
>
> - Generated mojom.js files export their definitions under the same namespace as
> the "module" statement in the corresponding mojom files.
>
> - This change also adds a "use_new_js_bindings" option to the generator. It
>   duplicates the control message mojom files in order to generate two
>   different flavors of JS bindings.
>
> - The new bindings use the Mojo system API defined by Web IDL.
>
> BUG=699569
>
> Review-Url: https://codereview.chromium.org/2759563004
> Cr-Commit-Position: refs/heads/master@{#459654}
> Committed: https://chromium.googlesource.com/chromium/src/+/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0

TBR=rockot@chromium.org,dcheng@chromium.org,alokp@chromium.org,yzshen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=699569

Review-Url: https://codereview.chromium.org/2779533002
Cr-Commit-Position: refs/heads/master@{#459745}

[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/interfaces/bindings/BUILD.gn
[delete] https://crrev.com/931e61729f1b53919be3192d0d77cdf1f004c894/mojo/public/interfaces/bindings/new_bindings/OWNERS
[delete] https://crrev.com/931e61729f1b53919be3192d0d77cdf1f004c894/mojo/public/interfaces/bindings/new_bindings/interface_control_messages.mojom
[delete] https://crrev.com/931e61729f1b53919be3192d0d77cdf1f004c894/mojo/public/interfaces/bindings/new_bindings/pipe_control_messages.mojom
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/interfaces/bindings/tests/BUILD.gn
[delete] https://crrev.com/931e61729f1b53919be3192d0d77cdf1f004c894/mojo/public/interfaces/bindings/tests/echo.mojom
[delete] https://crrev.com/931e61729f1b53919be3192d0d77cdf1f004c894/mojo/public/interfaces/bindings/tests/echo_import.mojom
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/BUILD.gn
[delete] https://crrev.com/931e61729f1b53919be3192d0d77cdf1f004c894/mojo/public/js/new_bindings/base.js
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/bindings.js
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/buffer.js
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/codec.js
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/connector.js
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/interface_types.js
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/lib/control_message_handler.js
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/lib/control_message_proxy.js
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/router.js
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/unicode.js
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/validator.js
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/tools/bindings/generators/js_templates/module_definition.tmpl
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/tools/bindings/generators/mojom_js_generator.py
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/tools/bindings/mojom.gni
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/tools/bindings/mojom_bindings_generator.py
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/tools/bindings/pylib/mojom/generate/generator.py
[delete] https://crrev.com/931e61729f1b53919be3192d0d77cdf1f004c894/third_party/WebKit/LayoutTests/mojo/module-loading.html

Project Member Comment 7 by bugdroid1@chromium.org, Apr 2
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a06469911359843f3d823fac7a7c06fec3c46edb

commit a06469911359843f3d823fac7a7c06fec3c46edb
Author: yzshen <yzshen@chromium.org>
Date: Sun Apr 02 22:01:27 2017

Mojo JS bindings: change module loading solution.

This change takes place on the mojo/public/js/new_bindings copy so it doesn't
affect existing users.

- This change gets rid of AMD module loading. Now the bindings API is defined in
the "mojo" namespace. At build time, all bindings files are combined
into a single file "mojo_bindings.js". Users should use <script> tag to include
this file (as well as generated mojom.js files).

- Generated mojom.js files export their definitions under the same namespace as
the "module" statement in the corresponding mojom files.

- This change also adds a "use_new_js_bindings" option to the generator. It
  duplicates the control message mojom files in order to generate two
  different flavors of JS bindings.

- The new bindings use the Mojo system API defined by Web IDL.

BUG=699569

Review-Url: https://codereview.chromium.org/2759563004
Cr-Original-Commit-Position: refs/heads/master@{#459654}
Committed: https://chromium.googlesource.com/chromium/src/+/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0
Review-Url: https://codereview.chromium.org/2759563004
Cr-Commit-Position: refs/heads/master@{#461349}

[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/BUILD.gn
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/interfaces/bindings/BUILD.gn
[add] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/interfaces/bindings/new_bindings/OWNERS
[add] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/interfaces/bindings/new_bindings/interface_control_messages.mojom
[add] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/interfaces/bindings/new_bindings/pipe_control_messages.mojom
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/interfaces/bindings/tests/BUILD.gn
[add] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/interfaces/bindings/tests/echo.mojom
[add] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/interfaces/bindings/tests/echo_import.mojom
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/BUILD.gn
[add] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/base.js
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/bindings.js
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/buffer.js
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/codec.js
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/connector.js
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/interface_types.js
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/lib/control_message_handler.js
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/lib/control_message_proxy.js
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/router.js
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/unicode.js
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/validator.js
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/tools/bindings/generators/js_templates/module_definition.tmpl
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/tools/bindings/generators/mojom_js_generator.py
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/tools/bindings/mojom.gni
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/tools/bindings/mojom_bindings_generator.py
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/tools/bindings/pylib/mojom/generate/generator.py
[add] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/third_party/WebKit/LayoutTests/mojo/module-loading.html

Blocking: 711009
Project Member Comment 10 by bugdroid1@chromium.org, May 20
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e95f5e84d92d7690faed48157cbe09fc6762376

commit 8e95f5e84d92d7690faed48157cbe09fc6762376
Author: yzshen <yzshen@chromium.org>
Date: Sat May 20 15:25:09 2017

Mojo JS bindings: switch all mojo/ layout tests to use the new bindings.

BUG=699569

Review-Url: https://codereview.chromium.org/2891193002
Cr-Commit-Position: refs/heads/master@{#473439}

[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/interfaces/bindings/tests/BUILD.gn
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/js/BUILD.gn
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/js/new_bindings/bindings.js
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/js/new_bindings/connector.js
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/js/new_bindings/lib/interface_endpoint_client.js
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/js/new_bindings/router.js
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/js/new_bindings/validator.js
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/tools/bindings/generators/js_templates/module_definition.tmpl
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/tools/bindings/pylib/mojom/generate/generator.py
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/associated_binding.html
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/associated_interface_ptr.html
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/binding.html
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/codec.html
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/connection.html
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/interface_ptr.html
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/resources/validation_test_input_parser.js
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/sample_service.html
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/struct.html
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/union.html
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/validation.html
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/Source/core/mojo/MojoWatcher.cpp

Project Member Comment 11 by bugdroid1@chromium.org, May 26
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2296029e3eb2343421c90354582aa111ecba43d6

commit 2296029e3eb2343421c90354582aa111ecba43d6
Author: Ken Rockot <rockot@chromium.org>
Date: Fri May 26 09:04:28 2017

Enable Blink native Mojo bindings in WebUI

Adds the concept of ContextEnabled features as an extended attribute in
Web IDL, exposing a way for embedders to turn specific API features on
or off at context creation time.

Affixes this extended attribute to Mojo, MojoHandle, and MojoWatcher
IDLs to allow their exposure to be controlled per-context separately
from the MojoJS RuntimeEnabled state.

Finally, this also flips on the MojoJS ContextEnabled feature for all
RenderFrame contexts in which WebUI bindings are enabled.

BUG=699569, 723923 

Change-Id: Ie0fd6383ae86c133685b3e7b31eeca769bf83e06
Reviewed-on: https://chromium-review.googlesource.com/509390
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474973}
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/content/browser/webui/web_ui_mojo_browsertest.cc
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/content/renderer/mojo_bindings_controller.cc
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/content/renderer/mojo_bindings_controller.h
[add] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/content/test/data/web_ui_mojo_native.html
[add] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/content/test/data/web_ui_mojo_native.js
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/IDLExtendedAttributes.md
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/IDLExtendedAttributes.txt
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/core/v8/ConditionalFeaturesForCore.cpp
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/scripts/generate_global_constructors.py
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/scripts/v8_attributes.py
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/scripts/v8_interface.py
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/scripts/v8_utilities.py
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/templates/interface.h.tmpl
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/templates/partial_interface.h.tmpl
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/tests/idls/core/TestInterface.idl
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/core/BUILD.gn
[add] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/core/context_features/BUILD.gn
[add] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/core/context_features/ContextFeatureSettings.cpp
[add] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/core/context_features/ContextFeatureSettings.h
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/core/mojo/Mojo.idl
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/core/mojo/MojoHandle.idl
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/core/mojo/MojoWatcher.idl
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/web/BUILD.gn
[add] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/web/WebContextFeatures.cpp
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/public/BUILD.gn
[add] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/public/web/WebContextFeatures.h

Blocking: 647036
Project Member Comment 13 by bugdroid1@chromium.org, May 29
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eae56c386f559a286494aeb58f7fd9857efd960d

commit eae56c386f559a286494aeb58f7fd9857efd960d
Author: yzshen <yzshen@chromium.org>
Date: Mon May 29 10:00:42 2017

Mojo JS bindings: flip the default value of use_new_js_bindings to true.

BUG=699569
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2910703004
Cr-Commit-Position: refs/heads/master@{#475327}

[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/chrome/browser/engagement/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/chrome/browser/ui/webui/omnibox/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/chrome/browser/ui/webui/usb_internals/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/chrome/common/media_router/mojo/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/components/payments/mojom/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/content/test/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/device/bluetooth/public/interfaces/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/device/generic_sensor/public/interfaces/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/device/geolocation/public/interfaces/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/device/usb/public/interfaces/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/device/vr/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/extensions/common/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/extensions/common/api/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/gpu/ipc/common/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/ios/web/test/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/media/capture/mojo/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/mojo/common/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/mojo/edk/js/tests/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/mojo/public/interfaces/bindings/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/mojo/public/interfaces/bindings/tests/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/mojo/public/tools/bindings/mojom.gni
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/net/interfaces/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/services/device/public/interfaces/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/services/service_manager/public/interfaces/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/services/shape_detection/public/interfaces/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/ui/gfx/geometry/mojo/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/url/mojo/BUILD.gn

Project Member Comment 14 by bugdroid1@chromium.org, Jun 2
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9821a80606c582307bc791c798c6ccaeadaa70ec

commit 9821a80606c582307bc791c798c6ccaeadaa70ec
Author: junwei.fu <junwei.fu@intel.com>
Date: Fri Jun 02 03:51:48 2017

Mojo JS bindings: flip the default value of use_new_js_bindings to true.

Test cases will time out when CL [1] using skia mojo bitmap.

[1] https://codereview.chromium.org/2875243002#

BUG=699569

Review-Url: https://codereview.chromium.org/2912323002
Cr-Commit-Position: refs/heads/master@{#476555}

[modify] https://crrev.com/9821a80606c582307bc791c798c6ccaeadaa70ec/skia/public/interfaces/BUILD.gn

Project Member Comment 16 by bugdroid1@chromium.org, Jun 7
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd57fa764813de09d159a232eeef1bb21b0ccc1e

commit dd57fa764813de09d159a232eeef1bb21b0ccc1e
Author: alokp <alokp@chromium.org>
Date: Wed Jun 07 04:27:00 2017

Moves mojo_js_integration_tests into blink.

BUG=699569

Review-Url: https://codereview.chromium.org/2734783008
Cr-Commit-Position: refs/heads/master@{#477549}

[modify] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/mojo/edk/js/tests/BUILD.gn
[delete] https://crrev.com/8709f78a5a70fd9db4414ca6c0fe281d668f31e5/mojo/edk/js/tests/js_to_cpp_tests.cc
[modify] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/testing/buildbot/client.v8.chromium.json
[modify] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/third_party/WebKit/Source/core/mojo/BUILD.gn
[rename] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/third_party/WebKit/Source/core/mojo/tests/JsToCpp.mojom
[add] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.cpp
[rename] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.js
[add] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/third_party/WebKit/Source/core/mojo/tests/OWNERS
[modify] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp
[modify] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h
[modify] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/tools/determinism/deterministic_build_whitelist.pyl

Project Member Comment 17 by bugdroid1@chromium.org, Jun 7
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6536a56d25c245bd109e32ed49240bfc04f8890f

commit 6536a56d25c245bd109e32ed49240bfc04f8890f
Author: jwd <jwd@chromium.org>
Date: Wed Jun 07 15:20:41 2017

Revert of Moves mojo_js_integration_tests into blink. (patchset #11 id:190001 of https://codereview.chromium.org/2734783008/ )

Reason for revert:
Seems related to webkit failures of the JsToCpp tests. E.x. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/34530.

Original issue's description:
> Moves mojo_js_integration_tests into blink.
>
> BUG=699569
>
> Review-Url: https://codereview.chromium.org/2734783008
> Cr-Commit-Position: refs/heads/master@{#477549}
> Committed: https://chromium.googlesource.com/chromium/src/+/dd57fa764813de09d159a232eeef1bb21b0ccc1e

TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,alokp@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=699569

Review-Url: https://codereview.chromium.org/2926143002
Cr-Commit-Position: refs/heads/master@{#477653}

[modify] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/mojo/edk/js/tests/BUILD.gn
[rename] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/mojo/edk/js/tests/js_to_cpp.mojom
[add] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/mojo/edk/js/tests/js_to_cpp_tests.cc
[rename] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/mojo/edk/js/tests/js_to_cpp_tests.js
[modify] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/testing/buildbot/client.v8.chromium.json
[modify] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/third_party/WebKit/Source/core/mojo/BUILD.gn
[delete] https://crrev.com/b3f80bd4e91f989a0a52f8cf2baa9fcc4df4fd75/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.cpp
[delete] https://crrev.com/b3f80bd4e91f989a0a52f8cf2baa9fcc4df4fd75/third_party/WebKit/Source/core/mojo/tests/OWNERS
[modify] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp
[modify] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h
[modify] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/tools/determinism/deterministic_build_whitelist.pyl

Project Member Comment 18 by bugdroid1@chromium.org, Jun 7
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea19acc0fca1c00e9ea1dd01df0a462126902faf

commit ea19acc0fca1c00e9ea1dd01df0a462126902faf
Author: Ken Rockot <rockot@chromium.org>
Date: Wed Jun 07 18:12:07 2017

Convert chrome://omnibox to new Mojo bindings

Makes the generated, concatenated public Mojo JS bindings library
available as a shared WebUI resource and converts the chrome://omnibox
page to use the new bindings in place of the old ones.

BUG=699569

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib22df79892cf737dbcfad5320b5ddf7b2028bfcf
Reviewed-on: https://chromium-review.googlesource.com/523421
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477707}
[modify] https://crrev.com/ea19acc0fca1c00e9ea1dd01df0a462126902faf/chrome/browser/resources/omnibox/omnibox.html
[modify] https://crrev.com/ea19acc0fca1c00e9ea1dd01df0a462126902faf/chrome/browser/resources/omnibox/omnibox.js
[modify] https://crrev.com/ea19acc0fca1c00e9ea1dd01df0a462126902faf/chrome/browser/ui/webui/omnibox/BUILD.gn
[modify] https://crrev.com/ea19acc0fca1c00e9ea1dd01df0a462126902faf/chrome/browser/ui/webui/omnibox/omnibox_ui.cc
[modify] https://crrev.com/ea19acc0fca1c00e9ea1dd01df0a462126902faf/content/browser/webui/shared_resources_data_source.cc
[modify] https://crrev.com/ea19acc0fca1c00e9ea1dd01df0a462126902faf/ui/resources/BUILD.gn
[modify] https://crrev.com/ea19acc0fca1c00e9ea1dd01df0a462126902faf/ui/webui/resources/webui_resources.grd

Project Member Comment 19 by bugdroid1@chromium.org, Jun 12
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961

commit 0fac10b6b0a132a25eedf971c8ccffaa6e8a4961
Author: alokp <alokp@chromium.org>
Date: Mon Jun 12 23:34:14 2017

Reland of Moves mojo_js_integration_tests into blink. (patchset #1 id:1 of https://codereview.chromium.org/2926143002/ )

Reason for revert:
Fixed failing tests.

Original issue's description:
> Revert of Moves mojo_js_integration_tests into blink. (patchset #11 id:190001 of https://codereview.chromium.org/2734783008/ )
>
> Reason for revert:
> Seems related to webkit failures of the JsToCpp tests. E.x. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/34530.
>
> Original issue's description:
> > Moves mojo_js_integration_tests into blink.
> >
> > BUG=699569
> >
> > Review-Url: https://codereview.chromium.org/2734783008
> > Cr-Commit-Position: refs/heads/master@{#477549}
> > Committed: https://chromium.googlesource.com/chromium/src/+/dd57fa764813de09d159a232eeef1bb21b0ccc1e
>
> TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,alokp@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=699569
>
> Review-Url: https://codereview.chromium.org/2926143002
> Cr-Commit-Position: refs/heads/master@{#477653}
> Committed: https://chromium.googlesource.com/chromium/src/+/6536a56d25c245bd109e32ed49240bfc04f8890f

TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,jwd@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=699569

Review-Url: https://codereview.chromium.org/2920383004
Cr-Commit-Position: refs/heads/master@{#478820}

[modify] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/mojo/edk/js/tests/BUILD.gn
[delete] https://crrev.com/f1e4c0cc3c76b155337800383e54537a88fcdfe7/mojo/edk/js/tests/js_to_cpp_tests.cc
[modify] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/testing/buildbot/client.v8.chromium.json
[modify] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/third_party/WebKit/Source/core/mojo/BUILD.gn
[rename] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/third_party/WebKit/Source/core/mojo/tests/JsToCpp.mojom
[add] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.cpp
[rename] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.js
[add] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/third_party/WebKit/Source/core/mojo/tests/OWNERS
[modify] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp
[modify] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h
[modify] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/tools/determinism/deterministic_build_whitelist.pyl

Project Member Comment 20 by bugdroid1@chromium.org, Jun 13
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38f3a45e512fed9682729fcf57bdacfc6bfc1ece

commit 38f3a45e512fed9682729fcf57bdacfc6bfc1ece
Author: tzik <tzik@chromium.org>
Date: Tue Jun 13 03:16:20 2017

Revert of Moves mojo_js_integration_tests into blink. (patchset #1 id:1 of https://codereview.chromium.org/2920383004/ )

Reason for revert:
This CL seems to break webkit_unittests.
The error log is:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/34695

The tests below were timed out:
JsToCppTest.BackPointer
JsToCppTest.BitFlip
JsToCppTest.Echo
JsToCppTest.Ping

Original issue's description:
> Reland of Moves mojo_js_integration_tests into blink. (patchset #1 id:1 of https://codereview.chromium.org/2926143002/ )
>
> Reason for revert:
> Fixed failing tests.
>
> Original issue's description:
> > Revert of Moves mojo_js_integration_tests into blink. (patchset #11 id:190001 of https://codereview.chromium.org/2734783008/ )
> >
> > Reason for revert:
> > Seems related to webkit failures of the JsToCpp tests. E.x. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/34530.
> >
> > Original issue's description:
> > > Moves mojo_js_integration_tests into blink.
> > >
> > > BUG=699569
> > >
> > > Review-Url: https://codereview.chromium.org/2734783008
> > > Cr-Commit-Position: refs/heads/master@{#477549}
> > > Committed: https://chromium.googlesource.com/chromium/src/+/dd57fa764813de09d159a232eeef1bb21b0ccc1e
> >
> > TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,alokp@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=699569
> >
> > Review-Url: https://codereview.chromium.org/2926143002
> > Cr-Commit-Position: refs/heads/master@{#477653}
> > Committed: https://chromium.googlesource.com/chromium/src/+/6536a56d25c245bd109e32ed49240bfc04f8890f
>
> TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,jwd@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=699569
>
> Review-Url: https://codereview.chromium.org/2920383004
> Cr-Commit-Position: refs/heads/master@{#478820}
> Committed: https://chromium.googlesource.com/chromium/src/+/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961

TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,jwd@chromium.org,alokp@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=699569

Review-Url: https://codereview.chromium.org/2939663002
Cr-Commit-Position: refs/heads/master@{#478881}

[modify] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/mojo/edk/js/tests/BUILD.gn
[rename] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/mojo/edk/js/tests/js_to_cpp.mojom
[add] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/mojo/edk/js/tests/js_to_cpp_tests.cc
[rename] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/mojo/edk/js/tests/js_to_cpp_tests.js
[modify] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/testing/buildbot/client.v8.chromium.json
[modify] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/third_party/WebKit/Source/core/mojo/BUILD.gn
[delete] https://crrev.com/7f4a499745ae9a8601e20ef616e8e1e877934269/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.cpp
[delete] https://crrev.com/7f4a499745ae9a8601e20ef616e8e1e877934269/third_party/WebKit/Source/core/mojo/tests/OWNERS
[modify] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp
[modify] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h
[modify] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/tools/determinism/deterministic_build_whitelist.pyl

Just so you know, I'm working on a large patch which converts a number of targets to the new Mojo JS bindings because I tried to depend on mojo/common:common_custom_types from a target that already used the new JS bindings.
Great! Thanks Reilly!
Project Member Comment 24 by bugdroid1@chromium.org, Jun 17
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c461e58ee3a426a1064c83895f9320ff94121712

commit c461e58ee3a426a1064c83895f9320ff94121712
Author: Daniel Cheng <dcheng@chromium.org>
Date: Sat Jun 17 08:08:38 2017

Revert "Reland of Moves mojo_js_integration_tests into blink. (patchset #1 id:1 of https://codereview.chromium.org/2939663002/ )"

Reason for revert:
WebKit Android (Nexus4) are still broken with four failing tests:
  JsToCppTest.BackPointer
  JsToCppTest.BitFlip
  JsToCppTest.Ping
  JsToCppTest.Echo

TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,jwd@chromium.org,alokp@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=699569

Change-Id: I925840dbe50bd21e6c87b03f23d6b4007d27df63
Reviewed-on: https://chromium-review.googlesource.com/538520
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480282}
[modify] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/mojo/edk/js/tests/BUILD.gn
[rename] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/mojo/edk/js/tests/js_to_cpp.mojom
[add] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/mojo/edk/js/tests/js_to_cpp_tests.cc
[rename] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/mojo/edk/js/tests/js_to_cpp_tests.js
[modify] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/testing/buildbot/client.v8.chromium.json
[modify] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/third_party/WebKit/Source/core/mojo/BUILD.gn
[delete] https://crrev.com/07f0acbacf4853d4cfe56a134a601576fd547cf0/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.cpp
[delete] https://crrev.com/07f0acbacf4853d4cfe56a134a601576fd547cf0/third_party/WebKit/Source/core/mojo/tests/OWNERS
[modify] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp
[modify] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h
[modify] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/tools/determinism/deterministic_build_whitelist.pyl

Project Member Comment 25 by bugdroid1@chromium.org, Jun 22 (5 days ago)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26834276c6bf9eab813f5ea7d4f37f4d73fb491c

commit 26834276c6bf9eab813f5ea7d4f37f4d73fb491c
Author: Alok Priyadarshi <alokp@chromium.org>
Date: Thu Jun 22 23:18:05 2017

Reland of "Moves mojo_js_integration_tests into blink."

This reverts commit c461e58ee3a426a1064c83895f9320ff94121712.

Reason for revert: JsToCpp.mojom.js should now be available on android devices when running webkit_unit_tests: https://chromium-review.googlesource.com/c/540085/

Original change's description:
> Revert "Reland of Moves mojo_js_integration_tests into blink. (patchset #1 id:1 of https://codereview.chromium.org/2939663002/ )"
>
> Reason for revert:
> WebKit Android (Nexus4) are still broken with four failing tests:
>   JsToCppTest.BackPointer
>   JsToCppTest.BitFlip
>   JsToCppTest.Ping
>   JsToCppTest.Echo
>
> TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,jwd@chromium.org,alokp@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=699569
>
> Change-Id: I925840dbe50bd21e6c87b03f23d6b4007d27df63
> Reviewed-on: https://chromium-review.googlesource.com/538520
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#480282}

TBR=dcheng@chromium.org,jwd@chromium.org,jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,agrieve@chromium.org,alokp@chromium.org

Bug: 699569
Change-Id: I59bcce1f0a4f650eedaea7cce999b650041e7506
Reviewed-on: https://chromium-review.googlesource.com/540664
Commit-Queue: Alok Priyadarshi <alokp@chromium.org>
Reviewed-by: Alok Priyadarshi <alokp@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481712}
[modify] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/mojo/edk/js/tests/BUILD.gn
[delete] https://crrev.com/d3bd31fdd98cd0b900581d77953eeaa3e25337ad/mojo/edk/js/tests/js_to_cpp_tests.cc
[modify] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/testing/buildbot/client.v8.chromium.json
[modify] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/third_party/WebKit/Source/core/mojo/BUILD.gn
[rename] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/third_party/WebKit/Source/core/mojo/tests/JsToCpp.mojom
[add] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.cpp
[rename] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.js
[add] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/third_party/WebKit/Source/core/mojo/tests/OWNERS
[modify] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp
[modify] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h
[modify] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/tools/determinism/deterministic_build_whitelist.pyl

Project Member Comment 26 by bugdroid1@chromium.org, Jun 23 (5 days ago)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa273aed7238cabd05b59be36b5eee9ce62f000c

commit aa273aed7238cabd05b59be36b5eee9ce62f000c
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Jun 23 02:08:48 2017

Revert "Reland of "Moves mojo_js_integration_tests into blink.""

This reverts commit 26834276c6bf9eab813f5ea7d4f37f4d73fb491c.

Reason for revert: These tests are still failing on WebKit Android (Nexus4):
  JsToCppTest.BackPointer
  JsToCppTest.BitFlip
  JsToCppTest.Ping
  JsToCppTest.Echo

Example build: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/66197


Original change's description:
> Reland of "Moves mojo_js_integration_tests into blink."
> 
> This reverts commit c461e58ee3a426a1064c83895f9320ff94121712.
> 
> Reason for revert: JsToCpp.mojom.js should now be available on android devices when running webkit_unit_tests: https://chromium-review.googlesource.com/c/540085/
> 
> Original change's description:
> > Revert "Reland of Moves mojo_js_integration_tests into blink. (patchset #1 id:1 of https://codereview.chromium.org/2939663002/ )"
> >
> > Reason for revert:
> > WebKit Android (Nexus4) are still broken with four failing tests:
> >   JsToCppTest.BackPointer
> >   JsToCppTest.BitFlip
> >   JsToCppTest.Ping
> >   JsToCppTest.Echo
> >
> > TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,jwd@chromium.org,alokp@chromium.org
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=699569
> >
> > Change-Id: I925840dbe50bd21e6c87b03f23d6b4007d27df63
> > Reviewed-on: https://chromium-review.googlesource.com/538520
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Commit-Queue: Daniel Cheng <dcheng@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#480282}
> 
> TBR=dcheng@chromium.org,jwd@chromium.org,jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,agrieve@chromium.org,alokp@chromium.org
> 
> Bug: 699569
> Change-Id: I59bcce1f0a4f650eedaea7cce999b650041e7506
> Reviewed-on: https://chromium-review.googlesource.com/540664
> Commit-Queue: Alok Priyadarshi <alokp@chromium.org>
> Reviewed-by: Alok Priyadarshi <alokp@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#481712}

TBR=dcheng@chromium.org,jwd@chromium.org,jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,agrieve@chromium.org,alokp@chromium.org

Change-Id: I496aba914c51b914ffb8082d9d6cb4c8cf45f590
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 699569
Reviewed-on: https://chromium-review.googlesource.com/544452
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481784}
[modify] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/mojo/edk/js/tests/BUILD.gn
[rename] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/mojo/edk/js/tests/js_to_cpp.mojom
[add] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/mojo/edk/js/tests/js_to_cpp_tests.cc
[rename] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/mojo/edk/js/tests/js_to_cpp_tests.js
[modify] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/testing/buildbot/client.v8.chromium.json
[modify] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/third_party/WebKit/Source/core/mojo/BUILD.gn
[delete] https://crrev.com/b4bc987ccfa1400e505bcaae38fd7463af0b11ac/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.cpp
[delete] https://crrev.com/b4bc987ccfa1400e505bcaae38fd7463af0b11ac/third_party/WebKit/Source/core/mojo/tests/OWNERS
[modify] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp
[modify] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h
[modify] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/tools/determinism/deterministic_build_whitelist.pyl

Comment 27 by aluo@chromium.org, Jun 23 (4 days ago)
Labels: chromium-waterfall
Project Member Comment 28 by bugdroid1@chromium.org, Yesterday (35 hours ago)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e5e955eb4ab56b4970578ed743616858ef77817

commit 7e5e955eb4ab56b4970578ed743616858ef77817
Author: yzshen <yzshen@chromium.org>
Date: Mon Jun 26 21:56:26 2017

Support new-style Mojo JS core API on IOS.

BUG=699569

Review-Url: https://codereview.chromium.org/2946383002
Cr-Commit-Position: refs/heads/master@{#482426}

[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/third_party/requirejs/LICENSE
[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/third_party/requirejs/OWNERS
[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/third_party/requirejs/README.chromium
[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/third_party/requirejs/require.js
[modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/BUILD.gn
[modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/ios_web_resources.grd
[modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/test/BUILD.gn
[modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/test/data/mojo_test.html
[modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/test/data/mojo_test.js
[modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/webui/crw_web_ui_manager.mm
[modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/webui/crw_web_ui_manager_unittest.mm
[modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/webui/mojo_facade.h
[modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/webui/mojo_facade.mm
[modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/webui/mojo_facade_unittest.mm
[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/mojo_js_constants.cc
[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/mojo_js_constants.h
[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/resources/console.js
[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/resources/core.js
[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/resources/handle_util.js
[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/resources/interface_provider.js
[add] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/webui/resources/mojo_api.js
[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/resources/support.js
[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/resources/sync_message_channel.js
[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/resources/timer.js
[modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/webui/resources/web_ui_bundle.js
[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/resources/web_ui_module_load_notifier.js
[modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/webui/web_ui_mojo_inttest.mm
[modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/mojo/public/js/new_bindings/base.js

Sign in to add a comment