Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Starred by 7 users
Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 647036
issue 711009



Sign in to add a comment
Mojo JS bindings: change module loading from AMD to <script> tag
Project Member Reported by yzshen@chromium.org, Mar 8 Back to list
.
 
Project Member Comment 1 by bugdroid1@chromium.org, Mar 8
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b

commit e3c870b6d13a2b5a55deba853b04ad328fc4bc6b
Author: yzshen <yzshen@chromium.org>
Date: Wed Mar 08 18:06:52 2017

Mojo JS bindings: duplicate the bindings files into src/mojo/public/js/new_bindings.

New module-loading approach will be developed on this copy. The original code
will be removed after all user code is switched to the new approach.

BUG=699569

Review-Url: https://codereview.chromium.org/2736273002
Cr-Commit-Position: refs/heads/master@{#455492}

[add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/bindings.js
[add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/buffer.js
[add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/codec.js
[add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/connector.js
[add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/interface_types.js
[add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/lib/control_message_handler.js
[add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/lib/control_message_proxy.js
[add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/router.js
[add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/unicode.js
[add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/validator.js

Project Member Comment 2 by bugdroid1@chromium.org, Mar 25
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/628771d2f70705a9aba44a5f994dafdac9fd61ea

commit 628771d2f70705a9aba44a5f994dafdac9fd61ea
Author: yzshen <yzshen@chromium.org>
Date: Sat Mar 25 07:24:06 2017

Layout tests: Enable fetching generated files from the build directory.

This CL allows URLs that start with "file:///gen/" to be mapped to the files in "<build_dir>/gen/".

One use case is to allow loading generated mojom.js files using <script> tag. (We are already loading those generated mojom.js files, but using a special JS function exposed to the testing environment for AMD-style module loading. This CL is a cleaner approach.)

BUG=699569
TBR=jam@chromium.org
(jam@ delegated to other reviewers)

Review-Url: https://codereview.chromium.org/2759803002
Cr-Commit-Position: refs/heads/master@{#459641}

[modify] https://crrev.com/628771d2f70705a9aba44a5f994dafdac9fd61ea/content/shell/browser/layout_test/blink_test_controller.cc
[modify] https://crrev.com/628771d2f70705a9aba44a5f994dafdac9fd61ea/content/shell/common/layout_test.mojom
[modify] https://crrev.com/628771d2f70705a9aba44a5f994dafdac9fd61ea/content/shell/renderer/layout_test/blink_test_runner.cc

Project Member Comment 3 by bugdroid1@chromium.org, Mar 25
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0

commit e6a5534bb3fe61b5224f1a22e43ba957190ad5d0
Author: yzshen <yzshen@chromium.org>
Date: Sat Mar 25 15:59:50 2017

Mojo JS bindings: change module loading solution.

This change takes place on the mojo/public/js/new_bindings copy so it doesn't
affect existing users.

- This change gets rid of AMD module loading. Now the bindings API is defined in
the "mojoBindings" namespace. At build time, all bindings files are combined
into a single file "mojo_bindings.js". Users should use <script> tag to include
this file (as well as generated mojom.js files).

- Generated mojom.js files export their definitions under the same namespace as
the "module" statement in the corresponding mojom files.

- This change also adds a "use_new_js_bindings" option to the generator. It
  duplicates the control message mojom files in order to generate two
  different flavors of JS bindings.

- The new bindings use the Mojo system API defined by Web IDL.

BUG=699569

Review-Url: https://codereview.chromium.org/2759563004
Cr-Commit-Position: refs/heads/master@{#459654}

[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/interfaces/bindings/BUILD.gn
[add] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/interfaces/bindings/new_bindings/OWNERS
[add] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/interfaces/bindings/new_bindings/interface_control_messages.mojom
[add] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/interfaces/bindings/new_bindings/pipe_control_messages.mojom
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/interfaces/bindings/tests/BUILD.gn
[add] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/interfaces/bindings/tests/echo.mojom
[add] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/interfaces/bindings/tests/echo_import.mojom
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/BUILD.gn
[add] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/base.js
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/bindings.js
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/buffer.js
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/codec.js
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/connector.js
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/interface_types.js
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/lib/control_message_handler.js
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/lib/control_message_proxy.js
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/router.js
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/unicode.js
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/validator.js
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/tools/bindings/generators/js_templates/module_definition.tmpl
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/tools/bindings/generators/mojom_js_generator.py
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/tools/bindings/mojom.gni
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/tools/bindings/mojom_bindings_generator.py
[modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/tools/bindings/pylib/mojom/generate/generator.py
[add] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/third_party/WebKit/LayoutTests/mojo/module-loading.html

Project Member Comment 4 by bugdroid1@chromium.org, Mar 27
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e326a5d409dadb3df6811b3dca7f1cfecb4ef520

commit e326a5d409dadb3df6811b3dca7f1cfecb4ef520
Author: yzshen <yzshen@chromium.org>
Date: Mon Mar 27 03:19:20 2017

Mojo JS bindings: support auto-loading mojom.js deps.

It also adds a config to turn off this behavior.

BUG=699569

Review-Url: https://codereview.chromium.org/2779493002
Cr-Commit-Position: refs/heads/master@{#459695}

[modify] https://crrev.com/e326a5d409dadb3df6811b3dca7f1cfecb4ef520/mojo/public/js/new_bindings/base.js
[modify] https://crrev.com/e326a5d409dadb3df6811b3dca7f1cfecb4ef520/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl
[modify] https://crrev.com/e326a5d409dadb3df6811b3dca7f1cfecb4ef520/mojo/public/tools/bindings/generators/mojom_js_generator.py
[add] https://crrev.com/e326a5d409dadb3df6811b3dca7f1cfecb4ef520/third_party/WebKit/LayoutTests/mojo/module-loading-manual-deps-loading.html
[modify] https://crrev.com/e326a5d409dadb3df6811b3dca7f1cfecb4ef520/third_party/WebKit/LayoutTests/mojo/module-loading.html

Project Member Comment 5 by bugdroid1@chromium.org, Mar 27
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae2b29ed27f84f0209be6f0482f5b85c0578ee75

commit ae2b29ed27f84f0209be6f0482f5b85c0578ee75
Author: hayato <hayato@chromium.org>
Date: Mon Mar 27 08:48:19 2017

Revert of Mojo JS bindings: support auto-loading mojom.js deps. (patchset #3 id:40001 of https://codereview.chromium.org/2779493002/ )

Reason for revert:
It looks we have to revert this CL too in order to revert https://codereview.chromium.org/2759563004/.

The previous revert failed in: https://codereview.chromium.org/2779533002/

Original issue's description:
> Mojo JS bindings: support auto-loading mojom.js deps.
>
> It also adds a config to turn off this behavior.
>
> BUG=699569
>
> Review-Url: https://codereview.chromium.org/2779493002
> Cr-Commit-Position: refs/heads/master@{#459695}
> Committed: https://chromium.googlesource.com/chromium/src/+/e326a5d409dadb3df6811b3dca7f1cfecb4ef520

TBR=rockot@chromium.org,yzshen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=699569

Review-Url: https://codereview.chromium.org/2777083002
Cr-Commit-Position: refs/heads/master@{#459724}

[modify] https://crrev.com/ae2b29ed27f84f0209be6f0482f5b85c0578ee75/mojo/public/js/new_bindings/base.js
[modify] https://crrev.com/ae2b29ed27f84f0209be6f0482f5b85c0578ee75/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl
[modify] https://crrev.com/ae2b29ed27f84f0209be6f0482f5b85c0578ee75/mojo/public/tools/bindings/generators/mojom_js_generator.py
[delete] https://crrev.com/f988185f6973f485ef5aeed2cc1b6e38797359bd/third_party/WebKit/LayoutTests/mojo/module-loading-manual-deps-loading.html
[modify] https://crrev.com/ae2b29ed27f84f0209be6f0482f5b85c0578ee75/third_party/WebKit/LayoutTests/mojo/module-loading.html

Project Member Comment 6 by bugdroid1@chromium.org, Mar 27
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06cde11f9f3843eb13e3d3d73296a07e9e8601f5

commit 06cde11f9f3843eb13e3d3d73296a07e9e8601f5
Author: hayato <hayato@chromium.org>
Date: Mon Mar 27 10:55:09 2017

Revert of Mojo JS bindings: change module loading solution. (patchset #7 id:120001 of https://codereview.chromium.org/2759563004/ )

Reason for revert:
Consistent failure: webkit_tests failing on 6 builders

33 since the first detection
e.g. https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.10

This CL is suspicious because mojo/module-loading.html has been failing.

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Mac10.10%2F31815%2F%2B%2Frecipes%2Fsteps%2Fwebkit_tests%2F0%2Fstdout

Regressions: Unexpected text-only failures (1)
  mojo/module-loading.html [ Failure ]

09:20:53.708 5958 worker/0 virtual/mojo-loading/http/tests/bluetooth/https/requestDevice/cross-origin-iframe.html output stderr lines:
09:20:53.709 5958   [09:20:53.354] vtDecompressionDuctCreate signalled err=-8973 (err) (Could not select and open decoder instance) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.235/Sources/VideoToolbox/VTDecompressionSession.c line 1181
09:20:53.709 5958   <<<< VTVideoEncoderSelection >>>> VTSelectAndCreateVideoEncoderInstanceInternal: no video encoder found for 'avc1'

Original issue's description:
> Mojo JS bindings: change module loading solution.
>
> This change takes place on the mojo/public/js/new_bindings copy so it doesn't
> affect existing users.
>
> - This change gets rid of AMD module loading. Now the bindings API is defined in
> the "mojoBindings" namespace. At build time, all bindings files are combined
> into a single file "mojo_bindings.js". Users should use <script> tag to include
> this file (as well as generated mojom.js files).
>
> - Generated mojom.js files export their definitions under the same namespace as
> the "module" statement in the corresponding mojom files.
>
> - This change also adds a "use_new_js_bindings" option to the generator. It
>   duplicates the control message mojom files in order to generate two
>   different flavors of JS bindings.
>
> - The new bindings use the Mojo system API defined by Web IDL.
>
> BUG=699569
>
> Review-Url: https://codereview.chromium.org/2759563004
> Cr-Commit-Position: refs/heads/master@{#459654}
> Committed: https://chromium.googlesource.com/chromium/src/+/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0

TBR=rockot@chromium.org,dcheng@chromium.org,alokp@chromium.org,yzshen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=699569

Review-Url: https://codereview.chromium.org/2779533002
Cr-Commit-Position: refs/heads/master@{#459745}

[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/interfaces/bindings/BUILD.gn
[delete] https://crrev.com/931e61729f1b53919be3192d0d77cdf1f004c894/mojo/public/interfaces/bindings/new_bindings/OWNERS
[delete] https://crrev.com/931e61729f1b53919be3192d0d77cdf1f004c894/mojo/public/interfaces/bindings/new_bindings/interface_control_messages.mojom
[delete] https://crrev.com/931e61729f1b53919be3192d0d77cdf1f004c894/mojo/public/interfaces/bindings/new_bindings/pipe_control_messages.mojom
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/interfaces/bindings/tests/BUILD.gn
[delete] https://crrev.com/931e61729f1b53919be3192d0d77cdf1f004c894/mojo/public/interfaces/bindings/tests/echo.mojom
[delete] https://crrev.com/931e61729f1b53919be3192d0d77cdf1f004c894/mojo/public/interfaces/bindings/tests/echo_import.mojom
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/BUILD.gn
[delete] https://crrev.com/931e61729f1b53919be3192d0d77cdf1f004c894/mojo/public/js/new_bindings/base.js
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/bindings.js
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/buffer.js
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/codec.js
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/connector.js
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/interface_types.js
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/lib/control_message_handler.js
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/lib/control_message_proxy.js
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/router.js
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/unicode.js
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/validator.js
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/tools/bindings/generators/js_templates/module_definition.tmpl
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/tools/bindings/generators/mojom_js_generator.py
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/tools/bindings/mojom.gni
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/tools/bindings/mojom_bindings_generator.py
[modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/tools/bindings/pylib/mojom/generate/generator.py
[delete] https://crrev.com/931e61729f1b53919be3192d0d77cdf1f004c894/third_party/WebKit/LayoutTests/mojo/module-loading.html

Project Member Comment 7 by bugdroid1@chromium.org, Apr 2
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a06469911359843f3d823fac7a7c06fec3c46edb

commit a06469911359843f3d823fac7a7c06fec3c46edb
Author: yzshen <yzshen@chromium.org>
Date: Sun Apr 02 22:01:27 2017

Mojo JS bindings: change module loading solution.

This change takes place on the mojo/public/js/new_bindings copy so it doesn't
affect existing users.

- This change gets rid of AMD module loading. Now the bindings API is defined in
the "mojo" namespace. At build time, all bindings files are combined
into a single file "mojo_bindings.js". Users should use <script> tag to include
this file (as well as generated mojom.js files).

- Generated mojom.js files export their definitions under the same namespace as
the "module" statement in the corresponding mojom files.

- This change also adds a "use_new_js_bindings" option to the generator. It
  duplicates the control message mojom files in order to generate two
  different flavors of JS bindings.

- The new bindings use the Mojo system API defined by Web IDL.

BUG=699569

Review-Url: https://codereview.chromium.org/2759563004
Cr-Original-Commit-Position: refs/heads/master@{#459654}
Committed: https://chromium.googlesource.com/chromium/src/+/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0
Review-Url: https://codereview.chromium.org/2759563004
Cr-Commit-Position: refs/heads/master@{#461349}

[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/BUILD.gn
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/interfaces/bindings/BUILD.gn
[add] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/interfaces/bindings/new_bindings/OWNERS
[add] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/interfaces/bindings/new_bindings/interface_control_messages.mojom
[add] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/interfaces/bindings/new_bindings/pipe_control_messages.mojom
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/interfaces/bindings/tests/BUILD.gn
[add] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/interfaces/bindings/tests/echo.mojom
[add] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/interfaces/bindings/tests/echo_import.mojom
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/BUILD.gn
[add] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/base.js
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/bindings.js
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/buffer.js
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/codec.js
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/connector.js
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/interface_types.js
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/lib/control_message_handler.js
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/lib/control_message_proxy.js
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/router.js
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/unicode.js
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/validator.js
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/tools/bindings/generators/js_templates/module_definition.tmpl
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/tools/bindings/generators/mojom_js_generator.py
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/tools/bindings/mojom.gni
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/tools/bindings/mojom_bindings_generator.py
[modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/tools/bindings/pylib/mojom/generate/generator.py
[add] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/third_party/WebKit/LayoutTests/mojo/module-loading.html

Project Member Comment 8 by bugdroid1@chromium.org, Apr 3
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8e4332ca05f3220a36557b0e25dd3fa75365672

commit b8e4332ca05f3220a36557b0e25dd3fa75365672
Author: yzshen <yzshen@chromium.org>
Date: Mon Apr 03 00:51:40 2017

Mojo JS bindings: support auto-loading mojom.js deps.

It also adds a config to turn off this behavior.

BUG=699569

Review-Url: https://codereview.chromium.org/2779493002
Cr-Commit-Position: refs/heads/master@{#461354}

[modify] https://crrev.com/b8e4332ca05f3220a36557b0e25dd3fa75365672/mojo/public/js/new_bindings/base.js
[modify] https://crrev.com/b8e4332ca05f3220a36557b0e25dd3fa75365672/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl
[modify] https://crrev.com/b8e4332ca05f3220a36557b0e25dd3fa75365672/mojo/public/tools/bindings/generators/mojom_js_generator.py
[add] https://crrev.com/b8e4332ca05f3220a36557b0e25dd3fa75365672/third_party/WebKit/LayoutTests/mojo/module-loading-manual-deps-loading.html
[modify] https://crrev.com/b8e4332ca05f3220a36557b0e25dd3fa75365672/third_party/WebKit/LayoutTests/mojo/module-loading.html

Blocking: 711009
Project Member Comment 10 by bugdroid1@chromium.org, May 20
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e95f5e84d92d7690faed48157cbe09fc6762376

commit 8e95f5e84d92d7690faed48157cbe09fc6762376
Author: yzshen <yzshen@chromium.org>
Date: Sat May 20 15:25:09 2017

Mojo JS bindings: switch all mojo/ layout tests to use the new bindings.

BUG=699569

Review-Url: https://codereview.chromium.org/2891193002
Cr-Commit-Position: refs/heads/master@{#473439}

[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/interfaces/bindings/tests/BUILD.gn
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/js/BUILD.gn
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/js/new_bindings/bindings.js
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/js/new_bindings/connector.js
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/js/new_bindings/lib/interface_endpoint_client.js
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/js/new_bindings/router.js
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/js/new_bindings/validator.js
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/tools/bindings/generators/js_templates/module_definition.tmpl
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/tools/bindings/pylib/mojom/generate/generator.py
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/associated_binding.html
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/associated_interface_ptr.html
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/binding.html
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/codec.html
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/connection.html
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/interface_ptr.html
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/resources/validation_test_input_parser.js
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/sample_service.html
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/struct.html
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/union.html
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/validation.html
[modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/Source/core/mojo/MojoWatcher.cpp

Project Member Comment 11 by bugdroid1@chromium.org, May 26
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2296029e3eb2343421c90354582aa111ecba43d6

commit 2296029e3eb2343421c90354582aa111ecba43d6
Author: Ken Rockot <rockot@chromium.org>
Date: Fri May 26 09:04:28 2017

Enable Blink native Mojo bindings in WebUI

Adds the concept of ContextEnabled features as an extended attribute in
Web IDL, exposing a way for embedders to turn specific API features on
or off at context creation time.

Affixes this extended attribute to Mojo, MojoHandle, and MojoWatcher
IDLs to allow their exposure to be controlled per-context separately
from the MojoJS RuntimeEnabled state.

Finally, this also flips on the MojoJS ContextEnabled feature for all
RenderFrame contexts in which WebUI bindings are enabled.

BUG=699569,723923

Change-Id: Ie0fd6383ae86c133685b3e7b31eeca769bf83e06
Reviewed-on: https://chromium-review.googlesource.com/509390
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474973}
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/content/browser/webui/web_ui_mojo_browsertest.cc
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/content/renderer/mojo_bindings_controller.cc
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/content/renderer/mojo_bindings_controller.h
[add] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/content/test/data/web_ui_mojo_native.html
[add] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/content/test/data/web_ui_mojo_native.js
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/IDLExtendedAttributes.md
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/IDLExtendedAttributes.txt
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/core/v8/ConditionalFeaturesForCore.cpp
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/scripts/generate_global_constructors.py
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/scripts/v8_attributes.py
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/scripts/v8_interface.py
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/scripts/v8_utilities.py
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/templates/interface.h.tmpl
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/templates/partial_interface.h.tmpl
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/tests/idls/core/TestInterface.idl
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/core/BUILD.gn
[add] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/core/context_features/BUILD.gn
[add] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/core/context_features/ContextFeatureSettings.cpp
[add] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/core/context_features/ContextFeatureSettings.h
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/core/mojo/Mojo.idl
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/core/mojo/MojoHandle.idl
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/core/mojo/MojoWatcher.idl
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/web/BUILD.gn
[add] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/web/WebContextFeatures.cpp
[modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/public/BUILD.gn
[add] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/public/web/WebContextFeatures.h

Blocking: 647036
Project Member Comment 13 by bugdroid1@chromium.org, May 29
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eae56c386f559a286494aeb58f7fd9857efd960d

commit eae56c386f559a286494aeb58f7fd9857efd960d
Author: yzshen <yzshen@chromium.org>
Date: Mon May 29 10:00:42 2017

Mojo JS bindings: flip the default value of use_new_js_bindings to true.

BUG=699569
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2910703004
Cr-Commit-Position: refs/heads/master@{#475327}

[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/chrome/browser/engagement/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/chrome/browser/ui/webui/omnibox/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/chrome/browser/ui/webui/usb_internals/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/chrome/common/media_router/mojo/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/components/payments/mojom/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/content/test/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/device/bluetooth/public/interfaces/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/device/generic_sensor/public/interfaces/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/device/geolocation/public/interfaces/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/device/usb/public/interfaces/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/device/vr/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/extensions/common/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/extensions/common/api/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/gpu/ipc/common/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/ios/web/test/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/media/capture/mojo/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/mojo/common/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/mojo/edk/js/tests/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/mojo/public/interfaces/bindings/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/mojo/public/interfaces/bindings/tests/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/mojo/public/tools/bindings/mojom.gni
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/net/interfaces/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/services/device/public/interfaces/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/services/service_manager/public/interfaces/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/services/shape_detection/public/interfaces/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/ui/gfx/geometry/mojo/BUILD.gn
[modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/url/mojo/BUILD.gn

Project Member Comment 14 by bugdroid1@chromium.org, Jun 2
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9821a80606c582307bc791c798c6ccaeadaa70ec

commit 9821a80606c582307bc791c798c6ccaeadaa70ec
Author: junwei.fu <junwei.fu@intel.com>
Date: Fri Jun 02 03:51:48 2017

Mojo JS bindings: flip the default value of use_new_js_bindings to true.

Test cases will time out when CL [1] using skia mojo bitmap.

[1] https://codereview.chromium.org/2875243002#

BUG=699569

Review-Url: https://codereview.chromium.org/2912323002
Cr-Commit-Position: refs/heads/master@{#476555}

[modify] https://crrev.com/9821a80606c582307bc791c798c6ccaeadaa70ec/skia/public/interfaces/BUILD.gn

Project Member Comment 15 by bugdroid1@chromium.org, Jun 2
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e70d197e633996bf32ece4aac1158582fad51462

commit e70d197e633996bf32ece4aac1158582fad51462
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Fri Jun 02 18:03:57 2017

Mojo JS bindings: add documentation.

TBR=rockot@chromium.org,jam@chromium.org
BUG=699569

Change-Id: I5542a46a2f377ac9c6e64b1519f94659ab7fd4bc
Reviewed-on: https://chromium-review.googlesource.com/521789
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476719}
[modify] https://crrev.com/e70d197e633996bf32ece4aac1158582fad51462/mojo/README.md
[modify] https://crrev.com/e70d197e633996bf32ece4aac1158582fad51462/mojo/public/cpp/bindings/README.md
[modify] https://crrev.com/e70d197e633996bf32ece4aac1158582fad51462/mojo/public/js/README.md
[modify] https://crrev.com/e70d197e633996bf32ece4aac1158582fad51462/third_party/WebKit/Source/core/mojo/README.md

Project Member Comment 16 by bugdroid1@chromium.org, Jun 7
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd57fa764813de09d159a232eeef1bb21b0ccc1e

commit dd57fa764813de09d159a232eeef1bb21b0ccc1e
Author: alokp <alokp@chromium.org>
Date: Wed Jun 07 04:27:00 2017

Moves mojo_js_integration_tests into blink.

BUG=699569

Review-Url: https://codereview.chromium.org/2734783008
Cr-Commit-Position: refs/heads/master@{#477549}

[modify] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/mojo/edk/js/tests/BUILD.gn
[delete] https://crrev.com/8709f78a5a70fd9db4414ca6c0fe281d668f31e5/mojo/edk/js/tests/js_to_cpp_tests.cc
[modify] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/testing/buildbot/client.v8.chromium.json
[modify] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/third_party/WebKit/Source/core/mojo/BUILD.gn
[rename] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/third_party/WebKit/Source/core/mojo/tests/JsToCpp.mojom
[add] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.cpp
[rename] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.js
[add] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/third_party/WebKit/Source/core/mojo/tests/OWNERS
[modify] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp
[modify] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h
[modify] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/tools/determinism/deterministic_build_whitelist.pyl

Project Member Comment 17 by bugdroid1@chromium.org, Jun 7
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6536a56d25c245bd109e32ed49240bfc04f8890f

commit 6536a56d25c245bd109e32ed49240bfc04f8890f
Author: jwd <jwd@chromium.org>
Date: Wed Jun 07 15:20:41 2017

Revert of Moves mojo_js_integration_tests into blink. (patchset #11 id:190001 of https://codereview.chromium.org/2734783008/ )

Reason for revert:
Seems related to webkit failures of the JsToCpp tests. E.x. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/34530.

Original issue's description:
> Moves mojo_js_integration_tests into blink.
>
> BUG=699569
>
> Review-Url: https://codereview.chromium.org/2734783008
> Cr-Commit-Position: refs/heads/master@{#477549}
> Committed: https://chromium.googlesource.com/chromium/src/+/dd57fa764813de09d159a232eeef1bb21b0ccc1e

TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,alokp@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=699569

Review-Url: https://codereview.chromium.org/2926143002
Cr-Commit-Position: refs/heads/master@{#477653}

[modify] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/mojo/edk/js/tests/BUILD.gn
[rename] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/mojo/edk/js/tests/js_to_cpp.mojom
[add] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/mojo/edk/js/tests/js_to_cpp_tests.cc
[rename] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/mojo/edk/js/tests/js_to_cpp_tests.js
[modify] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/testing/buildbot/client.v8.chromium.json
[modify] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/third_party/WebKit/Source/core/mojo/BUILD.gn
[delete] https://crrev.com/b3f80bd4e91f989a0a52f8cf2baa9fcc4df4fd75/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.cpp
[delete] https://crrev.com/b3f80bd4e91f989a0a52f8cf2baa9fcc4df4fd75/third_party/WebKit/Source/core/mojo/tests/OWNERS
[modify] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp
[modify] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h
[modify] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/tools/determinism/deterministic_build_whitelist.pyl

Project Member Comment 18 by bugdroid1@chromium.org, Jun 7
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea19acc0fca1c00e9ea1dd01df0a462126902faf

commit ea19acc0fca1c00e9ea1dd01df0a462126902faf
Author: Ken Rockot <rockot@chromium.org>
Date: Wed Jun 07 18:12:07 2017

Convert chrome://omnibox to new Mojo bindings

Makes the generated, concatenated public Mojo JS bindings library
available as a shared WebUI resource and converts the chrome://omnibox
page to use the new bindings in place of the old ones.

BUG=699569

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib22df79892cf737dbcfad5320b5ddf7b2028bfcf
Reviewed-on: https://chromium-review.googlesource.com/523421
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477707}
[modify] https://crrev.com/ea19acc0fca1c00e9ea1dd01df0a462126902faf/chrome/browser/resources/omnibox/omnibox.html
[modify] https://crrev.com/ea19acc0fca1c00e9ea1dd01df0a462126902faf/chrome/browser/resources/omnibox/omnibox.js
[modify] https://crrev.com/ea19acc0fca1c00e9ea1dd01df0a462126902faf/chrome/browser/ui/webui/omnibox/BUILD.gn
[modify] https://crrev.com/ea19acc0fca1c00e9ea1dd01df0a462126902faf/chrome/browser/ui/webui/omnibox/omnibox_ui.cc
[modify] https://crrev.com/ea19acc0fca1c00e9ea1dd01df0a462126902faf/content/browser/webui/shared_resources_data_source.cc
[modify] https://crrev.com/ea19acc0fca1c00e9ea1dd01df0a462126902faf/ui/resources/BUILD.gn
[modify] https://crrev.com/ea19acc0fca1c00e9ea1dd01df0a462126902faf/ui/webui/resources/webui_resources.grd

Project Member Comment 19 by bugdroid1@chromium.org, Jun 12
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961

commit 0fac10b6b0a132a25eedf971c8ccffaa6e8a4961
Author: alokp <alokp@chromium.org>
Date: Mon Jun 12 23:34:14 2017

Reland of Moves mojo_js_integration_tests into blink. (patchset #1 id:1 of https://codereview.chromium.org/2926143002/ )

Reason for revert:
Fixed failing tests.

Original issue's description:
> Revert of Moves mojo_js_integration_tests into blink. (patchset #11 id:190001 of https://codereview.chromium.org/2734783008/ )
>
> Reason for revert:
> Seems related to webkit failures of the JsToCpp tests. E.x. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/34530.
>
> Original issue's description:
> > Moves mojo_js_integration_tests into blink.
> >
> > BUG=699569
> >
> > Review-Url: https://codereview.chromium.org/2734783008
> > Cr-Commit-Position: refs/heads/master@{#477549}
> > Committed: https://chromium.googlesource.com/chromium/src/+/dd57fa764813de09d159a232eeef1bb21b0ccc1e
>
> TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,alokp@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=699569
>
> Review-Url: https://codereview.chromium.org/2926143002
> Cr-Commit-Position: refs/heads/master@{#477653}
> Committed: https://chromium.googlesource.com/chromium/src/+/6536a56d25c245bd109e32ed49240bfc04f8890f

TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,jwd@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=699569

Review-Url: https://codereview.chromium.org/2920383004
Cr-Commit-Position: refs/heads/master@{#478820}

[modify] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/mojo/edk/js/tests/BUILD.gn
[delete] https://crrev.com/f1e4c0cc3c76b155337800383e54537a88fcdfe7/mojo/edk/js/tests/js_to_cpp_tests.cc
[modify] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/testing/buildbot/client.v8.chromium.json
[modify] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/third_party/WebKit/Source/core/mojo/BUILD.gn
[rename] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/third_party/WebKit/Source/core/mojo/tests/JsToCpp.mojom
[add] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.cpp
[rename] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.js
[add] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/third_party/WebKit/Source/core/mojo/tests/OWNERS
[modify] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp
[modify] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h
[modify] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/tools/determinism/deterministic_build_whitelist.pyl

Project Member Comment 20 by bugdroid1@chromium.org, Jun 13
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38f3a45e512fed9682729fcf57bdacfc6bfc1ece

commit 38f3a45e512fed9682729fcf57bdacfc6bfc1ece
Author: tzik <tzik@chromium.org>
Date: Tue Jun 13 03:16:20 2017

Revert of Moves mojo_js_integration_tests into blink. (patchset #1 id:1 of https://codereview.chromium.org/2920383004/ )

Reason for revert:
This CL seems to break webkit_unittests.
The error log is:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/34695

The tests below were timed out:
JsToCppTest.BackPointer
JsToCppTest.BitFlip
JsToCppTest.Echo
JsToCppTest.Ping

Original issue's description:
> Reland of Moves mojo_js_integration_tests into blink. (patchset #1 id:1 of https://codereview.chromium.org/2926143002/ )
>
> Reason for revert:
> Fixed failing tests.
>
> Original issue's description:
> > Revert of Moves mojo_js_integration_tests into blink. (patchset #11 id:190001 of https://codereview.chromium.org/2734783008/ )
> >
> > Reason for revert:
> > Seems related to webkit failures of the JsToCpp tests. E.x. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/34530.
> >
> > Original issue's description:
> > > Moves mojo_js_integration_tests into blink.
> > >
> > > BUG=699569
> > >
> > > Review-Url: https://codereview.chromium.org/2734783008
> > > Cr-Commit-Position: refs/heads/master@{#477549}
> > > Committed: https://chromium.googlesource.com/chromium/src/+/dd57fa764813de09d159a232eeef1bb21b0ccc1e
> >
> > TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,alokp@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=699569
> >
> > Review-Url: https://codereview.chromium.org/2926143002
> > Cr-Commit-Position: refs/heads/master@{#477653}
> > Committed: https://chromium.googlesource.com/chromium/src/+/6536a56d25c245bd109e32ed49240bfc04f8890f
>
> TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,jwd@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=699569
>
> Review-Url: https://codereview.chromium.org/2920383004
> Cr-Commit-Position: refs/heads/master@{#478820}
> Committed: https://chromium.googlesource.com/chromium/src/+/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961

TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,jwd@chromium.org,alokp@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=699569

Review-Url: https://codereview.chromium.org/2939663002
Cr-Commit-Position: refs/heads/master@{#478881}

[modify] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/mojo/edk/js/tests/BUILD.gn
[rename] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/mojo/edk/js/tests/js_to_cpp.mojom
[add] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/mojo/edk/js/tests/js_to_cpp_tests.cc
[rename] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/mojo/edk/js/tests/js_to_cpp_tests.js
[modify] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/testing/buildbot/client.v8.chromium.json
[modify] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/third_party/WebKit/Source/core/mojo/BUILD.gn
[delete] https://crrev.com/7f4a499745ae9a8601e20ef616e8e1e877934269/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.cpp
[delete] https://crrev.com/7f4a499745ae9a8601e20ef616e8e1e877934269/third_party/WebKit/Source/core/mojo/tests/OWNERS
[modify] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp
[modify] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h
[modify] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/tools/determinism/deterministic_build_whitelist.pyl

Project Member Comment 21 by bugdroid1@chromium.org, Jun 13
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4ddb86f7b07335a3a02e1ce5a37ae6c4070ae4e

commit c4ddb86f7b07335a3a02e1ce5a37ae6c4070ae4e
Author: yzshen <yzshen@chromium.org>
Date: Tue Jun 13 14:14:05 2017

Mojo JS bindings: convert relative path to URL properly.

BUG=699569
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2930423002
Cr-Commit-Position: refs/heads/master@{#479006}

[modify] https://crrev.com/c4ddb86f7b07335a3a02e1ce5a37ae6c4070ae4e/mojo/public/interfaces/bindings/tests/BUILD.gn
[modify] https://crrev.com/c4ddb86f7b07335a3a02e1ce5a37ae6c4070ae4e/mojo/public/interfaces/bindings/tests/echo.mojom
[add] https://crrev.com/c4ddb86f7b07335a3a02e1ce5a37ae6c4070ae4e/mojo/public/interfaces/bindings/tests/echo_import/OWNERS
[rename] https://crrev.com/c4ddb86f7b07335a3a02e1ce5a37ae6c4070ae4e/mojo/public/interfaces/bindings/tests/echo_import/echo_import.mojom
[modify] https://crrev.com/c4ddb86f7b07335a3a02e1ce5a37ae6c4070ae4e/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl
[modify] https://crrev.com/c4ddb86f7b07335a3a02e1ce5a37ae6c4070ae4e/mojo/public/tools/bindings/generators/mojom_js_generator.py
[modify] https://crrev.com/c4ddb86f7b07335a3a02e1ce5a37ae6c4070ae4e/third_party/WebKit/LayoutTests/mojo/module-loading-manual-deps-loading.html

Just so you know, I'm working on a large patch which converts a number of targets to the new Mojo JS bindings because I tried to depend on mojo/common:common_custom_types from a target that already used the new JS bindings.
Great! Thanks Reilly!
Project Member Comment 24 by bugdroid1@chromium.org, Jun 17
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c461e58ee3a426a1064c83895f9320ff94121712

commit c461e58ee3a426a1064c83895f9320ff94121712
Author: Daniel Cheng <dcheng@chromium.org>
Date: Sat Jun 17 08:08:38 2017

Revert "Reland of Moves mojo_js_integration_tests into blink. (patchset #1 id:1 of https://codereview.chromium.org/2939663002/ )"

Reason for revert:
WebKit Android (Nexus4) are still broken with four failing tests:
  JsToCppTest.BackPointer
  JsToCppTest.BitFlip
  JsToCppTest.Ping
  JsToCppTest.Echo

TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,jwd@chromium.org,alokp@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=699569

Change-Id: I925840dbe50bd21e6c87b03f23d6b4007d27df63
Reviewed-on: https://chromium-review.googlesource.com/538520
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480282}
[modify] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/mojo/edk/js/tests/BUILD.gn
[rename] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/mojo/edk/js/tests/js_to_cpp.mojom
[add] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/mojo/edk/js/tests/js_to_cpp_tests.cc
[rename] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/mojo/edk/js/tests/js_to_cpp_tests.js
[modify] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/testing/buildbot/client.v8.chromium.json
[modify] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/third_party/WebKit/Source/core/mojo/BUILD.gn
[delete] https://crrev.com/07f0acbacf4853d4cfe56a134a601576fd547cf0/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.cpp
[delete] https://crrev.com/07f0acbacf4853d4cfe56a134a601576fd547cf0/third_party/WebKit/Source/core/mojo/tests/OWNERS
[modify] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp
[modify] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h
[modify] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/tools/determinism/deterministic_build_whitelist.pyl

Project Member Comment 25 by bugdroid1@chromium.org, Jun 22
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26834276c6bf9eab813f5ea7d4f37f4d73fb491c

commit 26834276c6bf9eab813f5ea7d4f37f4d73fb491c
Author: Alok Priyadarshi <alokp@chromium.org>
Date: Thu Jun 22 23:18:05 2017

Reland of "Moves mojo_js_integration_tests into blink."

This reverts commit c461e58ee3a426a1064c83895f9320ff94121712.

Reason for revert: JsToCpp.mojom.js should now be available on android devices when running webkit_unit_tests: https://chromium-review.googlesource.com/c/540085/

Original change's description:
> Revert "Reland of Moves mojo_js_integration_tests into blink. (patchset #1 id:1 of https://codereview.chromium.org/2939663002/ )"
>
> Reason for revert:
> WebKit Android (Nexus4) are still broken with four failing tests:
>   JsToCppTest.BackPointer
>   JsToCppTest.BitFlip
>   JsToCppTest.Ping
>   JsToCppTest.Echo
>
> TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,jwd@chromium.org,alokp@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=699569
>
> Change-Id: I925840dbe50bd21e6c87b03f23d6b4007d27df63
> Reviewed-on: https://chromium-review.googlesource.com/538520
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#480282}

TBR=dcheng@chromium.org,jwd@chromium.org,jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,agrieve@chromium.org,alokp@chromium.org

Bug: 699569
Change-Id: I59bcce1f0a4f650eedaea7cce999b650041e7506
Reviewed-on: https://chromium-review.googlesource.com/540664
Commit-Queue: Alok Priyadarshi <alokp@chromium.org>
Reviewed-by: Alok Priyadarshi <alokp@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481712}
[modify] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/mojo/edk/js/tests/BUILD.gn
[delete] https://crrev.com/d3bd31fdd98cd0b900581d77953eeaa3e25337ad/mojo/edk/js/tests/js_to_cpp_tests.cc
[modify] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/testing/buildbot/client.v8.chromium.json
[modify] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/third_party/WebKit/Source/core/mojo/BUILD.gn
[rename] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/third_party/WebKit/Source/core/mojo/tests/JsToCpp.mojom
[add] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.cpp
[rename] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.js
[add] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/third_party/WebKit/Source/core/mojo/tests/OWNERS
[modify] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp
[modify] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h
[modify] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/tools/determinism/deterministic_build_whitelist.pyl

Project Member Comment 26 by bugdroid1@chromium.org, Jun 23
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa273aed7238cabd05b59be36b5eee9ce62f000c

commit aa273aed7238cabd05b59be36b5eee9ce62f000c
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Jun 23 02:08:48 2017

Revert "Reland of "Moves mojo_js_integration_tests into blink.""

This reverts commit 26834276c6bf9eab813f5ea7d4f37f4d73fb491c.

Reason for revert: These tests are still failing on WebKit Android (Nexus4):
  JsToCppTest.BackPointer
  JsToCppTest.BitFlip
  JsToCppTest.Ping
  JsToCppTest.Echo

Example build: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/66197


Original change's description:
> Reland of "Moves mojo_js_integration_tests into blink."
> 
> This reverts commit c461e58ee3a426a1064c83895f9320ff94121712.
> 
> Reason for revert: JsToCpp.mojom.js should now be available on android devices when running webkit_unit_tests: https://chromium-review.googlesource.com/c/540085/
> 
> Original change's description:
> > Revert "Reland of Moves mojo_js_integration_tests into blink. (patchset #1 id:1 of https://codereview.chromium.org/2939663002/ )"
> >
> > Reason for revert:
> > WebKit Android (Nexus4) are still broken with four failing tests:
> >   JsToCppTest.BackPointer
> >   JsToCppTest.BitFlip
> >   JsToCppTest.Ping
> >   JsToCppTest.Echo
> >
> > TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,jwd@chromium.org,alokp@chromium.org
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=699569
> >
> > Change-Id: I925840dbe50bd21e6c87b03f23d6b4007d27df63
> > Reviewed-on: https://chromium-review.googlesource.com/538520
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Commit-Queue: Daniel Cheng <dcheng@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#480282}
> 
> TBR=dcheng@chromium.org,jwd@chromium.org,jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,agrieve@chromium.org,alokp@chromium.org
> 
> Bug: 699569
> Change-Id: I59bcce1f0a4f650eedaea7cce999b650041e7506
> Reviewed-on: https://chromium-review.googlesource.com/540664
> Commit-Queue: Alok Priyadarshi <alokp@chromium.org>
> Reviewed-by: Alok Priyadarshi <alokp@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#481712}

TBR=dcheng@chromium.org,jwd@chromium.org,jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,agrieve@chromium.org,alokp@chromium.org

Change-Id: I496aba914c51b914ffb8082d9d6cb4c8cf45f590
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 699569
Reviewed-on: https://chromium-review.googlesource.com/544452
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481784}
[modify] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/mojo/edk/js/tests/BUILD.gn
[rename] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/mojo/edk/js/tests/js_to_cpp.mojom
[add] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/mojo/edk/js/tests/js_to_cpp_tests.cc
[rename] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/mojo/edk/js/tests/js_to_cpp_tests.js
[modify] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/testing/buildbot/client.v8.chromium.json
[modify] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/third_party/WebKit/Source/core/mojo/BUILD.gn
[delete] https://crrev.com/b4bc987ccfa1400e505bcaae38fd7463af0b11ac/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.cpp
[delete] https://crrev.com/b4bc987ccfa1400e505bcaae38fd7463af0b11ac/third_party/WebKit/Source/core/mojo/tests/OWNERS
[modify] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp
[modify] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h
[modify] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/tools/determinism/deterministic_build_whitelist.pyl

Labels: chromium-waterfall
Project Member Comment 28 by bugdroid1@chromium.org, Jun 26
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e5e955eb4ab56b4970578ed743616858ef77817

commit 7e5e955eb4ab56b4970578ed743616858ef77817
Author: yzshen <yzshen@chromium.org>
Date: Mon Jun 26 21:56:26 2017

Support new-style Mojo JS core API on IOS.

BUG=699569

Review-Url: https://codereview.chromium.org/2946383002
Cr-Commit-Position: refs/heads/master@{#482426}

[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/third_party/requirejs/LICENSE
[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/third_party/requirejs/OWNERS
[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/third_party/requirejs/README.chromium
[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/third_party/requirejs/require.js
[modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/BUILD.gn
[modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/ios_web_resources.grd
[modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/test/BUILD.gn
[modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/test/data/mojo_test.html
[modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/test/data/mojo_test.js
[modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/webui/crw_web_ui_manager.mm
[modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/webui/crw_web_ui_manager_unittest.mm
[modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/webui/mojo_facade.h
[modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/webui/mojo_facade.mm
[modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/webui/mojo_facade_unittest.mm
[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/mojo_js_constants.cc
[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/mojo_js_constants.h
[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/resources/console.js
[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/resources/core.js
[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/resources/handle_util.js
[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/resources/interface_provider.js
[add] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/webui/resources/mojo_api.js
[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/resources/support.js
[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/resources/sync_message_channel.js
[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/resources/timer.js
[modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/webui/resources/web_ui_bundle.js
[delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/resources/web_ui_module_load_notifier.js
[modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/webui/web_ui_mojo_inttest.mm
[modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/mojo/public/js/new_bindings/base.js

Project Member Comment 29 by bugdroid1@chromium.org, Jul 4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc048bef86deaed860574f5d3a29b23f0c3e6c73

commit dc048bef86deaed860574f5d3a29b23f0c3e6c73
Author: yzshen <yzshen@chromium.org>
Date: Tue Jul 04 19:10:23 2017

Mojo JS bindings: add support to generate "dual-mode" code.

Previously, if mojom target A and B both depend on C, in order to convert A to
the new mode, we need to convert C, and also all the targets that depend on C
(i.e., B).

With this CL, we could let target C generate code supporting both modes. That
way B don't have to be touched in the same CL.

TBR=brettw@chromium.org
(For the changes in url/mojo/BUILD.gn)

BUG=699569
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2965803003
Cr-Commit-Position: refs/heads/master@{#484145}

[modify] https://crrev.com/dc048bef86deaed860574f5d3a29b23f0c3e6c73/chrome/browser/resources/usb_internals/usb_internals.html
[modify] https://crrev.com/dc048bef86deaed860574f5d3a29b23f0c3e6c73/chrome/browser/resources/usb_internals/usb_internals.js
[modify] https://crrev.com/dc048bef86deaed860574f5d3a29b23f0c3e6c73/chrome/browser/ui/webui/usb_internals/BUILD.gn
[modify] https://crrev.com/dc048bef86deaed860574f5d3a29b23f0c3e6c73/chrome/browser/ui/webui/usb_internals/usb_internals_ui.cc
[modify] https://crrev.com/dc048bef86deaed860574f5d3a29b23f0c3e6c73/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl
[modify] https://crrev.com/dc048bef86deaed860574f5d3a29b23f0c3e6c73/mojo/public/tools/bindings/generators/js_templates/module_definition.tmpl
[modify] https://crrev.com/dc048bef86deaed860574f5d3a29b23f0c3e6c73/mojo/public/tools/bindings/generators/mojom_js_generator.py
[modify] https://crrev.com/dc048bef86deaed860574f5d3a29b23f0c3e6c73/mojo/public/tools/bindings/mojom.gni
[modify] https://crrev.com/dc048bef86deaed860574f5d3a29b23f0c3e6c73/mojo/public/tools/bindings/mojom_bindings_generator.py
[modify] https://crrev.com/dc048bef86deaed860574f5d3a29b23f0c3e6c73/mojo/public/tools/bindings/pylib/mojom/generate/generator.py
[modify] https://crrev.com/dc048bef86deaed860574f5d3a29b23f0c3e6c73/third_party/WebKit/LayoutTests/vibration/vibration-expected.txt
[modify] https://crrev.com/dc048bef86deaed860574f5d3a29b23f0c3e6c73/url/mojo/BUILD.gn

Project Member Comment 30 by bugdroid1@chromium.org, Jul 6
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7b1af385b62029ed042d59e93112ea9f7fed8ef

commit e7b1af385b62029ed042d59e93112ea9f7fed8ef
Author: Reilly Grant <reillyg@chromium.org>
Date: Thu Jul 06 23:35:46 2017

Switch the WebVR LayoutTests to the new Mojo JS bindings

This change switches the WebVR Mojo interface JS bindings to the new
style and updates the LayoutTests accordingly. Mojoms that this
interface depends on are switched to generating both styles of bindings
while some users have not yet been updated.

Bug: 699569
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If9171cf4b764a39ebfeb00e21b2c039e7f3e6812
Reviewed-on: https://chromium-review.googlesource.com/560578
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Oliver Chang (OOO until July 10) <ochang@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484766}
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/device/vr/BUILD.gn
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/gpu/ipc/common/BUILD.gn
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/mojo/common/BUILD.gn
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/events_vrdisplayactivate.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/events_vrdisplayconnect.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/events_vrdisplaypresentchange.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/exitPresent_reject_notpresenting.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/exitPresent_resolve.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/getEyeParameters_match.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/getFrameData_noupdate.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/getFrameData_oneframeupdate.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/getFrameData_samewithinframe.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/getLayers_notpresenting.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/getLayers_presenting.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/getLayers_presenting_nondefaultbounds.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/getLayers_update.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/getVRDisplays_one_display.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/getVRDisplays_two_display.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/getVRDisplays_zero_display.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/multiple_requestAnimationFrame_called.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestAnimationFrame_called.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestAnimationFrame_consistentTimestamps.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestAnimationFrame_handoff.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestAnimationFrame_invalidhandle.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestAnimationFrame_submitFrame_combinations.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestAnimationFrame_unregister.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_reject_badleftbounds.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_reject_badrightbounds.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nogesture.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nolayers.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nosource.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_reject_notsupported.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nowebgl.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nullsource.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_reject_toomanylayers.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_resolve.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_resolve_repeatwithgesture.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_resolve_repeatwithoutgesture.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_resolve_then_reject.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_resolve_webgl2.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/resources/mock-vr-service.js
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/stageParameters_match.html
[modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/ui/gfx/geometry/mojo/BUILD.gn

Project Member Comment 31 by bugdroid1@chromium.org, Jul 7
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47d872925a8504668a2b2c65f1d0572264d08398

commit 47d872925a8504668a2b2c65f1d0572264d08398
Author: Reilly Grant <reillyg@chromium.org>
Date: Fri Jul 07 21:17:26 2017

Switch the Shape Detection LayoutTests to the new Mojo JS bindings

This change switches the Shape Detection Mojo interface JS bindings to
the new style and updates the LayoutTests accordingly. The Skia Mojo
interfaces are also switched to generating the new binding style while
the ui/gfx/geometry interfaces must still generated both as a
temporary step while some code has not yet been updated.

These tests demonstrate how the DCHECK in ~MojoWatcher is invalid and
so it is removed.

Bug: 699569
Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
Change-Id: Ic83ac9bd50072eae8461edc0b85cd4bcae147358
Reviewed-on: https://chromium-review.googlesource.com/560646
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485049}
[modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/services/shape_detection/public/interfaces/BUILD.gn
[modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/skia/public/interfaces/BUILD.gn
[modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html
[modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
[modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html
[modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html
[modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html
[modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/LayoutTests/shapedetection/detection-on-worker.html
[modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/LayoutTests/shapedetection/detection-options.html
[modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/LayoutTests/shapedetection/detection-security-test.html
[modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/LayoutTests/shapedetection/detector-same-object.html
[modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/LayoutTests/shapedetection/resources/mock-barcodedetection.js
[modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js
[modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/LayoutTests/shapedetection/resources/mock-textdetection.js
[modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/LayoutTests/shapedetection/resources/worker.js
[modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/Source/core/mojo/MojoWatcher.cpp

Project Member Comment 32 by bugdroid1@chromium.org, Jul 10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5946acdc3a28c62847b18991fe06f86e631a40c1

commit 5946acdc3a28c62847b18991fe06f86e631a40c1
Author: Reilly Grant <reillyg@chromium.org>
Date: Mon Jul 10 23:53:55 2017

Switch the MediaSession LayoutTests to the new Mojo JS bindings

This change enables generation of both Mojo JS bindings styles in the
//third_party/WebKit/public:android_mojo_bindings target and updates the
LayoutTests for the MediaSession API to use the new style.

Bug: 699569
Change-Id: Ifebdcbe5cffffd61d3dfcb48b590c447416d8d7a
Reviewed-on: https://chromium-review.googlesource.com/563704
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485452}
[modify] https://crrev.com/5946acdc3a28c62847b18991fe06f86e631a40c1/third_party/WebKit/LayoutTests/media/mediasession/mojo/callback-alive-after-gc.html
[modify] https://crrev.com/5946acdc3a28c62847b18991fe06f86e631a40c1/third_party/WebKit/LayoutTests/media/mediasession/mojo/file-image-removed.html
[modify] https://crrev.com/5946acdc3a28c62847b18991fe06f86e631a40c1/third_party/WebKit/LayoutTests/media/mediasession/mojo/media-control-action-reaches-client.html
[modify] https://crrev.com/5946acdc3a28c62847b18991fe06f86e631a40c1/third_party/WebKit/LayoutTests/media/mediasession/mojo/media-control-set-handler-notifies-service.html
[modify] https://crrev.com/5946acdc3a28c62847b18991fe06f86e631a40c1/third_party/WebKit/LayoutTests/media/mediasession/mojo/metadata-async.html
[modify] https://crrev.com/5946acdc3a28c62847b18991fe06f86e631a40c1/third_party/WebKit/LayoutTests/media/mediasession/mojo/metadata-propagated-twice.html
[modify] https://crrev.com/5946acdc3a28c62847b18991fe06f86e631a40c1/third_party/WebKit/LayoutTests/media/mediasession/mojo/metadata-propagated.html
[modify] https://crrev.com/5946acdc3a28c62847b18991fe06f86e631a40c1/third_party/WebKit/LayoutTests/media/mediasession/mojo/metadata-session-link.html
[modify] https://crrev.com/5946acdc3a28c62847b18991fe06f86e631a40c1/third_party/WebKit/LayoutTests/media/mediasession/mojo/playback-state-propagated.html
[modify] https://crrev.com/5946acdc3a28c62847b18991fe06f86e631a40c1/third_party/WebKit/LayoutTests/media/mediasession/mojo/resources/mediasessionservice-mock.js
[modify] https://crrev.com/5946acdc3a28c62847b18991fe06f86e631a40c1/third_party/WebKit/LayoutTests/media/mediasession/mojo/set-null-metadata.html
[modify] https://crrev.com/5946acdc3a28c62847b18991fe06f86e631a40c1/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/5946acdc3a28c62847b18991fe06f86e631a40c1/ui/gfx/geometry/mojo/BUILD.gn

Project Member Comment 33 by bugdroid1@chromium.org, Jul 11
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57

commit be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57
Author: Reilly Grant <reillyg@chromium.org>
Date: Tue Jul 11 01:51:26 2017

Switch the Geolocation LayoutTests to the new Mojo JS bindings

This change switches the Geolocation Mojo interface JS bindings to the
new style and updates the LayoutTests accordingly. The Blink Mojo
interfaces are switched to generating both styles of bindings as an
temporary step while some code has not yet been updated.

These tests demonstrate how the DCHECK in ~MojoWatcher is invalid and
so it is removed.

Bug: 699569
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ie7001384afcdc812218d840c8fd0057360868354
Reviewed-on: https://chromium-review.googlesource.com/560544
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485488}
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/device/geolocation/public/interfaces/BUILD.gn
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/cached-position-called-once.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/callback-exception-expected.txt
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/callback-exception.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/callback-to-deleted-context.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/callback-to-remote-context.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/callback-to-remote-context2.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/clear-watch-invalid-id-crash.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/coordinates-interface-attributes.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/delayed-permission-allowed-for-multiple-requests.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/delayed-permission-allowed.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/delayed-permission-denied-for-multiple-requests.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/delayed-permission-denied.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/disconnected-frame-already.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/disconnected-frame-permission-denied.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/disconnected-frame.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/error-clear-watch.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/error-service-connection-error.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/error.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/maximum-age.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/multiple-requests.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/notimer-after-unload.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/permission-denied-already-clear-watch.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/permission-denied-already-error.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/permission-denied-already-success.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/permission-denied-stops-watches.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/permission-denied.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/permission-service-connection-error.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/position-string.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/reentrant-error.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/reentrant-permission-denied.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/reentrant-success.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/remove-remote-context-in-error-callback-crash.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/resources/callback-to-remote-context-inner.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/resources/geolocation-mock.js
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/resources/remove-remote-context-in-error-callback-crash-inner.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/resources/window-close-popup.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/success-clear-watch.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/success.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/timeout-clear-watch.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/timeout-negative.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/timeout-over-max-of-unsigned.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/timeout-zero.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/timeout.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/timestamp.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/watch.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/watchPosition-page-visibility.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/watchPosition-unique.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/window-close-crash.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/resources/geolocation.html
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/apache_http.py
[modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/public/BUILD.gn

Project Member Comment 34 by bugdroid1@chromium.org, Jul 13
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a

commit 3b3cf0c8188d7cf51e439d696755e4a43fd21b3a
Author: Alok Priyadarshi <alokp@chromium.org>
Date: Thu Jul 13 02:38:53 2017

Reland of "Moves mojo_js_integration_tests into blink."

This reverts commit aa273aed7238cabd05b59be36b5eee9ce62f000c.

Reason for revert: I have disabled the test on Android and filed
crbug.com/741925 to track data dependency issue on Android test bots.

TBR=jbroman,dpranke,yzshen

Bug: 699569
Change-Id: Ic007cf56937c586b90fc3b68a76369cd489aff53
Reviewed-on: https://chromium-review.googlesource.com/568272
Reviewed-by: Alok Priyadarshi <alokp@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: Alok Priyadarshi <alokp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486232}
[modify] https://crrev.com/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a/mojo/edk/js/tests/BUILD.gn
[delete] https://crrev.com/22ec9a55f303639c9e30487ec690d194a78e1582/mojo/edk/js/tests/js_to_cpp_tests.cc
[modify] https://crrev.com/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a/testing/buildbot/client.v8.chromium.json
[modify] https://crrev.com/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a/third_party/WebKit/Source/core/mojo/BUILD.gn
[rename] https://crrev.com/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a/third_party/WebKit/Source/core/mojo/tests/JsToCpp.mojom
[add] https://crrev.com/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.cpp
[rename] https://crrev.com/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.js
[add] https://crrev.com/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a/third_party/WebKit/Source/core/mojo/tests/OWNERS
[modify] https://crrev.com/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a/third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp
[modify] https://crrev.com/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h
[modify] https://crrev.com/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a/tools/determinism/deterministic_build_whitelist.pyl

Project Member Comment 35 by bugdroid1@chromium.org, Jul 14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2802973e5d90d2da902b44cf614bfe9f94bb6b0a

commit 2802973e5d90d2da902b44cf614bfe9f94bb6b0a
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Fri Jul 14 21:20:37 2017

Convert sensor layout tests to use the new mojo JS bindings.

This change also exposes the SensorProvider interface from the frame.
The frame then forwards the request to the device service. This is
likely what we want in the long term to enforce permission check. And it
also enables layout tests to intercept the interface.

BUG=699569

Change-Id: Ic00466126aac982e57242829a103b0c10ba0f1ba
Reviewed-on: https://chromium-review.googlesource.com/569641
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486890}
[modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/content/browser/BUILD.gn
[modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/content/public/app/mojo/content_renderer_manifest.json
[modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/services/device/public/interfaces/BUILD.gn
[modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/third_party/WebKit/LayoutTests/sensor/accelerometer.html
[modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html
[modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/third_party/WebKit/LayoutTests/sensor/gyroscope.html
[modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/third_party/WebKit/LayoutTests/sensor/magnetometer.html
[modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/third_party/WebKit/LayoutTests/sensor/mock-sensor.html
[modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/third_party/WebKit/LayoutTests/sensor/orientation-sensor.html
[modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js
[modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js
[modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp

Project Member Comment 36 by bugdroid1@chromium.org, Jul 25
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd

commit cbdd3c86c21f676697e68fc6e54f17a66d52c1fd
Author: Reilly Grant <reillyg@chromium.org>
Date: Tue Jul 25 03:07:26 2017

Switch ImageCapture to the new Mojo JS bindings

This change switches the ImageCapture Mojo interface to using the new
Mojo JS bindings and rewrites the LayoutTests to use the new style.

Bug: 699569
Change-Id: I40e0b376892c0308fa83ed26c53c67bfdcc77e9b
Reviewed-on: https://chromium-review.googlesource.com/580673
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489202}
[modify] https://crrev.com/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd/media/capture/mojo/BUILD.gn
[modify] https://crrev.com/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd/third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-getSettings.html
[modify] https://crrev.com/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd/third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-reject.html
[modify] https://crrev.com/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd/third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints.html
[modify] https://crrev.com/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd/third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-getCapabilities.html
[modify] https://crrev.com/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd/third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-getSettings.html
[modify] https://crrev.com/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd/third_party/WebKit/LayoutTests/imagecapture/getPhotoCapabilities.html
[modify] https://crrev.com/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd/third_party/WebKit/LayoutTests/imagecapture/getPhotoSettings.html
[modify] https://crrev.com/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd/third_party/WebKit/LayoutTests/imagecapture/resources/mock-imagecapture.js
[modify] https://crrev.com/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd/third_party/WebKit/LayoutTests/imagecapture/setOptions-reject.html
[modify] https://crrev.com/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd/third_party/WebKit/LayoutTests/imagecapture/setOptions.html
[modify] https://crrev.com/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd/third_party/WebKit/LayoutTests/imagecapture/takePhoto-with-PhotoSettings.html
[modify] https://crrev.com/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd/third_party/WebKit/LayoutTests/imagecapture/takePhoto.html

Project Member Comment 37 by bugdroid1@chromium.org, Jul 26
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70ca2546ecb5718196a3f939442e4ef87a7c02f3

commit 70ca2546ecb5718196a3f939442e4ef87a7c02f3
Author: Reilly Grant <reillyg@chromium.org>
Date: Wed Jul 26 20:52:46 2017

Fix and switch Vibration API to the new Mojo JS bindings

This patch fixes bugs in the Vibration API LayoutTests and switches them
to using the new Mojo JS bindings.

Bug: 699569
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I3fb19ddc3bb2415dec0f2f047aba68d98cb1e4d5
Reviewed-on: https://chromium-review.googlesource.com/584022
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489751}
[modify] https://crrev.com/70ca2546ecb5718196a3f939442e4ef87a7c02f3/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/70ca2546ecb5718196a3f939442e4ef87a7c02f3/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/70ca2546ecb5718196a3f939442e4ef87a7c02f3/content/public/app/mojo/content_renderer_manifest.json
[modify] https://crrev.com/70ca2546ecb5718196a3f939442e4ef87a7c02f3/services/device/public/interfaces/BUILD.gn
[modify] https://crrev.com/70ca2546ecb5718196a3f939442e4ef87a7c02f3/third_party/WebKit/LayoutTests/vibration/resources/vibrate-from-iframe.html
[modify] https://crrev.com/70ca2546ecb5718196a3f939442e4ef87a7c02f3/third_party/WebKit/LayoutTests/vibration/resources/vibration-helpers.js
[delete] https://crrev.com/096f91f3c998aac2e1e4efcb24eb279b18e54829/third_party/WebKit/LayoutTests/vibration/vibration-expected.txt
[delete] https://crrev.com/096f91f3c998aac2e1e4efcb24eb279b18e54829/third_party/WebKit/LayoutTests/vibration/vibration-iframe-expected.txt
[modify] https://crrev.com/70ca2546ecb5718196a3f939442e4ef87a7c02f3/third_party/WebKit/LayoutTests/vibration/vibration-iframe.html
[modify] https://crrev.com/70ca2546ecb5718196a3f939442e4ef87a7c02f3/third_party/WebKit/LayoutTests/vibration/vibration.html
[modify] https://crrev.com/70ca2546ecb5718196a3f939442e4ef87a7c02f3/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp
[modify] https://crrev.com/70ca2546ecb5718196a3f939442e4ef87a7c02f3/third_party/WebKit/Source/modules/vibration/NavigatorVibration.h
[modify] https://crrev.com/70ca2546ecb5718196a3f939442e4ef87a7c02f3/third_party/WebKit/Source/modules/vibration/VibrationController.cpp
[modify] https://crrev.com/70ca2546ecb5718196a3f939442e4ef87a7c02f3/third_party/WebKit/Source/modules/vibration/VibrationController.h

Project Member Comment 38 by bugdroid1@chromium.org, Jul 27
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8fc64da8db4f9f2260b45897386da5754657e28

commit d8fc64da8db4f9f2260b45897386da5754657e28
Author: Reilly Grant <reillyg@chromium.org>
Date: Thu Jul 27 00:14:14 2017

Switch the NFC LayoutTests to the new Mojo JS bindings

This change updates the NFC LayoutTests to use the new style of Mojo JS
bindings.

Bug: 699569
Change-Id: If0cf63de62d7ff35e0163b6025d8d9b834526105
Reviewed-on: https://chromium-review.googlesource.com/584853
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489809}
[modify] https://crrev.com/d8fc64da8db4f9f2260b45897386da5754657e28/third_party/WebKit/LayoutTests/nfc/mock-nfc.html
[modify] https://crrev.com/d8fc64da8db4f9f2260b45897386da5754657e28/third_party/WebKit/LayoutTests/nfc/nfc-block-iframe.html
[modify] https://crrev.com/d8fc64da8db4f9f2260b45897386da5754657e28/third_party/WebKit/LayoutTests/nfc/push.html
[modify] https://crrev.com/d8fc64da8db4f9f2260b45897386da5754657e28/third_party/WebKit/LayoutTests/nfc/resources/nfc-helpers.js
[modify] https://crrev.com/d8fc64da8db4f9f2260b45897386da5754657e28/third_party/WebKit/LayoutTests/nfc/watch.html

Project Member Comment 39 by bugdroid1@chromium.org, Jul 29
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/451e2b33beb1d1d395c1adf95a87074b5b5202e1

commit 451e2b33beb1d1d395c1adf95a87074b5b5202e1
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Sat Jul 29 06:56:07 2017

Mojo JS bindings: switch web_ui_test_mojo_bindings to use new mode.

BUG=699569

Change-Id: I98a9f7053742f29473f25ad97b70d519ce337b30
Reviewed-on: https://chromium-review.googlesource.com/592276
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490639}
[modify] https://crrev.com/451e2b33beb1d1d395c1adf95a87074b5b5202e1/content/browser/webui/web_ui_mojo_browsertest.cc
[modify] https://crrev.com/451e2b33beb1d1d395c1adf95a87074b5b5202e1/content/test/BUILD.gn
[modify] https://crrev.com/451e2b33beb1d1d395c1adf95a87074b5b5202e1/content/test/data/web_ui_mojo.html
[modify] https://crrev.com/451e2b33beb1d1d395c1adf95a87074b5b5202e1/content/test/data/web_ui_mojo.js

Project Member Comment 40 by bugdroid1@chromium.org, Aug 1
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92466de58f6060945cea3c8cef01302c5e4eec3c

commit 92466de58f6060945cea3c8cef01302c5e4eec3c
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Tue Aug 01 17:51:07 2017

Mojo JS bindings: switch site_engagement_details.mojom to use the new mode.

BUG=699569

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib314a69a4717fe1a932ece2f0025ec20c8c64f26
Reviewed-on: https://chromium-review.googlesource.com/592607
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491047}
[modify] https://crrev.com/92466de58f6060945cea3c8cef01302c5e4eec3c/chrome/browser/browser_resources.grd
[modify] https://crrev.com/92466de58f6060945cea3c8cef01302c5e4eec3c/chrome/browser/engagement/BUILD.gn
[modify] https://crrev.com/92466de58f6060945cea3c8cef01302c5e4eec3c/chrome/browser/resources/engagement/site_engagement.html
[modify] https://crrev.com/92466de58f6060945cea3c8cef01302c5e4eec3c/chrome/browser/resources/engagement/site_engagement.js
[modify] https://crrev.com/92466de58f6060945cea3c8cef01302c5e4eec3c/chrome/browser/ui/webui/engagement/site_engagement_ui.cc
[modify] https://crrev.com/92466de58f6060945cea3c8cef01302c5e4eec3c/chrome/test/data/webui/engagement/site_engagement_browsertest.js

Project Member Comment 41 by bugdroid1@chromium.org, Aug 1
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6382f72d093d987ead9bf13a7a4ec1d9348e09ac

commit 6382f72d093d987ead9bf13a7a4ec1d9348e09ac
Author: Reilly Grant <reillyg@chromium.org>
Date: Tue Aug 01 19:06:59 2017

Switch Budget API LayoutTests to the new Mojo JS bindings

This change rewrites the Budget API layout tests to use the new Mojo
JS bindings.

Bug: 699569
Change-Id: I4af6e3a78c16cf4ecc6aeedc5317eaf1021ca9eb
Reviewed-on: https://chromium-review.googlesource.com/595234
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491073}
[modify] https://crrev.com/6382f72d093d987ead9bf13a7a4ec1d9348e09ac/third_party/WebKit/LayoutTests/http/tests/budget/budget-service-mock.js
[delete] https://crrev.com/81112286430d0e761cc00915e6186330d5cf4155/third_party/WebKit/LayoutTests/http/tests/budget/get-budget-expected.txt
[modify] https://crrev.com/6382f72d093d987ead9bf13a7a4ec1d9348e09ac/third_party/WebKit/LayoutTests/http/tests/budget/get-budget-in-service-worker.html
[modify] https://crrev.com/6382f72d093d987ead9bf13a7a4ec1d9348e09ac/third_party/WebKit/LayoutTests/http/tests/budget/get-budget.html
[modify] https://crrev.com/6382f72d093d987ead9bf13a7a4ec1d9348e09ac/third_party/WebKit/LayoutTests/http/tests/budget/get-cost-fails-in-service-worker.html
[modify] https://crrev.com/6382f72d093d987ead9bf13a7a4ec1d9348e09ac/third_party/WebKit/LayoutTests/http/tests/budget/get-cost-in-service-worker.html
[modify] https://crrev.com/6382f72d093d987ead9bf13a7a4ec1d9348e09ac/third_party/WebKit/LayoutTests/http/tests/budget/get-cost.html
[modify] https://crrev.com/6382f72d093d987ead9bf13a7a4ec1d9348e09ac/third_party/WebKit/LayoutTests/http/tests/budget/reserve-in-service-worker.html
[modify] https://crrev.com/6382f72d093d987ead9bf13a7a4ec1d9348e09ac/third_party/WebKit/LayoutTests/http/tests/budget/reserve.html
[modify] https://crrev.com/6382f72d093d987ead9bf13a7a4ec1d9348e09ac/third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js

Project Member Comment 42 by bugdroid1@chromium.org, Aug 1
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5bb5a2b5fabce64044a786d4bfaef26770c6523

commit b5bb5a2b5fabce64044a786d4bfaef26770c6523
Author: Reilly Grant <reillyg@chromium.org>
Date: Tue Aug 01 19:28:03 2017

Switch WebShare LayoutTests to the new Mojo JS bindings

This change rewrites the WebShare API layout tests to use the new Mojo
JS bindings.

Bug: 699569
Change-Id: Id95a016765c5b101ee347f760e7cec8b74ec4b7e
Reviewed-on: https://chromium-review.googlesource.com/587412
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491079}
[modify] https://crrev.com/b5bb5a2b5fabce64044a786d4bfaef26770c6523/third_party/WebKit/LayoutTests/webshare/resources/mock-share-service.js
[modify] https://crrev.com/b5bb5a2b5fabce64044a786d4bfaef26770c6523/third_party/WebKit/LayoutTests/webshare/share-arity.html
[modify] https://crrev.com/b5bb5a2b5fabce64044a786d4bfaef26770c6523/third_party/WebKit/LayoutTests/webshare/share-error.html
[modify] https://crrev.com/b5bb5a2b5fabce64044a786d4bfaef26770c6523/third_party/WebKit/LayoutTests/webshare/share-nonutf8-encoding.html
[modify] https://crrev.com/b5bb5a2b5fabce64044a786d4bfaef26770c6523/third_party/WebKit/LayoutTests/webshare/share-success.html
[modify] https://crrev.com/b5bb5a2b5fabce64044a786d4bfaef26770c6523/third_party/WebKit/LayoutTests/webshare/share-types.html
[modify] https://crrev.com/b5bb5a2b5fabce64044a786d4bfaef26770c6523/third_party/WebKit/LayoutTests/webshare/share-url-relative.html

Project Member Comment 43 by bugdroid1@chromium.org, Aug 1
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e36efa6b8d50503c355010612dab64fe421cbc35

commit e36efa6b8d50503c355010612dab64fe421cbc35
Author: Reilly Grant <reillyg@chromium.org>
Date: Tue Aug 01 19:28:11 2017

Switch Payments LayoutTest to the new Mojo JS bindings

This change rewrites the single Payments API layout test that uses Mojo
mock services to use the new Mojo JS bindings.

Bug: 699569
Change-Id: I6fa74bfb2e926d35ccf3232c87f7a0114592ce9a
Reviewed-on: https://chromium-review.googlesource.com/595246
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491080}
[modify] https://crrev.com/e36efa6b8d50503c355010612dab64fe421cbc35/third_party/WebKit/LayoutTests/payments/promises-keep-request-alive.html
[modify] https://crrev.com/e36efa6b8d50503c355010612dab64fe421cbc35/third_party/WebKit/LayoutTests/payments/resources/payment-request-mock.js

Project Member Comment 44 by bugdroid1@chromium.org, Aug 2
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3ccb44f7248444c819e4c196c078ee5e167d610

commit e3ccb44f7248444c819e4c196c078ee5e167d610
Author: Yuzhu Shen <yzshen@chromium.org>
Date: Wed Aug 02 21:13:19 2017

Mojo JS bindings: no need to generate the service_manager JS bindings.

BUG=699569

Change-Id: I0697f40e286a3ea7fbcccff3c02a605abc7bd8c5
Reviewed-on: https://chromium-review.googlesource.com/592280
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491500}
[modify] https://crrev.com/e3ccb44f7248444c819e4c196c078ee5e167d610/BUILD.gn
[modify] https://crrev.com/e3ccb44f7248444c819e4c196c078ee5e167d610/services/service_manager/public/interfaces/BUILD.gn
[modify] https://crrev.com/e3ccb44f7248444c819e4c196c078ee5e167d610/third_party/WebKit/LayoutTests/harness-tests/mojo-helpers.html

Sign in to add a comment