.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b commit e3c870b6d13a2b5a55deba853b04ad328fc4bc6b Author: yzshen <yzshen@chromium.org> Date: Wed Mar 08 18:06:52 2017 Mojo JS bindings: duplicate the bindings files into src/mojo/public/js/new_bindings. New module-loading approach will be developed on this copy. The original code will be removed after all user code is switched to the new approach. BUG=699569 Review-Url: https://codereview.chromium.org/2736273002 Cr-Commit-Position: refs/heads/master@{#455492} [add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/bindings.js [add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/buffer.js [add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/codec.js [add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/connector.js [add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/interface_types.js [add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/lib/control_message_handler.js [add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/lib/control_message_proxy.js [add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/router.js [add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/unicode.js [add] https://crrev.com/e3c870b6d13a2b5a55deba853b04ad328fc4bc6b/mojo/public/js/new_bindings/validator.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/628771d2f70705a9aba44a5f994dafdac9fd61ea commit 628771d2f70705a9aba44a5f994dafdac9fd61ea Author: yzshen <yzshen@chromium.org> Date: Sat Mar 25 07:24:06 2017 Layout tests: Enable fetching generated files from the build directory. This CL allows URLs that start with "file:///gen/" to be mapped to the files in "<build_dir>/gen/". One use case is to allow loading generated mojom.js files using <script> tag. (We are already loading those generated mojom.js files, but using a special JS function exposed to the testing environment for AMD-style module loading. This CL is a cleaner approach.) BUG=699569 TBR=jam@chromium.org (jam@ delegated to other reviewers) Review-Url: https://codereview.chromium.org/2759803002 Cr-Commit-Position: refs/heads/master@{#459641} [modify] https://crrev.com/628771d2f70705a9aba44a5f994dafdac9fd61ea/content/shell/browser/layout_test/blink_test_controller.cc [modify] https://crrev.com/628771d2f70705a9aba44a5f994dafdac9fd61ea/content/shell/common/layout_test.mojom [modify] https://crrev.com/628771d2f70705a9aba44a5f994dafdac9fd61ea/content/shell/renderer/layout_test/blink_test_runner.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0 commit e6a5534bb3fe61b5224f1a22e43ba957190ad5d0 Author: yzshen <yzshen@chromium.org> Date: Sat Mar 25 15:59:50 2017 Mojo JS bindings: change module loading solution. This change takes place on the mojo/public/js/new_bindings copy so it doesn't affect existing users. - This change gets rid of AMD module loading. Now the bindings API is defined in the "mojoBindings" namespace. At build time, all bindings files are combined into a single file "mojo_bindings.js". Users should use <script> tag to include this file (as well as generated mojom.js files). - Generated mojom.js files export their definitions under the same namespace as the "module" statement in the corresponding mojom files. - This change also adds a "use_new_js_bindings" option to the generator. It duplicates the control message mojom files in order to generate two different flavors of JS bindings. - The new bindings use the Mojo system API defined by Web IDL. BUG=699569 Review-Url: https://codereview.chromium.org/2759563004 Cr-Commit-Position: refs/heads/master@{#459654} [modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/interfaces/bindings/BUILD.gn [add] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/interfaces/bindings/new_bindings/OWNERS [add] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/interfaces/bindings/new_bindings/interface_control_messages.mojom [add] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/interfaces/bindings/new_bindings/pipe_control_messages.mojom [modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/interfaces/bindings/tests/BUILD.gn [add] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/interfaces/bindings/tests/echo.mojom [add] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/interfaces/bindings/tests/echo_import.mojom [modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/BUILD.gn [add] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/base.js [modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/bindings.js [modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/buffer.js [modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/codec.js [modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/connector.js [modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/interface_types.js [modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/lib/control_message_handler.js [modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/lib/control_message_proxy.js [modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/router.js [modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/unicode.js [modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/js/new_bindings/validator.js [modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl [modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/tools/bindings/generators/js_templates/module_definition.tmpl [modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/tools/bindings/generators/mojom_js_generator.py [modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/tools/bindings/mojom.gni [modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/tools/bindings/mojom_bindings_generator.py [modify] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/mojo/public/tools/bindings/pylib/mojom/generate/generator.py [add] https://crrev.com/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0/third_party/WebKit/LayoutTests/mojo/module-loading.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e326a5d409dadb3df6811b3dca7f1cfecb4ef520 commit e326a5d409dadb3df6811b3dca7f1cfecb4ef520 Author: yzshen <yzshen@chromium.org> Date: Mon Mar 27 03:19:20 2017 Mojo JS bindings: support auto-loading mojom.js deps. It also adds a config to turn off this behavior. BUG=699569 Review-Url: https://codereview.chromium.org/2779493002 Cr-Commit-Position: refs/heads/master@{#459695} [modify] https://crrev.com/e326a5d409dadb3df6811b3dca7f1cfecb4ef520/mojo/public/js/new_bindings/base.js [modify] https://crrev.com/e326a5d409dadb3df6811b3dca7f1cfecb4ef520/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl [modify] https://crrev.com/e326a5d409dadb3df6811b3dca7f1cfecb4ef520/mojo/public/tools/bindings/generators/mojom_js_generator.py [add] https://crrev.com/e326a5d409dadb3df6811b3dca7f1cfecb4ef520/third_party/WebKit/LayoutTests/mojo/module-loading-manual-deps-loading.html [modify] https://crrev.com/e326a5d409dadb3df6811b3dca7f1cfecb4ef520/third_party/WebKit/LayoutTests/mojo/module-loading.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae2b29ed27f84f0209be6f0482f5b85c0578ee75 commit ae2b29ed27f84f0209be6f0482f5b85c0578ee75 Author: hayato <hayato@chromium.org> Date: Mon Mar 27 08:48:19 2017 Revert of Mojo JS bindings: support auto-loading mojom.js deps. (patchset #3 id:40001 of https://codereview.chromium.org/2779493002/ ) Reason for revert: It looks we have to revert this CL too in order to revert https://codereview.chromium.org/2759563004/. The previous revert failed in: https://codereview.chromium.org/2779533002/ Original issue's description: > Mojo JS bindings: support auto-loading mojom.js deps. > > It also adds a config to turn off this behavior. > > BUG=699569 > > Review-Url: https://codereview.chromium.org/2779493002 > Cr-Commit-Position: refs/heads/master@{#459695} > Committed: https://chromium.googlesource.com/chromium/src/+/e326a5d409dadb3df6811b3dca7f1cfecb4ef520 TBR=rockot@chromium.org,yzshen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=699569 Review-Url: https://codereview.chromium.org/2777083002 Cr-Commit-Position: refs/heads/master@{#459724} [modify] https://crrev.com/ae2b29ed27f84f0209be6f0482f5b85c0578ee75/mojo/public/js/new_bindings/base.js [modify] https://crrev.com/ae2b29ed27f84f0209be6f0482f5b85c0578ee75/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl [modify] https://crrev.com/ae2b29ed27f84f0209be6f0482f5b85c0578ee75/mojo/public/tools/bindings/generators/mojom_js_generator.py [delete] https://crrev.com/f988185f6973f485ef5aeed2cc1b6e38797359bd/third_party/WebKit/LayoutTests/mojo/module-loading-manual-deps-loading.html [modify] https://crrev.com/ae2b29ed27f84f0209be6f0482f5b85c0578ee75/third_party/WebKit/LayoutTests/mojo/module-loading.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06cde11f9f3843eb13e3d3d73296a07e9e8601f5 commit 06cde11f9f3843eb13e3d3d73296a07e9e8601f5 Author: hayato <hayato@chromium.org> Date: Mon Mar 27 10:55:09 2017 Revert of Mojo JS bindings: change module loading solution. (patchset #7 id:120001 of https://codereview.chromium.org/2759563004/ ) Reason for revert: Consistent failure: webkit_tests failing on 6 builders 33 since the first detection e.g. https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.10 This CL is suspicious because mojo/module-loading.html has been failing. https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Mac10.10%2F31815%2F%2B%2Frecipes%2Fsteps%2Fwebkit_tests%2F0%2Fstdout Regressions: Unexpected text-only failures (1) mojo/module-loading.html [ Failure ] 09:20:53.708 5958 worker/0 virtual/mojo-loading/http/tests/bluetooth/https/requestDevice/cross-origin-iframe.html output stderr lines: 09:20:53.709 5958 [09:20:53.354] vtDecompressionDuctCreate signalled err=-8973 (err) (Could not select and open decoder instance) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.235/Sources/VideoToolbox/VTDecompressionSession.c line 1181 09:20:53.709 5958 <<<< VTVideoEncoderSelection >>>> VTSelectAndCreateVideoEncoderInstanceInternal: no video encoder found for 'avc1' Original issue's description: > Mojo JS bindings: change module loading solution. > > This change takes place on the mojo/public/js/new_bindings copy so it doesn't > affect existing users. > > - This change gets rid of AMD module loading. Now the bindings API is defined in > the "mojoBindings" namespace. At build time, all bindings files are combined > into a single file "mojo_bindings.js". Users should use <script> tag to include > this file (as well as generated mojom.js files). > > - Generated mojom.js files export their definitions under the same namespace as > the "module" statement in the corresponding mojom files. > > - This change also adds a "use_new_js_bindings" option to the generator. It > duplicates the control message mojom files in order to generate two > different flavors of JS bindings. > > - The new bindings use the Mojo system API defined by Web IDL. > > BUG=699569 > > Review-Url: https://codereview.chromium.org/2759563004 > Cr-Commit-Position: refs/heads/master@{#459654} > Committed: https://chromium.googlesource.com/chromium/src/+/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0 TBR=rockot@chromium.org,dcheng@chromium.org,alokp@chromium.org,yzshen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=699569 Review-Url: https://codereview.chromium.org/2779533002 Cr-Commit-Position: refs/heads/master@{#459745} [modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/interfaces/bindings/BUILD.gn [delete] https://crrev.com/931e61729f1b53919be3192d0d77cdf1f004c894/mojo/public/interfaces/bindings/new_bindings/OWNERS [delete] https://crrev.com/931e61729f1b53919be3192d0d77cdf1f004c894/mojo/public/interfaces/bindings/new_bindings/interface_control_messages.mojom [delete] https://crrev.com/931e61729f1b53919be3192d0d77cdf1f004c894/mojo/public/interfaces/bindings/new_bindings/pipe_control_messages.mojom [modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/interfaces/bindings/tests/BUILD.gn [delete] https://crrev.com/931e61729f1b53919be3192d0d77cdf1f004c894/mojo/public/interfaces/bindings/tests/echo.mojom [delete] https://crrev.com/931e61729f1b53919be3192d0d77cdf1f004c894/mojo/public/interfaces/bindings/tests/echo_import.mojom [modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/BUILD.gn [delete] https://crrev.com/931e61729f1b53919be3192d0d77cdf1f004c894/mojo/public/js/new_bindings/base.js [modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/bindings.js [modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/buffer.js [modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/codec.js [modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/connector.js [modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/interface_types.js [modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/lib/control_message_handler.js [modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/lib/control_message_proxy.js [modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/router.js [modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/unicode.js [modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/js/new_bindings/validator.js [modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl [modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/tools/bindings/generators/js_templates/module_definition.tmpl [modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/tools/bindings/generators/mojom_js_generator.py [modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/tools/bindings/mojom.gni [modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/tools/bindings/mojom_bindings_generator.py [modify] https://crrev.com/06cde11f9f3843eb13e3d3d73296a07e9e8601f5/mojo/public/tools/bindings/pylib/mojom/generate/generator.py [delete] https://crrev.com/931e61729f1b53919be3192d0d77cdf1f004c894/third_party/WebKit/LayoutTests/mojo/module-loading.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a06469911359843f3d823fac7a7c06fec3c46edb commit a06469911359843f3d823fac7a7c06fec3c46edb Author: yzshen <yzshen@chromium.org> Date: Sun Apr 02 22:01:27 2017 Mojo JS bindings: change module loading solution. This change takes place on the mojo/public/js/new_bindings copy so it doesn't affect existing users. - This change gets rid of AMD module loading. Now the bindings API is defined in the "mojo" namespace. At build time, all bindings files are combined into a single file "mojo_bindings.js". Users should use <script> tag to include this file (as well as generated mojom.js files). - Generated mojom.js files export their definitions under the same namespace as the "module" statement in the corresponding mojom files. - This change also adds a "use_new_js_bindings" option to the generator. It duplicates the control message mojom files in order to generate two different flavors of JS bindings. - The new bindings use the Mojo system API defined by Web IDL. BUG=699569 Review-Url: https://codereview.chromium.org/2759563004 Cr-Original-Commit-Position: refs/heads/master@{#459654} Committed: https://chromium.googlesource.com/chromium/src/+/e6a5534bb3fe61b5224f1a22e43ba957190ad5d0 Review-Url: https://codereview.chromium.org/2759563004 Cr-Commit-Position: refs/heads/master@{#461349} [modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/BUILD.gn [modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/interfaces/bindings/BUILD.gn [add] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/interfaces/bindings/new_bindings/OWNERS [add] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/interfaces/bindings/new_bindings/interface_control_messages.mojom [add] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/interfaces/bindings/new_bindings/pipe_control_messages.mojom [modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/interfaces/bindings/tests/BUILD.gn [add] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/interfaces/bindings/tests/echo.mojom [add] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/interfaces/bindings/tests/echo_import.mojom [modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/BUILD.gn [add] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/base.js [modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/bindings.js [modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/buffer.js [modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/codec.js [modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/connector.js [modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/interface_types.js [modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/lib/control_message_handler.js [modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/lib/control_message_proxy.js [modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/router.js [modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/unicode.js [modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/js/new_bindings/validator.js [modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl [modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/tools/bindings/generators/js_templates/module_definition.tmpl [modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/tools/bindings/generators/mojom_js_generator.py [modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/tools/bindings/mojom.gni [modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/tools/bindings/mojom_bindings_generator.py [modify] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/mojo/public/tools/bindings/pylib/mojom/generate/generator.py [add] https://crrev.com/a06469911359843f3d823fac7a7c06fec3c46edb/third_party/WebKit/LayoutTests/mojo/module-loading.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8e4332ca05f3220a36557b0e25dd3fa75365672 commit b8e4332ca05f3220a36557b0e25dd3fa75365672 Author: yzshen <yzshen@chromium.org> Date: Mon Apr 03 00:51:40 2017 Mojo JS bindings: support auto-loading mojom.js deps. It also adds a config to turn off this behavior. BUG=699569 Review-Url: https://codereview.chromium.org/2779493002 Cr-Commit-Position: refs/heads/master@{#461354} [modify] https://crrev.com/b8e4332ca05f3220a36557b0e25dd3fa75365672/mojo/public/js/new_bindings/base.js [modify] https://crrev.com/b8e4332ca05f3220a36557b0e25dd3fa75365672/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl [modify] https://crrev.com/b8e4332ca05f3220a36557b0e25dd3fa75365672/mojo/public/tools/bindings/generators/mojom_js_generator.py [add] https://crrev.com/b8e4332ca05f3220a36557b0e25dd3fa75365672/third_party/WebKit/LayoutTests/mojo/module-loading-manual-deps-loading.html [modify] https://crrev.com/b8e4332ca05f3220a36557b0e25dd3fa75365672/third_party/WebKit/LayoutTests/mojo/module-loading.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e95f5e84d92d7690faed48157cbe09fc6762376 commit 8e95f5e84d92d7690faed48157cbe09fc6762376 Author: yzshen <yzshen@chromium.org> Date: Sat May 20 15:25:09 2017 Mojo JS bindings: switch all mojo/ layout tests to use the new bindings. BUG=699569 Review-Url: https://codereview.chromium.org/2891193002 Cr-Commit-Position: refs/heads/master@{#473439} [modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/interfaces/bindings/tests/BUILD.gn [modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/js/BUILD.gn [modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/js/new_bindings/bindings.js [modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/js/new_bindings/connector.js [modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/js/new_bindings/lib/interface_endpoint_client.js [modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/js/new_bindings/router.js [modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/js/new_bindings/validator.js [modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl [modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl [modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/tools/bindings/generators/js_templates/module_definition.tmpl [modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/mojo/public/tools/bindings/pylib/mojom/generate/generator.py [modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/associated_binding.html [modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/associated_interface_ptr.html [modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/binding.html [modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/codec.html [modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/connection.html [modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/interface_ptr.html [modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/resources/validation_test_input_parser.js [modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/sample_service.html [modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/struct.html [modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/union.html [modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/LayoutTests/mojo/validation.html [modify] https://crrev.com/8e95f5e84d92d7690faed48157cbe09fc6762376/third_party/WebKit/Source/core/mojo/MojoWatcher.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2296029e3eb2343421c90354582aa111ecba43d6 commit 2296029e3eb2343421c90354582aa111ecba43d6 Author: Ken Rockot <rockot@chromium.org> Date: Fri May 26 09:04:28 2017 Enable Blink native Mojo bindings in WebUI Adds the concept of ContextEnabled features as an extended attribute in Web IDL, exposing a way for embedders to turn specific API features on or off at context creation time. Affixes this extended attribute to Mojo, MojoHandle, and MojoWatcher IDLs to allow their exposure to be controlled per-context separately from the MojoJS RuntimeEnabled state. Finally, this also flips on the MojoJS ContextEnabled feature for all RenderFrame contexts in which WebUI bindings are enabled. BUG=699569,723923 Change-Id: Ie0fd6383ae86c133685b3e7b31eeca769bf83e06 Reviewed-on: https://chromium-review.googlesource.com/509390 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#474973} [modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/content/browser/webui/web_ui_mojo_browsertest.cc [modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/content/renderer/mojo_bindings_controller.cc [modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/content/renderer/mojo_bindings_controller.h [add] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/content/test/data/web_ui_mojo_native.html [add] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/content/test/data/web_ui_mojo_native.js [modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/IDLExtendedAttributes.md [modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/IDLExtendedAttributes.txt [modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/core/v8/ConditionalFeaturesForCore.cpp [modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/scripts/generate_global_constructors.py [modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/scripts/v8_attributes.py [modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/scripts/v8_interface.py [modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/scripts/v8_utilities.py [modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/templates/interface.h.tmpl [modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl [modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/templates/partial_interface.h.tmpl [modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/bindings/tests/idls/core/TestInterface.idl [modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/core/BUILD.gn [add] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/core/context_features/BUILD.gn [add] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/core/context_features/ContextFeatureSettings.cpp [add] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/core/context_features/ContextFeatureSettings.h [modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/core/mojo/Mojo.idl [modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/core/mojo/MojoHandle.idl [modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/core/mojo/MojoWatcher.idl [modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/web/BUILD.gn [add] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/Source/web/WebContextFeatures.cpp [modify] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/public/BUILD.gn [add] https://crrev.com/2296029e3eb2343421c90354582aa111ecba43d6/third_party/WebKit/public/web/WebContextFeatures.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eae56c386f559a286494aeb58f7fd9857efd960d commit eae56c386f559a286494aeb58f7fd9857efd960d Author: yzshen <yzshen@chromium.org> Date: Mon May 29 10:00:42 2017 Mojo JS bindings: flip the default value of use_new_js_bindings to true. BUG=699569 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2910703004 Cr-Commit-Position: refs/heads/master@{#475327} [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/chrome/browser/engagement/BUILD.gn [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/chrome/browser/ui/webui/omnibox/BUILD.gn [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/chrome/browser/ui/webui/usb_internals/BUILD.gn [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/chrome/common/media_router/mojo/BUILD.gn [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/components/payments/mojom/BUILD.gn [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/content/test/BUILD.gn [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/device/bluetooth/public/interfaces/BUILD.gn [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/device/generic_sensor/public/interfaces/BUILD.gn [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/device/geolocation/public/interfaces/BUILD.gn [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/device/usb/public/interfaces/BUILD.gn [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/device/vr/BUILD.gn [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/extensions/common/BUILD.gn [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/extensions/common/api/BUILD.gn [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/gpu/ipc/common/BUILD.gn [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/ios/web/test/BUILD.gn [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/media/capture/mojo/BUILD.gn [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/mojo/common/BUILD.gn [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/mojo/edk/js/tests/BUILD.gn [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/mojo/public/interfaces/bindings/BUILD.gn [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/mojo/public/interfaces/bindings/tests/BUILD.gn [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/mojo/public/tools/bindings/mojom.gni [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/net/interfaces/BUILD.gn [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/services/device/public/interfaces/BUILD.gn [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/services/service_manager/public/interfaces/BUILD.gn [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/services/shape_detection/public/interfaces/BUILD.gn [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/third_party/WebKit/public/BUILD.gn [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/ui/gfx/geometry/mojo/BUILD.gn [modify] https://crrev.com/eae56c386f559a286494aeb58f7fd9857efd960d/url/mojo/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9821a80606c582307bc791c798c6ccaeadaa70ec commit 9821a80606c582307bc791c798c6ccaeadaa70ec Author: junwei.fu <junwei.fu@intel.com> Date: Fri Jun 02 03:51:48 2017 Mojo JS bindings: flip the default value of use_new_js_bindings to true. Test cases will time out when CL [1] using skia mojo bitmap. [1] https://codereview.chromium.org/2875243002# BUG=699569 Review-Url: https://codereview.chromium.org/2912323002 Cr-Commit-Position: refs/heads/master@{#476555} [modify] https://crrev.com/9821a80606c582307bc791c798c6ccaeadaa70ec/skia/public/interfaces/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e70d197e633996bf32ece4aac1158582fad51462 commit e70d197e633996bf32ece4aac1158582fad51462 Author: Yuzhu Shen <yzshen@chromium.org> Date: Fri Jun 02 18:03:57 2017 Mojo JS bindings: add documentation. TBR=rockot@chromium.org,jam@chromium.org BUG=699569 Change-Id: I5542a46a2f377ac9c6e64b1519f94659ab7fd4bc Reviewed-on: https://chromium-review.googlesource.com/521789 Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Yuzhu Shen <yzshen@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#476719} [modify] https://crrev.com/e70d197e633996bf32ece4aac1158582fad51462/mojo/README.md [modify] https://crrev.com/e70d197e633996bf32ece4aac1158582fad51462/mojo/public/cpp/bindings/README.md [modify] https://crrev.com/e70d197e633996bf32ece4aac1158582fad51462/mojo/public/js/README.md [modify] https://crrev.com/e70d197e633996bf32ece4aac1158582fad51462/third_party/WebKit/Source/core/mojo/README.md
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd57fa764813de09d159a232eeef1bb21b0ccc1e commit dd57fa764813de09d159a232eeef1bb21b0ccc1e Author: alokp <alokp@chromium.org> Date: Wed Jun 07 04:27:00 2017 Moves mojo_js_integration_tests into blink. BUG=699569 Review-Url: https://codereview.chromium.org/2734783008 Cr-Commit-Position: refs/heads/master@{#477549} [modify] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/mojo/edk/js/tests/BUILD.gn [delete] https://crrev.com/8709f78a5a70fd9db4414ca6c0fe281d668f31e5/mojo/edk/js/tests/js_to_cpp_tests.cc [modify] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/testing/buildbot/chromium.linux.json [modify] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/testing/buildbot/client.v8.chromium.json [modify] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/third_party/WebKit/Source/core/BUILD.gn [modify] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/third_party/WebKit/Source/core/mojo/BUILD.gn [rename] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/third_party/WebKit/Source/core/mojo/tests/JsToCpp.mojom [add] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.cpp [rename] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.js [add] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/third_party/WebKit/Source/core/mojo/tests/OWNERS [modify] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp [modify] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h [modify] https://crrev.com/dd57fa764813de09d159a232eeef1bb21b0ccc1e/tools/determinism/deterministic_build_whitelist.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6536a56d25c245bd109e32ed49240bfc04f8890f commit 6536a56d25c245bd109e32ed49240bfc04f8890f Author: jwd <jwd@chromium.org> Date: Wed Jun 07 15:20:41 2017 Revert of Moves mojo_js_integration_tests into blink. (patchset #11 id:190001 of https://codereview.chromium.org/2734783008/ ) Reason for revert: Seems related to webkit failures of the JsToCpp tests. E.x. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/34530. Original issue's description: > Moves mojo_js_integration_tests into blink. > > BUG=699569 > > Review-Url: https://codereview.chromium.org/2734783008 > Cr-Commit-Position: refs/heads/master@{#477549} > Committed: https://chromium.googlesource.com/chromium/src/+/dd57fa764813de09d159a232eeef1bb21b0ccc1e TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,alokp@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=699569 Review-Url: https://codereview.chromium.org/2926143002 Cr-Commit-Position: refs/heads/master@{#477653} [modify] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/mojo/edk/js/tests/BUILD.gn [rename] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/mojo/edk/js/tests/js_to_cpp.mojom [add] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/mojo/edk/js/tests/js_to_cpp_tests.cc [rename] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/mojo/edk/js/tests/js_to_cpp_tests.js [modify] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/testing/buildbot/chromium.linux.json [modify] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/testing/buildbot/client.v8.chromium.json [modify] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/third_party/WebKit/Source/core/BUILD.gn [modify] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/third_party/WebKit/Source/core/mojo/BUILD.gn [delete] https://crrev.com/b3f80bd4e91f989a0a52f8cf2baa9fcc4df4fd75/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.cpp [delete] https://crrev.com/b3f80bd4e91f989a0a52f8cf2baa9fcc4df4fd75/third_party/WebKit/Source/core/mojo/tests/OWNERS [modify] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp [modify] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h [modify] https://crrev.com/6536a56d25c245bd109e32ed49240bfc04f8890f/tools/determinism/deterministic_build_whitelist.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea19acc0fca1c00e9ea1dd01df0a462126902faf commit ea19acc0fca1c00e9ea1dd01df0a462126902faf Author: Ken Rockot <rockot@chromium.org> Date: Wed Jun 07 18:12:07 2017 Convert chrome://omnibox to new Mojo bindings Makes the generated, concatenated public Mojo JS bindings library available as a shared WebUI resource and converts the chrome://omnibox page to use the new bindings in place of the old ones. BUG=699569 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib22df79892cf737dbcfad5320b5ddf7b2028bfcf Reviewed-on: https://chromium-review.googlesource.com/523421 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#477707} [modify] https://crrev.com/ea19acc0fca1c00e9ea1dd01df0a462126902faf/chrome/browser/resources/omnibox/omnibox.html [modify] https://crrev.com/ea19acc0fca1c00e9ea1dd01df0a462126902faf/chrome/browser/resources/omnibox/omnibox.js [modify] https://crrev.com/ea19acc0fca1c00e9ea1dd01df0a462126902faf/chrome/browser/ui/webui/omnibox/BUILD.gn [modify] https://crrev.com/ea19acc0fca1c00e9ea1dd01df0a462126902faf/chrome/browser/ui/webui/omnibox/omnibox_ui.cc [modify] https://crrev.com/ea19acc0fca1c00e9ea1dd01df0a462126902faf/content/browser/webui/shared_resources_data_source.cc [modify] https://crrev.com/ea19acc0fca1c00e9ea1dd01df0a462126902faf/ui/resources/BUILD.gn [modify] https://crrev.com/ea19acc0fca1c00e9ea1dd01df0a462126902faf/ui/webui/resources/webui_resources.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961 commit 0fac10b6b0a132a25eedf971c8ccffaa6e8a4961 Author: alokp <alokp@chromium.org> Date: Mon Jun 12 23:34:14 2017 Reland of Moves mojo_js_integration_tests into blink. (patchset #1 id:1 of https://codereview.chromium.org/2926143002/ ) Reason for revert: Fixed failing tests. Original issue's description: > Revert of Moves mojo_js_integration_tests into blink. (patchset #11 id:190001 of https://codereview.chromium.org/2734783008/ ) > > Reason for revert: > Seems related to webkit failures of the JsToCpp tests. E.x. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/34530. > > Original issue's description: > > Moves mojo_js_integration_tests into blink. > > > > BUG=699569 > > > > Review-Url: https://codereview.chromium.org/2734783008 > > Cr-Commit-Position: refs/heads/master@{#477549} > > Committed: https://chromium.googlesource.com/chromium/src/+/dd57fa764813de09d159a232eeef1bb21b0ccc1e > > TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,alokp@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=699569 > > Review-Url: https://codereview.chromium.org/2926143002 > Cr-Commit-Position: refs/heads/master@{#477653} > Committed: https://chromium.googlesource.com/chromium/src/+/6536a56d25c245bd109e32ed49240bfc04f8890f TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,jwd@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=699569 Review-Url: https://codereview.chromium.org/2920383004 Cr-Commit-Position: refs/heads/master@{#478820} [modify] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/mojo/edk/js/tests/BUILD.gn [delete] https://crrev.com/f1e4c0cc3c76b155337800383e54537a88fcdfe7/mojo/edk/js/tests/js_to_cpp_tests.cc [modify] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/testing/buildbot/chromium.linux.json [modify] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/testing/buildbot/client.v8.chromium.json [modify] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/third_party/WebKit/Source/core/BUILD.gn [modify] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/third_party/WebKit/Source/core/mojo/BUILD.gn [rename] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/third_party/WebKit/Source/core/mojo/tests/JsToCpp.mojom [add] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.cpp [rename] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.js [add] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/third_party/WebKit/Source/core/mojo/tests/OWNERS [modify] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp [modify] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h [modify] https://crrev.com/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961/tools/determinism/deterministic_build_whitelist.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38f3a45e512fed9682729fcf57bdacfc6bfc1ece commit 38f3a45e512fed9682729fcf57bdacfc6bfc1ece Author: tzik <tzik@chromium.org> Date: Tue Jun 13 03:16:20 2017 Revert of Moves mojo_js_integration_tests into blink. (patchset #1 id:1 of https://codereview.chromium.org/2920383004/ ) Reason for revert: This CL seems to break webkit_unittests. The error log is: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/34695 The tests below were timed out: JsToCppTest.BackPointer JsToCppTest.BitFlip JsToCppTest.Echo JsToCppTest.Ping Original issue's description: > Reland of Moves mojo_js_integration_tests into blink. (patchset #1 id:1 of https://codereview.chromium.org/2926143002/ ) > > Reason for revert: > Fixed failing tests. > > Original issue's description: > > Revert of Moves mojo_js_integration_tests into blink. (patchset #11 id:190001 of https://codereview.chromium.org/2734783008/ ) > > > > Reason for revert: > > Seems related to webkit failures of the JsToCpp tests. E.x. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/34530. > > > > Original issue's description: > > > Moves mojo_js_integration_tests into blink. > > > > > > BUG=699569 > > > > > > Review-Url: https://codereview.chromium.org/2734783008 > > > Cr-Commit-Position: refs/heads/master@{#477549} > > > Committed: https://chromium.googlesource.com/chromium/src/+/dd57fa764813de09d159a232eeef1bb21b0ccc1e > > > > TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,alokp@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=699569 > > > > Review-Url: https://codereview.chromium.org/2926143002 > > Cr-Commit-Position: refs/heads/master@{#477653} > > Committed: https://chromium.googlesource.com/chromium/src/+/6536a56d25c245bd109e32ed49240bfc04f8890f > > TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,jwd@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=699569 > > Review-Url: https://codereview.chromium.org/2920383004 > Cr-Commit-Position: refs/heads/master@{#478820} > Committed: https://chromium.googlesource.com/chromium/src/+/0fac10b6b0a132a25eedf971c8ccffaa6e8a4961 TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,jwd@chromium.org,alokp@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=699569 Review-Url: https://codereview.chromium.org/2939663002 Cr-Commit-Position: refs/heads/master@{#478881} [modify] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/mojo/edk/js/tests/BUILD.gn [rename] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/mojo/edk/js/tests/js_to_cpp.mojom [add] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/mojo/edk/js/tests/js_to_cpp_tests.cc [rename] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/mojo/edk/js/tests/js_to_cpp_tests.js [modify] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/testing/buildbot/chromium.linux.json [modify] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/testing/buildbot/client.v8.chromium.json [modify] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/third_party/WebKit/Source/core/BUILD.gn [modify] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/third_party/WebKit/Source/core/mojo/BUILD.gn [delete] https://crrev.com/7f4a499745ae9a8601e20ef616e8e1e877934269/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.cpp [delete] https://crrev.com/7f4a499745ae9a8601e20ef616e8e1e877934269/third_party/WebKit/Source/core/mojo/tests/OWNERS [modify] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp [modify] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h [modify] https://crrev.com/38f3a45e512fed9682729fcf57bdacfc6bfc1ece/tools/determinism/deterministic_build_whitelist.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4ddb86f7b07335a3a02e1ce5a37ae6c4070ae4e commit c4ddb86f7b07335a3a02e1ce5a37ae6c4070ae4e Author: yzshen <yzshen@chromium.org> Date: Tue Jun 13 14:14:05 2017 Mojo JS bindings: convert relative path to URL properly. BUG=699569 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2930423002 Cr-Commit-Position: refs/heads/master@{#479006} [modify] https://crrev.com/c4ddb86f7b07335a3a02e1ce5a37ae6c4070ae4e/mojo/public/interfaces/bindings/tests/BUILD.gn [modify] https://crrev.com/c4ddb86f7b07335a3a02e1ce5a37ae6c4070ae4e/mojo/public/interfaces/bindings/tests/echo.mojom [add] https://crrev.com/c4ddb86f7b07335a3a02e1ce5a37ae6c4070ae4e/mojo/public/interfaces/bindings/tests/echo_import/OWNERS [rename] https://crrev.com/c4ddb86f7b07335a3a02e1ce5a37ae6c4070ae4e/mojo/public/interfaces/bindings/tests/echo_import/echo_import.mojom [modify] https://crrev.com/c4ddb86f7b07335a3a02e1ce5a37ae6c4070ae4e/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl [modify] https://crrev.com/c4ddb86f7b07335a3a02e1ce5a37ae6c4070ae4e/mojo/public/tools/bindings/generators/mojom_js_generator.py [modify] https://crrev.com/c4ddb86f7b07335a3a02e1ce5a37ae6c4070ae4e/third_party/WebKit/LayoutTests/mojo/module-loading-manual-deps-loading.html
Just so you know, I'm working on a large patch which converts a number of targets to the new Mojo JS bindings because I tried to depend on mojo/common:common_custom_types from a target that already used the new JS bindings.
Great! Thanks Reilly!
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c461e58ee3a426a1064c83895f9320ff94121712 commit c461e58ee3a426a1064c83895f9320ff94121712 Author: Daniel Cheng <dcheng@chromium.org> Date: Sat Jun 17 08:08:38 2017 Revert "Reland of Moves mojo_js_integration_tests into blink. (patchset #1 id:1 of https://codereview.chromium.org/2939663002/ )" Reason for revert: WebKit Android (Nexus4) are still broken with four failing tests: JsToCppTest.BackPointer JsToCppTest.BitFlip JsToCppTest.Ping JsToCppTest.Echo TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,jwd@chromium.org,alokp@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=699569 Change-Id: I925840dbe50bd21e6c87b03f23d6b4007d27df63 Reviewed-on: https://chromium-review.googlesource.com/538520 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#480282} [modify] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/mojo/edk/js/tests/BUILD.gn [rename] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/mojo/edk/js/tests/js_to_cpp.mojom [add] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/mojo/edk/js/tests/js_to_cpp_tests.cc [rename] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/mojo/edk/js/tests/js_to_cpp_tests.js [modify] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/testing/buildbot/chromium.linux.json [modify] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/testing/buildbot/client.v8.chromium.json [modify] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/third_party/WebKit/Source/core/BUILD.gn [modify] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/third_party/WebKit/Source/core/mojo/BUILD.gn [delete] https://crrev.com/07f0acbacf4853d4cfe56a134a601576fd547cf0/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.cpp [delete] https://crrev.com/07f0acbacf4853d4cfe56a134a601576fd547cf0/third_party/WebKit/Source/core/mojo/tests/OWNERS [modify] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp [modify] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h [modify] https://crrev.com/c461e58ee3a426a1064c83895f9320ff94121712/tools/determinism/deterministic_build_whitelist.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26834276c6bf9eab813f5ea7d4f37f4d73fb491c commit 26834276c6bf9eab813f5ea7d4f37f4d73fb491c Author: Alok Priyadarshi <alokp@chromium.org> Date: Thu Jun 22 23:18:05 2017 Reland of "Moves mojo_js_integration_tests into blink." This reverts commit c461e58ee3a426a1064c83895f9320ff94121712. Reason for revert: JsToCpp.mojom.js should now be available on android devices when running webkit_unit_tests: https://chromium-review.googlesource.com/c/540085/ Original change's description: > Revert "Reland of Moves mojo_js_integration_tests into blink. (patchset #1 id:1 of https://codereview.chromium.org/2939663002/ )" > > Reason for revert: > WebKit Android (Nexus4) are still broken with four failing tests: > JsToCppTest.BackPointer > JsToCppTest.BitFlip > JsToCppTest.Ping > JsToCppTest.Echo > > TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,jwd@chromium.org,alokp@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=699569 > > Change-Id: I925840dbe50bd21e6c87b03f23d6b4007d27df63 > Reviewed-on: https://chromium-review.googlesource.com/538520 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#480282} TBR=dcheng@chromium.org,jwd@chromium.org,jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,agrieve@chromium.org,alokp@chromium.org Bug: 699569 Change-Id: I59bcce1f0a4f650eedaea7cce999b650041e7506 Reviewed-on: https://chromium-review.googlesource.com/540664 Commit-Queue: Alok Priyadarshi <alokp@chromium.org> Reviewed-by: Alok Priyadarshi <alokp@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#481712} [modify] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/mojo/edk/js/tests/BUILD.gn [delete] https://crrev.com/d3bd31fdd98cd0b900581d77953eeaa3e25337ad/mojo/edk/js/tests/js_to_cpp_tests.cc [modify] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/testing/buildbot/chromium.linux.json [modify] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/testing/buildbot/client.v8.chromium.json [modify] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/third_party/WebKit/Source/core/BUILD.gn [modify] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/third_party/WebKit/Source/core/mojo/BUILD.gn [rename] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/third_party/WebKit/Source/core/mojo/tests/JsToCpp.mojom [add] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.cpp [rename] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.js [add] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/third_party/WebKit/Source/core/mojo/tests/OWNERS [modify] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp [modify] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h [modify] https://crrev.com/26834276c6bf9eab813f5ea7d4f37f4d73fb491c/tools/determinism/deterministic_build_whitelist.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa273aed7238cabd05b59be36b5eee9ce62f000c commit aa273aed7238cabd05b59be36b5eee9ce62f000c Author: Kunihiko Sakamoto <ksakamoto@chromium.org> Date: Fri Jun 23 02:08:48 2017 Revert "Reland of "Moves mojo_js_integration_tests into blink."" This reverts commit 26834276c6bf9eab813f5ea7d4f37f4d73fb491c. Reason for revert: These tests are still failing on WebKit Android (Nexus4): JsToCppTest.BackPointer JsToCppTest.BitFlip JsToCppTest.Ping JsToCppTest.Echo Example build: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/66197 Original change's description: > Reland of "Moves mojo_js_integration_tests into blink." > > This reverts commit c461e58ee3a426a1064c83895f9320ff94121712. > > Reason for revert: JsToCpp.mojom.js should now be available on android devices when running webkit_unit_tests: https://chromium-review.googlesource.com/c/540085/ > > Original change's description: > > Revert "Reland of Moves mojo_js_integration_tests into blink. (patchset #1 id:1 of https://codereview.chromium.org/2939663002/ )" > > > > Reason for revert: > > WebKit Android (Nexus4) are still broken with four failing tests: > > JsToCppTest.BackPointer > > JsToCppTest.BitFlip > > JsToCppTest.Ping > > JsToCppTest.Echo > > > > TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,jwd@chromium.org,alokp@chromium.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=699569 > > > > Change-Id: I925840dbe50bd21e6c87b03f23d6b4007d27df63 > > Reviewed-on: https://chromium-review.googlesource.com/538520 > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#480282} > > TBR=dcheng@chromium.org,jwd@chromium.org,jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,agrieve@chromium.org,alokp@chromium.org > > Bug: 699569 > Change-Id: I59bcce1f0a4f650eedaea7cce999b650041e7506 > Reviewed-on: https://chromium-review.googlesource.com/540664 > Commit-Queue: Alok Priyadarshi <alokp@chromium.org> > Reviewed-by: Alok Priyadarshi <alokp@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#481712} TBR=dcheng@chromium.org,jwd@chromium.org,jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,agrieve@chromium.org,alokp@chromium.org Change-Id: I496aba914c51b914ffb8082d9d6cb4c8cf45f590 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 699569 Reviewed-on: https://chromium-review.googlesource.com/544452 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#481784} [modify] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/mojo/edk/js/tests/BUILD.gn [rename] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/mojo/edk/js/tests/js_to_cpp.mojom [add] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/mojo/edk/js/tests/js_to_cpp_tests.cc [rename] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/mojo/edk/js/tests/js_to_cpp_tests.js [modify] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/testing/buildbot/chromium.linux.json [modify] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/testing/buildbot/client.v8.chromium.json [modify] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/third_party/WebKit/Source/core/BUILD.gn [modify] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/third_party/WebKit/Source/core/mojo/BUILD.gn [delete] https://crrev.com/b4bc987ccfa1400e505bcaae38fd7463af0b11ac/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.cpp [delete] https://crrev.com/b4bc987ccfa1400e505bcaae38fd7463af0b11ac/third_party/WebKit/Source/core/mojo/tests/OWNERS [modify] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp [modify] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h [modify] https://crrev.com/aa273aed7238cabd05b59be36b5eee9ce62f000c/tools/determinism/deterministic_build_whitelist.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e5e955eb4ab56b4970578ed743616858ef77817 commit 7e5e955eb4ab56b4970578ed743616858ef77817 Author: yzshen <yzshen@chromium.org> Date: Mon Jun 26 21:56:26 2017 Support new-style Mojo JS core API on IOS. BUG=699569 Review-Url: https://codereview.chromium.org/2946383002 Cr-Commit-Position: refs/heads/master@{#482426} [delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/third_party/requirejs/LICENSE [delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/third_party/requirejs/OWNERS [delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/third_party/requirejs/README.chromium [delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/third_party/requirejs/require.js [modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/BUILD.gn [modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/ios_web_resources.grd [modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/test/BUILD.gn [modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/test/data/mojo_test.html [modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/test/data/mojo_test.js [modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/webui/crw_web_ui_manager.mm [modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/webui/crw_web_ui_manager_unittest.mm [modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/webui/mojo_facade.h [modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/webui/mojo_facade.mm [modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/webui/mojo_facade_unittest.mm [delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/mojo_js_constants.cc [delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/mojo_js_constants.h [delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/resources/console.js [delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/resources/core.js [delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/resources/handle_util.js [delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/resources/interface_provider.js [add] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/webui/resources/mojo_api.js [delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/resources/support.js [delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/resources/sync_message_channel.js [delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/resources/timer.js [modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/webui/resources/web_ui_bundle.js [delete] https://crrev.com/1e7ac4345c9b98f7a32115809a64f7e86bee33e6/ios/web/webui/resources/web_ui_module_load_notifier.js [modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/ios/web/webui/web_ui_mojo_inttest.mm [modify] https://crrev.com/7e5e955eb4ab56b4970578ed743616858ef77817/mojo/public/js/new_bindings/base.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dc048bef86deaed860574f5d3a29b23f0c3e6c73 commit dc048bef86deaed860574f5d3a29b23f0c3e6c73 Author: yzshen <yzshen@chromium.org> Date: Tue Jul 04 19:10:23 2017 Mojo JS bindings: add support to generate "dual-mode" code. Previously, if mojom target A and B both depend on C, in order to convert A to the new mode, we need to convert C, and also all the targets that depend on C (i.e., B). With this CL, we could let target C generate code supporting both modes. That way B don't have to be touched in the same CL. TBR=brettw@chromium.org (For the changes in url/mojo/BUILD.gn) BUG=699569 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2965803003 Cr-Commit-Position: refs/heads/master@{#484145} [modify] https://crrev.com/dc048bef86deaed860574f5d3a29b23f0c3e6c73/chrome/browser/resources/usb_internals/usb_internals.html [modify] https://crrev.com/dc048bef86deaed860574f5d3a29b23f0c3e6c73/chrome/browser/resources/usb_internals/usb_internals.js [modify] https://crrev.com/dc048bef86deaed860574f5d3a29b23f0c3e6c73/chrome/browser/ui/webui/usb_internals/BUILD.gn [modify] https://crrev.com/dc048bef86deaed860574f5d3a29b23f0c3e6c73/chrome/browser/ui/webui/usb_internals/usb_internals_ui.cc [modify] https://crrev.com/dc048bef86deaed860574f5d3a29b23f0c3e6c73/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl [modify] https://crrev.com/dc048bef86deaed860574f5d3a29b23f0c3e6c73/mojo/public/tools/bindings/generators/js_templates/module_definition.tmpl [modify] https://crrev.com/dc048bef86deaed860574f5d3a29b23f0c3e6c73/mojo/public/tools/bindings/generators/mojom_js_generator.py [modify] https://crrev.com/dc048bef86deaed860574f5d3a29b23f0c3e6c73/mojo/public/tools/bindings/mojom.gni [modify] https://crrev.com/dc048bef86deaed860574f5d3a29b23f0c3e6c73/mojo/public/tools/bindings/mojom_bindings_generator.py [modify] https://crrev.com/dc048bef86deaed860574f5d3a29b23f0c3e6c73/mojo/public/tools/bindings/pylib/mojom/generate/generator.py [modify] https://crrev.com/dc048bef86deaed860574f5d3a29b23f0c3e6c73/third_party/WebKit/LayoutTests/vibration/vibration-expected.txt [modify] https://crrev.com/dc048bef86deaed860574f5d3a29b23f0c3e6c73/url/mojo/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7b1af385b62029ed042d59e93112ea9f7fed8ef commit e7b1af385b62029ed042d59e93112ea9f7fed8ef Author: Reilly Grant <reillyg@chromium.org> Date: Thu Jul 06 23:35:46 2017 Switch the WebVR LayoutTests to the new Mojo JS bindings This change switches the WebVR Mojo interface JS bindings to the new style and updates the LayoutTests accordingly. Mojoms that this interface depends on are switched to generating both styles of bindings while some users have not yet been updated. Bug: 699569 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If9171cf4b764a39ebfeb00e21b2c039e7f3e6812 Reviewed-on: https://chromium-review.googlesource.com/560578 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Oliver Chang (OOO until July 10) <ochang@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#484766} [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/device/vr/BUILD.gn [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/gpu/ipc/common/BUILD.gn [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/mojo/common/BUILD.gn [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/events_vrdisplayactivate.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/events_vrdisplayconnect.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/events_vrdisplaypresentchange.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/exitPresent_reject_notpresenting.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/exitPresent_resolve.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/getEyeParameters_match.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/getFrameData_noupdate.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/getFrameData_oneframeupdate.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/getFrameData_samewithinframe.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/getLayers_notpresenting.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/getLayers_presenting.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/getLayers_presenting_nondefaultbounds.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/getLayers_update.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/getVRDisplays_one_display.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/getVRDisplays_two_display.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/getVRDisplays_zero_display.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/multiple_requestAnimationFrame_called.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestAnimationFrame_called.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestAnimationFrame_consistentTimestamps.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestAnimationFrame_handoff.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestAnimationFrame_invalidhandle.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestAnimationFrame_submitFrame_combinations.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestAnimationFrame_unregister.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_reject_badleftbounds.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_reject_badrightbounds.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nogesture.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nolayers.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nosource.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_reject_notsupported.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nowebgl.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_reject_nullsource.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_reject_toomanylayers.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_resolve.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_resolve_repeatwithgesture.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_resolve_repeatwithoutgesture.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_resolve_then_reject.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/requestPresent_resolve_webgl2.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/resources/mock-vr-service.js [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/third_party/WebKit/LayoutTests/vr/stageParameters_match.html [modify] https://crrev.com/e7b1af385b62029ed042d59e93112ea9f7fed8ef/ui/gfx/geometry/mojo/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47d872925a8504668a2b2c65f1d0572264d08398 commit 47d872925a8504668a2b2c65f1d0572264d08398 Author: Reilly Grant <reillyg@chromium.org> Date: Fri Jul 07 21:17:26 2017 Switch the Shape Detection LayoutTests to the new Mojo JS bindings This change switches the Shape Detection Mojo interface JS bindings to the new style and updates the LayoutTests accordingly. The Skia Mojo interfaces are also switched to generating the new binding style while the ui/gfx/geometry interfaces must still generated both as a temporary step while some code has not yet been updated. These tests demonstrate how the DCHECK in ~MojoWatcher is invalid and so it is removed. Bug: 699569 Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Change-Id: Ic83ac9bd50072eae8461edc0b85cd4bcae147358 Reviewed-on: https://chromium-review.googlesource.com/560646 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by: Miguel Casas <mcasas@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#485049} [modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/services/shape_detection/public/interfaces/BUILD.gn [modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/skia/public/interfaces/BUILD.gn [modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLCanvasElement.html [modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html [modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLVideoElement.html [modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/LayoutTests/shapedetection/detection-ImageBitmap.html [modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/LayoutTests/shapedetection/detection-ImageData.html [modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/LayoutTests/shapedetection/detection-on-worker.html [modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/LayoutTests/shapedetection/detection-options.html [modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/LayoutTests/shapedetection/detection-security-test.html [modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/LayoutTests/shapedetection/detector-same-object.html [modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/LayoutTests/shapedetection/resources/mock-barcodedetection.js [modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js [modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/LayoutTests/shapedetection/resources/mock-textdetection.js [modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/LayoutTests/shapedetection/resources/worker.js [modify] https://crrev.com/47d872925a8504668a2b2c65f1d0572264d08398/third_party/WebKit/Source/core/mojo/MojoWatcher.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5946acdc3a28c62847b18991fe06f86e631a40c1 commit 5946acdc3a28c62847b18991fe06f86e631a40c1 Author: Reilly Grant <reillyg@chromium.org> Date: Mon Jul 10 23:53:55 2017 Switch the MediaSession LayoutTests to the new Mojo JS bindings This change enables generation of both Mojo JS bindings styles in the //third_party/WebKit/public:android_mojo_bindings target and updates the LayoutTests for the MediaSession API to use the new style. Bug: 699569 Change-Id: Ifebdcbe5cffffd61d3dfcb48b590c447416d8d7a Reviewed-on: https://chromium-review.googlesource.com/563704 Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Yuzhu Shen <yzshen@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#485452} [modify] https://crrev.com/5946acdc3a28c62847b18991fe06f86e631a40c1/third_party/WebKit/LayoutTests/media/mediasession/mojo/callback-alive-after-gc.html [modify] https://crrev.com/5946acdc3a28c62847b18991fe06f86e631a40c1/third_party/WebKit/LayoutTests/media/mediasession/mojo/file-image-removed.html [modify] https://crrev.com/5946acdc3a28c62847b18991fe06f86e631a40c1/third_party/WebKit/LayoutTests/media/mediasession/mojo/media-control-action-reaches-client.html [modify] https://crrev.com/5946acdc3a28c62847b18991fe06f86e631a40c1/third_party/WebKit/LayoutTests/media/mediasession/mojo/media-control-set-handler-notifies-service.html [modify] https://crrev.com/5946acdc3a28c62847b18991fe06f86e631a40c1/third_party/WebKit/LayoutTests/media/mediasession/mojo/metadata-async.html [modify] https://crrev.com/5946acdc3a28c62847b18991fe06f86e631a40c1/third_party/WebKit/LayoutTests/media/mediasession/mojo/metadata-propagated-twice.html [modify] https://crrev.com/5946acdc3a28c62847b18991fe06f86e631a40c1/third_party/WebKit/LayoutTests/media/mediasession/mojo/metadata-propagated.html [modify] https://crrev.com/5946acdc3a28c62847b18991fe06f86e631a40c1/third_party/WebKit/LayoutTests/media/mediasession/mojo/metadata-session-link.html [modify] https://crrev.com/5946acdc3a28c62847b18991fe06f86e631a40c1/third_party/WebKit/LayoutTests/media/mediasession/mojo/playback-state-propagated.html [modify] https://crrev.com/5946acdc3a28c62847b18991fe06f86e631a40c1/third_party/WebKit/LayoutTests/media/mediasession/mojo/resources/mediasessionservice-mock.js [modify] https://crrev.com/5946acdc3a28c62847b18991fe06f86e631a40c1/third_party/WebKit/LayoutTests/media/mediasession/mojo/set-null-metadata.html [modify] https://crrev.com/5946acdc3a28c62847b18991fe06f86e631a40c1/third_party/WebKit/public/BUILD.gn [modify] https://crrev.com/5946acdc3a28c62847b18991fe06f86e631a40c1/ui/gfx/geometry/mojo/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57 commit be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57 Author: Reilly Grant <reillyg@chromium.org> Date: Tue Jul 11 01:51:26 2017 Switch the Geolocation LayoutTests to the new Mojo JS bindings This change switches the Geolocation Mojo interface JS bindings to the new style and updates the LayoutTests accordingly. The Blink Mojo interfaces are switched to generating both styles of bindings as an temporary step while some code has not yet been updated. These tests demonstrate how the DCHECK in ~MojoWatcher is invalid and so it is removed. Bug: 699569 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: Ie7001384afcdc812218d840c8fd0057360868354 Reviewed-on: https://chromium-review.googlesource.com/560544 Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#485488} [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/device/geolocation/public/interfaces/BUILD.gn [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/cached-position-called-once.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/callback-exception-expected.txt [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/callback-exception.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/callback-to-deleted-context.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/callback-to-remote-context.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/callback-to-remote-context2.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/clear-watch-invalid-id-crash.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/coordinates-interface-attributes.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/delayed-permission-allowed-for-multiple-requests.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/delayed-permission-allowed.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/delayed-permission-denied-for-multiple-requests.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/delayed-permission-denied.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/disconnected-frame-already.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/disconnected-frame-permission-denied.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/disconnected-frame.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/error-clear-watch.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/error-service-connection-error.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/error.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/maximum-age.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/multiple-requests.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/notimer-after-unload.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/permission-denied-already-clear-watch.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/permission-denied-already-error.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/permission-denied-already-success.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/permission-denied-stops-watches.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/permission-denied.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/permission-service-connection-error.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/position-string.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/reentrant-error.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/reentrant-permission-denied.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/reentrant-success.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/remove-remote-context-in-error-callback-crash.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/resources/callback-to-remote-context-inner.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/resources/geolocation-mock.js [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/resources/remove-remote-context-in-error-callback-crash-inner.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/resources/window-close-popup.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/success-clear-watch.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/success.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/timeout-clear-watch.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/timeout-negative.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/timeout-over-max-of-unsigned.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/timeout-zero.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/timeout.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/timestamp.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/watch.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/watchPosition-page-visibility.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/watchPosition-unique.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/geolocation-api/window-close-crash.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/resources/geolocation.html [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/apache_http.py [modify] https://crrev.com/be310ab1cf337ebb1ad74ab3f4a1c2637cb33c57/third_party/WebKit/public/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a commit 3b3cf0c8188d7cf51e439d696755e4a43fd21b3a Author: Alok Priyadarshi <alokp@chromium.org> Date: Thu Jul 13 02:38:53 2017 Reland of "Moves mojo_js_integration_tests into blink." This reverts commit aa273aed7238cabd05b59be36b5eee9ce62f000c. Reason for revert: I have disabled the test on Android and filed crbug.com/741925 to track data dependency issue on Android test bots. TBR=jbroman,dpranke,yzshen Bug: 699569 Change-Id: Ic007cf56937c586b90fc3b68a76369cd489aff53 Reviewed-on: https://chromium-review.googlesource.com/568272 Reviewed-by: Alok Priyadarshi <alokp@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Yuzhu Shen <yzshen@chromium.org> Commit-Queue: Alok Priyadarshi <alokp@chromium.org> Cr-Commit-Position: refs/heads/master@{#486232} [modify] https://crrev.com/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a/mojo/edk/js/tests/BUILD.gn [delete] https://crrev.com/22ec9a55f303639c9e30487ec690d194a78e1582/mojo/edk/js/tests/js_to_cpp_tests.cc [modify] https://crrev.com/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a/testing/buildbot/chromium.linux.json [modify] https://crrev.com/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a/testing/buildbot/client.v8.chromium.json [modify] https://crrev.com/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a/third_party/WebKit/Source/core/BUILD.gn [modify] https://crrev.com/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a/third_party/WebKit/Source/core/mojo/BUILD.gn [rename] https://crrev.com/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a/third_party/WebKit/Source/core/mojo/tests/JsToCpp.mojom [add] https://crrev.com/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.cpp [rename] https://crrev.com/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a/third_party/WebKit/Source/core/mojo/tests/JsToCppTest.js [add] https://crrev.com/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a/third_party/WebKit/Source/core/mojo/tests/OWNERS [modify] https://crrev.com/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a/third_party/WebKit/Source/platform/testing/UnitTestHelpers.cpp [modify] https://crrev.com/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a/third_party/WebKit/Source/platform/testing/UnitTestHelpers.h [modify] https://crrev.com/3b3cf0c8188d7cf51e439d696755e4a43fd21b3a/tools/determinism/deterministic_build_whitelist.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2802973e5d90d2da902b44cf614bfe9f94bb6b0a commit 2802973e5d90d2da902b44cf614bfe9f94bb6b0a Author: Yuzhu Shen <yzshen@chromium.org> Date: Fri Jul 14 21:20:37 2017 Convert sensor layout tests to use the new mojo JS bindings. This change also exposes the SensorProvider interface from the frame. The frame then forwards the request to the device service. This is likely what we want in the long term to enforce permission check. And it also enables layout tests to intercept the interface. BUG=699569 Change-Id: Ic00466126aac982e57242829a103b0c10ba0f1ba Reviewed-on: https://chromium-review.googlesource.com/569641 Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#486890} [modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/content/browser/BUILD.gn [modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/content/public/app/mojo/content_renderer_manifest.json [modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/services/device/public/interfaces/BUILD.gn [modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/third_party/WebKit/LayoutTests/sensor/accelerometer.html [modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/third_party/WebKit/LayoutTests/sensor/ambient-light-sensor.html [modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/third_party/WebKit/LayoutTests/sensor/gyroscope.html [modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/third_party/WebKit/LayoutTests/sensor/magnetometer.html [modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/third_party/WebKit/LayoutTests/sensor/mock-sensor.html [modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/third_party/WebKit/LayoutTests/sensor/orientation-sensor.html [modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js [modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js [modify] https://crrev.com/2802973e5d90d2da902b44cf614bfe9f94bb6b0a/third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd commit cbdd3c86c21f676697e68fc6e54f17a66d52c1fd Author: Reilly Grant <reillyg@chromium.org> Date: Tue Jul 25 03:07:26 2017 Switch ImageCapture to the new Mojo JS bindings This change switches the ImageCapture Mojo interface to using the new Mojo JS bindings and rewrites the LayoutTests to use the new style. Bug: 699569 Change-Id: I40e0b376892c0308fa83ed26c53c67bfdcc77e9b Reviewed-on: https://chromium-review.googlesource.com/580673 Reviewed-by: Miguel Casas <mcasas@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#489202} [modify] https://crrev.com/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd/media/capture/mojo/BUILD.gn [modify] https://crrev.com/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd/third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-getSettings.html [modify] https://crrev.com/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd/third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-reject.html [modify] https://crrev.com/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd/third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints.html [modify] https://crrev.com/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd/third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-getCapabilities.html [modify] https://crrev.com/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd/third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-getSettings.html [modify] https://crrev.com/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd/third_party/WebKit/LayoutTests/imagecapture/getPhotoCapabilities.html [modify] https://crrev.com/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd/third_party/WebKit/LayoutTests/imagecapture/getPhotoSettings.html [modify] https://crrev.com/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd/third_party/WebKit/LayoutTests/imagecapture/resources/mock-imagecapture.js [modify] https://crrev.com/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd/third_party/WebKit/LayoutTests/imagecapture/setOptions-reject.html [modify] https://crrev.com/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd/third_party/WebKit/LayoutTests/imagecapture/setOptions.html [modify] https://crrev.com/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd/third_party/WebKit/LayoutTests/imagecapture/takePhoto-with-PhotoSettings.html [modify] https://crrev.com/cbdd3c86c21f676697e68fc6e54f17a66d52c1fd/third_party/WebKit/LayoutTests/imagecapture/takePhoto.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70ca2546ecb5718196a3f939442e4ef87a7c02f3 commit 70ca2546ecb5718196a3f939442e4ef87a7c02f3 Author: Reilly Grant <reillyg@chromium.org> Date: Wed Jul 26 20:52:46 2017 Fix and switch Vibration API to the new Mojo JS bindings This patch fixes bugs in the Vibration API LayoutTests and switches them to using the new Mojo JS bindings. Bug: 699569 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I3fb19ddc3bb2415dec0f2f047aba68d98cb1e4d5 Reviewed-on: https://chromium-review.googlesource.com/584022 Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#489751} [modify] https://crrev.com/70ca2546ecb5718196a3f939442e4ef87a7c02f3/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/70ca2546ecb5718196a3f939442e4ef87a7c02f3/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/70ca2546ecb5718196a3f939442e4ef87a7c02f3/content/public/app/mojo/content_renderer_manifest.json [modify] https://crrev.com/70ca2546ecb5718196a3f939442e4ef87a7c02f3/services/device/public/interfaces/BUILD.gn [modify] https://crrev.com/70ca2546ecb5718196a3f939442e4ef87a7c02f3/third_party/WebKit/LayoutTests/vibration/resources/vibrate-from-iframe.html [modify] https://crrev.com/70ca2546ecb5718196a3f939442e4ef87a7c02f3/third_party/WebKit/LayoutTests/vibration/resources/vibration-helpers.js [delete] https://crrev.com/096f91f3c998aac2e1e4efcb24eb279b18e54829/third_party/WebKit/LayoutTests/vibration/vibration-expected.txt [delete] https://crrev.com/096f91f3c998aac2e1e4efcb24eb279b18e54829/third_party/WebKit/LayoutTests/vibration/vibration-iframe-expected.txt [modify] https://crrev.com/70ca2546ecb5718196a3f939442e4ef87a7c02f3/third_party/WebKit/LayoutTests/vibration/vibration-iframe.html [modify] https://crrev.com/70ca2546ecb5718196a3f939442e4ef87a7c02f3/third_party/WebKit/LayoutTests/vibration/vibration.html [modify] https://crrev.com/70ca2546ecb5718196a3f939442e4ef87a7c02f3/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp [modify] https://crrev.com/70ca2546ecb5718196a3f939442e4ef87a7c02f3/third_party/WebKit/Source/modules/vibration/NavigatorVibration.h [modify] https://crrev.com/70ca2546ecb5718196a3f939442e4ef87a7c02f3/third_party/WebKit/Source/modules/vibration/VibrationController.cpp [modify] https://crrev.com/70ca2546ecb5718196a3f939442e4ef87a7c02f3/third_party/WebKit/Source/modules/vibration/VibrationController.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8fc64da8db4f9f2260b45897386da5754657e28 commit d8fc64da8db4f9f2260b45897386da5754657e28 Author: Reilly Grant <reillyg@chromium.org> Date: Thu Jul 27 00:14:14 2017 Switch the NFC LayoutTests to the new Mojo JS bindings This change updates the NFC LayoutTests to use the new style of Mojo JS bindings. Bug: 699569 Change-Id: If0cf63de62d7ff35e0163b6025d8d9b834526105 Reviewed-on: https://chromium-review.googlesource.com/584853 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#489809} [modify] https://crrev.com/d8fc64da8db4f9f2260b45897386da5754657e28/third_party/WebKit/LayoutTests/nfc/mock-nfc.html [modify] https://crrev.com/d8fc64da8db4f9f2260b45897386da5754657e28/third_party/WebKit/LayoutTests/nfc/nfc-block-iframe.html [modify] https://crrev.com/d8fc64da8db4f9f2260b45897386da5754657e28/third_party/WebKit/LayoutTests/nfc/push.html [modify] https://crrev.com/d8fc64da8db4f9f2260b45897386da5754657e28/third_party/WebKit/LayoutTests/nfc/resources/nfc-helpers.js [modify] https://crrev.com/d8fc64da8db4f9f2260b45897386da5754657e28/third_party/WebKit/LayoutTests/nfc/watch.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/451e2b33beb1d1d395c1adf95a87074b5b5202e1 commit 451e2b33beb1d1d395c1adf95a87074b5b5202e1 Author: Yuzhu Shen <yzshen@chromium.org> Date: Sat Jul 29 06:56:07 2017 Mojo JS bindings: switch web_ui_test_mojo_bindings to use new mode. BUG=699569 Change-Id: I98a9f7053742f29473f25ad97b70d519ce337b30 Reviewed-on: https://chromium-review.googlesource.com/592276 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#490639} [modify] https://crrev.com/451e2b33beb1d1d395c1adf95a87074b5b5202e1/content/browser/webui/web_ui_mojo_browsertest.cc [modify] https://crrev.com/451e2b33beb1d1d395c1adf95a87074b5b5202e1/content/test/BUILD.gn [modify] https://crrev.com/451e2b33beb1d1d395c1adf95a87074b5b5202e1/content/test/data/web_ui_mojo.html [modify] https://crrev.com/451e2b33beb1d1d395c1adf95a87074b5b5202e1/content/test/data/web_ui_mojo.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92466de58f6060945cea3c8cef01302c5e4eec3c commit 92466de58f6060945cea3c8cef01302c5e4eec3c Author: Yuzhu Shen <yzshen@chromium.org> Date: Tue Aug 01 17:51:07 2017 Mojo JS bindings: switch site_engagement_details.mojom to use the new mode. BUG=699569 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib314a69a4717fe1a932ece2f0025ec20c8c64f26 Reviewed-on: https://chromium-review.googlesource.com/592607 Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#491047} [modify] https://crrev.com/92466de58f6060945cea3c8cef01302c5e4eec3c/chrome/browser/browser_resources.grd [modify] https://crrev.com/92466de58f6060945cea3c8cef01302c5e4eec3c/chrome/browser/engagement/BUILD.gn [modify] https://crrev.com/92466de58f6060945cea3c8cef01302c5e4eec3c/chrome/browser/resources/engagement/site_engagement.html [modify] https://crrev.com/92466de58f6060945cea3c8cef01302c5e4eec3c/chrome/browser/resources/engagement/site_engagement.js [modify] https://crrev.com/92466de58f6060945cea3c8cef01302c5e4eec3c/chrome/browser/ui/webui/engagement/site_engagement_ui.cc [modify] https://crrev.com/92466de58f6060945cea3c8cef01302c5e4eec3c/chrome/test/data/webui/engagement/site_engagement_browsertest.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6382f72d093d987ead9bf13a7a4ec1d9348e09ac commit 6382f72d093d987ead9bf13a7a4ec1d9348e09ac Author: Reilly Grant <reillyg@chromium.org> Date: Tue Aug 01 19:06:59 2017 Switch Budget API LayoutTests to the new Mojo JS bindings This change rewrites the Budget API layout tests to use the new Mojo JS bindings. Bug: 699569 Change-Id: I4af6e3a78c16cf4ecc6aeedc5317eaf1021ca9eb Reviewed-on: https://chromium-review.googlesource.com/595234 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#491073} [modify] https://crrev.com/6382f72d093d987ead9bf13a7a4ec1d9348e09ac/third_party/WebKit/LayoutTests/http/tests/budget/budget-service-mock.js [delete] https://crrev.com/81112286430d0e761cc00915e6186330d5cf4155/third_party/WebKit/LayoutTests/http/tests/budget/get-budget-expected.txt [modify] https://crrev.com/6382f72d093d987ead9bf13a7a4ec1d9348e09ac/third_party/WebKit/LayoutTests/http/tests/budget/get-budget-in-service-worker.html [modify] https://crrev.com/6382f72d093d987ead9bf13a7a4ec1d9348e09ac/third_party/WebKit/LayoutTests/http/tests/budget/get-budget.html [modify] https://crrev.com/6382f72d093d987ead9bf13a7a4ec1d9348e09ac/third_party/WebKit/LayoutTests/http/tests/budget/get-cost-fails-in-service-worker.html [modify] https://crrev.com/6382f72d093d987ead9bf13a7a4ec1d9348e09ac/third_party/WebKit/LayoutTests/http/tests/budget/get-cost-in-service-worker.html [modify] https://crrev.com/6382f72d093d987ead9bf13a7a4ec1d9348e09ac/third_party/WebKit/LayoutTests/http/tests/budget/get-cost.html [modify] https://crrev.com/6382f72d093d987ead9bf13a7a4ec1d9348e09ac/third_party/WebKit/LayoutTests/http/tests/budget/reserve-in-service-worker.html [modify] https://crrev.com/6382f72d093d987ead9bf13a7a4ec1d9348e09ac/third_party/WebKit/LayoutTests/http/tests/budget/reserve.html [modify] https://crrev.com/6382f72d093d987ead9bf13a7a4ec1d9348e09ac/third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5bb5a2b5fabce64044a786d4bfaef26770c6523 commit b5bb5a2b5fabce64044a786d4bfaef26770c6523 Author: Reilly Grant <reillyg@chromium.org> Date: Tue Aug 01 19:28:03 2017 Switch WebShare LayoutTests to the new Mojo JS bindings This change rewrites the WebShare API layout tests to use the new Mojo JS bindings. Bug: 699569 Change-Id: Id95a016765c5b101ee347f760e7cec8b74ec4b7e Reviewed-on: https://chromium-review.googlesource.com/587412 Reviewed-by: Yuzhu Shen <yzshen@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491079} [modify] https://crrev.com/b5bb5a2b5fabce64044a786d4bfaef26770c6523/third_party/WebKit/LayoutTests/webshare/resources/mock-share-service.js [modify] https://crrev.com/b5bb5a2b5fabce64044a786d4bfaef26770c6523/third_party/WebKit/LayoutTests/webshare/share-arity.html [modify] https://crrev.com/b5bb5a2b5fabce64044a786d4bfaef26770c6523/third_party/WebKit/LayoutTests/webshare/share-error.html [modify] https://crrev.com/b5bb5a2b5fabce64044a786d4bfaef26770c6523/third_party/WebKit/LayoutTests/webshare/share-nonutf8-encoding.html [modify] https://crrev.com/b5bb5a2b5fabce64044a786d4bfaef26770c6523/third_party/WebKit/LayoutTests/webshare/share-success.html [modify] https://crrev.com/b5bb5a2b5fabce64044a786d4bfaef26770c6523/third_party/WebKit/LayoutTests/webshare/share-types.html [modify] https://crrev.com/b5bb5a2b5fabce64044a786d4bfaef26770c6523/third_party/WebKit/LayoutTests/webshare/share-url-relative.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e36efa6b8d50503c355010612dab64fe421cbc35 commit e36efa6b8d50503c355010612dab64fe421cbc35 Author: Reilly Grant <reillyg@chromium.org> Date: Tue Aug 01 19:28:11 2017 Switch Payments LayoutTest to the new Mojo JS bindings This change rewrites the single Payments API layout test that uses Mojo mock services to use the new Mojo JS bindings. Bug: 699569 Change-Id: I6fa74bfb2e926d35ccf3232c87f7a0114592ce9a Reviewed-on: https://chromium-review.googlesource.com/595246 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#491080} [modify] https://crrev.com/e36efa6b8d50503c355010612dab64fe421cbc35/third_party/WebKit/LayoutTests/payments/promises-keep-request-alive.html [modify] https://crrev.com/e36efa6b8d50503c355010612dab64fe421cbc35/third_party/WebKit/LayoutTests/payments/resources/payment-request-mock.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3ccb44f7248444c819e4c196c078ee5e167d610 commit e3ccb44f7248444c819e4c196c078ee5e167d610 Author: Yuzhu Shen <yzshen@chromium.org> Date: Wed Aug 02 21:13:19 2017 Mojo JS bindings: no need to generate the service_manager JS bindings. BUG=699569 Change-Id: I0697f40e286a3ea7fbcccff3c02a605abc7bd8c5 Reviewed-on: https://chromium-review.googlesource.com/592280 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#491500} [modify] https://crrev.com/e3ccb44f7248444c819e4c196c078ee5e167d610/BUILD.gn [modify] https://crrev.com/e3ccb44f7248444c819e4c196c078ee5e167d610/services/service_manager/public/interfaces/BUILD.gn [modify] https://crrev.com/e3ccb44f7248444c819e4c196c078ee5e167d610/third_party/WebKit/LayoutTests/harness-tests/mojo-helpers.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06367ab9d05ee9dabf40fa0b959b87c5cfb68c3e commit 06367ab9d05ee9dabf40fa0b959b87c5cfb68c3e Author: Reilly Grant <reillyg@chromium.org> Date: Sat Sep 02 02:00:16 2017 Switch Presentation API LayoutTests to the new Mojo JS bindings This change rewrites the Presentation API layout tests to use the new Mojo JS bindings. Note, these tests are flaky as reported in issue 761561. This change does not make the situation any better or worse. Bug: 699569 Change-Id: I722fdff615f894167950fa78b0034fc7cc9438b8 Reviewed-on: https://chromium-review.googlesource.com/597309 Reviewed-by: Yuzhu Shen <yzshen@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#499372} [modify] https://crrev.com/06367ab9d05ee9dabf40fa0b959b87c5cfb68c3e/third_party/WebKit/LayoutTests/presentation/presentation-controller-close-connection.html [modify] https://crrev.com/06367ab9d05ee9dabf40fa0b959b87c5cfb68c3e/third_party/WebKit/LayoutTests/presentation/presentation-controller-connection-closed-by-receiver.html [modify] https://crrev.com/06367ab9d05ee9dabf40fa0b959b87c5cfb68c3e/third_party/WebKit/LayoutTests/presentation/presentation-controller-terminate-connection.html [modify] https://crrev.com/06367ab9d05ee9dabf40fa0b959b87c5cfb68c3e/third_party/WebKit/LayoutTests/presentation/presentation-onreceiverconnection.html [modify] https://crrev.com/06367ab9d05ee9dabf40fa0b959b87c5cfb68c3e/third_party/WebKit/LayoutTests/presentation/presentation-receiver-terminate-connection.html [modify] https://crrev.com/06367ab9d05ee9dabf40fa0b959b87c5cfb68c3e/third_party/WebKit/LayoutTests/presentation/presentation-reconnect.html [modify] https://crrev.com/06367ab9d05ee9dabf40fa0b959b87c5cfb68c3e/third_party/WebKit/LayoutTests/presentation/presentation-start-error.html [modify] https://crrev.com/06367ab9d05ee9dabf40fa0b959b87c5cfb68c3e/third_party/WebKit/LayoutTests/presentation/presentation-start.html [modify] https://crrev.com/06367ab9d05ee9dabf40fa0b959b87c5cfb68c3e/third_party/WebKit/LayoutTests/presentation/presentationconnectionavailableevent-ctor-mock.html [modify] https://crrev.com/06367ab9d05ee9dabf40fa0b959b87c5cfb68c3e/third_party/WebKit/LayoutTests/presentation/presentationrequest.html [modify] https://crrev.com/06367ab9d05ee9dabf40fa0b959b87c5cfb68c3e/third_party/WebKit/LayoutTests/presentation/resources/presentation-receiver-close-connection.html [modify] https://crrev.com/06367ab9d05ee9dabf40fa0b959b87c5cfb68c3e/third_party/WebKit/LayoutTests/presentation/resources/presentation-receiver-postmessage.html [modify] https://crrev.com/06367ab9d05ee9dabf40fa0b959b87c5cfb68c3e/third_party/WebKit/LayoutTests/presentation/resources/presentation-service-mock.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09cdb4dda4c863fc8c8d7aebb020bd75b77d9105 commit 09cdb4dda4c863fc8c8d7aebb020bd75b77d9105 Author: Reilly Grant <reillyg@chromium.org> Date: Tue Sep 05 20:27:19 2017 Switch the installedapp API to the new Mojo JS bindings This change updates the installedapp API LayoutTests to use the new Mojo JS bindings. Bug: 699569 Change-Id: I5674be4eef9ce4977bf08bf1c2e21444fa8b18cd Reviewed-on: https://chromium-review.googlesource.com/647657 Reviewed-by: Yuzhu Shen <yzshen@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#499733} [modify] https://crrev.com/09cdb4dda4c863fc8c8d7aebb020bd75b77d9105/third_party/WebKit/LayoutTests/installedapp/getinstalledrelatedapps-empty.html [modify] https://crrev.com/09cdb4dda4c863fc8c8d7aebb020bd75b77d9105/third_party/WebKit/LayoutTests/installedapp/getinstalledrelatedapps.html [modify] https://crrev.com/09cdb4dda4c863fc8c8d7aebb020bd75b77d9105/third_party/WebKit/LayoutTests/installedapp/resources/installedapp-test-helper.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d20757302db1868ff48484bfaec61dfbe038f06 commit 6d20757302db1868ff48484bfaec61dfbe038f06 Author: Reilly Grant <reillyg@chromium.org> Date: Wed Sep 06 23:55:47 2017 Switch the battery status API to the new Mojo JS bindings This change updates the battery status API LayoutTests to use the new Mojo JS bindings. Bug: 699569 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: Ic1a3f249b44a5810eb838eea96cb986c8a9a1c3a Reviewed-on: https://chromium-review.googlesource.com/579791 Reviewed-by: Tim Volodine <timvolodine@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#500144} [modify] https://crrev.com/6d20757302db1868ff48484bfaec61dfbe038f06/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/6d20757302db1868ff48484bfaec61dfbe038f06/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/6d20757302db1868ff48484bfaec61dfbe038f06/content/public/app/mojo/content_renderer_manifest.json [modify] https://crrev.com/6d20757302db1868ff48484bfaec61dfbe038f06/services/device/public/interfaces/BUILD.gn [modify] https://crrev.com/6d20757302db1868ff48484bfaec61dfbe038f06/third_party/WebKit/LayoutTests/battery-status/api-defined.html [modify] https://crrev.com/6d20757302db1868ff48484bfaec61dfbe038f06/third_party/WebKit/LayoutTests/battery-status/multiple-promises-after-resolve.html [modify] https://crrev.com/6d20757302db1868ff48484bfaec61dfbe038f06/third_party/WebKit/LayoutTests/battery-status/multiple-promises.html [modify] https://crrev.com/6d20757302db1868ff48484bfaec61dfbe038f06/third_party/WebKit/LayoutTests/battery-status/multiple-windows-page-visibility.html [modify] https://crrev.com/6d20757302db1868ff48484bfaec61dfbe038f06/third_party/WebKit/LayoutTests/battery-status/multiple-windows.html [modify] https://crrev.com/6d20757302db1868ff48484bfaec61dfbe038f06/third_party/WebKit/LayoutTests/battery-status/no-gc-with-eventlisteners.html [modify] https://crrev.com/6d20757302db1868ff48484bfaec61dfbe038f06/third_party/WebKit/LayoutTests/battery-status/page-visibility.html [modify] https://crrev.com/6d20757302db1868ff48484bfaec61dfbe038f06/third_party/WebKit/LayoutTests/battery-status/promise-with-eventlisteners.html [modify] https://crrev.com/6d20757302db1868ff48484bfaec61dfbe038f06/third_party/WebKit/LayoutTests/battery-status/resources/mock-battery-monitor.js [modify] https://crrev.com/6d20757302db1868ff48484bfaec61dfbe038f06/third_party/WebKit/LayoutTests/battery-status/restricted-level-precision.html [modify] https://crrev.com/6d20757302db1868ff48484bfaec61dfbe038f06/third_party/WebKit/Source/modules/battery/BatteryDispatcher.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/806876d408e0bd2d1b13465b27b4944a41521e93 commit 806876d408e0bd2d1b13465b27b4944a41521e93 Author: Conley Owens <cco3@chromium.org> Date: Tue Oct 03 18:05:59 2017 bluetooth: Use a new promise_test wrapper This change wraps `promise_test` in a new function called `bluetooth_test`. This function automatically imports chromium-specific libraries. This will facilitate our transition to the new mojo bindings as well as our migration to wpt/. BUG=509038,699569 Change-Id: I64f3d11678c44cb74f313428f335459aaeb5f19e Reviewed-on: https://chromium-review.googlesource.com/688109 Commit-Queue: Conley Owens <cco3@chromium.org> Reviewed-by: Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#506102} [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/characteristicProperties.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-characteristic-is-removed.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-blocklisted.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-device-disconnects-before.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-device-disconnects-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-device-disconnects-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-disconnect-called-before.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-disconnect-called-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-disconnect-called-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-garbage-collection-ran-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-garbage-collection-ran-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-get-same-object.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-invalid-name.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-device-out-of-range.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-service-is-removed.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-characteristic-is-removed-with-uuid.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-characteristic-is-removed.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-blocklisted.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-device-disconnects-before-with-uuid.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-device-disconnects-before.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-device-disconnects-during-error-with-uuid.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-device-disconnects-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-device-disconnects-during-success-with-uuid.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-device-disconnects-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-disconnect-called-before-with-uuid.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-disconnect-called-before.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-disconnect-called-during-error-with-uuid.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-disconnect-called-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-disconnect-called-during-success-with-uuid.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-disconnect-called-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-garbage-collection-ran-during-error-with-uuid.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-garbage-collection-ran-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-garbage-collection-ran-during-success-with-uuid.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-garbage-collection-ran-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-get-same-object.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-descriptor-invalid-name.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-device-out-of-range-with-uuid.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-device-out-of-range.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-service-is-removed-with-uuid.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/gen-service-is-removed.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/gen-characteristic-is-removed.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/gen-gatt-op-device-disconnects-before.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/gen-gatt-op-device-disconnects-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/gen-gatt-op-device-disconnects-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/gen-gatt-op-device-reconnects-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/gen-gatt-op-device-reconnects-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/gen-gatt-op-disconnect-called-before.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/gen-gatt-op-disconnect-called-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/gen-gatt-op-disconnect-called-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/gen-gatt-op-garbage-collection-ran-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/gen-gatt-op-garbage-collection-ran-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/gen-gatt-op-reconnect-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/gen-gatt-op-reconnect-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/service-same-from-2-characteristics.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/service-same-object.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/startNotifications/gen-characteristic-is-removed.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/startNotifications/gen-gatt-op-device-disconnects-before.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/startNotifications/gen-gatt-op-device-disconnects-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/startNotifications/gen-gatt-op-device-disconnects-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/startNotifications/gen-gatt-op-device-reconnects-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/startNotifications/gen-gatt-op-device-reconnects-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/startNotifications/gen-gatt-op-disconnect-called-before.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/startNotifications/gen-gatt-op-disconnect-called-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/startNotifications/gen-gatt-op-disconnect-called-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/startNotifications/gen-gatt-op-garbage-collection-ran-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/startNotifications/gen-gatt-op-garbage-collection-ran-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/startNotifications/gen-gatt-op-reconnect-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/startNotifications/gen-gatt-op-reconnect-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/stopNotifications/gen-gatt-op-device-disconnects-before.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/stopNotifications/gen-gatt-op-device-disconnects-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/stopNotifications/gen-gatt-op-disconnect-called-before.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/stopNotifications/gen-gatt-op-disconnect-called-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/stopNotifications/gen-gatt-op-garbage-collection-ran-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/gen-characteristic-is-removed.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/gen-gatt-op-device-disconnects-before.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/gen-gatt-op-device-disconnects-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/gen-gatt-op-device-disconnects-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/gen-gatt-op-device-reconnects-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/gen-gatt-op-device-reconnects-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/gen-gatt-op-disconnect-called-before.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/gen-gatt-op-disconnect-called-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/gen-gatt-op-disconnect-called-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/gen-gatt-op-garbage-collection-ran-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/gen-gatt-op-garbage-collection-ran-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/gen-gatt-op-reconnect-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/gen-gatt-op-reconnect-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/characteristic-same-from-2-descriptors.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/characteristic-same-object.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-descriptor-is-removed.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-device-goes-out-of-range.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-device-disconnects-before.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-device-disconnects-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-device-disconnects-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-device-reconnects-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-device-reconnects-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-disconnect-called-before.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-disconnect-called-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-disconnect-called-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-fails.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-garbage-collection-ran-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-garbage-collection-ran-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-reconnect-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-io-op-reconnect-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/gen-service-is-removed.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-descriptor-is-removed.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-device-disconnects-before.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-device-disconnects-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-device-disconnects-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-device-reconnects-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-device-reconnects-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-disconnect-called-before.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-disconnect-called-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-disconnect-called-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-fails.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-garbage-collection-ran-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-garbage-collection-ran-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-reconnect-during-error.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-io-op-reconnect-during-success.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/gen-service-is-removed.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/idl/idl-BluetoothDevice.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/requestDevice/blocklisted-service-in-filter.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/requestDevice/blocklisted-service-in-optionalServices.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/requestDevice/consumes-user-gesture.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/requestDevice/correct-filters.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/requestDevice/discovery-fails-to-start.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/requestDevice/discovery-succeeds.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/requestDevice/filter-does-not-match.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/requestDevice/filter-matches.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/requestDevice/le-not-supported.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/requestDevice/name-empty-device-from-name-empty-filter.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/requestDevice/name-empty-device-from-name-prefix-filter.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/requestDevice/name-empty-device-from-name-wrong-filter.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/bluetooth/requestDevice/name-empty-device-from-service-filter.html [modify] https://crrev.com/806876d408e0bd2d1b13465b27b4944a41521e93/third_party/WebKit/LayoutTests/blue
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d commit 6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d Author: Conley Owens <cco3@chromium.org> Date: Fri Oct 06 23:09:16 2017 bluetooth: Use new mojo bindings in LayoutTests This change updates our mojo bindings in javascript to use the new `mojo_bindings.js` library. This is important for our migration to Web Platform Tests, because we don't intend to use `mojo-helpers.js` in wpt/. BUG=509038,699569 Change-Id: I1309f57a9811802d36649daca4c780e21c3d0d0d Reviewed-on: https://chromium-review.googlesource.com/690603 Commit-Queue: Conley Owens <cco3@chromium.org> Reviewed-by: Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#507216} [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/device/bluetooth/public/interfaces/BUILD.gn [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/descriptor-not-found.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/blocklisted-descriptors-not-present.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/add-listener-after-promise.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/add-multiple-event-listeners.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/characteristic-does-not-support-notifications.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/characteristic-is-removed.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/concurrent-starts-and-receive-notification.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/concurrent-starts.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/concurrent-stops.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/device-goes-out-of-range.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/event-after-starting.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/gc-with-pending-start.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/gc-with-pending-stop.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/notification-after-disconnection.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/parallel-start-stop.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/service-is-removed.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/start-before-stop-resolves.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/start-fails.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/start-stop-start-stop.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/start-succeeds.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/start-twice-in-a-row.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/stop-after-start-succeeds.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/stop-twice.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/stop-without-starting.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/add-multiple-event-listeners.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/blocklisted-characteristic.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/characteristic-is-removed.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/device-goes-out-of-range.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/event-is-fired.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/read-fails.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/read-succeeds.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/read-updates-value.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/service-is-removed.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/stopNotifications/device-reconnects-during-success.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/stopNotifications/reconnect-during-success.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/blocklisted-characteristic.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/characteristic-is-removed.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/device-goes-out-of-range.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/service-is-removed.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/value-too-long.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/write-fails.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/write-succeeds.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/write-updates-value.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/descriptor-is-blocklisted.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/read-succeeds.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/read-updates-value.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/descriptor-is-blocklisted.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/value-too-long.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/write-succeeds.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/write-updates-value.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/device/gattserverdisconnected-event/disconnected.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/device/gattserverdisconnected-event/disconnected_gc.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/device/gattserverdisconnected-event/one-event-per-disconnection.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/device/gattserverdisconnected-event/reconnect-during-disconnected-event.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/acceptAllDevices/device-with-empty-name.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/acceptAllDevices/device-with-name.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/acceptAllDevices/device-with-no-name.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/acceptAllDevices/device-with-uuids.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/acceptAllDevices/optional-services-missing.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/acceptAllDevices/optional-services-present.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/device-name-longer-than-29-bytes.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/empty-filter.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/empty-filters-member.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/empty-namePrefix.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/empty-services-member.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/filters-xor-acceptAllDevices.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-exceeded-name-unicode.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-exceeded-name.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-exceeded-namePrefix-unicode.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-exceeded-namePrefix.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-name-unicode.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-name.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-namePrefix-unicode.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-namePrefix.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/no-arguments.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-valid-length-name-name.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-valid-length-name-namePrefix.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/wrong-service-in-optionalServices-member.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/wrong-service-in-services-member.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/consecutive-calls.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/device-removed.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/multiple-matching-devices.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-all-types.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-connected-devices.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-device-added.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-device-changed.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-services-discovered.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/restart-scan-finds-new-device.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/restart-scan-includes-previous-device.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/server/connect/connect-disconnected-connect.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/server/connect/connect-twice.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/server/connect/connection-fails.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/server/connect/device-goes-out-of-range.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/server/connect/garbage-collection-ran-during-error.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/server/connect/garbage-collection-ran-during-success.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/server/connect/get-same-gatt-server.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/server/connect/same-gatt-server-both-receive-disconnect-event.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/server/disconnect/connect-disconnect-twice.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/server/disconnect/disconnect-after-request-disconnection.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/server/disconnect/disconnect-fires-event.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/server/disconnect/disconnect-once.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/server/disconnect/disconnect-twice-in-a-row.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/service-found.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/two-iframes-from-same-origin.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/blocklisted-services-with-uuid.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/blocklisted-services.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/correct-services.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/delayed-discovery-no-permission-present-service.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/delayed-discovery-service-not-found.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/no-permission-present-service.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/services-found-with-uuid.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/services-found.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/services-not-found.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/characteristic-found.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/blocklisted-characteristics.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/characteristics-found-with-uuid.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/characteristics-found.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/characteristics-not-found.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/correct-characteristics.html [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js [modify] https://crrev.com/6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d/third_party/WebKit/LayoutTests/resources/bluetooth/web-bluetooth-test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8 commit dd03c6e284c83b30f356a9c5df4cc9b3196afaf8 Author: Henrik Grunell <grunell@chromium.org> Date: Mon Oct 09 14:39:36 2017 Revert "bluetooth: Use new mojo bindings in LayoutTests" This reverts commit 6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d. Reason for revert: suspected to break bluetooth/requestDevice/canonicalizeFilter/no-arguments.html on Android, see https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29?numbuilds=200 Original change's description: > bluetooth: Use new mojo bindings in LayoutTests > > This change updates our mojo bindings in javascript to use the new > `mojo_bindings.js` library. This is important for our migration to Web > Platform Tests, because we don't intend to use `mojo-helpers.js` in > wpt/. > > BUG=509038,699569 > > Change-Id: I1309f57a9811802d36649daca4c780e21c3d0d0d > Reviewed-on: https://chromium-review.googlesource.com/690603 > Commit-Queue: Conley Owens <cco3@chromium.org> > Reviewed-by: Vincent Scheib <scheib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#507216} TBR=dcheng@chromium.org,scheib@chromium.org,cco3@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 509038, 699569 Change-Id: I4ff5a248d1b59c320d01c9a082b226a702dd8ae5 Reviewed-on: https://chromium-review.googlesource.com/707114 Reviewed-by: Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#507373} [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/device/bluetooth/public/interfaces/BUILD.gn [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/descriptor-not-found.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/blocklisted-descriptors-not-present.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/add-listener-after-promise.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/add-multiple-event-listeners.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/characteristic-does-not-support-notifications.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/characteristic-is-removed.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/concurrent-starts-and-receive-notification.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/concurrent-starts.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/concurrent-stops.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/device-goes-out-of-range.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/event-after-starting.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/gc-with-pending-start.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/gc-with-pending-stop.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/notification-after-disconnection.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/parallel-start-stop.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/service-is-removed.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/start-before-stop-resolves.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/start-fails.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/start-stop-start-stop.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/start-succeeds.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/start-twice-in-a-row.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/stop-after-start-succeeds.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/stop-twice.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/stop-without-starting.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/add-multiple-event-listeners.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/blocklisted-characteristic.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/characteristic-is-removed.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/device-goes-out-of-range.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/event-is-fired.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/read-fails.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/read-succeeds.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/read-updates-value.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/service-is-removed.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/stopNotifications/device-reconnects-during-success.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/stopNotifications/reconnect-during-success.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/blocklisted-characteristic.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/characteristic-is-removed.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/device-goes-out-of-range.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/service-is-removed.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/value-too-long.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/write-fails.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/write-succeeds.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/write-updates-value.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/descriptor-is-blocklisted.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/read-succeeds.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/read-updates-value.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/descriptor-is-blocklisted.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/value-too-long.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/write-succeeds.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/write-updates-value.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/device/gattserverdisconnected-event/disconnected.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/device/gattserverdisconnected-event/disconnected_gc.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/device/gattserverdisconnected-event/one-event-per-disconnection.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/device/gattserverdisconnected-event/reconnect-during-disconnected-event.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/acceptAllDevices/device-with-empty-name.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/acceptAllDevices/device-with-name.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/acceptAllDevices/device-with-no-name.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/acceptAllDevices/device-with-uuids.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/acceptAllDevices/optional-services-missing.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/acceptAllDevices/optional-services-present.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/device-name-longer-than-29-bytes.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/empty-filter.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/empty-filters-member.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/empty-namePrefix.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/empty-services-member.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/filters-xor-acceptAllDevices.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-exceeded-name-unicode.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-exceeded-name.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-exceeded-namePrefix-unicode.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-exceeded-namePrefix.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-name-unicode.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-name.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-namePrefix-unicode.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-namePrefix.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/no-arguments.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-valid-length-name-name.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-valid-length-name-namePrefix.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/wrong-service-in-optionalServices-member.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/wrong-service-in-services-member.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/consecutive-calls.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/device-removed.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/multiple-matching-devices.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-all-types.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-connected-devices.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-device-added.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-device-changed.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-services-discovered.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/restart-scan-finds-new-device.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/restart-scan-includes-previous-device.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/server/connect/connect-disconnected-connect.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/server/connect/connect-twice.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/server/connect/connection-fails.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/server/connect/device-goes-out-of-range.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/server/connect/garbage-collection-ran-during-error.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/server/connect/garbage-collection-ran-during-success.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/server/connect/get-same-gatt-server.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/server/connect/same-gatt-server-both-receive-disconnect-event.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/server/disconnect/connect-disconnect-twice.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/server/disconnect/disconnect-after-request-disconnection.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/server/disconnect/disconnect-fires-event.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/server/disconnect/disconnect-once.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/server/disconnect/disconnect-twice-in-a-row.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/service-found.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/two-iframes-from-same-origin.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/blocklisted-services-with-uuid.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/blocklisted-services.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/correct-services.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/delayed-discovery-no-permission-present-service.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/delayed-discovery-service-not-found.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/no-permission-present-service.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/services-found-with-uuid.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/services-found.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/services-not-found.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/characteristic-found.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/blocklisted-characteristics.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/characteristics-found-with-uuid.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/characteristics-found.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/characteristics-not-found.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/correct-characteristics.html [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js [modify] https://crrev.com/dd03c6e284c83b30f356a9c5df4cc9b3196afaf8/third_party/WebKit/LayoutTests/resources/bluetooth/web-bluetooth-test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6e985a89c7c5e64d70f1320a62c250c7841e1de commit c6e985a89c7c5e64d70f1320a62c250c7841e1de Author: Conley Owens <cco3@chromium.org> Date: Tue Oct 10 00:44:46 2017 Revert "Revert "bluetooth: Use new mojo bindings in LayoutTests"" This reverts commit dd03c6e284c83b30f356a9c5df4cc9b3196afaf8. Reason for revert: The original change caused one layout test to fail. This version does not update that test to use the new wrapper but leaves it the way it was originally. Original change's description: > Revert "bluetooth: Use new mojo bindings in LayoutTests" > > This reverts commit 6aad68efd7c4d64df7d7d85cea1f6c17fb42b46d. > > Reason for revert: suspected to break bluetooth/requestDevice/canonicalizeFilter/no-arguments.html on Android, see https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29?numbuilds=200 > > Original change's description: > > bluetooth: Use new mojo bindings in LayoutTests > > > > This change updates our mojo bindings in javascript to use the new > > `mojo_bindings.js` library. This is important for our migration to Web > > Platform Tests, because we don't intend to use `mojo-helpers.js` in > > wpt/. > > > > BUG=509038,699569 > > > > Change-Id: I1309f57a9811802d36649daca4c780e21c3d0d0d > > Reviewed-on: https://chromium-review.googlesource.com/690603 > > Commit-Queue: Conley Owens <cco3@chromium.org> > > Reviewed-by: Vincent Scheib <scheib@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#507216} > > TBR=dcheng@chromium.org,scheib@chromium.org,cco3@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 509038, 699569 > Change-Id: I4ff5a248d1b59c320d01c9a082b226a702dd8ae5 > Reviewed-on: https://chromium-review.googlesource.com/707114 > Reviewed-by: Henrik Grunell <grunell@chromium.org> > Commit-Queue: Henrik Grunell <grunell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#507373} TBR=dcheng@chromium.org,grunell@chromium.org,scheib@chromium.org,cco3@chromium.org Change-Id: I63f939070f8c3efeaa9d543ad3a19ff8000af90e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 509038, 699569 Reviewed-on: https://chromium-review.googlesource.com/706189 Commit-Queue: Conley Owens <cco3@chromium.org> Reviewed-by: Conley Owens <cco3@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#507553} [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/device/bluetooth/public/interfaces/BUILD.gn [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/descriptor-not-found.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptors/blocklisted-descriptors-not-present.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/add-listener-after-promise.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/add-multiple-event-listeners.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/characteristic-does-not-support-notifications.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/characteristic-is-removed.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/concurrent-starts-and-receive-notification.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/concurrent-starts.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/concurrent-stops.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/device-goes-out-of-range.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/event-after-starting.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/gc-with-pending-start.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/gc-with-pending-stop.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/notification-after-disconnection.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/parallel-start-stop.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/service-is-removed.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/start-before-stop-resolves.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/start-fails.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/start-stop-start-stop.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/start-succeeds.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/start-twice-in-a-row.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/stop-after-start-succeeds.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/stop-twice.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/stop-without-starting.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/add-multiple-event-listeners.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/blocklisted-characteristic.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/characteristic-is-removed.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/device-goes-out-of-range.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/event-is-fired.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/read-fails.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/read-succeeds.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/read-updates-value.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/service-is-removed.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/stopNotifications/device-reconnects-during-success.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/stopNotifications/reconnect-during-success.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/blocklisted-characteristic.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/characteristic-is-removed.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/device-goes-out-of-range.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/service-is-removed.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/value-too-long.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/write-fails.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/write-succeeds.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/write-updates-value.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/descriptor-is-blocklisted.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/read-succeeds.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/descriptor/readValue/read-updates-value.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/descriptor-is-blocklisted.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/value-too-long.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/write-succeeds.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/descriptor/writeValue/write-updates-value.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/device/gattserverdisconnected-event/disconnected.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/device/gattserverdisconnected-event/disconnected_gc.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/device/gattserverdisconnected-event/one-event-per-disconnection.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/device/gattserverdisconnected-event/reconnect-during-disconnected-event.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/acceptAllDevices/device-with-empty-name.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/acceptAllDevices/device-with-name.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/acceptAllDevices/device-with-no-name.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/acceptAllDevices/device-with-uuids.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/acceptAllDevices/optional-services-missing.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/acceptAllDevices/optional-services-present.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/device-name-longer-than-29-bytes.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/empty-filter.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/empty-filters-member.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/empty-namePrefix.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/empty-services-member.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/filters-xor-acceptAllDevices.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-exceeded-name-unicode.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-exceeded-name.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-exceeded-namePrefix-unicode.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-exceeded-namePrefix.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-name-unicode.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-name.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-namePrefix-unicode.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/max-length-namePrefix.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-valid-length-name-name.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-valid-length-name-namePrefix.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/wrong-service-in-optionalServices-member.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/wrong-service-in-services-member.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/consecutive-calls.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/device-removed.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/multiple-matching-devices.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-all-types.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-connected-devices.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-device-added.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-device-changed.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/new-scan-services-discovered.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/restart-scan-finds-new-device.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/requestDevice/chooser/restart-scan-includes-previous-device.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/server/connect/connect-disconnected-connect.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/server/connect/connect-twice.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/server/connect/connection-fails.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/server/connect/device-goes-out-of-range.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/server/connect/garbage-collection-ran-during-error.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/server/connect/garbage-collection-ran-during-success.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/server/connect/get-same-gatt-server.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/server/connect/same-gatt-server-both-receive-disconnect-event.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/server/disconnect/connect-disconnect-twice.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/server/disconnect/disconnect-after-request-disconnection.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/server/disconnect/disconnect-fires-event.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/server/disconnect/disconnect-once.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/server/disconnect/disconnect-twice-in-a-row.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/service-found.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/two-iframes-from-same-origin.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/blocklisted-services-with-uuid.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/blocklisted-services.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/correct-services.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/delayed-discovery-no-permission-present-service.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/delayed-discovery-service-not-found.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/no-permission-present-service.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/services-found-with-uuid.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/services-found.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/services-not-found.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/characteristic-found.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/blocklisted-characteristics.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/characteristics-found-with-uuid.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/characteristics-found.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/characteristics-not-found.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/correct-characteristics.html [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js [modify] https://crrev.com/c6e985a89c7c5e64d70f1320a62c250c7841e1de/third_party/WebKit/LayoutTests/resources/bluetooth/web-bluetooth-test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0ecfb585a0a049c71bb456927c8ef68a887f3a0 commit f0ecfb585a0a049c71bb456927c8ef68a887f3a0 Author: Reilly Grant <reillyg@chromium.org> Date: Tue Oct 10 18:16:06 2017 Disable old JS bindings for Blink Mojo interfaces All LayoutTests depending on the old bindings style should have been ported. The mojo-helpers.js script is now unused and is removed. Bug: 699569 Change-Id: I99d8579d83cb20e9558853cf0c41f85d774a16a7 Reviewed-on: https://chromium-review.googlesource.com/706538 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#507720} [delete] https://crrev.com/77b5c02595149a6301138eab2922f1cfa247e7cf/third_party/WebKit/LayoutTests/harness-tests/mojo-helpers.html [delete] https://crrev.com/77b5c02595149a6301138eab2922f1cfa247e7cf/third_party/WebKit/LayoutTests/harness-tests/resources/mojo-helpers-inner.html [delete] https://crrev.com/77b5c02595149a6301138eab2922f1cfa247e7cf/third_party/WebKit/LayoutTests/resources/mojo-helpers.js [modify] https://crrev.com/f0ecfb585a0a049c71bb456927c8ef68a887f3a0/third_party/WebKit/public/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d0ed665941395ce99f617628980665ffdcf35d8 commit 7d0ed665941395ce99f617628980665ffdcf35d8 Author: Reilly Grant <reillyg@chromium.org> Date: Thu Oct 12 10:13:12 2017 Port chrome://bluetooth-internals to the new Mojo JS bindings This change switches chrome://bluetooth-internals to the new Mojo JS bindings and updates the tests to match. This required updating the test runner so that MojoInterfaceInterceptor is available to WebUI in the same way that addInterfaceOverrideForTesting is for the old bindings. Bug: 699569 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifb020b12e53d24a6f06b5fce9f462b0fd463193c Reviewed-on: https://chromium-review.googlesource.com/710636 Reviewed-by: Yuzhu Shen <yzshen@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#508301} [modify] https://crrev.com/7d0ed665941395ce99f617628980665ffdcf35d8/chrome/browser/browser_resources.grd [modify] https://crrev.com/7d0ed665941395ce99f617628980665ffdcf35d8/chrome/browser/resources/bluetooth_internals/adapter_broker.js [modify] https://crrev.com/7d0ed665941395ce99f617628980665ffdcf35d8/chrome/browser/resources/bluetooth_internals/adapter_page.js [modify] https://crrev.com/7d0ed665941395ce99f617628980665ffdcf35d8/chrome/browser/resources/bluetooth_internals/bluetooth_internals.html [modify] https://crrev.com/7d0ed665941395ce99f617628980665ffdcf35d8/chrome/browser/resources/bluetooth_internals/bluetooth_internals.js [modify] https://crrev.com/7d0ed665941395ce99f617628980665ffdcf35d8/chrome/browser/resources/bluetooth_internals/characteristic_list.js [modify] https://crrev.com/7d0ed665941395ce99f617628980665ffdcf35d8/chrome/browser/resources/bluetooth_internals/descriptor_list.js [modify] https://crrev.com/7d0ed665941395ce99f617628980665ffdcf35d8/chrome/browser/resources/bluetooth_internals/device_broker.js [modify] https://crrev.com/7d0ed665941395ce99f617628980665ffdcf35d8/chrome/browser/resources/bluetooth_internals/device_collection.js [modify] https://crrev.com/7d0ed665941395ce99f617628980665ffdcf35d8/chrome/browser/resources/bluetooth_internals/device_details_page.js [modify] https://crrev.com/7d0ed665941395ce99f617628980665ffdcf35d8/chrome/browser/resources/bluetooth_internals/device_table.js [modify] https://crrev.com/7d0ed665941395ce99f617628980665ffdcf35d8/chrome/browser/resources/bluetooth_internals/devices_page.js [delete] https://crrev.com/a21c18d015a215df8e3f5e24386b9db06c3f1ed6/chrome/browser/resources/bluetooth_internals/interfaces.js [modify] https://crrev.com/7d0ed665941395ce99f617628980665ffdcf35d8/chrome/browser/resources/bluetooth_internals/service_list.js [modify] https://crrev.com/7d0ed665941395ce99f617628980665ffdcf35d8/chrome/browser/resources/bluetooth_internals/value_control.js [modify] https://crrev.com/7d0ed665941395ce99f617628980665ffdcf35d8/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc [modify] https://crrev.com/7d0ed665941395ce99f617628980665ffdcf35d8/chrome/test/data/webui/bluetooth_internals_browsertest.js [modify] https://crrev.com/7d0ed665941395ce99f617628980665ffdcf35d8/content/renderer/mojo_bindings_controller.cc [modify] https://crrev.com/7d0ed665941395ce99f617628980665ffdcf35d8/device/bluetooth/public/interfaces/BUILD.gn [modify] https://crrev.com/7d0ed665941395ce99f617628980665ffdcf35d8/mojo/public/js/new_bindings/connector.js [modify] https://crrev.com/7d0ed665941395ce99f617628980665ffdcf35d8/third_party/WebKit/Source/bindings/templates/ConditionalFeaturesForCore.cpp.tmpl [modify] https://crrev.com/7d0ed665941395ce99f617628980665ffdcf35d8/third_party/WebKit/Source/bindings/tests/results/core/ConditionalFeaturesForCore.cpp [modify] https://crrev.com/7d0ed665941395ce99f617628980665ffdcf35d8/third_party/WebKit/Source/core/context_features/ContextFeatureSettings.h [modify] https://crrev.com/7d0ed665941395ce99f617628980665ffdcf35d8/third_party/WebKit/Source/core/exported/WebContextFeatures.cpp [modify] https://crrev.com/7d0ed665941395ce99f617628980665ffdcf35d8/third_party/WebKit/Source/core/mojo/test/MojoInterfaceInterceptor.idl [modify] https://crrev.com/7d0ed665941395ce99f617628980665ffdcf35d8/third_party/WebKit/Source/core/mojo/test/MojoInterfaceRequestEvent.idl [modify] https://crrev.com/7d0ed665941395ce99f617628980665ffdcf35d8/third_party/WebKit/public/web/WebContextFeatures.h [modify] https://crrev.com/7d0ed665941395ce99f617628980665ffdcf35d8/ui/webui/resources/js/util.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f7b3ad2efec05959db1f056c016edd949e4e298 commit 4f7b3ad2efec05959db1f056c016edd949e4e298 Author: Reilly Grant <reillyg@chromium.org> Date: Wed Oct 18 22:53:30 2017 Remove old Mojo JS bindings support in LayoutTests and WebUI The old Mojo JS bindings are now only used in blessed extension contexts. All of the support for LayoutTests and WebUI can be removed. Logic to enable the new Mojo bindings in WebUI contexts is moved to RenderFrameImpl::DidCreateScriptContext. Bug: 699569 Change-Id: Ib0d9e43a6d73ada45a9286aa85e13d15bc421473 Reviewed-on: https://chromium-review.googlesource.com/706380 Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Nick Carter <nick@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#509907} [modify] https://crrev.com/4f7b3ad2efec05959db1f056c016edd949e4e298/content/BUILD.gn [modify] https://crrev.com/4f7b3ad2efec05959db1f056c016edd949e4e298/content/content_resources.grd [modify] https://crrev.com/4f7b3ad2efec05959db1f056c016edd949e4e298/content/public/common/bindings_policy.h [modify] https://crrev.com/4f7b3ad2efec05959db1f056c016edd949e4e298/content/renderer/BUILD.gn [modify] https://crrev.com/4f7b3ad2efec05959db1f056c016edd949e4e298/content/renderer/mojo/blink_connector_js_wrapper.cc [modify] https://crrev.com/4f7b3ad2efec05959db1f056c016edd949e4e298/content/renderer/mojo/blink_connector_js_wrapper.h [modify] https://crrev.com/4f7b3ad2efec05959db1f056c016edd949e4e298/content/renderer/mojo/interface_provider_js_wrapper.cc [modify] https://crrev.com/4f7b3ad2efec05959db1f056c016edd949e4e298/content/renderer/mojo/interface_provider_js_wrapper.h [delete] https://crrev.com/261aa73f059831df53079f24ab452685e75feac9/content/renderer/mojo_bindings_controller.cc [delete] https://crrev.com/261aa73f059831df53079f24ab452685e75feac9/content/renderer/mojo_bindings_controller.h [delete] https://crrev.com/261aa73f059831df53079f24ab452685e75feac9/content/renderer/mojo_context_state.cc [delete] https://crrev.com/261aa73f059831df53079f24ab452685e75feac9/content/renderer/mojo_context_state.h [delete] https://crrev.com/261aa73f059831df53079f24ab452685e75feac9/content/renderer/mojo_main_runner.cc [delete] https://crrev.com/261aa73f059831df53079f24ab452685e75feac9/content/renderer/mojo_main_runner.h [modify] https://crrev.com/4f7b3ad2efec05959db1f056c016edd949e4e298/content/renderer/render_frame_impl.cc [modify] https://crrev.com/4f7b3ad2efec05959db1f056c016edd949e4e298/content/shell/browser/layout_test/blink_test_controller.cc [modify] https://crrev.com/4f7b3ad2efec05959db1f056c016edd949e4e298/content/shell/browser/layout_test/layout_test_browser_context.cc [modify] https://crrev.com/4f7b3ad2efec05959db1f056c016edd949e4e298/extensions/BUILD.gn [modify] https://crrev.com/4f7b3ad2efec05959db1f056c016edd949e4e298/extensions/renderer/dispatcher.cc [modify] https://crrev.com/4f7b3ad2efec05959db1f056c016edd949e4e298/extensions/renderer/resources/extensions_renderer_resources.grd [modify] https://crrev.com/4f7b3ad2efec05959db1f056c016edd949e4e298/mojo/public/js/BUILD.gn [modify] https://crrev.com/4f7b3ad2efec05959db1f056c016edd949e4e298/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/4f7b3ad2efec05959db1f056c016edd949e4e298/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/4f7b3ad2efec05959db1f056c016edd949e4e298/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/4f7b3ad2efec05959db1f056c016edd949e4e298/ui/resources/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eca9c1de14c95fc5c4f23f1b2b144349de5f2817 commit eca9c1de14c95fc5c4f23f1b2b144349de5f2817 Author: Yuzhu Shen <yzshen@chromium.org> Date: Thu Nov 02 17:20:00 2017 Remove unused method define() in the private mojoPrivate extensions API. Bug: 699569,718047 Change-Id: I2ebda3e66b6cb7f74cb6bc3f577f978022374a14 Reviewed-on: https://chromium-review.googlesource.com/750191 Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#513529} [modify] https://crrev.com/eca9c1de14c95fc5c4f23f1b2b144349de5f2817/extensions/common/api/mojo_private.idl [modify] https://crrev.com/eca9c1de14c95fc5c4f23f1b2b144349de5f2817/extensions/renderer/api/mojo_private/mojo_private_unittest.cc [modify] https://crrev.com/eca9c1de14c95fc5c4f23f1b2b144349de5f2817/extensions/renderer/resources/mojo_private_custom_bindings.js [modify] https://crrev.com/eca9c1de14c95fc5c4f23f1b2b144349de5f2817/extensions/test/data/mojo_private_unittest.js [modify] https://crrev.com/eca9c1de14c95fc5c4f23f1b2b144349de5f2817/tools/valgrind/memcheck/suppressions.txt
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a07793629b292186d42e059b36275549745202c commit 4a07793629b292186d42e059b36275549745202c Author: Yuzhu Shen <yzshen@chromium.org> Date: Fri Nov 10 17:38:41 2017 extensions::ModuleSystem: expose a loadScript('module_name') function. This function directly runs the given module in the current scope. Bug: 699569, 718047 Change-Id: I233392e2c5cce5c26ebc6c10f324f2bcfb1e12b1 Reviewed-on: https://chromium-review.googlesource.com/762399 Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#515584} [modify] https://crrev.com/4a07793629b292186d42e059b36275549745202c/extensions/renderer/module_system.cc [modify] https://crrev.com/4a07793629b292186d42e059b36275549745202c/extensions/renderer/module_system.h [modify] https://crrev.com/4a07793629b292186d42e059b36275549745202c/extensions/renderer/module_system_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2efe42776d86948a7e0cdb69ef2462c66bbd8abf commit 2efe42776d86948a7e0cdb69ef2462c66bbd8abf Author: Yuzhu Shen <yzshen@chromium.org> Date: Sat Nov 11 02:01:09 2017 Move the mojo JS bindings resource into a separate grd file in mojo/pubilc/js. So that the resource could be used from both WebUI and extensions. BUG=699569, 718047 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If2ce60b15e0351aba801746cd863e5a2b9e85485 Reviewed-on: https://chromium-review.googlesource.com/762393 Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#515792} [modify] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/ash/resources/BUILD.gn [modify] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/chrome/chrome_paks.gni [modify] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/chromecast/BUILD.gn [modify] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/content/browser/BUILD.gn [modify] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/content/browser/webui/shared_resources_data_source.cc [modify] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/content/shell/BUILD.gn [modify] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/extensions/BUILD.gn [modify] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/headless/BUILD.gn [modify] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/ios/chrome/app/resources/BUILD.gn [modify] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/mojo/public/js/BUILD.gn [add] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/mojo/public/js/mojo_bindings_resources.grd [modify] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/tools/gritsettings/resource_ids [modify] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/ui/resources/BUILD.gn [modify] https://crrev.com/2efe42776d86948a7e0cdb69ef2462c66bbd8abf/ui/webui/resources/webui_resources.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bcd734d18252271a42d52a0e9f263f6b16ac88a1 commit bcd734d18252271a42d52a0e9f263f6b16ac88a1 Author: Yuzhu Shen <yzshen@chromium.org> Date: Wed Nov 15 20:40:58 2017 Enable new mojo JS bindings in extensions blessed context. This CL: - Adds support to load extensions JS sources from gzipped resources, since the JS file for new mojo JS bindings is gzipped. The alternative is to change the JS file to uncompressed, which would increase Chrome size quite significantly. For example, adding ~132KB to resources.pak for Linux official build. - Converts mimeHandlerPrivate to use new Mojo JS bindings. BUG=699569, 718047 Change-Id: If485020558f607a1d2e81296476c60a20e7dd21b Reviewed-on: https://chromium-review.googlesource.com/767649 Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#516811} [modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/common/api/BUILD.gn [modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/renderer/DEPS [modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/renderer/api_test_base.cc [modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/renderer/dispatcher.cc [modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/renderer/dispatcher.h [modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/renderer/module_system.cc [modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/renderer/module_system_test.cc [modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/renderer/module_system_test.h [modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/renderer/resource_bundle_source_map.cc [modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/renderer/resource_bundle_source_map.h [modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/renderer/resources/extensions_renderer_resources.grd [modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/renderer/resources/mime_handler_private_custom_bindings.js [modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/renderer/string_source_map.cc [modify] https://crrev.com/bcd734d18252271a42d52a0e9f263f6b16ac88a1/extensions/renderer/string_source_map.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d91c0f145e1dfd5364e6f8bb5441257d84d2fc51 commit d91c0f145e1dfd5364e6f8bb5441257d84d2fc51 Author: Yuzhu Shen <yzshen@chromium.org> Date: Mon Nov 20 22:51:17 2017 Extensions: convert keep_alive.js to use new Mojo JS bindings. Bug: 699569, 718047 Change-Id: I61f40ef3a6e7248eb11b3fba75ead7f96ca9cb51 Reviewed-on: https://chromium-review.googlesource.com/770149 Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#517966} [modify] https://crrev.com/d91c0f145e1dfd5364e6f8bb5441257d84d2fc51/extensions/common/BUILD.gn [modify] https://crrev.com/d91c0f145e1dfd5364e6f8bb5441257d84d2fc51/extensions/renderer/BUILD.gn [delete] https://crrev.com/d550293969c69349438e5f8e18d074489e905261/extensions/renderer/mojo/keep_alive_client_unittest.cc [modify] https://crrev.com/d91c0f145e1dfd5364e6f8bb5441257d84d2fc51/extensions/renderer/resources/keep_alive.js [modify] https://crrev.com/d91c0f145e1dfd5364e6f8bb5441257d84d2fc51/extensions/renderer/resources/utils.js [delete] https://crrev.com/d550293969c69349438e5f8e18d074489e905261/extensions/test/data/keep_alive_client_unittest.js [modify] https://crrev.com/d91c0f145e1dfd5364e6f8bb5441257d84d2fc51/mojo/public/js/new_bindings/base.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd47059ede03db6318da217f017bc73b186e09eb commit cd47059ede03db6318da217f017bc73b186e09eb Author: Yuzhu Shen <yzshen@chromium.org> Date: Fri Dec 01 23:50:20 2017 Extensions: convert media_router_bindings.js to use new Mojo JS bindings. This CL also changes the mojoPrivate API to be simply an async wrapper around require(). Bug: 699569, 718047 Change-Id: I271887d1cc1eb49fd2faefff47467c47be23a3be Reviewed-on: https://chromium-review.googlesource.com/783645 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Derek Cheng <imcheng@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#521129} [modify] https://crrev.com/cd47059ede03db6318da217f017bc73b186e09eb/chrome/common/media_router/mojo/BUILD.gn [modify] https://crrev.com/cd47059ede03db6318da217f017bc73b186e09eb/chrome/renderer/resources/extensions/media_router_bindings.js [modify] https://crrev.com/cd47059ede03db6318da217f017bc73b186e09eb/extensions/common/BUILD.gn [modify] https://crrev.com/cd47059ede03db6318da217f017bc73b186e09eb/extensions/renderer/api/mojo_private/mojo_private_unittest.cc [modify] https://crrev.com/cd47059ede03db6318da217f017bc73b186e09eb/extensions/renderer/resources/mime_handler_private_custom_bindings.js [modify] https://crrev.com/cd47059ede03db6318da217f017bc73b186e09eb/extensions/renderer/resources/mojo_private_custom_bindings.js [modify] https://crrev.com/cd47059ede03db6318da217f017bc73b186e09eb/extensions/test/data/mojo_private_unittest.js [modify] https://crrev.com/cd47059ede03db6318da217f017bc73b186e09eb/media/mojo/interfaces/BUILD.gn [modify] https://crrev.com/cd47059ede03db6318da217f017bc73b186e09eb/mojo/common/BUILD.gn [modify] https://crrev.com/cd47059ede03db6318da217f017bc73b186e09eb/net/interfaces/BUILD.gn [modify] https://crrev.com/cd47059ede03db6318da217f017bc73b186e09eb/url/mojo/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/312031eec9c97d5cb9dea801f4f3cefe2f3ad937 commit 312031eec9c97d5cb9dea801f4f3cefe2f3ad937 Author: Yuzhu Shen <yzshen@chromium.org> Date: Mon Dec 04 23:31:23 2017 Extensions: Remove old Mojo JS bindings support and AMD-style module support. This significantly reduces non-Android chrome size. With an official build on Linux, before the change - resources.pak 12230694 after the change - resources.pak 12069587 The difference is about 160KB. Bug: 699569, 718047 Change-Id: I2d2f6985cb10c27637a8a7d478001b18ac1b8111 Reviewed-on: https://chromium-review.googlesource.com/804974 Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#521516} [modify] https://crrev.com/312031eec9c97d5cb9dea801f4f3cefe2f3ad937/extensions/renderer/BUILD.gn [delete] https://crrev.com/deb6be0c94f8f9724f6e73b2092964fed8b6a6b6/extensions/renderer/api/mojo_private/mojo_private_unittest.cc [delete] https://crrev.com/deb6be0c94f8f9724f6e73b2092964fed8b6a6b6/extensions/renderer/api_test_base.cc [delete] https://crrev.com/deb6be0c94f8f9724f6e73b2092964fed8b6a6b6/extensions/renderer/api_test_base.h [delete] https://crrev.com/deb6be0c94f8f9724f6e73b2092964fed8b6a6b6/extensions/renderer/api_test_base_unittest.cc [modify] https://crrev.com/312031eec9c97d5cb9dea801f4f3cefe2f3ad937/extensions/renderer/dispatcher.cc [modify] https://crrev.com/312031eec9c97d5cb9dea801f4f3cefe2f3ad937/extensions/renderer/module_system.cc [modify] https://crrev.com/312031eec9c97d5cb9dea801f4f3cefe2f3ad937/extensions/renderer/module_system.h [modify] https://crrev.com/312031eec9c97d5cb9dea801f4f3cefe2f3ad937/extensions/renderer/module_system_unittest.cc [delete] https://crrev.com/deb6be0c94f8f9724f6e73b2092964fed8b6a6b6/extensions/renderer/resources/async_waiter.js [modify] https://crrev.com/312031eec9c97d5cb9dea801f4f3cefe2f3ad937/extensions/renderer/resources/extensions_renderer_resources.grd [delete] https://crrev.com/deb6be0c94f8f9724f6e73b2092964fed8b6a6b6/extensions/test/data/api_test_base_unittest.js [delete] https://crrev.com/deb6be0c94f8f9724f6e73b2092964fed8b6a6b6/extensions/test/data/mojo_private_unittest.js [delete] https://crrev.com/deb6be0c94f8f9724f6e73b2092964fed8b6a6b6/extensions/test/data/unit_test_environment_specific_bindings.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/332f5981400c7806126279035c96a96dc777f89c commit 332f5981400c7806126279035c96a96dc777f89c Author: Yuzhu Shen <yzshen@chromium.org> Date: Wed Dec 06 21:11:05 2017 Remove support for old-style Mojo JS bindings. Bug: 699569, 718047 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3e2d9e55cac52b392bd31c96c51cc94a361b618b Reviewed-on: https://chromium-review.googlesource.com/809545 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#522193} [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/build/sanitizers/lsan_suppressions.cc [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/chrome/browser/BUILD.gn [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/chrome/renderer/resources/extensions/media_router_bindings.js [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/components/cronet/tools/generators/cronet_bindings_generator.py [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/content/browser/BUILD.gn [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/content/public/common/bindings_policy.h [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/content/public/renderer/render_frame.h [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/content/renderer/BUILD.gn [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/content/renderer/mojo/blink_connector_js_wrapper.cc [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/content/renderer/mojo/blink_connector_js_wrapper.h [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/content/renderer/mojo/interface_provider_js_wrapper.cc [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/content/renderer/mojo/interface_provider_js_wrapper.h [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/content/renderer/render_frame_impl.cc [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/content/renderer/render_frame_impl.h [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/content/shell/BUILD.gn [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/content/test/BUILD.gn [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/extensions/BUILD.gn [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/mojo/BUILD.gn [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/mojo/edk/DEPS [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/BUILD.gn [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/core.cc [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/core.h [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/drain_data.cc [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/drain_data.h [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/handle.cc [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/handle.h [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/handle_close_observer.h [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/handle_unittest.cc [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/js_export.h [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/mojo_runner_delegate.cc [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/mojo_runner_delegate.h [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/support.cc [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/support.h [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/tests/BUILD.gn [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/tests/OWNERS [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/tests/run_js_unittests.cc [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/threading.cc [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/threading.h [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/waiting_callback.cc [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/edk/js/waiting_callback.h [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/mojo/public/BUILD.gn [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/mojo/public/interfaces/bindings/BUILD.gn [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/interfaces/bindings/new_bindings/OWNERS [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/interfaces/bindings/new_bindings/interface_control_messages.mojom [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/interfaces/bindings/new_bindings/pipe_control_messages.mojom [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/mojo/public/js/BUILD.gn [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/mojo/public/js/README.md [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/associated_bindings.js [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/bindings.js [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/buffer.js [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/codec.js [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/connector.js [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/constants.cc [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/constants.h [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/core.js [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/interface_types.js [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/lib/control_message_handler.js [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/lib/control_message_proxy.js [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/lib/interface_endpoint_client.js [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/lib/interface_endpoint_handle.js [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/lib/pipe_control_message_handler.js [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/lib/pipe_control_message_proxy.js [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/mojo/public/js/new_bindings/lib/control_message_handler.js [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/mojo/public/js/new_bindings/lib/control_message_proxy.js [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/mojo/public/js/new_bindings/lib/pipe_control_message_handler.js [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/mojo/public/js/new_bindings/lib/pipe_control_message_proxy.js [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/router.js [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/support.js [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/tests/core_unittest.js [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/threading.js [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/unicode.js [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/mojo/public/js/validator.js [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/mojo/public/tools/bindings/generators/mojom_js_generator.py [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/mojo/public/tools/bindings/mojom.gni [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/testing/buildbot/chromium.linux.json [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/testing/buildbot/chromium.sandbox.json [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/testing/buildbot/client.v8.chromium.json [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/testing/buildbot/filters/BUILD.gn [delete] https://crrev.com/a12c770e918a69cc0bbba2d2579c22ff6ae76936/testing/buildbot/filters/fuchsia.mojo_js_unittests.filter [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/testing/buildbot/test_suite_exceptions.pyl [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/testing/buildbot/test_suites.pyl [modify] https://crrev.com/332f5981400c7806126279035c96a96dc777f89c/tools/determinism/deterministic_build_whitelist.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ccd2691f48d4b43829434b0d7ee5a1d4d885695 commit 4ccd2691f48d4b43829434b0d7ee5a1d4d885695 Author: Yuzhu Shen <yzshen@chromium.org> Date: Mon Dec 11 19:14:25 2017 Mojo JS bindings: move the code out of the "new_bindings" folder into mojo/public/js. This change also puts some more files that don't expose public interfaces into mojo/public/js/lib. BUG=699569 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia84ec62323140c374fbe3def41152758a51cd337 Reviewed-on: https://chromium-review.googlesource.com/812106 Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#523160} [modify] https://crrev.com/4ccd2691f48d4b43829434b0d7ee5a1d4d885695/BUILD.gn [modify] https://crrev.com/4ccd2691f48d4b43829434b0d7ee5a1d4d885695/ios/web/BUILD.gn [modify] https://crrev.com/4ccd2691f48d4b43829434b0d7ee5a1d4d885695/mojo/public/js/BUILD.gn [modify] https://crrev.com/4ccd2691f48d4b43829434b0d7ee5a1d4d885695/mojo/public/js/README.md [rename] https://crrev.com/4ccd2691f48d4b43829434b0d7ee5a1d4d885695/mojo/public/js/base.js [rename] https://crrev.com/4ccd2691f48d4b43829434b0d7ee5a1d4d885695/mojo/public/js/bindings.js [rename] https://crrev.com/4ccd2691f48d4b43829434b0d7ee5a1d4d885695/mojo/public/js/interface_types.js [rename] https://crrev.com/4ccd2691f48d4b43829434b0d7ee5a1d4d885695/mojo/public/js/lib/buffer.js [rename] https://crrev.com/4ccd2691f48d4b43829434b0d7ee5a1d4d885695/mojo/public/js/lib/codec.js [rename] https://crrev.com/4ccd2691f48d4b43829434b0d7ee5a1d4d885695/mojo/public/js/lib/connector.js [rename] https://crrev.com/4ccd2691f48d4b43829434b0d7ee5a1d4d885695/mojo/public/js/lib/control_message_handler.js [rename] https://crrev.com/4ccd2691f48d4b43829434b0d7ee5a1d4d885695/mojo/public/js/lib/control_message_proxy.js [rename] https://crrev.com/4ccd2691f48d4b43829434b0d7ee5a1d4d885695/mojo/public/js/lib/interface_endpoint_client.js [rename] https://crrev.com/4ccd2691f48d4b43829434b0d7ee5a1d4d885695/mojo/public/js/lib/interface_endpoint_handle.js [rename] https://crrev.com/4ccd2691f48d4b43829434b0d7ee5a1d4d885695/mojo/public/js/lib/pipe_control_message_handler.js [rename] https://crrev.com/4ccd2691f48d4b43829434b0d7ee5a1d4d885695/mojo/public/js/lib/pipe_control_message_proxy.js [rename] https://crrev.com/4ccd2691f48d4b43829434b0d7ee5a1d4d885695/mojo/public/js/lib/router.js [rename] https://crrev.com/4ccd2691f48d4b43829434b0d7ee5a1d4d885695/mojo/public/js/lib/unicode.js [rename] https://crrev.com/4ccd2691f48d4b43829434b0d7ee5a1d4d885695/mojo/public/js/lib/validator.js [modify] https://crrev.com/4ccd2691f48d4b43829434b0d7ee5a1d4d885695/third_party/WebKit/Source/core/mojo/BUILD.gn
Comment 1 by bugdroid1@chromium.org
, Mar 8 2017