New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699551 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Chrome_Mac:base::internal::Invoker<base::internal::BindState<bool (safe_browsing::SafeBrowsingDatabaseManager::*)(GURL const&), scoped_refptr<safe_browsing::SafeBrowsingDatabaseManager>, GURL>, bool ()>::Run

Project Member Reported by ranjitkan@chromium.org, Mar 8 2017

Issue description

Product name: Chrome_Mac
Magic Signature: base::internal::Invoker<base::internal::BindState<bool (safe_browsing::SafeBrowsingDatabaseManager::*)(GURL const&), scoped_refptr<safe_browsing::SafeBrowsingDatabaseManager>, GURL>, bool ()>::Run

Current link:
https://crash.corp.google.com/browse?q=product.name%3D%27Chrome_Mac%27%20AND%20product.version%3D%2759.0.3035.0%27%20AND%20custom_data.ChromeCrashProto.channel%3D%27canary%27%20AND%20custom_data.ChromeCrashProto.ptype%3D%27browser%27%20AND%20ReportID%3D%2799dd4c6480000000%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D&stbtiq=&reportid=&index=0#0

Search properties:
product.name: Chrome_Mac
product.version: 59.0.3035.0
custom_data.chromecrashproto.ptype: browser
reportid: 99dd4c6480000000

Metadata :
Product Name: Chrome_Mac
Product Version: 59.0.3035.0
Report ID: 99dd4c6480000000
Report Time: Wed, 08 Mar 2017 12:31:34 GMT
Uptime: 2123000 ms
Cumulative Uptime: 0 ms
User Email: 
OS Name: Mac OS X
OS Version: 10.12.3 16D32
CPU Architecture: amd64
CPU Info: family 6 model 61 stepping 4

Stack trace
==============
CRASHED [EXC_BAD_ACCESS / KERN_INVALID_ADDRESS @ 0x00000000 ] MAGIC SIGNATURE THREAD
Stack Quality76%Show frame trust levels
0x000000010451ae1c	(Google Chrome Framework -bind_internal.h:214 )	base::internal::Invoker<base::internal::BindState<bool (safe_browsing::SafeBrowsingDatabaseManager::*)(GURL const&), scoped_refptr<safe_browsing::SafeBrowsingDatabaseManager>, GURL>, bool ()>::Run(base::internal::BindStateBase*)
0x000000010336e1bd	(Google Chrome Framework -callback.h:85 )	void base::internal::ReturnAsParamAdapter<bool>(base::Callback<bool (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, bool*)
0x0000000104c17807	(Google Chrome Framework -callback.h:85 )	base::(anonymous namespace)::PostTaskAndReplyRelay::RunTaskAndPostReply()
0x0000000104ba5d1f	(Google Chrome Framework -callback.h:68 )	base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*)
0x0000000104bcb8fa	(Google Chrome Framework -message_loop.cc:423 )	base::MessageLoop::RunTask(base::PendingTask*)
0x0000000104bcbc4b	(Google Chrome Framework -message_loop.cc:434 )	base::MessageLoop::DeferOrRunPendingTask(base::PendingTask)
0x0000000104bcc012	(Google Chrome Framework -message_loop.cc:527 )	base::MessageLoop::DoWork()
0x0000000104bce7c4	(Google Chrome Framework -message_pump_libevent.cc:219 )	base::MessagePumpLibevent::Run(base::MessagePump::Delegate*)
0x0000000104bed862	(Google Chrome Framework -run_loop.cc:37 )	base::RunLoop::Run()
0x000000010364de53	(Google Chrome Framework -browser_thread_impl.cc:277 )	content::BrowserThreadImpl::IOThreadRun(base::RunLoop*)
0x000000010364df1b	(Google Chrome Framework -browser_thread_impl.cc:312 )	content::BrowserThreadImpl::Run(base::RunLoop*)
0x0000000104c1c538	(Google Chrome Framework -thread.cc:333 )	base::Thread::ThreadMain()
0x0000000104c17626	(Google Chrome Framework -platform_thread_posix.cc:71 )	base::(anonymous namespace)::ThreadFunc(void*)
0x00007fff8b7b3aaa	(libsystem_pthread.dylib + 0x00003aaa )	_pthread_body
0x00007fff8b7b39f6	(libsystem_pthread.dylib + 0x000039f6 )	_pthread_start
0x00007fff8b7b31fc	(libsystem_pthread.dylib + 0x000031fc )	thread_start
0x0000000104c175cf	(Google Chrome Framework + 0x01a825cf )	

Instances for this crash is reported so far on Canary builds 59.0.3034.0 & 59.0.3035.0. Below link gives in detail about the same:

https://crash.corp.google.com/browse?q=product.name%3D%27Chrome_Mac%27%20AND%20custom_data.ChromeCrashProto.channel%3D%27canary%27%20AND%20custom_data.ChromeCrashProto.ptype%3D%27browser%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27base%3A%3Ainternal%3A%3AInvoker%3Cbase%3A%3Ainternal%3A%3ABindState%3Cbool%20(safe_browsing%3A%3ASafeBrowsingDatabaseManager%3A%3A*)(GURL%20const%26)%2C%20scoped_refptr%3Csafe_browsing%3A%3ASafeBrowsingDatabaseManager%3E%2C%20GURL%3E%2C%20bool%20()%3E%3A%3ARun%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D

So far 6 instances reported on canary 59.0.3035.0 from different client ID's. Adding Release block label, please undo if not the case. This browser crash is ranked 1 when reported for MAC OS.

Change Log: https://chromium.googlesource.com/chromium/src/+log/59.0.3033.0..59.0.3034.0?pretty=fuller&n=10000

Suspecting below change could be a possible suspect:

https://chromium.googlesource.com/chromium/src/+/6deb9558472020122deac99571bf8e20169f3834

@ lpz: Assigning to you, request you to please take a look into it. Please help us to find an owner if not with respect to your change.

Thanks.!
 
Description: Show this description

Comment 2 by lpz@chromium.org, Mar 8 2017

Cc: jialiul@chromium.org
Owner: vakh@chromium.org
+vakh,jialiul - would you be able to assist here? Looking at the crash report doesn't give too many clues. I tried looking at the minidump file on linux but since these are Mac crashes it didn't work. I can't find much useful info on how to debug MacOS crashes either.

Thoughts?

Comment 3 by lpz@chromium.org, Mar 8 2017

Cc: lpz@chromium.org
Components: Services>Safebrowsing
Labels: OS-Windows
I am seeing one more variant of magic signature w/ similar crash stack on Windows.

https://goto.google.com/qczbb (Magic Signature: 'base::internal::ReturnAsParamAdapter<bool>').

Thank you!

Comment 6 by vakh@chromium.org, Mar 8 2017

jialiul and I are looking at this right now.

Comment 7 by vakh@chromium.org, Mar 8 2017

Status: Started (was: Assigned)
Project Member

Comment 8 by sheriffbot@chromium.org, Mar 8 2017

Labels: FoundIn-M-59 Fracas
Users experienced this crash on the following builds:

Mac Canary 59.0.3035.0 -  25.79 CPM, 25 reports, 24 clients (signature base::internal::Invoker<base::internal::BindState<bool (safe_browsing::SafeBrowsingDatabaseManager::*)(GURL const&), scoped_refptr<safe_browsing::SafeBrowsingDatabaseManager>, GURL>, bool ()>::Run)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Cc: fdoray@chromium.org
Similar crashes mentioned in comment #5 seem have nothing to do safe browsing.
Is it possible this is caused by up stream changes? 
cc fdoray@, who should be more familiar with base::internal::ReturnAsParamAdapter code. 
Cc: scottmg@chromium.org
Labels: Stability-Sheriff-Desktop
Adding 'scottmg@' as a 'Stability-Sheriff-Desktop' for more inputs.

Thank you!

Comment 11 by vakh@chromium.org, Mar 8 2017

The change log (https://chromium.googlesource.com/chromium/src/+log/59.0.3033.0..59.0.3034.0?pretty=fuller&n=10000) has no SafeBrowsing changes that would cause a crash at this stack level.
Cc: vakh@chromium.org
Owner: jialiul@chromium.org
(stability sheriff) Hi, I dug into this a bit. On Windows at least, the crashing task is posted from safe_browsing::PasswordProtectionService::RecordPasswordReuse().

The CL that added that code was a little while ago (https://crrev.com/2720643003) which predates the appearance of these crashes, but could it perhaps be due to https://codereview.chromium.org/2734863004 which was landed at 3034, which sounds like it's wiring things up?

jialiul@ could you look into this to either disable or revert to see the effect on Canary?
Thanks scottmg@! I reverted crrev.com/2734863004.
Let's see if this crash will go away. 

Comment 14 by ajha@chromium.org, Mar 9 2017

Just to update, revert(https://codereview.chromium.org/2738073002/) commited @ #455628 missed today's canary(59.0.3036.0) cut @#455621.

Will verify this in tomorrow's canary.

Comment 15 by vakh@chromium.org, Mar 9 2017

FWIW -- all the crashes were observed in the Pver4 population. Thanks Chirp.

See: http://go/heedi
Labels: Hotlist-ConOps
I just ran into this bug (crash ID: a2d30c3920000000) in Canary, signing in to my gmail account in Incognito on Windows 10. I was able to reproduce this 3 out of 3 tries.
Thanks, melodychu@. The offending CL was reverted yesterday.

Comment 18 by ajha@chromium.org, Mar 10 2017

Labels: TE-Verified-M59 TE-verified-59.0.3037.0
Windows and Mac canary(59.0.3027.0) has been live for 5 & 8 hours respectively without any crash instances. 

Adding the verified label, therefore.

Comment 19 by vakh@chromium.org, Mar 10 2017

Labels: SafeBrowsing-Triaged

Comment 20 by vakh@chromium.org, Mar 10 2017

Status: Fixed (was: Started)
Issue 699582 has been merged into this issue.

Sign in to add a comment