Password manager does not offer to save password for www.irccloud.com |
|||||
Issue descriptionNeither for sign-up nor sign-in does the password manager offer to save the password you entered on https://www.irccloud.com.
,
Mar 14 2017
The logs indicate that the password form reappeared. This might be a case for improving our login success detection.
,
Jan 26 2018
,
Jan 29 2018
a form is visible, but it is not a login form. We shouldn't compare actions if they are empty (IsPasswordFormReappeared). We already do that for in-page navigations in PasswordAutofillAgent. Look for |form_action_is_empty|.
,
Feb 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ada53fd633a1625eae0bc40b6721f149d989464e commit ada53fd633a1625eae0bc40b6721f149d989464e Author: Luka Dojcilovic <l.dojcilovic@gmail.com> Date: Mon Feb 19 13:57:44 2018 [Password Manager] Fix password form reappear detection for empty action forms. This CL chnages IsPasswordFormReappeared so it doesn't compare form actions if they are empty. R=cfroussios@chromium.org, kolos@chromium.org Bug: 699539 Change-Id: Ia57c6ec7245d972e5df5f88b64c5ddac9c2c5c43 Reviewed-on: https://chromium-review.googlesource.com/916565 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#537643} [modify] https://crrev.com/ada53fd633a1625eae0bc40b6721f149d989464e/AUTHORS [modify] https://crrev.com/ada53fd633a1625eae0bc40b6721f149d989464e/chrome/browser/password_manager/password_manager_browsertest.cc [add] https://crrev.com/ada53fd633a1625eae0bc40b6721f149d989464e/chrome/test/data/password/navigate_to_same_url_empty_actions.html [modify] https://crrev.com/ada53fd633a1625eae0bc40b6721f149d989464e/components/password_manager/core/browser/password_manager.cc
,
Feb 19 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by battre@chromium.org
, Mar 8 2017