New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699537 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

[Android O] Remove the vibration setting from notification Site Settings

Project Member Reported by peter@chromium.org, Mar 8 2017

Issue description

We won't be able to support it, so let's hide it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e55e49510812c8041307c7d1eef2282f80c0169

commit 1e55e49510812c8041307c7d1eef2282f80c0169
Author: awdf <awdf@chromium.org>
Date: Thu Mar 09 13:21:44 2017

Android settings: conditionally show notification vibrate option

BUG= 699537 

Review-Url: https://codereview.chromium.org/2742583004
Cr-Commit-Position: refs/heads/master@{#455729}

[modify] https://crrev.com/1e55e49510812c8041307c7d1eef2282f80c0169/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java

Comment 2 by awdf@chromium.org, Mar 9 2017

Labels: Merge-Request-58
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 9 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 9 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1431bd9c7641f1b2a541cdad285038059b4eb735

commit 1431bd9c7641f1b2a541cdad285038059b4eb735
Author: Anita Woodruff <awdf@chromium.org>
Date: Thu Mar 09 15:36:18 2017

Android settings: conditionally show notification vibrate option

BUG= 699537 

Review-Url: https://codereview.chromium.org/2742583004
Cr-Commit-Position: refs/heads/master@{#455729}
(cherry picked from commit 1e55e49510812c8041307c7d1eef2282f80c0169)

Review-Url: https://codereview.chromium.org/2740153002 .
Cr-Commit-Position: refs/branch-heads/3029@{#83}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/1431bd9c7641f1b2a541cdad285038059b4eb735/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java

Comment 5 by awdf@chromium.org, Mar 10 2017

Status: Fixed (was: Assigned)

Comment 6 by awdf@chromium.org, Apr 6 2017

Labels: -Restrict-View-Google

Sign in to add a comment