New issue
Advanced search Search tips

Issue 699536 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Fix UMA metric for accept= on input type=file

Project Member Reported by finnur@chromium.org, Mar 8 2017

Issue description

The UMA metric is currently counting "image/x-png, image/gif, image/jpeg" as needing a generic picker, when a photo picker would be preferrable.
 
Cc: -bever...@google.com beverloo@chromium.org
Cc: -beverloo@chromium.org peter@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0dbc85ff55c7ec0e32dcf731ca7ff31543866da

commit e0dbc85ff55c7ec0e32dcf731ca7ff31543866da
Author: finnur <finnur@chromium.org>
Date: Tue Mar 14 14:39:36 2017

Update the File Picker UMA metric to account for extensions, as per spec.

Note: The list of extensions is not permanent, and will be removed once we have the data we need.

BUG= 699536 

Review-Url: https://codereview.chromium.org/2746143002
Cr-Commit-Position: refs/heads/master@{#456698}

[modify] https://crrev.com/e0dbc85ff55c7ec0e32dcf731ca7ff31543866da/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java
[modify] https://crrev.com/e0dbc85ff55c7ec0e32dcf731ca7ff31543866da/ui/android/junit/src/org/chromium/ui/base/SelectFileDialogTest.java

Comment 5 by finnur@chromium.org, Mar 16 2017

Labels: Merge-Request-58
Two small changes to metrics, requesting permission to merge to M58. 
Project Member

Comment 6 by sheriffbot@chromium.org, Mar 16 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 16 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a97978af4fc41569e1ac27eb02b584b52c923399

commit a97978af4fc41569e1ac27eb02b584b52c923399
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Thu Mar 16 12:56:23 2017

Fix UMA metric to not count multiple image/ tags as generic.

BUG= 699536 

Review-Url: https://codereview.chromium.org/2737843004
Cr-Commit-Position: refs/heads/master@{#455771}
(cherry picked from commit 384e24962ca4e9f0b9c8b821f5c021db93693d2a)

Review-Url: https://codereview.chromium.org/2756593003 .
Cr-Commit-Position: refs/branch-heads/3029@{#236}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/a97978af4fc41569e1ac27eb02b584b52c923399/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java
[modify] https://crrev.com/a97978af4fc41569e1ac27eb02b584b52c923399/ui/android/junit/src/org/chromium/ui/base/SelectFileDialogTest.java

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb2ad2264a7922af6c049489c8c26bd7b7fa7685

commit bb2ad2264a7922af6c049489c8c26bd7b7fa7685
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Thu Mar 16 12:58:23 2017

Update the File Picker UMA metric to account for extensions, as per spec.

Note: The list of extensions is not permanent, and will be removed once we have the data we need.

BUG= 699536 

Review-Url: https://codereview.chromium.org/2746143002
Cr-Commit-Position: refs/heads/master@{#456698}
(cherry picked from commit e0dbc85ff55c7ec0e32dcf731ca7ff31543866da)

Review-Url: https://codereview.chromium.org/2754843002 .
Cr-Commit-Position: refs/branch-heads/3029@{#237}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/bb2ad2264a7922af6c049489c8c26bd7b7fa7685/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java
[modify] https://crrev.com/bb2ad2264a7922af6c049489c8c26bd7b7fa7685/ui/android/junit/src/org/chromium/ui/base/SelectFileDialogTest.java

Comment 9 by finnur@chromium.org, Mar 16 2017

Status: Fixed (was: Started)

Sign in to add a comment