Issue 172082  has been merged into this issue.

Issue 616343 has been merged into this issue.

 Issue 532123  has been merged into this issue.

 Issue 173932  has been merged into this issue.

 Issue 172009  has been merged into this issue.

 Issue 546506  has been merged into this issue.

Issue 389035 has been merged into this issue.

 Issue 633515  has been merged into this issue.

 Issue 631473  has been merged into this issue.

cnn.com

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/718d242b21b1964f8a06e79bf00dcce7e073dac7

commit 718d242b21b1964f8a06e79bf00dcce7e073dac7
Author: kolos <kolos@chromium.org>
Date: Wed Mar 22 17:16:30 2017

[Password Manager] Send username correction votes

If a user changes autofilled username on a form, but the correct username is in |PasswordForm.other_possible_usernames|, send USERNAME vote for the element that contained the correct username.

This CL changes the data structure of |other_possible_usernames| from vector<string> to vector<pair<string, string>>.

The CL updates only one local storage - login_database. We need to receive enough votes, there is no need to cover 100% of Chrome instances. But the results based on the votes would propagated to all instances.

BUG=699530

Review-Url: https://codereview.chromium.org/2747733004
Cr-Commit-Position: refs/heads/master@{#458788}

[modify] https://crrev.com/718d242b21b1964f8a06e79bf00dcce7e073dac7/components/autofill/content/common/autofill_types.mojom
[modify] https://crrev.com/718d242b21b1964f8a06e79bf00dcce7e073dac7/components/autofill/content/common/autofill_types.typemap
[modify] https://crrev.com/718d242b21b1964f8a06e79bf00dcce7e073dac7/components/autofill/content/common/autofill_types_struct_traits.cc
[modify] https://crrev.com/718d242b21b1964f8a06e79bf00dcce7e073dac7/components/autofill/content/common/autofill_types_struct_traits.h
[modify] https://crrev.com/718d242b21b1964f8a06e79bf00dcce7e073dac7/components/autofill/content/common/autofill_types_struct_traits_unittest.cc
[modify] https://crrev.com/718d242b21b1964f8a06e79bf00dcce7e073dac7/components/autofill/content/renderer/password_form_conversion_utils.cc
[modify] https://crrev.com/718d242b21b1964f8a06e79bf00dcce7e073dac7/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
[modify] https://crrev.com/718d242b21b1964f8a06e79bf00dcce7e073dac7/components/autofill/core/common/password_form.cc
[modify] https://crrev.com/718d242b21b1964f8a06e79bf00dcce7e073dac7/components/autofill/core/common/password_form.h
[modify] https://crrev.com/718d242b21b1964f8a06e79bf00dcce7e073dac7/components/password_manager/core/browser/BUILD.gn
[modify] https://crrev.com/718d242b21b1964f8a06e79bf00dcce7e073dac7/components/password_manager/core/browser/login_database.cc
[modify] https://crrev.com/718d242b21b1964f8a06e79bf00dcce7e073dac7/components/password_manager/core/browser/login_database_unittest.cc
[modify] https://crrev.com/718d242b21b1964f8a06e79bf00dcce7e073dac7/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/718d242b21b1964f8a06e79bf00dcce7e073dac7/components/password_manager/core/browser/password_form_manager.h
[modify] https://crrev.com/718d242b21b1964f8a06e79bf00dcce7e073dac7/components/password_manager/core/browser/password_form_manager_unittest.cc
[add] https://crrev.com/718d242b21b1964f8a06e79bf00dcce7e073dac7/components/test/data/password_manager/login_db_v19.sql

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3696a2abf42720bdb9a5c9a9378b9f8efdfef9b4

commit 3696a2abf42720bdb9a5c9a9378b9f8efdfef9b4
Author: dvadym <dvadym@chromium.org>
Date: Mon Apr 10 09:57:21 2017

Sending autofill types for username fields in sign-in forms for improving username detection.

Using Autofill types of username from sign-in forms we can improve username detections, details are in go/chrome-password-manager-username-detection-with-server-side.

BUG=699530

Review-Url: https://codereview.chromium.org/2796873002
Cr-Commit-Position: refs/heads/master@{#463207}

[modify] https://crrev.com/3696a2abf42720bdb9a5c9a9378b9f8efdfef9b4/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/3696a2abf42720bdb9a5c9a9378b9f8efdfef9b4/components/autofill/core/browser/autofill_manager.h
[modify] https://crrev.com/3696a2abf42720bdb9a5c9a9378b9f8efdfef9b4/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/3696a2abf42720bdb9a5c9a9378b9f8efdfef9b4/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/3696a2abf42720bdb9a5c9a9378b9f8efdfef9b4/components/autofill/core/browser/form_structure.h
[modify] https://crrev.com/3696a2abf42720bdb9a5c9a9378b9f8efdfef9b4/components/autofill/core/browser/form_structure_unittest.cc
[modify] https://crrev.com/3696a2abf42720bdb9a5c9a9378b9f8efdfef9b4/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/3696a2abf42720bdb9a5c9a9378b9f8efdfef9b4/components/password_manager/core/browser/password_form_manager.h
[modify] https://crrev.com/3696a2abf42720bdb9a5c9a9378b9f8efdfef9b4/components/password_manager/core/browser/password_form_manager_unittest.cc

http://www.openstreetmap.org/

https://www.mintos.com/en/investor-registration/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2366977b83a1eb2ce167821d7d1d9e084bd602fc

commit 2366977b83a1eb2ce167821d7d1d9e084bd602fc
Author: dvadym <dvadym@chromium.org>
Date: Mon Apr 24 13:10:20 2017

Fix sending autofill votes for sign-in forms.

On CL https://codereview.chromium.org/2796873002/ a sending of autofill votes for sing-in forms was implemented, but |available_field_types_| doesn't contain PASSWORD type, that makes that the server skips such forms as invalid. This CL adds PASSWORD type for sign-in form uploads.

BUG= 713688 , 699530

Review-Url: https://codereview.chromium.org/2830303002
Cr-Commit-Position: refs/heads/master@{#466621}

[modify] https://crrev.com/2366977b83a1eb2ce167821d7d1d9e084bd602fc/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/2366977b83a1eb2ce167821d7d1d9e084bd602fc/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/2366977b83a1eb2ce167821d7d1d9e084bd602fc/components/autofill/core/browser/form_structure.cc

Some issues from test plan:
hein-gericke.de
macecraft.com
tommyteleshopping.com
vaneeva.livejournal.com
tommyteleshopping.com
brainmeta.com
tinami.com
familyplanning2020.org
averdade.com
thehome.com.au

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c4e650dc5f0b6f20a9669c0943bd20c18e85ed1

commit 6c4e650dc5f0b6f20a9669c0943bd20c18e85ed1
Author: dvadym <dvadym@chromium.org>
Date: Fri May 19 10:58:14 2017

Fix sending autofill votes for sign-in forms.

On CL https://codereview.chromium.org/2796873002/ a sending of autofill votes for sing-in forms was implemented. The problem is that FormData received from the renderer doesn't have values, so Autofill can't figure out any types. This CL adds username value to username field value in FormData structure.

BUG=699530

Review-Url: https://codereview.chromium.org/2886413002
Cr-Commit-Position: refs/heads/master@{#473155}

[modify] https://crrev.com/6c4e650dc5f0b6f20a9669c0943bd20c18e85ed1/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/6c4e650dc5f0b6f20a9669c0943bd20c18e85ed1/components/password_manager/core/browser/password_form_manager_unittest.cc

https://chromium-review.googlesource.com/c/582629 (not listed in the bug)

Reason for merge: This CL sends autofill votes that are needed for intern project. We would like to receive some data from stable before the end of internship.

This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1985eb3820283afc48e009b995edfc502638ce82

commit 1985eb3820283afc48e009b995edfc502638ce82
Author: Mâdâlina Hurmuz <madalinahurmuz@google.com>
Date: Fri Aug 11 15:02:42 2017

[Password Manager] - Send username vote type |USERNAME_EDITED| when a user edited username in a prompt

In this CL, we send username votes for the case in which the user edits
username value in a prompt (see  crbug.com/734965 ).
Chrome already uploads username votes if:
1. The user overwrites their credentials.
2. The user reuses their credentials.
For more details: https://chromium-review.googlesource.com/c/582629/ 

Bug: 699530
Change-Id: I765b9713960273ad8c4471940a7077031d1031c5
Reviewed-on: https://chromium-review.googlesource.com/597606
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493741}
[modify] https://crrev.com/1985eb3820283afc48e009b995edfc502638ce82/components/autofill/content/renderer/password_form_conversion_utils.cc
[modify] https://crrev.com/1985eb3820283afc48e009b995edfc502638ce82/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/1985eb3820283afc48e009b995edfc502638ce82/components/password_manager/core/browser/password_form_manager.h
[modify] https://crrev.com/1985eb3820283afc48e009b995edfc502638ce82/components/password_manager/core/browser/password_form_manager_unittest.cc

M61 is already in Beta and we're ONLY taking critical merges in. 

+abdulsyed@, what do you think about this (PTAL comment #35)?

Since this bug has been around for a while, and M61 is already branched and on it's 3rd Beta, my recommendation is to wait until M62. This does not meet the merge guidelines (go/chrome-merges). Our goal now is to stabilize the branch and take only critical and important fixes for regressions. I realize that M62 will probably be after the internship. 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3afb8e4faa0d0a83686a9815a3af8a78917f7f10

commit 3afb8e4faa0d0a83686a9815a3af8a78917f7f10
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Fri Sep 15 11:02:40 2017

[Password Manager] Fix bug in sending autofill votes

Before this CL, most of username correction votes were suppressed because of a bug.

New tests that will prevent similar issues will be added later. Opened  crbug.com/765578  for that.

Bug: 699530,  765578 
Change-Id: Ic08261f25425f13a26e4ba04ffda3a6f6258ed1a
Reviewed-on: https://chromium-review.googlesource.com/668365
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502223}
[modify] https://crrev.com/3afb8e4faa0d0a83686a9815a3af8a78917f7f10/components/password_manager/core/browser/password_form_manager.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3afb8e4faa0d0a83686a9815a3af8a78917f7f10

commit 3afb8e4faa0d0a83686a9815a3af8a78917f7f10
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Fri Sep 15 11:02:40 2017

[Password Manager] Fix bug in sending autofill votes

Before this CL, most of username correction votes were suppressed because of a bug.

New tests that will prevent similar issues will be added later. Opened  crbug.com/765578  for that.

Bug: 699530,  765578 
Change-Id: Ic08261f25425f13a26e4ba04ffda3a6f6258ed1a
Reviewed-on: https://chromium-review.googlesource.com/668365
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502223}
[modify] https://crrev.com/3afb8e4faa0d0a83686a9815a3af8a78917f7f10/components/password_manager/core/browser/password_form_manager.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e7383cbbde47b19bf16aea156e3b6db1735d034

commit 8e7383cbbde47b19bf16aea156e3b6db1735d034
Author: Ana-Cosmina Popescu <anacosmina@google.com>
Date: Mon Sep 18 09:47:05 2017

[Password Manager] Refactor |other_possible_usernames| logic in GetPasswordForm

Make the logic simpler. Moreover, the list possible username will be needed for HTML classifier (https://chromium-review.googlesource.com/c/chromium/src/+/652448)

Bug: 699530
Change-Id: I1ed0b3ac5ceac875818b38c0927e155752cd126c
Reviewed-on: https://chromium-review.googlesource.com/670261
Commit-Queue: Ana-Cosmina Popescu <anacosmina@google.com>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502543}
[modify] https://crrev.com/8e7383cbbde47b19bf16aea156e3b6db1735d034/components/autofill/content/renderer/password_form_conversion_utils.cc
[modify] https://crrev.com/8e7383cbbde47b19bf16aea156e3b6db1735d034/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7bd7b007f8ae421b6978a2d2eb52c1454f3a969

commit d7bd7b007f8ae421b6978a2d2eb52c1454f3a969
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Mon Sep 18 14:37:24 2017

[Password Manager] Add tests for uploading username correction votes

New tests check that username correction votes are uploaded when form has only two fields.

Two fields case (sign-in form) is actually the main case for uploading username votes, but https://codereview.chromium.org/2886413002 didn't send username votes when the form has only two fields. New tests should prevent breaking username votes logic in the future.

Bug: 699530,  765578 
Change-Id: I1b75edfc6e322c587c1e59adb9bb491c96891765
Reviewed-on: https://chromium-review.googlesource.com/670562
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502575}
[modify] https://crrev.com/d7bd7b007f8ae421b6978a2d2eb52c1454f3a969/components/password_manager/core/browser/password_form_manager_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d1155aa81c64965d6b1610a07dc332eda4e9975

commit 6d1155aa81c64965d6b1610a07dc332eda4e9975
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Wed Sep 20 08:40:17 2017

[Merge to M62] [Password Manager] Fix bug in sending autofill votes

Before this CL, most of username correction votes were suppressed because of a bug.

New tests that will prevent similar issues will be added later. Opened  crbug.com/765578  for that.

TBR=kolos@chromium.org

(cherry picked from commit 3afb8e4faa0d0a83686a9815a3af8a78917f7f10)

Bug: 699530,  765578 
Change-Id: Ic08261f25425f13a26e4ba04ffda3a6f6258ed1a
Reviewed-on: https://chromium-review.googlesource.com/668365
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502223}
Reviewed-on: https://chromium-review.googlesource.com/674685
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#352}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/6d1155aa81c64965d6b1610a07dc332eda4e9975/components/password_manager/core/browser/password_form_manager.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da3bcbe63028441f79997baa5c0e6b58ad36cef0

commit da3bcbe63028441f79997baa5c0e6b58ad36cef0
Author: Ana-Cosmina Popescu <anacosmina@google.com>
Date: Fri Sep 22 18:24:48 2017

[Password Manager] HTML classifier for improving username detection

Improve username detection in Chrome Password Manager by adding a HTML based classifier before applying the current heuristics (i.e. take field before password field as username).
The classifier analyzes certain HTML attribute values and matches them to certain word dictionaries that are likely to point to a username field. 

TBR=vabr@chromium.org

Bug: 699530
Change-Id: Id49f551d634d51c089d373180bf4809d9cdfe827
Reviewed-on: https://chromium-review.googlesource.com/652448
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503799}
[modify] https://crrev.com/da3bcbe63028441f79997baa5c0e6b58ad36cef0/chrome/browser/about_flags.cc
[modify] https://crrev.com/da3bcbe63028441f79997baa5c0e6b58ad36cef0/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/da3bcbe63028441f79997baa5c0e6b58ad36cef0/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/da3bcbe63028441f79997baa5c0e6b58ad36cef0/components/autofill/content/renderer/BUILD.gn
[add] https://crrev.com/da3bcbe63028441f79997baa5c0e6b58ad36cef0/components/autofill/content/renderer/html_based_username_detector.cc
[add] https://crrev.com/da3bcbe63028441f79997baa5c0e6b58ad36cef0/components/autofill/content/renderer/html_based_username_detector.h
[modify] https://crrev.com/da3bcbe63028441f79997baa5c0e6b58ad36cef0/components/autofill/content/renderer/password_form_conversion_utils.cc
[modify] https://crrev.com/da3bcbe63028441f79997baa5c0e6b58ad36cef0/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
[modify] https://crrev.com/da3bcbe63028441f79997baa5c0e6b58ad36cef0/components/password_manager/core/common/password_manager_features.cc
[modify] https://crrev.com/da3bcbe63028441f79997baa5c0e6b58ad36cef0/components/password_manager/core/common/password_manager_features.h
[modify] https://crrev.com/da3bcbe63028441f79997baa5c0e6b58ad36cef0/tools/metrics/histograms/enums.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08b0049ac7f3ef05fe4e4c5c7d7b5c191b6d8602

commit 08b0049ac7f3ef05fe4e4c5c7d7b5c191b6d8602
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Mon Oct 02 21:54:55 2017

[Password Manager] Change AutofillQueryResponseContents

This CL changes AutofillQueryResponseContents proto in order to support
multiple field predictions. A field may have several server-side
predictions. For example, for the same field we can have two different
classifications: |EMAIL_ADDRESS| and |USERNAME| and both are important.
This CL also updates how the response proto is parsed and the process of
choosing the autofill predictions which are useful for password manager.

The CL was almost done by Madalina (https://chromium-review.googlesource.com/c/chromium/src/+/664704). 
Here I applied a couple of comments from reviewer when Madalina's internship finished.

Bug: 699530
Change-Id: I65b3ca8683e03b5d85049f3180971bcdeb1a1309
Reviewed-on: https://chromium-review.googlesource.com/677298
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505805}
[modify] https://crrev.com/08b0049ac7f3ef05fe4e4c5c7d7b5c191b6d8602/components/autofill/core/browser/autofill_field.cc
[modify] https://crrev.com/08b0049ac7f3ef05fe4e4c5c7d7b5c191b6d8602/components/autofill/core/browser/autofill_field.h
[modify] https://crrev.com/08b0049ac7f3ef05fe4e4c5c7d7b5c191b6d8602/components/autofill/core/browser/autofill_field_unittest.cc
[modify] https://crrev.com/08b0049ac7f3ef05fe4e4c5c7d7b5c191b6d8602/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/08b0049ac7f3ef05fe4e4c5c7d7b5c191b6d8602/components/autofill/core/browser/autofill_metrics.cc
[modify] https://crrev.com/08b0049ac7f3ef05fe4e4c5c7d7b5c191b6d8602/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/08b0049ac7f3ef05fe4e4c5c7d7b5c191b6d8602/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/08b0049ac7f3ef05fe4e4c5c7d7b5c191b6d8602/components/autofill/core/browser/form_structure_unittest.cc
[modify] https://crrev.com/08b0049ac7f3ef05fe4e4c5c7d7b5c191b6d8602/components/autofill/core/browser/proto/server.proto
[modify] https://crrev.com/08b0049ac7f3ef05fe4e4c5c7d7b5c191b6d8602/components/password_manager/core/browser/browser_save_password_progress_logger_unittest.cc
[modify] https://crrev.com/08b0049ac7f3ef05fe4e4c5c7d7b5c191b6d8602/components/password_manager/core/browser/password_generation_manager.cc
[modify] https://crrev.com/08b0049ac7f3ef05fe4e4c5c7d7b5c191b6d8602/components/password_manager/core/browser/password_generation_manager_unittest.cc
[modify] https://crrev.com/08b0049ac7f3ef05fe4e4c5c7d7b5c191b6d8602/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/08b0049ac7f3ef05fe4e4c5c7d7b5c191b6d8602/components/password_manager/core/browser/password_manager_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af41898ce19d1ab8c4139ac36d220c23e4cf919b

commit af41898ce19d1ab8c4139ac36d220c23e4cf919b
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Fri Oct 06 11:45:56 2017

[Password Manager] Add UMA historgam for username correction uploads

Bug: 699530
Change-Id: I1327c3d367626c17125c080b374091877a66ae00
Reviewed-on: https://chromium-review.googlesource.com/702455
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507032}
[modify] https://crrev.com/af41898ce19d1ab8c4139ac36d220c23e4cf919b/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/af41898ce19d1ab8c4139ac36d220c23e4cf919b/components/password_manager/core/browser/password_form_manager.h
[modify] https://crrev.com/af41898ce19d1ab8c4139ac36d220c23e4cf919b/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/af41898ce19d1ab8c4139ac36d220c23e4cf919b/components/password_manager/core/browser/password_form_metrics_recorder.cc
[modify] https://crrev.com/af41898ce19d1ab8c4139ac36d220c23e4cf919b/components/password_manager/core/browser/password_form_metrics_recorder.h
[modify] https://crrev.com/af41898ce19d1ab8c4139ac36d220c23e4cf919b/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/af41898ce19d1ab8c4139ac36d220c23e4cf919b/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41c0196d6fa13c8d8d87fa840b306da752f2bc4d

commit 41c0196d6fa13c8d8d87fa840b306da752f2bc4d
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Fri Oct 20 12:34:06 2017

[Password Manager] Run HTML based username detector only once per form

The HTML based username detector is time-consuming. This CL introduce caching for results.

Bug: 699530
Change-Id: I3bc0e221475de98781ea9dfcdb714147c981dc27
Reviewed-on: https://chromium-review.googlesource.com/719008
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510411}
[modify] https://crrev.com/41c0196d6fa13c8d8d87fa840b306da752f2bc4d/components/autofill/content/renderer/html_based_username_detector.cc
[modify] https://crrev.com/41c0196d6fa13c8d8d87fa840b306da752f2bc4d/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

I think that we should revert the last CL because it leaks memory.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/556ce692c6002c2f86912230c296181d0547d34e

commit 556ce692c6002c2f86912230c296181d0547d34e
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Fri Oct 20 20:08:01 2017

Revert "[Password Manager] Run HTML based username detector only once per form"

This reverts commit 41c0196d6fa13c8d8d87fa840b306da752f2bc4d.

Reason for revert: The CL introduced a memory leak. The feature is behind a flag, but to be pretty sure that it wouldn't cause any problems, I will revert this CL.

Original change's description:
> [Password Manager] Run HTML based username detector only once per form
> 
> The HTML based username detector is time-consuming. This CL introduce caching for results.
> 
> Bug: 699530
> Change-Id: I3bc0e221475de98781ea9dfcdb714147c981dc27
> Reviewed-on: https://chromium-review.googlesource.com/719008
> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
> Reviewed-by: Vaclav Brozek <vabr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#510411}

TBR=vabr@chromium.org,kolos@chromium.org

Change-Id: I85c758fc8113d4b4a84324ae95c91d4d1d7b7ff5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 699530
Reviewed-on: https://chromium-review.googlesource.com/731045
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510536}
[modify] https://crrev.com/556ce692c6002c2f86912230c296181d0547d34e/components/autofill/content/renderer/html_based_username_detector.cc
[modify] https://crrev.com/556ce692c6002c2f86912230c296181d0547d34e/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

TODO: consider aria-label in InferLabelForElement

This would be a great improvement. Also, aria-hidden is not taken into account I believe. Don't want to hijack the bug :)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19ce5e33a0c8a680ee50ca871dff84068a2438c9

commit 19ce5e33a0c8a680ee50ca871dff84068a2438c9
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Thu Nov 09 15:32:23 2017

[Password Manager] Run HTML based username detector only once per form (V 2.0)

The HTML based username detector is time-consuming. This CL introduce caching for results.

Cache is implemented as a field of PasswordAutofillAgent.

Bug: 699530
Change-Id: I7ec4e787cde66e5ff8c9067d7d9c73a90cae7b0a
Reviewed-on: https://chromium-review.googlesource.com/753735
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515174}
[modify] https://crrev.com/19ce5e33a0c8a680ee50ca871dff84068a2438c9/components/autofill/content/renderer/html_based_username_detector.cc
[modify] https://crrev.com/19ce5e33a0c8a680ee50ca871dff84068a2438c9/components/autofill/content/renderer/html_based_username_detector.h
[modify] https://crrev.com/19ce5e33a0c8a680ee50ca871dff84068a2438c9/components/autofill/content/renderer/password_autofill_agent.cc
[modify] https://crrev.com/19ce5e33a0c8a680ee50ca871dff84068a2438c9/components/autofill/content/renderer/password_autofill_agent.h
[modify] https://crrev.com/19ce5e33a0c8a680ee50ca871dff84068a2438c9/components/autofill/content/renderer/password_form_conversion_utils.cc
[modify] https://crrev.com/19ce5e33a0c8a680ee50ca871dff84068a2438c9/components/autofill/content/renderer/password_form_conversion_utils.h
[modify] https://crrev.com/19ce5e33a0c8a680ee50ca871dff84068a2438c9/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
[modify] https://crrev.com/19ce5e33a0c8a680ee50ca871dff84068a2438c9/components/autofill/content/renderer/password_generation_agent.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7284655c756c514c36591407443606cc770619ba

commit 7284655c756c514c36591407443606cc770619ba
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Fri Dec 01 19:36:55 2017

[Password Manager] Polishing HTML based Username Detector


Bug: 699530
Change-Id: I6325ed2be5868d519c5b0d0cb720d09e7b80da4d
Reviewed-on: https://chromium-review.googlesource.com/759792
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521018}
[modify] https://crrev.com/7284655c756c514c36591407443606cc770619ba/components/autofill/content/renderer/BUILD.gn
[modify] https://crrev.com/7284655c756c514c36591407443606cc770619ba/components/autofill/content/renderer/html_based_username_detector.cc
[modify] https://crrev.com/7284655c756c514c36591407443606cc770619ba/components/autofill/content/renderer/html_based_username_detector.h
[add] https://crrev.com/7284655c756c514c36591407443606cc770619ba/components/autofill/content/renderer/html_based_username_detector_vocabulary.cc
[add] https://crrev.com/7284655c756c514c36591407443606cc770619ba/components/autofill/content/renderer/html_based_username_detector_vocabulary.h
[modify] https://crrev.com/7284655c756c514c36591407443606cc770619ba/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

www.openstreetmap.org and www.mintos.com/en/investor-registration/: will be fixed after https://chromium-review.googlesource.com/c/chromium/src/+/808865

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e8836a8b55a06124a600edb059f50c381e6ed34

commit 6e8836a8b55a06124a600edb059f50c381e6ed34
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Wed Dec 27 15:02:22 2017

[Password Manager] Enabling HTML based classifier and final fixes

Bug: 699530
Change-Id: I67069a9923740941c834f22156e5f97b12608144
Reviewed-on: https://chromium-review.googlesource.com/808865
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526222}
[modify] https://crrev.com/6e8836a8b55a06124a600edb059f50c381e6ed34/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
[modify] https://crrev.com/6e8836a8b55a06124a600edb059f50c381e6ed34/components/autofill/content/renderer/html_based_username_detector.cc
[modify] https://crrev.com/6e8836a8b55a06124a600edb059f50c381e6ed34/components/autofill/content/renderer/html_based_username_detector.h
[modify] https://crrev.com/6e8836a8b55a06124a600edb059f50c381e6ed34/components/autofill/content/renderer/password_form_conversion_utils.cc
[modify] https://crrev.com/6e8836a8b55a06124a600edb059f50c381e6ed34/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
[modify] https://crrev.com/6e8836a8b55a06124a600edb059f50c381e6ed34/components/password_manager/core/common/password_manager_features.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3692a35a5f1f4454443a8acfc8d6f56b317e98cc

commit 3692a35a5f1f4454443a8acfc8d6f56b317e98cc
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Tue Jan 09 19:44:27 2018

[Password Manager] Several fixes for username votes uploading

1) Don't save empty values to |PasswordForm.other_possible_usernames|
2) If the username value is empty, don't upload any username votes.
3) If the username value edited in a prompt has no match with another field of the form, |PasswordForm.username_element| should be empty.
4) Trim whitespaces in the username value typed in a prompt.
5) Don't trust server-side prediction of username field, if the prediction points to an empty field.
6) DCHECKs that |username_vote_type| cannot be |No_INFORMATION| if the autofill type is |USERNAME|.

Bug: 674151, 699530
Change-Id: I72d120a30fff14de77df1898710e28874318c290
Reviewed-on: https://chromium-review.googlesource.com/817276
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528073}
[modify] https://crrev.com/3692a35a5f1f4454443a8acfc8d6f56b317e98cc/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
[modify] https://crrev.com/3692a35a5f1f4454443a8acfc8d6f56b317e98cc/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
[modify] https://crrev.com/3692a35a5f1f4454443a8acfc8d6f56b317e98cc/components/autofill/content/renderer/password_form_conversion_utils.cc
[modify] https://crrev.com/3692a35a5f1f4454443a8acfc8d6f56b317e98cc/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
[modify] https://crrev.com/3692a35a5f1f4454443a8acfc8d6f56b317e98cc/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/3692a35a5f1f4454443a8acfc8d6f56b317e98cc/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/3692a35a5f1f4454443a8acfc8d6f56b317e98cc/components/password_manager/core/browser/password_form_manager.h
[modify] https://crrev.com/3692a35a5f1f4454443a8acfc8d6f56b317e98cc/components/password_manager/core/browser/password_form_manager_unittest.cc