New issue
Advanced search Search tips

Issue 699529 link

Starred by 7 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task


Sign in to add a comment

[Password Generation] [META] The format of generated passwords (site-wise)

Project Member Reported by kolos@chromium.org, Mar 8 2017

Issue description

This is a meta bug to collect various issues on the format of generated passwords.
 

Comment 1 by kolos@chromium.org, Mar 8 2017

Cc: sabineb@chromium.org kolos@chromium.org
Issue 686945 has been merged into this issue.

Comment 2 by kolos@chromium.org, Mar 8 2017

Issue 120478 has been merged into this issue.

Comment 3 by kolos@chromium.org, Mar 8 2017

Issue 120791 has been merged into this issue.

Comment 4 by kolos@chromium.org, Mar 9 2017

Cc: vabr@chromium.org melandory@chromium.org
 Issue 532949  has been merged into this issue.

Comment 5 by kolos@chromium.org, Mar 9 2017

Issue 546044 has been merged into this issue.

Comment 6 by kolos@chromium.org, Mar 9 2017

Summary: [Password Generation] [META] The format of generated passwords (site-wise) (was: [Password Generation] [Meta] The format of generated passwords (site-wise))

Comment 7 by vabr@chromium.org, Mar 14 2017

Labels: tracking_work

Comment 8 by kolos@chromium.org, Mar 15 2017

Blocking: 686945

Comment 9 by kolos@chromium.org, Mar 15 2017

Blocking: 546044 532949 120478 120791

Comment 10 by vabr@chromium.org, May 2 2017

Labels: -tracking_work Type-Task

Comment 11 by kolos@chromium.org, Jun 14 2017

Owner: kolos@chromium.org
Status: Assigned (was: Available)
I analyzed the current set of blocked bugs:
* On shutterfly.com, the site limited the length of passwords and saved truncated password, but Chrome saved the generated password. Now the site uses “max-length” attribute, Chrome takes it into account. So, it is ok. 
* creditkarma.ca requires a special symbol. It is probably the most common failure. 
* Optional: do consider "pattern" attribute as well. Supporting all possible patterns may complicate password generator implementation. 

The plan is the following:
1. Add flag that indicates whether user edited generated password.
2. Check the sites where many edits happen. Are there problems with length, special symbols or something else?
(3) Optional: Collect more detailed data about edits (changed length, special symbols, etc.). 
4. Implement server-side processing of data collected at (1) and (3) and propagate the outcome to the client side.
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5257dd237f1d169b88719b16c2e76682828b35c0

commit 5257dd237f1d169b88719b16c2e76682828b35c0
Author: kolos <kolos@chromium.org>
Date: Wed Jun 21 15:21:17 2017

[Password Generation] Send a boolean flag of whether user changed generated password

The flag helps to find the sites where passwords generated by Chrome doesn't meet site's requirements

BUG=699529

Review-Url: https://codereview.chromium.org/2937033002
Cr-Commit-Position: refs/heads/master@{#481210}

[modify] https://crrev.com/5257dd237f1d169b88719b16c2e76682828b35c0/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc
[modify] https://crrev.com/5257dd237f1d169b88719b16c2e76682828b35c0/chrome/browser/ui/autofill/password_generation_popup_controller_impl.h
[modify] https://crrev.com/5257dd237f1d169b88719b16c2e76682828b35c0/chrome/browser/ui/autofill/password_generation_popup_view_browsertest.cc
[modify] https://crrev.com/5257dd237f1d169b88719b16c2e76682828b35c0/components/autofill/content/renderer/password_generation_agent.cc
[modify] https://crrev.com/5257dd237f1d169b88719b16c2e76682828b35c0/components/autofill/core/browser/autofill_field.h
[modify] https://crrev.com/5257dd237f1d169b88719b16c2e76682828b35c0/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/5257dd237f1d169b88719b16c2e76682828b35c0/components/autofill/core/browser/form_structure_unittest.cc
[modify] https://crrev.com/5257dd237f1d169b88719b16c2e76682828b35c0/components/autofill/core/browser/proto/server.proto
[modify] https://crrev.com/5257dd237f1d169b88719b16c2e76682828b35c0/components/password_manager/content/browser/content_password_manager_driver.cc
[modify] https://crrev.com/5257dd237f1d169b88719b16c2e76682828b35c0/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/5257dd237f1d169b88719b16c2e76682828b35c0/components/password_manager/core/browser/password_form_manager.h
[modify] https://crrev.com/5257dd237f1d169b88719b16c2e76682828b35c0/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/5257dd237f1d169b88719b16c2e76682828b35c0/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/5257dd237f1d169b88719b16c2e76682828b35c0/components/password_manager/core/browser/password_manager.h
[modify] https://crrev.com/5257dd237f1d169b88719b16c2e76682828b35c0/components/password_manager/core/browser/password_manager_unittest.cc
[modify] https://crrev.com/5257dd237f1d169b88719b16c2e76682828b35c0/ios/chrome/browser/passwords/password_generation_agent.mm

Labels: meta-bug
Blockedon: 783099
Project Member

Comment 16 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebb4446d476d15e362379d5db96f5450f2b94aec

commit ebb4446d476d15e362379d5db96f5450f2b94aec
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Tue May 29 14:38:28 2018

[Password Generation] Add UMA metric for generated password editing

Let's measure how frequently users need to edit the generated passwords

Bug: 699529
Change-Id: I69091b2fe724533ceef943d8abc26a03d220d836
Reviewed-on: https://chromium-review.googlesource.com/1075888
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562419}
[modify] https://crrev.com/ebb4446d476d15e362379d5db96f5450f2b94aec/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/ebb4446d476d15e362379d5db96f5450f2b94aec/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/ebb4446d476d15e362379d5db96f5450f2b94aec/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/ebb4446d476d15e362379d5db96f5450f2b94aec/tools/metrics/histograms/histograms.xml

Labels: Merge-Rejected-68
We would like measure the number of edits of generated passwords. In M69, we introduce mechanism to adjust passwords based on sites' requirements. We need to see the difference.
Labels: -Merge-Rejected-68 Merge-Request-68
Project Member

Comment 19 by sheriffbot@chromium.org, Jun 2 2018

Labels: -Merge-Request-68 Hotlist-Merge-Approved Merge-Approved-68
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 20 by bugdroid1@chromium.org, Jun 2 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7be7837d30f70f894de02b06b0a993fcefd4abe0

commit 7be7837d30f70f894de02b06b0a993fcefd4abe0
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Sat Jun 02 06:33:37 2018

[Password Generation] Add UMA metric for generated password editing

Let's measure how frequently users need to edit the generated passwords

Bug: 699529
Change-Id: I69091b2fe724533ceef943d8abc26a03d220d836
Reviewed-on: https://chromium-review.googlesource.com/1075888
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562419}(cherry picked from commit ebb4446d476d15e362379d5db96f5450f2b94aec)
Reviewed-on: https://chromium-review.googlesource.com/1084111
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#117}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/7be7837d30f70f894de02b06b0a993fcefd4abe0/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/7be7837d30f70f894de02b06b0a993fcefd4abe0/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/7be7837d30f70f894de02b06b0a993fcefd4abe0/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/7be7837d30f70f894de02b06b0a993fcefd4abe0/tools/metrics/histograms/histograms.xml

Cc: -vabr@chromium.org
vabr going hobby only -> reducing involvement.
Please contact me directly in urgent matters.

Sign in to add a comment