New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699518 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Not on Chrome anymore
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Implement PrintBrowser on SPV1

Project Member Reported by nainar@chromium.org, Mar 8 2017

Issue description

Currently PrintBrowser is implemented only on SPV2 and should be ported over to SPV1. 

CL for SPV2 here: https://codereview.chromium.org/2672983003

Design Doc here: https://docs.google.com/document/d/1G2RoH7yiwh_vosEHsHTwqETBvt2ij8p9ov0D3kIz4ww/edit
 
Labels: BugSource-Chromium PaintTeamTriaged-20170308
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aca9ff5295e91d1bba92e50285bf1ee2893de5e4

commit aca9ff5295e91d1bba92e50285bf1ee2893de5e4
Author: nainar <nainar@chromium.org>
Date: Sun Apr 16 00:38:38 2017

Move PrintBrowser from SPV2 to SPV1

This patch removed the dependancy of PrintBrowser on SPV2 and moves it
over to stable SPV1.

CL for SPV2 here: https://codereview.chromium.org/2672983003

Design Doc here: https://docs.google.com/document/d/1G2RoH7yiwh_vosEHsHTwqETBvt2ij8p9ov0D3kIz4ww/edit

BUG= 699518 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2802903002
Cr-Commit-Position: refs/heads/master@{#464875}

[modify] https://crrev.com/aca9ff5295e91d1bba92e50285bf1ee2893de5e4/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/aca9ff5295e91d1bba92e50285bf1ee2893de5e4/third_party/WebKit/Source/core/paint/TextPainter.cpp
[modify] https://crrev.com/aca9ff5295e91d1bba92e50285bf1ee2893de5e4/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5

Comment 3 by nainar@chromium.org, Apr 16 2017

Status: Fixed (was: Available)
Hi folks. Moved this over to SPV1 let me know if any new issues arise due to this. Please do so by filing new bugs and adding me as Owner. The component should be PrintBrowser (won't autocomplete)

Sign in to add a comment