New issue
Advanced search Search tips

Issue 699491 link

Starred by 6 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Division by 0 in opj_int_ceildiv

Project Member Reported by ClusterFuzz, Mar 8 2017

Issue description

Cc: dsinclair@chromium.org
Components: Internals>Plugins>PDF
Labels: Test-Predator-Wrong M-59
Owner: npm@chromium.org
Status: Assigned (was: Untriaged)
npm@, could you please take a look?.
Thank you
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/9818dc150132ac04148174258423e394eb0948b9

commit 9818dc150132ac04148174258423e394eb0948b9
Author: Nicolas Pena <npm@chromium.org>
Date: Mon Mar 13 18:05:22 2017

LibopenJPEG: Fix some divisions by 0 in pi.c

The undefined shifts in libopenjpeg are sometimes used as divisors. This CL
checks that we are not trying to divide by 0 or mod by 0 in some places in
pi.c.

BUG= chromium:699491 

Change-Id: Iaf629112437068d6479dbbb52b339bec6edefed0
Reviewed-on: https://pdfium-review.googlesource.com/2962
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Nicolás Peña <npm@chromium.org>

[add] https://crrev.com/9818dc150132ac04148174258423e394eb0948b9/third_party/libopenjpeg20/0029-avoid-division-by-0.patch
[modify] https://crrev.com/9818dc150132ac04148174258423e394eb0948b9/third_party/libopenjpeg20/pi.c
[modify] https://crrev.com/9818dc150132ac04148174258423e394eb0948b9/third_party/libopenjpeg20/README.pdfium

Comment 3 by npm@chromium.org, Mar 13 2017

Status: Fixed (was: Assigned)
Summary: Division by 0 in opj_int_ceildiv (was: b)
b does not say much
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a179639e0748a31beeefad1801ab727d7c11fed5

commit a179639e0748a31beeefad1801ab727d7c11fed5
Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org>
Date: Mon Mar 13 21:18:51 2017

Roll src/third_party/pdfium/ 8f03b422e..9818dc150 (3 commits)

https://pdfium.googlesource.com/pdfium.git/+log/8f03b422ed85..9818dc150132

$ git log 8f03b422e..9818dc150 --date=short --no-merges --format='%ad %ae %s'
2017-03-13 npm LibopenJPEG: Fix some divisions by 0 in pi.c
2017-03-13 dsinclair Replace discrete array with a map.
2017-03-13 dsinclair Convert TxtBreak line pieces to a vector.

Created with:
  roll-dep src/third_party/pdfium
BUG= 699491 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2751473002
Cr-Commit-Position: refs/heads/master@{#456485}

[modify] https://crrev.com/a179639e0748a31beeefad1801ab727d7c11fed5/DEPS

Cc: och...@chromium.org
 Issue 644628  has been merged into this issue.
Project Member

Comment 7 by ClusterFuzz, Sep 13 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5700362172628992 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment