Regression: Tip of colour picker window is not centre aligned in devtools |
||||
Issue descriptionChrome Version: 59.0.3034.0 dev OS: Linux,Windows What steps will reproduce the problem? (1)Launch chrome,go to chrome://apps and open devtools (2)Click on colour in styles section of elements tab to open colour picker window and observe tip of it Expected: Colour picker should be centre aligned. Actual: Instead it is seen on right end. This is a regression issue broken in M59. Good Build: 59.0.3033.0 dev Bad Build: 59.0.3034.0 dev
,
Mar 8 2017
Using the normal bisect providing the bisect results, Good build:59.0.3033.0 (Revision: 455023). Bad build:59.0.3034.0 (Revision: 455336). You are probably looking for a change made after 455292 (known good), but no later than 455303 (first known bad). CHANGE-LOG URL: --------------- https://chromium.googlesource.com/chromium/src/+log/8db99b6d494c3b357108a3ba82c9ad52689615e5..3aa23b6bd85fa5bb3b96e23fb08f1d400a75747e From the CL above, assigning the issue to the concern owner @dgozman : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Review-Url:https://codereview.chromium.org/2712063002 Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #58.0.3034.0 Unable to given the per revision bisect due to all good builds are coming.So providing the normal bisect.
,
Mar 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2d78373f7f7b3e71c3f08707d7d0a27c082de1d commit c2d78373f7f7b3e71c3f08707d7d0a27c082de1d Author: dgozman <dgozman@chromium.org> Date: Thu Mar 09 01:22:48 2017 [DevTools] Adjust popover position so accomodate for arrow. When there is enough space we can move popover so that arrow points to the middle of anchor box (as opposite to the side). BUG= 699489 Review-Url: https://codereview.chromium.org/2742503002 Cr-Commit-Position: refs/heads/master@{#455622} [modify] https://crrev.com/c2d78373f7f7b3e71c3f08707d7d0a27c082de1d/third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js
,
Mar 9 2017
,
Mar 17 2017
Tested the issue on Windows-7,Mac-10.12.3 and Linux Ubuntu-14.04 using chrome version#59.0.3043.0 with the steps mentioned in comment#0. Observed that the fix is working as expected. Hence adding TE-Verified labels. Please find the attached screen cast for the same. Thanks!! |
||||
►
Sign in to add a comment |
||||
Comment 1 by durga.behera@chromium.org
, Mar 8 2017