Regression:Font size drop down list is not properly aligned in Md-settings page. |
||||||
Issue descriptionChrome Version:59.0.3034.0 dev OS:Ubuntu 14.04,Windows What steps will reproduce the problem? (1)Launch chrome and go to chrome://md-settings page (2)Navigate to Appearance>>Font size>>Click on the drop down and Observe the menu list (kindly refer video) Actual Result :Drop down list is not aligned properly. Expected Result:Drop down list should be properly aligned. This is regression issue broken in 'M 59' Manual Bisect Info: ===================== Good Build:59.0.3033.0 Bad Build :59.0.3034.0
,
Mar 8 2017
Using the per-revision bisect providing the bisect results, Good build:59.0.3033.0 (Revision: 455023). Bad build:59.0.3034.0 (Revision: 455336). You are probably looking for a change made after 455245 (known good), but no later than 455246 (first known bad). CHANGE-LOG URL: --------------- https://chromium.googlesource.com/chromium/src/+log/efcd0c614acac68022267a2eb1af6519353906fb..95dec86ee4d37aaef13df66737e46a93c669907a From the CL above, assigning the issue to the concern owner @dschuyler : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Review-Url:https://codereview.chromium.org/2728683004 Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #58.0.3034.0
,
Mar 8 2017
FYI I also mentioned this at https://bugs.chromium.org/p/chromium/issues/detail?id=654323#c11. The margin an settings-dropdown-menu should be changed to padding.
,
Mar 8 2017
,
Mar 8 2017
,
Mar 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27e9e232d7a4b8c3e255925093f51d8de8fcf63e commit 27e9e232d7a4b8c3e255925093f51d8de8fcf63e Author: dschuyler <dschuyler@chromium.org> Date: Thu Mar 09 02:17:18 2017 [MD settings] keep dropdown menu same width when adding indicator This CL moves the spacing around a controlled-by indicator to the indictor itself, so that the width of the dropdown menu no longer changes. BUG= 699486 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2732213007 Cr-Commit-Position: refs/heads/master@{#455641} [modify] https://crrev.com/27e9e232d7a4b8c3e255925093f51d8de8fcf63e/chrome/browser/resources/settings/controls/settings_dropdown_menu.html
,
Mar 9 2017
,
Mar 17 2017
Tested the issue on Windows-10, Ubuntu 14.04 and Mac OS 10.12.3 using chrome latest Dev M59-59.0.3043.0 by following steps mentioned in the original comment. Observed that Drop down list aligned properly and displaying as expected. Hence adding TE-Verified label. Please find the screen shot for reference. Thank you! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by kavvaru@chromium.org
, Mar 8 2017Status: Untriaged (was: Unconfirmed)