New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699485 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Crash in NumberToSize

Project Member Reported by ClusterFuzz, Mar 8 2017

Issue description

Components: Blink>JavaScript
Labels: Test-Predator-Wrong M-59
Cc: bradnelson@chromium.org
Owner: ahaas@chromium.org
Status: Assigned (was: Untriaged)
Crash in WebAssembly while growing memory. Report generated by WebAssembly fuzzer.

Comment 3 by ahaas@chromium.org, Mar 21 2017

Cc: ahaas@chromium.org
Owner: gdeepti@chromium.org
Hi Deepti,
this crash seems GrowMemory related, can you take a look?

I was able to reproduce it both with the v8-wasm-fuzzer. I tried to create an mjsunit test by using --wasm-code-fuzzer-gen-test and combine the output with an existing regression test, but that failed, so maybe something in the module header has influence on the bug.
Cheers, Andreas
Status: Started (was: Assigned)
Status: Fixed (was: Started)
Labels: Merge-Request-58
Added Merge Request to 58, because this patch fixes a customer-observed failure: Autodesk's Stingray project crashes without it. (https://autodesk.box.com/s/8pezgbd6o090lj7lftr0ktswiz0d0i6f)

Verified by cherry-picking this CL onto Chrome 58 (v8 5.8.283.1)
Project Member

Comment 9 by sheriffbot@chromium.org, Apr 22 2017

Labels: -Merge-Request-58 Merge-Review-58 Hotlist-Merge-Review
This bug requires manual review: We are only 2 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: mtrofin@chromium.org gdeepti@chromium.org
 Issue v8:6289  has been merged into this issue.
Cc: hablich@chromium.org
+hablich@ for M58 merge review. Please note M58 is already in stable and we're only taking absolutely critical and safe CL for next M58 refresh if any. 
Labels: -Merge-Review-58 Merge-Approved-58
Safe (only WASM) and fixes a real world use-case.
Labels: OS-Android OS-Chrome OS-Mac OS-Windows
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 24 2017

Labels: merge-merged-5.8
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/ed5c5a6b0450e980191dac58222574c824822e63

commit ed5c5a6b0450e980191dac58222574c824822e63
Author: Deepti Gandluri <gdeepti@google.com>
Date: Mon Apr 24 23:07:18 2017

Merged: [wasm] Detach memory buffer only when GrowMemory is called from the JS API

Revision: c8b2656622faff4d0ee53c251c859deaa87f7e7a

BUG= chromium:699485 
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=bradnelson@chromium.org, mtrofin@chromium.org

Change-Id: I53a4a81cf592d05974e621f602d7a5814ed21d06
Reviewed-on: https://chromium-review.googlesource.com/486125
Reviewed-by: Brad Nelson <bradnelson@chromium.org>
Cr-Commit-Position: refs/branch-heads/5.8@{#71}
Cr-Branched-From: eda659cc5e307f20ac1ad542ba12ab32eaf4c7ef-refs/heads/5.8.283@{#1}
Cr-Branched-From: 4310cd02d2160b1457baed81a2f40063eb264a21-refs/heads/master@{#43429}
[modify] https://crrev.com/ed5c5a6b0450e980191dac58222574c824822e63/src/wasm/wasm-js.cc
[modify] https://crrev.com/ed5c5a6b0450e980191dac58222574c824822e63/src/wasm/wasm-module.cc
[modify] https://crrev.com/ed5c5a6b0450e980191dac58222574c824822e63/src/wasm/wasm-module.h
[add] https://crrev.com/ed5c5a6b0450e980191dac58222574c824822e63/test/mjsunit/regress/wasm/regression-699485.js

Project Member

Comment 15 by sheriffbot@chromium.org, Apr 27 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-58
Removing "Merge-Approved-58" label as change is already merged to M58 at #14.

per hablich@, this merge is fine because customer issue and it affects only wasm and it is baked for a long time.
Labels: -Hotlist-Merge-Review

Sign in to add a comment