New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699469 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 693640
issue v8:6062

Blocking:
issue v8:4743
issue 719963



Sign in to add a comment

Upgrade ICU to 59

Project Member Reported by js...@chromium.org, Mar 8 2017

Issue description

ICU 59 will be released in a few weeks. 

Filing now to track prep steps. 
 

Comment 1 by js...@chromium.org, Mar 8 2017

Blockedon: v8:6062

Comment 2 by js...@chromium.org, Mar 10 2017

Also blocked by two goma issues:

b/36108313 and b/36108653  

Somehow, goma hates ICU 59.x .......  

Comment 3 by js...@chromium.org, Apr 17 2017

Cc: js...@chromium.org adamk@chromium.org jgruber@chromium.org math...@qiwi.be
 Issue 711901  has been merged into this issue.

Comment 4 by js...@chromium.org, Apr 17 2017

Blocking: v8:4743

Comment 5 by js...@chromium.org, May 9 2017

https://codereview.chromium.org/2873603002 is a CL to test ICU 59.1 before actually rolling. 

https://chromium.googlesource.com/chromium/deps/icu/+log/chromium/59staging : ICU 59 staging branch. 

Commits in that branch will be cherry-picked in master. 

Comment 6 by drott@chromium.org, May 9 2017

Blocking: 719963

Comment 7 by drott@chromium.org, May 9 2017

Cc: drott@chromium.org

Comment 8 by drott@chromium.org, May 9 2017

Thanks for working on this, Jungshik. I just tested the CLs and the newly generated emoji test case in https://codereview.chromium.org/2870093002. I built the preliminary CLs with goma on Mac without problems, and the test succeeds.

Comment 9 by js...@chromium.org, May 9 2017

Labels: -Pri-3 Pri-2
Thanks, Dominik, for testing. As soon as bug V8:6062 is fixed again, I'll be ready barring new issues (test failures etc).
Project Member

Comment 10 by bugdroid1@chromium.org, May 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/deps/icu.git/+/87232d8d763692d4b8303f0194472a82c829a6a9

commit 87232d8d763692d4b8303f0194472a82c829a6a9
Author: Jungshik Shin <jshin@chromium.org>
Date: Sun May 14 04:10:56 2017

Update ICU to 59.1

* Highlights:
  - Emoji 5.0 data (partial; Emoji_Component property not included)
  - CLDR 31.0.1 (http://blog.unicode.org/2017/03/cldr-version-31-released.html)
    UTC and GMT are treated as distinct)
  - New case mapping API for styled text
  - C++ 11 is required
  - char16_t for UChar (UTF-16)
  - Source code is in UTF-8

* Size changes

  common: 10,130,560 => 10,175,056
  android: 6,573,872 => 6,616,864
  iOS: 6,562,352 => 6,605,152

On top of ICU 59.1 from the upstream, the following changes were applied.
See https://chromium.googlesource.com/chromium/deps/icu/+log/chromium/59staging

  - Fix C++ 11 string literal assignment issue (upstream bug:  13192 )
  - Fix C4229 warning by MSVC
  - Apply utf32.patch and include unistr.h in fuzzer_util
  - Update ICU data files
  - Fix wpo.patch
  - Apply Google locale patch and locale1.patch
  - update readme
  - Apply breakiterator related patches
  - Apply and update wpo.patch
  - Drop unused patch, apply data.build.win.patch, update README.chromium
  - Add /utf-8 flag for Windows/Visual Studio
  - Update BUILD.gn for UChar, stubdata and apply data_sym.patch
  - use stubdata.cpp instead of stubdata.c in icu.gyp
  - Update icu.gyp* files for v8
  - Update BUILD.gn, apply data.build.patch and vscomp.patch
  - Add new files in ICU 59.1
  - Get a fresh copy of ICU 59.1 from the upstream
  - Update update.sh script

TBR=drott@chromium.org, yangguo@chromium.org
Bug:699469
TEST: layout tests, all unittests, browser tests
Change-Id: Ie1e77323aa0c7f872153680c4deca6471a771a5c
Reviewed-on: https://chromium-review.googlesource.com/505173
Reviewed-by: Jungshik Shin <jshin@chromium.org>

[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/APIChangeReport.html
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/BUILD.gn
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/LICENSE
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/README.chromium
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/android/icudtl.dat
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/common/icudtb.dat
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/common/icudtl.dat
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/fuzzers/fuzzer_utils.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/icu.gyp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/icu.gypi
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/ios/icudtl.dat
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/license.html
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/patches/data.build.win.patch
[delete] https://crrev.com/4b06aadd0556135d3a90a4eb03eca24ef249e03e/patches/digilist.patch
[delete] https://crrev.com/4b06aadd0556135d3a90a4eb03eca24ef249e03e/patches/greek_upper.patch
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/patches/locale_google.patch
[add] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/patches/msvc4229.patch
[delete] https://crrev.com/4b06aadd0556135d3a90a4eb03eca24ef249e03e/patches/scriptset.patch
[add] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/patches/string_literal_charptr.patch
[delete] https://crrev.com/4b06aadd0556135d3a90a4eb03eca24ef249e03e/patches/uspoof.patch
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/patches/utf32.patch
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/patches/vscomp.patch
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/patches/wordbrk.patch
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/patches/wpo.patch
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/readme.html
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/scripts/update.sh
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/Doxyfile.in
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/Makefile.in
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/Makefile.in
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/appendable.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/bmpset.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/bmpset.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/brkeng.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/brkeng.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/brkiter.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/bytestream.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/bytestrie.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/bytestriebuilder.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/bytestrieiterator.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/caniter.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/chariter.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/charstr.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/charstr.h
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/cmemory.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/cmemory.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/cpputils.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/cstr.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/cstr.h
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/cstring.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/cstring.h
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/cwchar.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/cwchar.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/dictbe.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/dictbe.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/dictionarydata.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/dictionarydata.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/dtintrv.cpp
[add] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/edits.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/errorcode.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/filteredbrk.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/filterednormalizer2.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/hash.h
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/icudataver.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/icuplug.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/icuplugimp.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/listformatter.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/loadednormalizer2impl.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/localsvc.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/locavailable.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/locbased.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/locbased.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/locdispnames.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/locdspnm.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/locid.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/loclikely.cpp
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/locmap.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/locmap.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/locresdata.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/locutil.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/locutil.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/messageimpl.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/messagepattern.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/msvcres.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/mutex.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/norm2_nfc_data.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/norm2allmodes.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/normalizer2.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/normalizer2impl.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/normalizer2impl.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/normlzr.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/parsepos.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/patternprops.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/patternprops.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/pluralmap.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/pluralmap.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/propname.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/propname.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/propname_data.h
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/propsvec.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/propsvec.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/punycode.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/punycode.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/putil.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/putilimp.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/rbbi.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/rbbidata.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/rbbidata.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/rbbinode.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/rbbinode.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/rbbirb.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/rbbirb.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/rbbirpt.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/rbbiscan.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/rbbiscan.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/rbbisetb.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/rbbisetb.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/rbbistbl.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/rbbitblb.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/rbbitblb.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/resbund.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/resbund_cnv.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/resource.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/resource.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ruleiter.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ruleiter.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/schriter.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/serv.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/serv.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/servlk.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/servlkf.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/servloc.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/servls.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/servnotf.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/servnotf.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/servrbf.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/servslkf.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/sharedobject.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/sharedobject.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/simpleformatter.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/sprpimpl.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/stringpiece.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/stringtriebuilder.cpp
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/uarrsort.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/uarrsort.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/uassert.h
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ubidi.cpp
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ubidi_props.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ubidi_props.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ubidi_props_data.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ubidiimp.h
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ubidiln.cpp
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ubiditransform.cpp
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ubidiwrt.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ubrk.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ubrkimpl.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucase.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucase.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucase_props_data.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucasemap.cpp
[add] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucasemap_imp.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucasemap_titlecase_brkiter.cpp
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucat.cpp
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/uchar.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/uchar_props_data.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucharstrie.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucharstriebuilder.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucharstrieiterator.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/uchriter.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucln.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucln_cmn.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucln_cmn.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucln_imp.h
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucmndata.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucmndata.h
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnv.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnv2022.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnv_bld.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnv_bld.h
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnv_cb.cpp
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnv_cnv.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnv_cnv.h
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnv_ct.cpp
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnv_err.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnv_ext.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnv_ext.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnv_imp.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnv_io.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnv_io.h
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnv_lmb.cpp
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnv_set.cpp
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnv_u16.cpp
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnv_u32.cpp
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnv_u7.cpp
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnv_u8.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnvbocu.cpp
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnvdisp.cpp
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnvhz.cpp
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnvisci.cpp
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnvlat1.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnvmbcs.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnvmbcs.h
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnvscsu.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucnvsel.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucol_data.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucol_swp.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucol_swp.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucurr.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ucurrimp.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/udata.cpp
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/udatamem.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/udatamem.h
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/udataswp.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/udataswp.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/uelement.h
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/uenum.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/uenumimp.h
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/uhash.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/uhash.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/uhash_us.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/uidna.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/uinit.cpp
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/uinvchar.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/uinvchar.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/uiter.cpp
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ulist.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ulist.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ulistformatter.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/uloc.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/uloc_keytype.cpp
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/uloc_tag.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/ulocimp.h
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/umapfile.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/umapfile.h
[rename] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/umath.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/umutex.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/umutex.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/unames.cpp
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/unicode/appendable.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/unicode/brkiter.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/unicode/bytestream.h
[modify] https://crrev.com/87232d8d763692d4b8303f0194472a82c829a6a9/source/common/unicode/bytestrie.h
[modify] http
Project Member

Comment 11 by bugdroid1@chromium.org, May 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee36babf91a54379889370cdd207e818555acb5d

commit ee36babf91a54379889370cdd207e818555acb5d
Author: jshin <jshin@chromium.org>
Date: Sun May 14 08:22:14 2017

Update ICU to 59.1

For details on what's new and changed in ICU 59.1, see

https://chromium-review.googlesource.com/c/505173/

On all platforms, ICU data size is increased by ~ 42 kB.

Inside ICU, UChar is typedef'd to be char16_t. Externally, it's
either uint16_t (non-Windows) or WChar (Windows) for now (i.e.
UChar is the same type as base::char16). This way, the minimal
amount of changes is necessary in Chromium, Blink and v8.

See https://bugs.chromium.org/p/v8/issues/detail?id=6062
    https://bugs.chromium.org/p/chromium/issues/detail?id=693640
for changes made to work with ICU 59.1.

V8 was confirmed to pass all tests at
  https://chromium-review.googlesource.com/c/505255 .

In addition, enable SymbolsIteratorTest.Emoji5AdditionsExceptFlags
(blink_platform_unittests).

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel,mac10.12_blink_rel,win10_blink_rel;master.tryserver.chromium.android:android_blink_rel

BUG= 699469 
TEST=blink layout tests, all *unittests including webkit,blink*, browsertests
TBR=drott@chromium.org, yangguo@chromium.org,michaeldo@chromium.org

Review-Url: https://codereview.chromium.org/2873603002
Cr-Commit-Position: refs/heads/master@{#471620}

[modify] https://crrev.com/ee36babf91a54379889370cdd207e818555acb5d/DEPS
[modify] https://crrev.com/ee36babf91a54379889370cdd207e818555acb5d/third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp

Comment 12 by js...@chromium.org, May 15 2017

Status: Fixed (was: Assigned)

Sign in to add a comment