New issue
Advanced search Search tips

Issue 699449 link

Starred by 2 users
Status: Fixed
Owner:
tkent@chromium.org
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 651744



Sign in to add a comment

Node.lookupNamespaceURI() handles empty prefix incorrectly

Project Member Reported by tkent@chromium.org, Mar 8 2017 
Chrome Version: 59 canary
OS: All but iOS

What steps will reproduce the problem?
(1) Open http://w3c-test.org/dom/nodes/Node-lookupNamespaceURI.html

What is the expected result?
The following sub-tests pass.
- Element should have baz namespace, prefix "" 
- Comment should inherit  baz namespace 
- Child element should have null namespace 
- Document should have xhtml namespace, prefix "" 

What happens instead?
They fail.

Please use labels and text to provide additional information.
https://dom.spec.whatwg.org/#dom-node-lookupnamespaceuri

Empty prefix handling of Blink implementation seems wrong.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3803c1269c408f40f27582052656e22d83d1332d

commit 3803c1269c408f40f27582052656e22d83d1332d
Author: tkent <tkent@chromium.org>
Date: Wed Mar 08 18:02:01 2017

DOM: Fix "" handling in Node.lookupNamespaceURI().

"" should be handled as null.
https://dom.spec.whatwg.org/#dom-node-lookupnamespaceuri

New behavior matches to Firefox, Edge, and the latest DOM standard.

This CL fixes four tests in wpt, and removes two obsolete DOM conformance tests
which this CL breaks.

BUG= 699449 

Review-Url: https://codereview.chromium.org/2739843002
Cr-Commit-Position: refs/heads/master@{#455490}

[delete] https://crrev.com/051b0af2835a602463b2960894f296f3dcc22680/third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/nodelookupnamespaceuri08-expected.txt
[delete] https://crrev.com/051b0af2835a602463b2960894f296f3dcc22680/third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/nodelookupnamespaceuri08.js
[delete] https://crrev.com/051b0af2835a602463b2960894f296f3dcc22680/third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/nodelookupnamespaceuri08.xhtml
[delete] https://crrev.com/051b0af2835a602463b2960894f296f3dcc22680/third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/nodelookupnamespaceuri09-expected.txt
[delete] https://crrev.com/051b0af2835a602463b2960894f296f3dcc22680/third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/nodelookupnamespaceuri09.js
[delete] https://crrev.com/051b0af2835a602463b2960894f296f3dcc22680/third_party/WebKit/LayoutTests/dom/legacy_dom_conformance/xhtml/level3/core/nodelookupnamespaceuri09.xhtml
[modify] https://crrev.com/3803c1269c408f40f27582052656e22d83d1332d/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Node-lookupNamespaceURI-expected.txt
[modify] https://crrev.com/3803c1269c408f40f27582052656e22d83d1332d/third_party/WebKit/Source/core/dom/Node.cpp

Comment 2 by tkent@chromium.org, Mar 9 2017

Labels: M-59
Status: Fixed (was: Started)
►

Sign in to add a comment