ContentVerifierTest.FailOnDone and ContentVerifierTest.FailOnRead fail on Win 10 x64 with PlzNavigate |
||||
Issue descriptionIn https://codereview.chromium.org/2736943004/ I added PlzNavigate versions of major test suites on the Windows 10 x64 main waterfall bot. ContentVerifierTest.FailOnDone and ContentVerifierTest.FailOnRead both failed on the main waterfall run: https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/8969 and the trybot: https://build.chromium.org/p/tryserver.chromium.win/builders/win10_chromium_x64_rel_ng/builds/751 I can't explain why they only fail with PlzNavigate on Windows 10. They do pass on Win 7 trybots.
,
Apr 20 2017
,
May 8 2017
rdevlin.cronin@, would you be able to look at this before branch cut? We are trying to ship PlzNavigate in M60 and it will be good to either get this fixed or understand whether it is a blocker.
,
May 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b7b56141f9b86e96cc9f62423a81ff8ad3cd96b commit 1b7b56141f9b86e96cc9f62423a81ff8ad3cd96b Author: Nasko Oskov <nasko@chromium.org> Date: Fri May 12 20:51:44 2017 Revert "Disable ContentVerifierTest.FailOnDone and ContentVerifierTest.FailOnRead on Win 10 with PlzNavigate." This reverts commit e3cba8b7bd9d5bf5b045b5cb08434a80cf53b288. Bug: 699437 Change-Id: I48c898574d26cca9af8d9def984c084680f71adb Reviewed-on: https://chromium-review.googlesource.com/504929 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#471440} [modify] https://crrev.com/1b7b56141f9b86e96cc9f62423a81ff8ad3cd96b/chrome/browser/extensions/content_verifier_browsertest.cc
,
May 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ce949feaa2a13577a7c757783037bc8ca670d3d commit 5ce949feaa2a13577a7c757783037bc8ca670d3d Author: Justin Donnelly <jdonnelly@chromium.org> Date: Fri May 12 22:03:51 2017 Revert "Revert "Disable ContentVerifierTest.FailOnDone and ContentVerifierTest.FailOnRead on Win 10 with PlzNavigate."" This reverts commit 1b7b56141f9b86e96cc9f62423a81ff8ad3cd96b. Reason for revert: Bots are complaining again. :) See failure at: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win10%20Tests%20x64/builds/11572 Original change's description: > Revert "Disable ContentVerifierTest.FailOnDone and ContentVerifierTest.FailOnRead on Win 10 with PlzNavigate." > > This reverts commit e3cba8b7bd9d5bf5b045b5cb08434a80cf53b288. > > Bug: 699437 > Change-Id: I48c898574d26cca9af8d9def984c084680f71adb > Reviewed-on: https://chromium-review.googlesource.com/504929 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: Nasko Oskov <nasko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#471440} TBR=nasko@chromium.org,rdevlin.cronin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug: 699437 Change-Id: I41584a9c90a174a482d3a7e3bc86b7914b9839e1 Reviewed-on: https://chromium-review.googlesource.com/505094 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#471457} [modify] https://crrev.com/5ce949feaa2a13577a7c757783037bc8ca670d3d/chrome/browser/extensions/content_verifier_browsertest.cc
,
May 23 2017
,
May 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c958dad1cb42b5e9ad6660b4fd35761b51444d5b commit c958dad1cb42b5e9ad6660b4fd35761b51444d5b Author: jam <jam@chromium.org> Date: Tue May 23 17:05:44 2017 Fix ContentVerifierTest.FailOnDone and ContentVerifierTest.FailOnRead on Windows 10 with PlzNavigate. The tests were loading a tab that would be closed. The test code was waiting for both a didstop IPC (inside InProcessBrowserTest::AddTabAtIndexToBrowser) and for the extension-unloaded notification (what the test is really testing). With PlzNavigate, the didstop IPC is sent later and it's racy whether the renderer will send it before the tab is closed. So remove the first wait. BUG= 699437 Review-Url: https://codereview.chromium.org/2896853005 Cr-Commit-Position: refs/heads/master@{#473949} [modify] https://crrev.com/c958dad1cb42b5e9ad6660b4fd35761b51444d5b/chrome/browser/extensions/content_verifier_browsertest.cc
,
May 23 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Mar 8 2017