New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699426 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"Delete/FileManagerBrowserTest.Test/0" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Mar 8 2017

Issue description

"Delete/FileManagerBrowserTest.Test/0" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLwsSBUZsYWtlIiREZWxldGUvRmlsZU1hbmFnZXJCcm93c2VyVGVzdC5UZXN0LzAM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Labels: -Sheriff-Chromium
Owner: dtapu...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by chromium...@appspot.gserviceaccount.com, Mar 14 2017

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "Delete/FileManagerBrowserTest.Test/0". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLwsSBUZsYWtlIiREZWxldGUvRmlsZU1hbmFnZXJCcm93c2VyVGVzdC5UZXN0LzAM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Owner: yoshiki@chromium.org
yoshiki@ not sure why this got assigned to me but assigning it to an owner of the tests to figure out flakiness.
Project Member

Comment 4 by chromium...@appspot.gserviceaccount.com, Mar 15 2017

Detected 4 new flakes for test/step "Delete/FileManagerBrowserTest.Test/0". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLwsSBUZsYWtlIiREZWxldGUvRmlsZU1hbmFnZXJCcm93c2VyVGVzdC5UZXN0LzAM. This message was posted automatically by the chromium-try-flakes app.
Owner: oka@chromium.org
Assigning to oka@ who is the current owner.

Comment 6 by oka@chromium.org, Mar 16 2017

The log contains:
[26534:26534:0308/160947.544436:INFO:CONSOLE(291)] "Uncaught TypeError: this._attributeChangedImpl is not a function", source: chrome://resources/polymer/v1_0/polymer/polymer-micro-extracted.js (291)

Comment 8 by oka@chromium.org, Mar 16 2017

Cc: yamaguchi@chromium.org fukino@chromium.org

Comment 9 by oka@chromium.org, Mar 16 2017

Cc: dbeam@chromium.org
dbeam@,

Recently some of Files app tests are flaky, and the log says error happens inside polymer-micro-extracted.js.
"TypeError: this._attributeChangedImpl is not a function".

Do you know any recent change which could produce this?

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 16 2017

Comment 11 by dbeam@chromium.org, Mar 16 2017

Cc: dpa...@chromium.org
we rolled polymer a little while ago

https://chromium.googlesource.com/chromium/src/+/f049d39bddb99f0338f98342e2c79e11ace4574c

could be related.

also, RootPath.DOWNALOD should probably be RootPath.DOWNLOADS
https://cs.chromium.org/chromium/src/ui/file_manager/integration_tests/test_util.js?type=cs&q=rootpath+download&l=174

(if that matters)
Labels: -Sheriff-Chromium
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90d5f745cc067692983a90c5199dc6394366432d

commit 90d5f745cc067692983a90c5199dc6394366432d
Author: oka <oka@chromium.org>
Date: Tue Mar 21 04:39:55 2017

Fix typo in tests.

Fixed typo in strings which should be RootPath.DOWNLOADS.

BUG= 699426 
TEST=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2761433002
Cr-Commit-Position: refs/heads/master@{#458310}

[modify] https://crrev.com/90d5f745cc067692983a90c5199dc6394366432d/ui/file_manager/integration_tests/file_manager/delete.js
[modify] https://crrev.com/90d5f745cc067692983a90c5199dc6394366432d/ui/file_manager/integration_tests/file_manager/directory_tree_context_menu.js

Comment 14 by oka@chromium.org, Mar 21 2017

Thank you Dan for the catch. Fixed the typo. It's not the root cause of all the failures though.

Project Member

Comment 15 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/170e8dd6e7055e5c583be95da018cafc3c79d7fb

commit 170e8dd6e7055e5c583be95da018cafc3c79d7fb
Author: oka <oka@chromium.org>
Date: Tue Mar 21 07:36:47 2017

fix typo in test to disable them for real

BUG= 699426 ,  701923 

Review-Url: https://codereview.chromium.org/2764783002
Cr-Commit-Position: refs/heads/master@{#458344}

[modify] https://crrev.com/170e8dd6e7055e5c583be95da018cafc3c79d7fb/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Comment 16 by oka@chromium.org, Mar 28 2017

Status: Fixed (was: Assigned)
Project Member

Comment 17 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54a3dd064413a8d341253c27cb944ba739acba2c

commit 54a3dd064413a8d341253c27cb944ba739acba2c
Author: tetsui <tetsui@google.com>
Date: Tue Apr 11 01:50:55 2017

Enable once flaky tests in Chrome OS file manager.

These tests were previously flaky and there seems to be a shared issue.
However, they do not reproduce anymore on the latest master branch.

It reproduced on commit a2b501b65e0987b4f2a23561a4906eb02f955a40 and
it did not reproduce on 577b8f369864082950e5922472780e54317ea2ac.

BUG= 699426 , 700156 , 699083 , 698834 , 702119 , 701923 , 699171 , 699978 , 702119 , 699534 , 615259 , 698772 
TEST=none
TBR=fukino@chromium.org

Review-Url: https://codereview.chromium.org/2801573002
Cr-Commit-Position: refs/heads/master@{#463493}

[modify] https://crrev.com/54a3dd064413a8d341253c27cb944ba739acba2c/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Sign in to add a comment