New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 699421 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Unwanted 'Clear and reset' button is seen for default link in chrome://md-settings/content/all .

Reported by rk...@etouch.net, Mar 8 2017

Issue description

Chrome Version: 59.0.3034.0 (Official Build) 3164ef05aedfd208cf1d9e43558d7e8d59b14a2c-refs/heads/master@{#455336}
OS: Windows(7,8,10),Mac(10.12.1, 10.11.6, 10.12), Liunx

Pre-condition: Enabled 'Site settings with All sites and Site details' flag from chrome://flags

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://md-settings/content/all
(2) Click on any default link and observe.

Actual: Unwanted Clear and reset button is seen for default link.

Expected: 'Clear and reset' button should not seen for default link.

This is a regression issue, broken in 'M-58', will soon update the other info:

Good Build: 58.0.2301.0
Bad Build: 58.0.2302.0
 
Actual_Option.mp4
329 KB View Download
Labels: -M-59 hasbisect-per-revision M-58
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results, (*correction in Good & bad builds) 
Good Build: 58.0.3001.0 (Revision: 447896)
Bad Build: 58.0.3002.0 (Revision: 448123)

You are probably looking for a change made after 447904 (known good), but no later than 447905 (first known bad).CHANGELOG URL:
The script might not always return single CL as suspectas some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/1b48ba269c836ccff3c6f9cc76210f04d791e824..b69c81cc077bc63f12c61a46528dff5ce22e9985

dpapad@ could you please check the issue and update.
Cc: dschuyler@chromium.org
Labels: -Pri-1 Proj-MaterialDesign-WebUI Pri-3
Owner: ----
Status: Available (was: Assigned)
Site settings are behind a flag and will not be included in 1st launch. Lowering the priority.
Labels: -Pri-3 -M-58 M-59 Pri-2
Owner: dpa...@chromium.org
Status: Assigned (was: Available)
Strangely enough, I can still navigate to chrome://md-settings/content/all even with the flag disabled. Can we remove that page altogether?
Labels: Hotlist-MD-Settings-Privacy-SiteSettings

Comment 5 by dpa...@chromium.org, Mar 15 2017

Status: Started (was: Assigned)
Currently we use the loadTimeData 'enableSiteSettings' boolean to prevent the user from navigating via clicks to the "all sites" page, see [1]. But we don't prevent the user from navigating by URL. See [2] where the URL is still registered in the Router, and [3] where the HTML code is not guarded by any special condition.

[1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/site_settings/site_list.js?l=408
[2] 
[3] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/privacy_page/privacy_page.html?l=207

I have a potential fix at https://codereview.chromium.org/2741343010.

Comment 7 by dpa...@chromium.org, Mar 20 2017

Labels: -M-59
Owner: ----
Status: Available (was: Started)
crrev.com/457303 fixed the case where the disabled UI was showing up when it should not. The problems within the "all sites" view are separate, and since this view is not part of the initial MD Settings launch, this is a lower priority.

For the record, there is an exception thrown in the console that might be related (see attachment where the C++ call to getSiteDetails fails).
console_error.png
187 KB View Download
Project Member

Comment 8 by sheriffbot@chromium.org, Apr 6 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment