Regression: Unwanted 'Clear and reset' button is seen for default link in chrome://md-settings/content/all .
Reported by
rk...@etouch.net,
Mar 8 2017
|
|||||||
Issue descriptionChrome Version: 59.0.3034.0 (Official Build) 3164ef05aedfd208cf1d9e43558d7e8d59b14a2c-refs/heads/master@{#455336} OS: Windows(7,8,10),Mac(10.12.1, 10.11.6, 10.12), Liunx Pre-condition: Enabled 'Site settings with All sites and Site details' flag from chrome://flags What steps will reproduce the problem? (1) Launch chrome, navigate to chrome://md-settings/content/all (2) Click on any default link and observe. Actual: Unwanted Clear and reset button is seen for default link. Expected: 'Clear and reset' button should not seen for default link. This is a regression issue, broken in 'M-58', will soon update the other info: Good Build: 58.0.2301.0 Bad Build: 58.0.2302.0
,
Mar 8 2017
Site settings are behind a flag and will not be included in 1st launch. Lowering the priority.
,
Mar 13 2017
Strangely enough, I can still navigate to chrome://md-settings/content/all even with the flag disabled. Can we remove that page altogether?
,
Mar 13 2017
,
Mar 15 2017
Currently we use the loadTimeData 'enableSiteSettings' boolean to prevent the user from navigating via clicks to the "all sites" page, see [1]. But we don't prevent the user from navigating by URL. See [2] where the URL is still registered in the Router, and [3] where the HTML code is not guarded by any special condition. [1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/site_settings/site_list.js?l=408 [2] [3] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/privacy_page/privacy_page.html?l=207 I have a potential fix at https://codereview.chromium.org/2741343010.
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/480869caaa149d728cbc2381476dbb5a153dc652 commit 480869caaa149d728cbc2381476dbb5a153dc652 Author: dpapad <dpapad@chromium.org> Date: Thu Mar 16 01:39:32 2017 MD Settings: Prevent direct navigation to disabled Site Settings UI. BUG=699421 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2741343010 Cr-Commit-Position: refs/heads/master@{#457303} [modify] https://crrev.com/480869caaa149d728cbc2381476dbb5a153dc652/chrome/browser/resources/settings/compiled_resources2.gyp [modify] https://crrev.com/480869caaa149d728cbc2381476dbb5a153dc652/chrome/browser/resources/settings/route.html [modify] https://crrev.com/480869caaa149d728cbc2381476dbb5a153dc652/chrome/browser/resources/settings/route.js [modify] https://crrev.com/480869caaa149d728cbc2381476dbb5a153dc652/chrome/test/data/webui/settings/cr_settings_browsertest.js [modify] https://crrev.com/480869caaa149d728cbc2381476dbb5a153dc652/chrome/test/data/webui/settings/site_list_tests.js
,
Mar 20 2017
crrev.com/457303 fixed the case where the disabled UI was showing up when it should not. The problems within the "all sites" view are separate, and since this view is not part of the initial MD Settings launch, this is a lower priority. For the record, there is an exception thrown in the console that might be related (see attachment where the C++ call to getSiteDetails fails).
,
Apr 6 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by nyerramilli@chromium.org
, Mar 8 2017Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)